Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/62403/?format=api
{ "id": 62403, "url": "https://patches.dpdk.org/api/patches/62403/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20191104230225.98450-2-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191104230225.98450-2-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191104230225.98450-2-ajit.khaparde@broadcom.com", "date": "2019-11-04T23:02:22", "name": "[v2,1/4] net/bnxt: fix RSS table update for start/stop rxq", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "7118e566888dbfeb539a3d104d481310c94f7fc2", "submitter": { "id": 501, "url": "https://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 1766, "url": "https://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20191104230225.98450-2-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 7229, "url": "https://patches.dpdk.org/api/series/7229/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=7229", "date": "2019-11-04T23:02:21", "name": "net/bnxt: rxq stop/start fixes", "version": 2, "mbox": "https://patches.dpdk.org/series/7229/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/62403/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/62403/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8C134A0352;\n\tTue, 5 Nov 2019 00:02:42 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id EA74D31FC;\n\tTue, 5 Nov 2019 00:02:36 +0100 (CET)", "from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com\n [192.19.229.170]) by dpdk.org (Postfix) with ESMTP id 95EB62BF4\n for <dev@dpdk.org>; Tue, 5 Nov 2019 00:02:33 +0100 (CET)", "from mail-irv-17.broadcom.com (mail-irv-17.lvn.broadcom.net\n [10.75.242.48])\n by rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id 2CDAF30C0F5;\n Mon, 4 Nov 2019 14:59:44 -0800 (PST)", "from C02VPB22HTD6.wifi.broadcom.net (c02vpb22htd6.wifi.broadcom.net\n [10.69.74.102])\n by mail-irv-17.broadcom.com (Postfix) with ESMTP id 2E7E8140069;\n Mon, 4 Nov 2019 15:02:30 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com 2CDAF30C0F5", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n s=dkimrelay; t=1572908384;\n bh=p+8C5r1wOW5W1q5OC79U8b8bu+OCeo1ryBJGL9I1pTs=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=D/KSeZF3aY4XGOmfAbn7ybuEQWXqlhP6CJH+lsjEUnSvd0vboPGBTVqO6PZvOPSxP\n tF6nko3kbofATXwwMZvSk+anI8L+DMydjmFPXuC3fxfS+R/qG3VbvbQCva/hcm1qPY\n MtpVX7ps8yyZyL5ISILzEAFdbh4p539vrh9BEOF4=", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com,\n\tLance Richardson <lance.richardson@broadcom.com>", "Date": "Mon, 4 Nov 2019 15:02:22 -0800", "Message-Id": "<20191104230225.98450-2-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.21.0 (Apple Git-122)", "In-Reply-To": "<20191104230225.98450-1-ajit.khaparde@broadcom.com>", "References": "\n <CADyeNEB7K_iMcDnmpjzbXtTeXQj=Kxn+MMx=r02nkfH+2sCiqw@mail.gmail.com>\n <20191104230225.98450-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 1/4] net/bnxt: fix RSS table update for\n\tstart/stop rxq", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Lance Richardson <lance.richardson@broadcom.com>\n\nA previous commit made updating of the RSS table when a receive\nqueue is stopped/started conditional on vnic->rx_queue_cnt being\nnonzero. This count is only nonzero for dynamically created VNICs,\nso the RSS table was not being updated in the normal path.\nFix by restoring the original logic.\n\nAlso ensure that vnic->rx_queue_cnt is initialized to zero when\nreinitializing the VNIC array.\n\nFixes: 36024b2e7fe5 (\"net/bnxt: allow dynamic creation of VNIC\")\n\nSigned-off-by: Lance Richardson <lance.richardson@broadcom.com>\nReviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt_rxq.c | 6 ++----\n drivers/net/bnxt/bnxt_vnic.c | 1 +\n 2 files changed, 3 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_rxq.c b/drivers/net/bnxt/bnxt_rxq.c\nindex 6420281d3..ab889c10e 100644\n--- a/drivers/net/bnxt/bnxt_rxq.c\n+++ b/drivers/net/bnxt/bnxt_rxq.c\n@@ -466,8 +466,7 @@ int bnxt_rx_queue_start(struct rte_eth_dev *dev, uint16_t rx_queue_id)\n \t\t}\n \n \t\tPMD_DRV_LOG(DEBUG, \"Rx Queue Count %d\\n\", vnic->rx_queue_cnt);\n-\t\tif (vnic->rx_queue_cnt > 1)\n-\t\t\trc = bnxt_vnic_rss_configure(bp, vnic);\n+\t\trc = bnxt_vnic_rss_configure(bp, vnic);\n \t}\n \n \tif (rc == 0)\n@@ -522,8 +521,7 @@ int bnxt_rx_queue_stop(struct rte_eth_dev *dev, uint16_t rx_queue_id)\n \t\t\tvnic->fw_grp_ids[rx_queue_id] = INVALID_HW_RING_ID;\n \n \t\tPMD_DRV_LOG(DEBUG, \"Rx Queue Count %d\\n\", vnic->rx_queue_cnt);\n-\t\tif (vnic->rx_queue_cnt > 1)\n-\t\t\trc = bnxt_vnic_rss_configure(bp, vnic);\n+\t\trc = bnxt_vnic_rss_configure(bp, vnic);\n \t}\n \n \tif (rc == 0)\ndiff --git a/drivers/net/bnxt/bnxt_vnic.c b/drivers/net/bnxt/bnxt_vnic.c\nindex 412a53dc0..52a4badfc 100644\n--- a/drivers/net/bnxt/bnxt_vnic.c\n+++ b/drivers/net/bnxt/bnxt_vnic.c\n@@ -51,6 +51,7 @@ static void bnxt_init_vnics(struct bnxt *bp)\n \t\tvnic->lb_rule = (uint16_t)HWRM_NA_SIGNATURE;\n \t\tvnic->hash_mode =\n \t\t\tHWRM_VNIC_RSS_CFG_INPUT_HASH_MODE_FLAGS_DEFAULT;\n+\t\tvnic->rx_queue_cnt = 0;\n \n \t\tSTAILQ_INIT(&vnic->filter);\n \t\tSTAILQ_INIT(&vnic->flow_list);\n", "prefixes": [ "v2", "1/4" ] }