Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/62392/?format=api
{ "id": 62392, "url": "https://patches.dpdk.org/api/patches/62392/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20191104202747.12897-2-lance.richardson@broadcom.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191104202747.12897-2-lance.richardson@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191104202747.12897-2-lance.richardson@broadcom.com", "date": "2019-11-04T20:27:44", "name": "[1/4] net/bnxt: fix RSS table update for start/stop rxq", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "7118e566888dbfeb539a3d104d481310c94f7fc2", "submitter": { "id": 1323, "url": "https://patches.dpdk.org/api/people/1323/?format=api", "name": "Lance Richardson", "email": "lance.richardson@broadcom.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20191104202747.12897-2-lance.richardson@broadcom.com/mbox/", "series": [ { "id": 7227, "url": "https://patches.dpdk.org/api/series/7227/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=7227", "date": "2019-11-04T20:27:43", "name": "net/bnxt: rxq stop/start fixes", "version": 1, "mbox": "https://patches.dpdk.org/series/7227/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/62392/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/62392/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id ED103A0352;\n\tMon, 4 Nov 2019 21:28:02 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6F8F731FC;\n\tMon, 4 Nov 2019 21:28:00 +0100 (CET)", "from mail-wr1-f67.google.com (mail-wr1-f67.google.com\n [209.85.221.67]) by dpdk.org (Postfix) with ESMTP id 4D18F2BF5\n for <dev@dpdk.org>; Mon, 4 Nov 2019 21:27:59 +0100 (CET)", "by mail-wr1-f67.google.com with SMTP id v9so18671040wrq.5\n for <dev@dpdk.org>; Mon, 04 Nov 2019 12:27:59 -0800 (PST)", "from lrichardson-VirtualBox.dhcp.broadcom.net ([192.19.231.250])\n by smtp.gmail.com with ESMTPSA id i3sm17995365wrw.69.2019.11.04.12.27.57\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 04 Nov 2019 12:27:58 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com;\n s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references;\n bh=zFP0v8mf/0QH/2zjA9gz5Zi/WHZAIjVM3iqixKP/Zus=;\n b=USTPlToYl3kYax0cG5+UlaGl6Fkk51wwtPL3Vl3bzuiqoLaQevvSVBDxtfb/fg2iBl\n ivGioxvyZrKr3L3SK3SDc8xfai7sa+x5/XjdszOoabYGm2RB0Mix26QzSlP7C56NpK0f\n ArHCkoW+GdJnkafYuCqQLzR7rxrF6eX5u7+W0=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references;\n bh=zFP0v8mf/0QH/2zjA9gz5Zi/WHZAIjVM3iqixKP/Zus=;\n b=Q0Z9YMYAkAMpb6ZNKJgzgRE6xDGGTBfTemGDmK3UcOuPYEqyvfbnvCe3KZDiPuylsc\n s/nsgzzMn2PvgN0s8VkWT3OazlUfnLWyg40zVTSSYNu+A326T3xigl08gfaLbccOsVQp\n KXX6+Qxa9YrmVSR2ZRaInSYk+2Tznt4ORmO4Uw3rsTZVKlPo7/ZZeKiV+rRHvbFskM6U\n nOYOTZ+2VV81jl+hhDSOjrzyA9H8HG69y/SmFhCqw0FY09gA5hZLDd/dazUDv3dZc4BM\n xTDq9IxMwc/TvxrWHhOfAPwirDGRPqlb9JtGH/eT3/xBWoDmEJWsV8k4m9uy2wUKzFqN\n CEXA==", "X-Gm-Message-State": "APjAAAVaeolxq11oqDXF9r8FrG4Agwf+Io03H66duTv9OPYXn3nI0zay\n zi5J9LpKvgHPX+ce/BSIihxhQT9NgYj0EPZCZNOaXiZLmMOEBTRwbmQdXjrizzKPHTNQ6HZPZwF\n lCyoQFhx4jS2rRmSIi34Fp4AwEhac73z57ejhRJV4+FFRR/pQFezteMD59iLTfrvL", "X-Google-Smtp-Source": "\n APXvYqxCBSCwiFB307gOc7Po5P7IujQv3brYb4Vph8lweWfAx+wwjyHtp0ki6DE+mFSUaOrvpxZXCQ==", "X-Received": "by 2002:adf:f489:: with SMTP id l9mr21196383wro.337.1572899278777;\n Mon, 04 Nov 2019 12:27:58 -0800 (PST)", "From": "Lance Richardson <lance.richardson@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ajit.khaparde@broadcom.com, ferruh.yigit@intel.com,\n Lance Richardson <lance.richardson@broadcom.com>", "Date": "Mon, 4 Nov 2019 15:27:44 -0500", "Message-Id": "<20191104202747.12897-2-lance.richardson@broadcom.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20191104202747.12897-1-lance.richardson@broadcom.com>", "References": "<20191104202747.12897-1-lance.richardson@broadcom.com>", "Subject": "[dpdk-dev] [PATCH 1/4] net/bnxt: fix RSS table update for\n\tstart/stop rxq", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "A previous commit made updating of the RSS table when a receive\nqueue is stopped/started conditional on vnic->rx_queue_cnt being\nnonzero. This count is only nonzero for dynamically created VNICs,\nso the RSS table was not being updated in the normal path.\nFix by restoring the original logic.\n\nAlso ensure that vnic->rx_queue_cnt is initialized to zero when\nreinitializing the VNIC array.\n\nFixes: 36024b2e7fe5 (\"net/bnxt: allow dynamic creation of VNIC\")\n\nSigned-off-by: Lance Richardson <lance.richardson@broadcom.com>\nReviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>\nSigned-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt_rxq.c | 6 ++----\n drivers/net/bnxt/bnxt_vnic.c | 1 +\n 2 files changed, 3 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_rxq.c b/drivers/net/bnxt/bnxt_rxq.c\nindex 6420281d3..ab889c10e 100644\n--- a/drivers/net/bnxt/bnxt_rxq.c\n+++ b/drivers/net/bnxt/bnxt_rxq.c\n@@ -466,8 +466,7 @@ int bnxt_rx_queue_start(struct rte_eth_dev *dev, uint16_t rx_queue_id)\n \t\t}\n \n \t\tPMD_DRV_LOG(DEBUG, \"Rx Queue Count %d\\n\", vnic->rx_queue_cnt);\n-\t\tif (vnic->rx_queue_cnt > 1)\n-\t\t\trc = bnxt_vnic_rss_configure(bp, vnic);\n+\t\trc = bnxt_vnic_rss_configure(bp, vnic);\n \t}\n \n \tif (rc == 0)\n@@ -522,8 +521,7 @@ int bnxt_rx_queue_stop(struct rte_eth_dev *dev, uint16_t rx_queue_id)\n \t\t\tvnic->fw_grp_ids[rx_queue_id] = INVALID_HW_RING_ID;\n \n \t\tPMD_DRV_LOG(DEBUG, \"Rx Queue Count %d\\n\", vnic->rx_queue_cnt);\n-\t\tif (vnic->rx_queue_cnt > 1)\n-\t\t\trc = bnxt_vnic_rss_configure(bp, vnic);\n+\t\trc = bnxt_vnic_rss_configure(bp, vnic);\n \t}\n \n \tif (rc == 0)\ndiff --git a/drivers/net/bnxt/bnxt_vnic.c b/drivers/net/bnxt/bnxt_vnic.c\nindex 412a53dc0..52a4badfc 100644\n--- a/drivers/net/bnxt/bnxt_vnic.c\n+++ b/drivers/net/bnxt/bnxt_vnic.c\n@@ -51,6 +51,7 @@ static void bnxt_init_vnics(struct bnxt *bp)\n \t\tvnic->lb_rule = (uint16_t)HWRM_NA_SIGNATURE;\n \t\tvnic->hash_mode =\n \t\t\tHWRM_VNIC_RSS_CFG_INPUT_HASH_MODE_FLAGS_DEFAULT;\n+\t\tvnic->rx_queue_cnt = 0;\n \n \t\tSTAILQ_INIT(&vnic->filter);\n \t\tSTAILQ_INIT(&vnic->flow_list);\n", "prefixes": [ "1/4" ] }