Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/62346/?format=api
{ "id": 62346, "url": "https://patches.dpdk.org/api/patches/62346/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20191102142316.750-1-pbhagavatula@marvell.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191102142316.750-1-pbhagavatula@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191102142316.750-1-pbhagavatula@marvell.com", "date": "2019-11-02T14:23:15", "name": "[v2] usertools: enhance device bind script module detection", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "c768b09bb4a45f28afc66f2face1988cca1bab2e", "submitter": { "id": 1183, "url": "https://patches.dpdk.org/api/people/1183/?format=api", "name": "Pavan Nikhilesh Bhagavatula", "email": "pbhagavatula@marvell.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20191102142316.750-1-pbhagavatula@marvell.com/mbox/", "series": [ { "id": 7203, "url": "https://patches.dpdk.org/api/series/7203/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=7203", "date": "2019-11-02T14:23:15", "name": "[v2] usertools: enhance device bind script module detection", "version": 2, "mbox": "https://patches.dpdk.org/series/7203/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/62346/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/62346/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B7741A034F;\n\tSat, 2 Nov 2019 15:23:24 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1510A1D405;\n\tSat, 2 Nov 2019 15:23:24 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 88D121BF1B\n for <dev@dpdk.org>; Sat, 2 Nov 2019 15:23:22 +0100 (CET)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id\n xA2EN7p9016831; Sat, 2 Nov 2019 07:23:21 -0700", "from sc-exch02.marvell.com ([199.233.58.182])\n by mx0a-0016f401.pphosted.com with ESMTP id 2w17n8rg93-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Sat, 02 Nov 2019 07:23:21 -0700", "from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH02.marvell.com\n (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Sat, 2 Nov\n 2019 07:23:20 -0700", "from maili.marvell.com (10.93.176.43) by SC-EXCH03.marvell.com\n (10.93.176.83) with Microsoft SMTP Server id 15.0.1367.3 via Frontend\n Transport; Sat, 2 Nov 2019 07:23:20 -0700", "from BG-LT7430.marvell.com (unknown [10.28.17.62])\n by maili.marvell.com (Postfix) with ESMTP id 2D9603F703F;\n Sat, 2 Nov 2019 07:23:17 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0818;\n bh=CSzzwiDINyDRrXwar/b6AvSIg01HRE4bn7a/voezkXQ=;\n b=oC8O80/gPUhyVWY8Rf2RwBIi53f9Z1BJsBwei6S4GPoTaXMAP1BTRcP193LoCQgMBsEy\n PmvfNeEbtz9QhU5EXrDNTBM32TMCEkdm8X2uHbf2rjLPaCjpUImRQMeJwoyAJK9Ju8wb\n 89qgxx4LQAXxJjITmUOj17/22qOS0tbT4Wvk5gxqAif1zq2G/pC9WyqM2xkXVUC7aaWd\n quOyl64wTQ6C7pPE9LH5q3tH45e3nYX1Ma4OMrAIUJkK2O3QuWg27sg/ahUmhdn8kWLV\n wV/pXLeZAwcphyKaSTdNp8FXJ4qFVh8imECSmtecMttR3et7Nw87amt/3zgPJ3+0DQxg hQ==", "From": "<pbhagavatula@marvell.com>", "To": "<thomas@monjalon.net>, <jerinj@marvell.com>", "CC": "<dev@dpdk.org>, Pavan Nikhilesh <pbhagavatula@marvell.com>, \"Phanendra\n Vukkisala\" <pvukkisala@marvell.com>", "Date": "Sat, 2 Nov 2019 19:53:15 +0530", "Message-ID": "<20191102142316.750-1-pbhagavatula@marvell.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20190921181626.13034-1-pbhagavatula@marvell.com>", "References": "<20190921181626.13034-1-pbhagavatula@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.95,1.0.8\n definitions=2019-11-02_09:2019-11-01,2019-11-02 signatures=0", "Subject": "[dpdk-dev] [PATCH v2] usertools: enhance device bind script module\n\tdetection", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Pavan Nikhilesh <pbhagavatula@marvell.com>\n\nSome kernel modules use '-' in their name when registering through\n`pci_register_driver` and the same name is populated in\n'/sys/bus/pci/drivers/'.\nBut the kernel always populates modules names replacing '-' with '_'\nin '/sys/module/'.\n\nExample:\n\t# ./usertools/dpdk-devbind.py -b octeontx2-nicpf 0002:03:00.0\n\tError: Driver 'octeontx2-nicpf' is not loaded.\n\n\t# ls /sys/bus/pci/drivers/octeontx2-nicpf\n\tbind module new_id remove_id uevent unbind\n\t# ls /sys/module/octeontx2_nicpf/\n\tdrivers uevent version\n\nThe patch addresses it by always replacing '-' with '_' when looking in\n'/sys/module/'\n\nSigned-off-by: Phanendra Vukkisala <pvukkisala@marvell.com>\nSigned-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>\n---\n usertools/dpdk-devbind.py | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)", "diff": "diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py\nindex 7b5cbc12c..b1d149876 100755\n--- a/usertools/dpdk-devbind.py\n+++ b/usertools/dpdk-devbind.py\n@@ -153,6 +153,9 @@ def check_output(args, stderr=None):\n def module_is_loaded(module):\n global loaded_modules\n \n+ if module == 'vfio_pci':\n+ module = 'vfio-pci'\n+\n if loaded_modules:\n return module in loaded_modules\n \n@@ -520,7 +523,7 @@ def bind_all(dev_list, driver, force=False):\n pass\n \n # check if we're attempting to bind to a driver that isn't loaded\n- if not module_is_loaded(driver):\n+ if not module_is_loaded(driver.replace('-','_')):\n sys.exit(\"Error: Driver '%s' is not loaded.\" % driver)\n \n try:\n", "prefixes": [ "v2" ] }