Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/62344/?format=api
{ "id": 62344, "url": "https://patches.dpdk.org/api/patches/62344/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20191101201255.4853-3-stephen@networkplumber.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191101201255.4853-3-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20191101201255.4853-3-stephen@networkplumber.org", "date": "2019-11-01T20:12:56", "name": "[2/2] failsafe: implement xstats", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "09db18b036da9b7e512c3036a744b735d8441a37", "submitter": { "id": 27, "url": "https://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20191101201255.4853-3-stephen@networkplumber.org/mbox/", "series": [ { "id": 7201, "url": "https://patches.dpdk.org/api/series/7201/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=7201", "date": "2019-11-01T20:12:54", "name": "xstats related patches", "version": 1, "mbox": "https://patches.dpdk.org/series/7201/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/62344/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/62344/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id EB6CAA00BE;\n\tFri, 1 Nov 2019 21:13:29 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id BD3EA1E894;\n\tFri, 1 Nov 2019 21:13:18 +0100 (CET)", "from mail-pg1-f193.google.com (mail-pg1-f193.google.com\n [209.85.215.193]) by dpdk.org (Postfix) with ESMTP id 129E31E886\n for <dev@dpdk.org>; Fri, 1 Nov 2019 21:13:16 +0100 (CET)", "by mail-pg1-f193.google.com with SMTP id f19so7113975pgn.13\n for <dev@dpdk.org>; Fri, 01 Nov 2019 13:13:16 -0700 (PDT)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n by smtp.gmail.com with ESMTPSA id x9sm9744588pje.27.2019.11.01.13.13.14\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 01 Nov 2019 13:13:14 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=fYVEIUsb/9LJ9fq0NkuQdr4NGSRtZOiIhg/H2QJy6W4=;\n b=qaxnLuV/Ti91jc7tdcuVc1DNMFyyohHipikq7Di+2XuYfnH0oh0nMeGxMvtF7bb9td\n wGsx5hVS0v9BD+49PjrbvzanAJ2c9fNWr4shhkiSJASx5gKqih1e3ITpGYlxITveoTQP\n v2LEaZIzjaMzK+HP3e4lBo1g2Wi78Et0rI8DgYENxQmEEjp7Fl5sTXf5o4hFUKsHCKLR\n relKBMlctC4JAkaFiVuhBtm170S+Amz1maDrNmrugKEjU6IlLhkMEdGRIrdIjg7DXG7u\n P9Xu4lajhj8NJo7aSIwOeGSybvNKK9MhVYlsM2fhwYeBWOfnukYIaglvhsc4RMA12f+H\n T6ww==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=fYVEIUsb/9LJ9fq0NkuQdr4NGSRtZOiIhg/H2QJy6W4=;\n b=qhM0C3ahDvQseLDlGHwEl4yqLlW8mKU3zmhZASsDP5uLm5UtEBzlN9CStY98eh+rmk\n PtZLdBt/ZaTIVQRaOM3mSbOpobi906fVYBpNzR1+b7kczwrtZZtTonpybdURrvkohWfe\n +AQcrAVjLBo9KA4Lh08oK4aGr+V9PT+N/6I064uevqz8XiL+aZ/L1gN8/jAVc8ft4Lyj\n Lvp1TnJVA7MKaafDkyOYJ5swqj1QxcEb6xaq5mxO8STs/eaR5XQ0WGWmn0rF68F9eU7A\n s9q0Nw4eXfTBcEqR+n205TrAzZXZF90RTtVICvYdHlxIvetYUSUwgxpMejP3RNmh3HsQ\n OAMQ==", "X-Gm-Message-State": "APjAAAVFQEZA3JtA4jOHiYWxq3UBcbn2ELCDX5kXEBOIkFgWmFr5vM6G\n d+lI1wodGinsOvyePz7W234LeEgF1B5A0w==", "X-Google-Smtp-Source": "\n APXvYqxRnKAkljQtk582Sx8/9ZH4Y3LhV/s5BnMoSRV9mp5w2OxZiedZDLYfIKsoegDpF0Eht9EHRA==", "X-Received": "by 2002:a62:2a41:: with SMTP id\n q62mr15774009pfq.131.1572639195607;\n Fri, 01 Nov 2019 13:13:15 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Date": "Fri, 1 Nov 2019 13:12:56 -0700", "Message-Id": "<20191101201255.4853-3-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20191101201255.4853-1-stephen@networkplumber.org>", "References": "<20191101201255.4853-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 2/2] failsafe: implement xstats", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add support for extended statistics in failsafe driver.\nReports detailed statistics for each sub device.\n\nExample:\n\ntestpmd> show port xstats 1\nrx_good_packets: 0\ntx_good_packets: 0\nrx_good_bytes: 0\ntx_good_bytes: 0\nrx_missed_errors: 0\nrx_errors: 0\ntx_errors: 0\nrx_mbuf_allocation_errors: 0\nrx_q0packets: 0\nrx_q0bytes: 0\nrx_q0errors: 0\ntx_q0packets: 0\ntx_q0bytes: 0\nrx_sub0_good_packets: 0\ntx_sub0_good_packets: 0\n...\nrx_sub1_good_packets: 0\ntx_sub1_good_packets: 0\nrx_sub1_good_bytes: 0\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/failsafe/failsafe_ops.c | 152 ++++++++++++++++++++++++++++\n 1 file changed, 152 insertions(+)", "diff": "diff --git a/drivers/net/failsafe/failsafe_ops.c b/drivers/net/failsafe/failsafe_ops.c\nindex 0afae6c71feb..a87e49b97d33 100644\n--- a/drivers/net/failsafe/failsafe_ops.c\n+++ b/drivers/net/failsafe/failsafe_ops.c\n@@ -14,6 +14,7 @@\n #include <rte_flow.h>\n #include <rte_cycles.h>\n #include <rte_ethdev.h>\n+#include <rte_string_fns.h>\n \n #include \"failsafe_private.h\"\n \n@@ -881,6 +882,154 @@ fs_stats_reset(struct rte_eth_dev *dev)\n \treturn 0;\n }\n \n+static int\n+__fs_xstats_count(struct rte_eth_dev *dev)\n+{\n+\tstruct sub_device *sdev;\n+\tint count = 0;\n+\tuint8_t i;\n+\tint ret;\n+\n+\tFOREACH_SUBDEV_STATE(sdev, i, dev, DEV_ACTIVE) {\n+\t\tret = rte_eth_xstats_get_names(PORT_ID(sdev), NULL, 0);\n+\t\tif (ret < 0)\n+\t\t\treturn ret;\n+\t\tcount += ret;\n+\t}\n+\n+\treturn count;\n+}\n+\n+static int\n+__fs_xstats_get_names(struct rte_eth_dev *dev,\n+\t\t struct rte_eth_xstat_name *xstats_names,\n+\t\t unsigned int limit)\n+{\n+\tstruct sub_device *sdev;\n+\tunsigned int count = 0;\n+\tuint8_t i;\n+\n+\t/* Caller only cares about count */\n+\tif (!xstats_names)\n+\t\treturn __fs_xstats_count(dev);\n+\n+\tFOREACH_SUBDEV_STATE(sdev, i, dev, DEV_ACTIVE) {\n+\t\tstruct rte_eth_xstat_name *sub_names = xstats_names + count;\n+\t\tint j, r;\n+\n+\t\tif (count >= limit)\n+\t\t\tbreak;\n+\n+\t\tr = rte_eth_xstats_get_names(PORT_ID(sdev),\n+\t\t\t\t\t sub_names, limit - count);\n+\t\tif (r < 0)\n+\t\t\treturn r;\n+\n+\t\t/* add subN_ prefix to names */\n+\t\tfor (j = 0; j < r; j++) {\n+\t\t\tchar *xname = sub_names[j].name;\n+\t\t\tchar tmp[RTE_ETH_XSTATS_NAME_SIZE];\n+\n+\t\t\tif ((xname[0] == 't' || xname[0] == 'r') &&\n+\t\t\t xname[1] == 'x' && xname[2] == '_')\n+\t\t\t\tsnprintf(tmp, sizeof(tmp), \"%.3ssub%u_%s\",\n+\t\t\t\t\t xname, i, xname + 3);\n+\t\t\telse\n+\t\t\t\tsnprintf(tmp, sizeof(tmp), \"sub%u_%s\",\n+\t\t\t\t\t i, xname);\n+\n+\t\t\tstrlcpy(xname, tmp, RTE_ETH_XSTATS_NAME_SIZE);\n+\t\t}\n+\t\tcount += r;\n+\t}\n+\treturn count;\n+}\n+\n+static int\n+fs_xstats_get_names(struct rte_eth_dev *dev,\n+\t\t struct rte_eth_xstat_name *xstats_names,\n+\t\t unsigned int limit)\n+{\n+\tint ret;\n+\n+\tfs_lock(dev, 0);\n+\tret = __fs_xstats_get_names(dev, xstats_names, limit);\n+\tfs_unlock(dev, 0);\n+\treturn ret;\n+}\n+\n+static int\n+__fs_xstats_get(struct rte_eth_dev *dev,\n+\t struct rte_eth_xstat *xstats,\n+\t unsigned int n)\n+{\n+\tunsigned int count = 0;\n+\tstruct sub_device *sdev;\n+\tuint8_t i;\n+\tint j, ret;\n+\n+\tret = __fs_xstats_count(dev);\n+\t/*\n+\t * if error\n+\t * or caller did not give enough space\n+\t * or just querying\n+\t */\n+\tif (ret < 0 || ret > (int)n || xstats == NULL)\n+\t\treturn ret;\n+\n+\tFOREACH_SUBDEV_STATE(sdev, i, dev, DEV_ACTIVE) {\n+\t\tret = rte_eth_xstats_get(PORT_ID(sdev), xstats, n);\n+\t\tif (ret < 0)\n+\t\t\treturn ret;\n+\n+\t\tif (ret > (int)n)\n+\t\t\treturn n + count;\n+\n+\t\t/* add offset to id's from sub-device */\n+\t\tfor (j = 0; j < ret; j++)\n+\t\t\txstats[j].id += count;\n+\n+\t\txstats += ret;\n+\t\tn -= ret;\n+\t\tcount += ret;\n+\t}\n+\n+\treturn count;\n+}\n+\n+static int\n+fs_xstats_get(struct rte_eth_dev *dev,\n+\t struct rte_eth_xstat *xstats,\n+\t unsigned int n)\n+{\n+\tint ret;\n+\n+\tfs_lock(dev, 0);\n+\tret = __fs_xstats_get(dev, xstats, n);\n+\tfs_unlock(dev, 0);\n+\n+\treturn ret;\n+}\n+\n+\n+static int\n+fs_xstats_reset(struct rte_eth_dev *dev)\n+{\n+\tstruct sub_device *sdev;\n+\tuint8_t i;\n+\tint r = 0;\n+\n+\tfs_lock(dev, 0);\n+\tFOREACH_SUBDEV_STATE(sdev, i, dev, DEV_ACTIVE) {\n+\t\tr = rte_eth_xstats_reset(PORT_ID(sdev));\n+\t\tif (r < 0)\n+\t\t\tbreak;\n+\t}\n+\tfs_unlock(dev, 0);\n+\n+\treturn r;\n+}\n+\n static void\n fs_dev_merge_desc_lim(struct rte_eth_desc_lim *to,\n \t\t const struct rte_eth_desc_lim *from)\n@@ -1331,6 +1480,9 @@ const struct eth_dev_ops failsafe_ops = {\n \t.link_update = fs_link_update,\n \t.stats_get = fs_stats_get,\n \t.stats_reset = fs_stats_reset,\n+\t.xstats_get = fs_xstats_get,\n+\t.xstats_get_names = fs_xstats_get_names,\n+\t.xstats_reset = fs_xstats_reset,\n \t.dev_infos_get = fs_dev_infos_get,\n \t.dev_supported_ptypes_get = fs_dev_supported_ptypes_get,\n \t.mtu_set = fs_mtu_set,\n", "prefixes": [ "2/2" ] }