Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/62262/?format=api
{ "id": 62262, "url": "https://patches.dpdk.org/api/patches/62262/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20191031102923.70585-1-taox.zhu@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191031102923.70585-1-taox.zhu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191031102923.70585-1-taox.zhu@intel.com", "date": "2019-10-31T10:29:23", "name": "[DPDK] net/ice: set vlan tpid is not supported by ice", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "aa3db9fc962698742d308c7b68d52f0f596e871b", "submitter": { "id": 1368, "url": "https://patches.dpdk.org/api/people/1368/?format=api", "name": "Zhu, TaoX", "email": "taox.zhu@intel.com" }, "delegate": { "id": 31221, "url": "https://patches.dpdk.org/api/users/31221/?format=api", "username": "yexl", "first_name": "xiaolong", "last_name": "ye", "email": "xiaolong.ye@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20191031102923.70585-1-taox.zhu@intel.com/mbox/", "series": [ { "id": 7166, "url": "https://patches.dpdk.org/api/series/7166/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=7166", "date": "2019-10-31T10:29:23", "name": "[DPDK] net/ice: set vlan tpid is not supported by ice", "version": 1, "mbox": "https://patches.dpdk.org/series/7166/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/62262/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/62262/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 43081A00BE;\n\tThu, 31 Oct 2019 03:01:06 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id BE9461C030;\n\tThu, 31 Oct 2019 03:01:04 +0100 (CET)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n by dpdk.org (Postfix) with ESMTP id BCF7E44C3\n for <dev@dpdk.org>; Thu, 31 Oct 2019 03:01:02 +0100 (CET)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n 30 Oct 2019 19:01:01 -0700", "from unknown (HELO localhost.localdomain) ([10.240.176.181])\n by fmsmga002.fm.intel.com with ESMTP; 30 Oct 2019 19:01:00 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.68,249,1569308400\"; d=\"scan'208\";a=\"230679312\"", "From": "taox.zhu@intel.com", "To": "qiming.yang@intel.com,\n\twenzhuo.lu@intel.com", "Cc": "dev@dpdk.org,\n\tZhu Tao <taox.zhu@intel.com>", "Date": "Thu, 31 Oct 2019 18:29:23 +0800", "Message-Id": "<20191031102923.70585-1-taox.zhu@intel.com>", "X-Mailer": "git-send-email 2.17.1", "Subject": "[dpdk-dev] [DPDK] net/ice: set vlan tpid is not supported by ice", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Zhu Tao <taox.zhu@intel.com>\n\nSet vlan tpid is not supported by ice hardware. Delete driver code\nthat doesn't work.\n\nSigned-off-by: Zhu Tao <taox.zhu@intel.com>\n---\n drivers/net/ice/ice_ethdev.c | 54 ------------------------------------\n 1 file changed, 54 deletions(-)", "diff": "diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c\nindex d74675842..ec0234091 100644\n--- a/drivers/net/ice/ice_ethdev.c\n+++ b/drivers/net/ice/ice_ethdev.c\n@@ -69,9 +69,6 @@ static int ice_dev_set_link_down(struct rte_eth_dev *dev);\n \n static int ice_mtu_set(struct rte_eth_dev *dev, uint16_t mtu);\n static int ice_vlan_offload_set(struct rte_eth_dev *dev, int mask);\n-static int ice_vlan_tpid_set(struct rte_eth_dev *dev,\n-\t\t\t enum rte_vlan_type vlan_type,\n-\t\t\t uint16_t tpid);\n static int ice_rss_reta_update(struct rte_eth_dev *dev,\n \t\t\t struct rte_eth_rss_reta_entry64 *reta_conf,\n \t\t\t uint16_t reta_size);\n@@ -156,7 +153,6 @@ static const struct eth_dev_ops ice_eth_dev_ops = {\n \t.mac_addr_remove = ice_macaddr_remove,\n \t.vlan_filter_set = ice_vlan_filter_set,\n \t.vlan_offload_set = ice_vlan_offload_set,\n-\t.vlan_tpid_set = ice_vlan_tpid_set,\n \t.reta_update = ice_rss_reta_update,\n \t.reta_query = ice_rss_reta_query,\n \t.rss_hash_update = ice_rss_hash_update,\n@@ -3340,56 +3336,6 @@ ice_vlan_offload_set(struct rte_eth_dev *dev, int mask)\n \treturn 0;\n }\n \n-static int\n-ice_vlan_tpid_set(struct rte_eth_dev *dev,\n-\t\t enum rte_vlan_type vlan_type,\n-\t\t uint16_t tpid)\n-{\n-\tstruct ice_hw *hw = ICE_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n-\tuint64_t reg_r = 0, reg_w = 0;\n-\tuint16_t reg_id = 0;\n-\tint ret = 0;\n-\tint qinq = dev->data->dev_conf.rxmode.offloads &\n-\t\t DEV_RX_OFFLOAD_VLAN_EXTEND;\n-\n-\tswitch (vlan_type) {\n-\tcase ETH_VLAN_TYPE_OUTER:\n-\t\tif (qinq)\n-\t\t\treg_id = 3;\n-\t\telse\n-\t\t\treg_id = 5;\n-\t\tbreak;\n-\tcase ETH_VLAN_TYPE_INNER:\n-\t\tif (qinq) {\n-\t\t\treg_id = 5;\n-\t\t} else {\n-\t\t\tPMD_DRV_LOG(ERR,\n-\t\t\t\t \"Unsupported vlan type in single vlan.\");\n-\t\t\treturn -EINVAL;\n-\t\t}\n-\t\tbreak;\n-\tdefault:\n-\t\tPMD_DRV_LOG(ERR, \"Unsupported vlan type %d\", vlan_type);\n-\t\treturn -EINVAL;\n-\t}\n-\treg_r = ICE_READ_REG(hw, GL_SWT_L2TAGCTRL(reg_id));\n-\tPMD_DRV_LOG(DEBUG, \"Debug read from ICE GL_SWT_L2TAGCTRL[%d]: \"\n-\t\t \"0x%08\"PRIx64\"\", reg_id, reg_r);\n-\n-\treg_w = reg_r & (~(GL_SWT_L2TAGCTRL_ETHERTYPE_M));\n-\treg_w |= ((uint64_t)tpid << GL_SWT_L2TAGCTRL_ETHERTYPE_S);\n-\tif (reg_r == reg_w) {\n-\t\tPMD_DRV_LOG(DEBUG, \"No need to write\");\n-\t\treturn 0;\n-\t}\n-\n-\tICE_WRITE_REG(hw, GL_SWT_L2TAGCTRL(reg_id), reg_w);\n-\tPMD_DRV_LOG(DEBUG, \"Debug write 0x%08\"PRIx64\" to \"\n-\t\t \"ICE GL_SWT_L2TAGCTRL[%d]\", reg_w, reg_id);\n-\n-\treturn ret;\n-}\n-\n static int\n ice_get_rss_lut(struct ice_vsi *vsi, uint8_t *lut, uint16_t lut_size)\n {\n", "prefixes": [ "DPDK" ] }