Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/62200/?format=api
{ "id": 62200, "url": "https://patches.dpdk.org/api/patches/62200/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20191030152516.34615-1-yong.liu@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191030152516.34615-1-yong.liu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191030152516.34615-1-yong.liu@intel.com", "date": "2019-10-30T15:25:16", "name": "[v5] net/virtio: fix multicast and promisc mode enable failure", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "b79c0c960b5a6c421637e8d8affe279d285efe19", "submitter": { "id": 17, "url": "https://patches.dpdk.org/api/people/17/?format=api", "name": "Marvin Liu", "email": "yong.liu@intel.com" }, "delegate": { "id": 2642, "url": "https://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20191030152516.34615-1-yong.liu@intel.com/mbox/", "series": [ { "id": 7151, "url": "https://patches.dpdk.org/api/series/7151/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=7151", "date": "2019-10-30T15:25:16", "name": "[v5] net/virtio: fix multicast and promisc mode enable failure", "version": 5, "mbox": "https://patches.dpdk.org/series/7151/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/62200/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/62200/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7EF91A00BE;\n\tWed, 30 Oct 2019 08:46:03 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 444661BEB5;\n\tWed, 30 Oct 2019 08:46:03 +0100 (CET)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n by dpdk.org (Postfix) with ESMTP id D3D301BEB4;\n Wed, 30 Oct 2019 08:46:01 +0100 (CET)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n 30 Oct 2019 00:46:01 -0700", "from npg-dpdk-virtual-marvin-dev.sh.intel.com ([10.67.119.142])\n by fmsmga002.fm.intel.com with ESMTP; 30 Oct 2019 00:46:00 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.68,246,1569308400\"; d=\"scan'208\";a=\"230357514\"", "From": "Marvin Liu <yong.liu@intel.com>", "To": "maxime.coquelin@redhat.com,\n\ttiwei.bie@intel.com,\n\tzhihong.wang@intel.com", "Cc": "dev@dpdk.org,\n\tMarvin Liu <yong.liu@intel.com>,\n\tstable@dpdk.org", "Date": "Wed, 30 Oct 2019 23:25:16 +0800", "Message-Id": "<20191030152516.34615-1-yong.liu@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20191030103047.70782-1-yong.liu@intel.com>", "References": "<20191030103047.70782-1-yong.liu@intel.com>", "Subject": "[dpdk-dev] [PATCH v5] net/virtio: fix multicast and promisc mode\n\tenable failure", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "As doc mentioned, Rx/Mac/vlan filters are all supported by best effort.\nThese control commands should return pass. Promisc and all multicast\nmodes are always enabled in virio-user, initialize related values in\nethernet data.\n\nFixes: f9b9d1a55775 (\"net/virtio-user: add multiple queues in device emulation\")\nCc: stable@dpdk.org\n\nSigned-off-by: Marvin Liu <yong.liu@intel.com>\n---\n drivers/net/virtio/virtio_user/virtio_user_dev.c | 8 ++++++++\n drivers/net/virtio/virtio_user_ethdev.c | 4 ++++\n 2 files changed, 12 insertions(+)", "diff": "diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c b/drivers/net/virtio/virtio_user/virtio_user_dev.c\nindex 1c575d0cd..a4400e772 100644\n--- a/drivers/net/virtio/virtio_user/virtio_user_dev.c\n+++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c\n@@ -613,6 +613,10 @@ virtio_user_handle_ctrl_msg(struct virtio_user_dev *dev, struct vring *vring,\n \n \t\tqueues = *(uint16_t *)(uintptr_t)vring->desc[idx_data].addr;\n \t\tstatus = virtio_user_handle_mq(dev, queues);\n+\t} else if (hdr->class == VIRTIO_NET_CTRL_RX ||\n+\t\t hdr->class == VIRTIO_NET_CTRL_MAC ||\n+\t\t hdr->class == VIRTIO_NET_CTRL_VLAN) {\n+\t\tstatus = 0;\n \t}\n \n \t/* Update status */\n@@ -664,6 +668,10 @@ virtio_user_handle_ctrl_msg_packed(struct virtio_user_dev *dev,\n \t\tqueues = *(uint16_t *)(uintptr_t)\n \t\t\t\tvring->desc[idx_data].addr;\n \t\tstatus = virtio_user_handle_mq(dev, queues);\n+\t} else if (hdr->class == VIRTIO_NET_CTRL_RX ||\n+\t\t hdr->class == VIRTIO_NET_CTRL_MAC ||\n+\t\t hdr->class == VIRTIO_NET_CTRL_VLAN) {\n+\t\tstatus = 0;\n \t}\n \n \t/* Update status */\ndiff --git a/drivers/net/virtio/virtio_user_ethdev.c b/drivers/net/virtio/virtio_user_ethdev.c\nindex 3fc172573..18caf5e88 100644\n--- a/drivers/net/virtio/virtio_user_ethdev.c\n+++ b/drivers/net/virtio/virtio_user_ethdev.c\n@@ -660,6 +660,10 @@ virtio_user_pmd_probe(struct rte_vdev_device *dev)\n \t\tgoto end;\n \t}\n \n+\t/* multicast and promisc mode are always enabled */\n+\teth_dev->data->promiscuous = 1;\n+\teth_dev->data->all_multicast = 1;\n+\n \thw = eth_dev->data->dev_private;\n \tif (virtio_user_dev_init(hw->virtio_user_dev, path, queues, cq,\n \t\t\t queue_size, mac_addr, &ifname, server_mode,\n", "prefixes": [ "v5" ] }