Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/62092/?format=api
{ "id": 62092, "url": "https://patches.dpdk.org/api/patches/62092/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1572252623-96127-16-git-send-email-andy.pei@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1572252623-96127-16-git-send-email-andy.pei@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1572252623-96127-16-git-send-email-andy.pei@intel.com", "date": "2019-10-28T08:50:19", "name": "[v14,15/19] raw/ifpga/base: clean fme errors", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "37b7caa19b91ca110d19f96f4de539b4a40b26c3", "submitter": { "id": 1185, "url": "https://patches.dpdk.org/api/people/1185/?format=api", "name": "Pei, Andy", "email": "andy.pei@intel.com" }, "delegate": { "id": 31221, "url": "https://patches.dpdk.org/api/users/31221/?format=api", "username": "yexl", "first_name": "xiaolong", "last_name": "ye", "email": "xiaolong.ye@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1572252623-96127-16-git-send-email-andy.pei@intel.com/mbox/", "series": [ { "id": 7100, "url": "https://patches.dpdk.org/api/series/7100/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=7100", "date": "2019-10-28T08:50:04", "name": "add PCIe AER disable and IRQ support for ipn3ke", "version": 14, "mbox": "https://patches.dpdk.org/series/7100/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/62092/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/62092/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 2EC101BF51;\n\tMon, 28 Oct 2019 10:02:45 +0100 (CET)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby dpdk.org (Postfix) with ESMTP id 71DB81BF2E\n\tfor <dev@dpdk.org>; Mon, 28 Oct 2019 10:01:40 +0100 (CET)", "from orsmga005.jf.intel.com ([10.7.209.41])\n\tby orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t28 Oct 2019 02:01:40 -0700", "from dpdk-dipei.sh.intel.com ([10.67.110.224])\n\tby orsmga005.jf.intel.com with ESMTP; 28 Oct 2019 02:01:38 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.68,239,1569308400\"; d=\"scan'208\";a=\"374177884\"", "From": "Andy Pei <andy.pei@intel.com>", "To": "dev@dpdk.org", "Cc": "rosen.xu@intel.com, tianfei.zhang@intel.com, andy.pei@intel.com,\n\txiaolong.ye@intel.com, ferruh.yigit@intel.com", "Date": "Mon, 28 Oct 2019 16:50:19 +0800", "Message-Id": "<1572252623-96127-16-git-send-email-andy.pei@intel.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1572252623-96127-1-git-send-email-andy.pei@intel.com>", "References": "<1571917119-149534-2-git-send-email-andy.pei@intel.com>\n\t<1572252623-96127-1-git-send-email-andy.pei@intel.com>", "Subject": "[dpdk-dev] [PATCH v14 15/19] raw/ifpga/base: clean fme errors", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Tianfei zhang <tianfei.zhang@intel.com>\n\nClean fme errors register when some fme errors occurred.\n\nSigned-off-by: Tianfei zhang <tianfei.zhang@intel.com>\nSigned-off-by: Andy Pei <andy.pei@intel.com>\n---\n drivers/raw/ifpga/base/ifpga_fme_error.c | 24 ++----------------------\n drivers/raw/ifpga/ifpga_rawdev.c | 22 ++++++++++++++++++++++\n 2 files changed, 24 insertions(+), 22 deletions(-)", "diff": "diff --git a/drivers/raw/ifpga/base/ifpga_fme_error.c b/drivers/raw/ifpga/base/ifpga_fme_error.c\nindex 5d6d630..5905eac 100644\n--- a/drivers/raw/ifpga/base/ifpga_fme_error.c\n+++ b/drivers/raw/ifpga/base/ifpga_fme_error.c\n@@ -48,34 +48,14 @@ static int fme_err_set_clear(struct ifpga_fme_hw *fme, u64 val)\n \tstruct feature_fme_err *fme_err\n \t\t= get_fme_feature_ioaddr_by_index(fme,\n \t\t\t\t\t\t FME_FEATURE_ID_GLOBAL_ERR);\n-\tstruct feature_fme_error0 fme_error0;\n-\tstruct feature_fme_first_error fme_first_err;\n-\tstruct feature_fme_next_error fme_next_err;\n-\tint ret = 0;\n \n \tspinlock_lock(&fme->lock);\n-\twriteq(GENMASK_ULL(63, 0), &fme_err->fme_err_mask);\n-\n-\tfme_error0.csr = readq(&fme_err->fme_err);\n-\tif (val != fme_error0.csr) {\n-\t\tret = -EBUSY;\n-\t\tgoto exit;\n-\t}\n-\n-\tfme_first_err.csr = readq(&fme_err->fme_first_err);\n-\tfme_next_err.csr = readq(&fme_err->fme_next_err);\n \n-\twriteq(fme_error0.csr, &fme_err->fme_err);\n-\twriteq(fme_first_err.csr & FME_FIRST_ERROR_MASK,\n-\t &fme_err->fme_first_err);\n-\twriteq(fme_next_err.csr & FME_NEXT_ERROR_MASK,\n-\t &fme_err->fme_next_err);\n+\twriteq(val, &fme_err->fme_err);\n \n-exit:\n-\twriteq(FME_ERROR0_MASK_DEFAULT, &fme_err->fme_err_mask);\n \tspinlock_unlock(&fme->lock);\n \n-\treturn ret;\n+\treturn 0;\n }\n \n static int fme_err_get_revision(struct ifpga_fme_hw *fme, u64 *val)\ndiff --git a/drivers/raw/ifpga/ifpga_rawdev.c b/drivers/raw/ifpga/ifpga_rawdev.c\nindex 01ff76a..95f079a 100644\n--- a/drivers/raw/ifpga/ifpga_rawdev.c\n+++ b/drivers/raw/ifpga/ifpga_rawdev.c\n@@ -1174,6 +1174,25 @@ static int fme_clear_warning_intr(struct opae_manager *mgr)\n \treturn 0;\n }\n \n+static int fme_clean_fme_error(struct opae_manager *mgr)\n+{\n+\tu64 val;\n+\n+\tif (ifpga_get_fme_error_prop(mgr, FME_ERR_PROP_ERRORS, &val))\n+\t\treturn -EINVAL;\n+\n+\tIFPGA_RAWDEV_PMD_DEBUG(\"before clean 0x%lx\\n\", val);\n+\n+\tifpga_set_fme_error_prop(mgr, FME_ERR_PROP_CLEAR, val);\n+\n+\tif (ifpga_get_fme_error_prop(mgr, FME_ERR_PROP_ERRORS, &val))\n+\t\treturn -EINVAL;\n+\n+\tIFPGA_RAWDEV_PMD_DEBUG(\"after clean 0x%lx\\n\", val);\n+\n+\treturn 0;\n+}\n+\n static int\n fme_err_handle_error0(struct opae_manager *mgr)\n {\n@@ -1183,6 +1202,9 @@ static int fme_clear_warning_intr(struct opae_manager *mgr)\n \tif (ifpga_get_fme_error_prop(mgr, FME_ERR_PROP_ERRORS, &val))\n \t\treturn -EINVAL;\n \n+\tif (fme_clean_fme_error(mgr))\n+\t\treturn -EINVAL;\n+\n \tfme_error0.csr = val;\n \n \tif (fme_error0.fabric_err)\n", "prefixes": [ "v14", "15/19" ] }