Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/62071/?format=api
{ "id": 62071, "url": "https://patches.dpdk.org/api/patches/62071/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20191028141811.73444-2-yong.liu@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191028141811.73444-2-yong.liu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191028141811.73444-2-yong.liu@intel.com", "date": "2019-10-28T14:18:11", "name": "[2/2] vhost: do not limit packed ring size", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "ea2102b2a0eaf169c70e7487ba654523fdb2083e", "submitter": { "id": 17, "url": "https://patches.dpdk.org/api/people/17/?format=api", "name": "Marvin Liu", "email": "yong.liu@intel.com" }, "delegate": { "id": 2642, "url": "https://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20191028141811.73444-2-yong.liu@intel.com/mbox/", "series": [ { "id": 7095, "url": "https://patches.dpdk.org/api/series/7095/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=7095", "date": "2019-10-28T14:18:10", "name": "[1/2] net/virtio: do not limit packed ring size", "version": 1, "mbox": "https://patches.dpdk.org/series/7095/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/62071/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/62071/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 26D6B1BF14;\n\tMon, 28 Oct 2019 07:38:50 +0100 (CET)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n\tby dpdk.org (Postfix) with ESMTP id 89DFE1BEF7\n\tfor <dev@dpdk.org>; Mon, 28 Oct 2019 07:38:44 +0100 (CET)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t27 Oct 2019 23:38:43 -0700", "from npg-dpdk-virtual-marvin-dev.sh.intel.com ([10.67.119.142])\n\tby orsmga001.jf.intel.com with ESMTP; 27 Oct 2019 23:38:41 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.68,239,1569308400\"; d=\"scan'208\";a=\"282856811\"", "From": "Marvin Liu <yong.liu@intel.com>", "To": "maxime.coquelin@redhat.com, tiwei.bie@intel.com, zhihong.wang@intel.com", "Cc": "dev@dpdk.org,\n\tMarvin Liu <yong.liu@intel.com>", "Date": "Mon, 28 Oct 2019 22:18:11 +0800", "Message-Id": "<20191028141811.73444-2-yong.liu@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20191028141811.73444-1-yong.liu@intel.com>", "References": "<20191028141811.73444-1-yong.liu@intel.com>", "Subject": "[dpdk-dev] [PATCH 2/2] vhost: do not limit packed ring size", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Virtio spec only set rule that packed ring maximum size is up to 2^15\nentries. Do not limit packed ring size to power of two.\n\nSigned-off-by: Marvin Liu <yong.liu@intel.com>\n---\n lib/librte_vhost/vhost_user.c | 15 ++++++++++++++-\n 1 file changed, 14 insertions(+), 1 deletion(-)", "diff": "diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c\nindex 87dc3fc53..bbf323373 100644\n--- a/lib/librte_vhost/vhost_user.c\n+++ b/lib/librte_vhost/vhost_user.c\n@@ -363,8 +363,21 @@ vhost_user_set_vring_num(struct virtio_net **pdev,\n \t *\n \t * Queue Size value is always a power of 2. The maximum Queue Size\n \t * value is 32768.\n+\t *\n+\t * VIRTIO 1.1 2.7 Virtqueues says:\n+\t *\n+\t * Packed virtqueues support up to 2^15 entries each.\n \t */\n-\tif ((vq->size & (vq->size - 1)) || vq->size > 32768) {\n+\tif (!vq_is_packed(dev)) {\n+\t\tif (vq->size & (vq->size - 1)) {\n+\t\t\tRTE_LOG(ERR, VHOST_CONFIG,\n+\t\t\t\t\"invalid virtqueue size %u\\n\", vq->size);\n+\t\t\treturn RTE_VHOST_MSG_RESULT_ERR;\n+\t\t}\n+\n+\t}\n+\n+\tif (vq->size > 32768) {\n \t\tRTE_LOG(ERR, VHOST_CONFIG,\n \t\t\t\"invalid virtqueue size %u\\n\", vq->size);\n \t\treturn RTE_VHOST_MSG_RESULT_ERR;\n", "prefixes": [ "2/2" ] }