Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/61793/?format=api
{ "id": 61793, "url": "https://patches.dpdk.org/api/patches/61793/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1571856864-8779-13-git-send-email-david.marchand@redhat.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1571856864-8779-13-git-send-email-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1571856864-8779-13-git-send-email-david.marchand@redhat.com", "date": "2019-10-23T18:54:24", "name": "[v2,12/12] eal: make the global configuration private", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "1aed0ae407bcb19909a4b176a22a26b18bd1e50c", "submitter": { "id": 1173, "url": "https://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1571856864-8779-13-git-send-email-david.marchand@redhat.com/mbox/", "series": [ { "id": 7024, "url": "https://patches.dpdk.org/api/series/7024/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=7024", "date": "2019-10-23T18:54:12", "name": "EAL and PCI ABI changes for 19.11", "version": 2, "mbox": "https://patches.dpdk.org/series/7024/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/61793/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/61793/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A597C1D449;\n\tWed, 23 Oct 2019 20:55:25 +0200 (CEST)", "from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com\n\t[205.139.110.120]) by dpdk.org (Postfix) with ESMTP id C36DB1D175\n\tfor <dev@dpdk.org>; Wed, 23 Oct 2019 20:55:19 +0200 (CEST)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n\t[209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n\tus-mta-68-Omo89_nkPlSOTChiraBllQ-1; Wed, 23 Oct 2019 14:55:16 -0400", "from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mimecast-mx01.redhat.com (Postfix) with ESMTPS id B096080183E;\n\tWed, 23 Oct 2019 18:55:14 +0000 (UTC)", "from dmarchan.remote.csb (ovpn-204-129.brq.redhat.com\n\t[10.40.204.129])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id A11B860872;\n\tWed, 23 Oct 2019 18:55:12 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1571856919;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=U5qRUXLnr7YKIqFD9daArkiOvIIlYjHdxZMzTWRLF5I=;\n\tb=X82AOnCc1dV3T5cIzfqMnqyNo9iDlSk63DerpsKv15LA4YiT3exGk0EEWtCuMEfSv1djq2\n\t5sAsOg7e04T3eCFMpT1r4q4lK5+Lu8/R0BS4bKXqauxtLO/cEZDUZ5xsR8rYebe9qNuzTo\n\tC503HaOCq1DlqZPpIp8wXGRfgikZuTM=", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "stephen@networkplumber.org, anatoly.burakov@intel.com,\n\tthomas@monjalon.net, John McNamara <john.mcnamara@intel.com>,\n\tMarko Kovacevic <marko.kovacevic@intel.com>", "Date": "Wed, 23 Oct 2019 20:54:24 +0200", "Message-Id": "<1571856864-8779-13-git-send-email-david.marchand@redhat.com>", "In-Reply-To": "<1571856864-8779-1-git-send-email-david.marchand@redhat.com>", "References": "<1571736761-32134-1-git-send-email-david.marchand@redhat.com>\n\t<1571856864-8779-1-git-send-email-david.marchand@redhat.com>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.13", "X-MC-Unique": "Omo89_nkPlSOTChiraBllQ-1", "X-Mimecast-Spam-Score": "0", "Content-Type": "text/plain; charset=WINDOWS-1252", "Content-Transfer-Encoding": "quoted-printable", "Subject": "[dpdk-dev] [PATCH v2 12/12] eal: make the global configuration\n\tprivate", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Now that all elements of the rte_config structure have (deinlined)\naccessors, we can hide it.\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\n doc/guides/rel_notes/release_19_11.rst | 3 +++\n lib/librte_eal/common/eal_common_mcfg.c | 1 +\n lib/librte_eal/common/eal_private.h | 32 ++++++++++++++++++++++++++++++++\n lib/librte_eal/common/include/rte_eal.h | 32 --------------------------------\n lib/librte_eal/common/malloc_heap.c | 1 +\n lib/librte_eal/common/rte_malloc.c | 1 +\n lib/librte_eal/rte_eal_version.map | 1 -\n 7 files changed, 38 insertions(+), 33 deletions(-)", "diff": "diff --git a/doc/guides/rel_notes/release_19_11.rst b/doc/guides/rel_notes/release_19_11.rst\nindex 082c570..ae0f21e 100644\n--- a/doc/guides/rel_notes/release_19_11.rst\n+++ b/doc/guides/rel_notes/release_19_11.rst\n@@ -212,6 +212,9 @@ ABI Changes\n \n * eal: made the ``rte_logs`` struct and global symbol private.\n \n+* eal: made the ``rte_config`` struct and ``rte_eal_get_configuration``\n+ function private.\n+\n * pci: removed the following deprecated functions since dpdk:\n \n - ``eal_parse_pci_BDF`` replaced by ``rte_pci_addr_parse``\ndiff --git a/lib/librte_eal/common/eal_common_mcfg.c b/lib/librte_eal/common/eal_common_mcfg.c\nindex 0665494..0cf9a62 100644\n--- a/lib/librte_eal/common/eal_common_mcfg.c\n+++ b/lib/librte_eal/common/eal_common_mcfg.c\n@@ -8,6 +8,7 @@\n \n #include \"eal_internal_cfg.h\"\n #include \"eal_memcfg.h\"\n+#include \"eal_private.h\"\n \n void\n eal_mcfg_complete(void)\ndiff --git a/lib/librte_eal/common/eal_private.h b/lib/librte_eal/common/eal_private.h\nindex 0e4b033..52eea9a 100644\n--- a/lib/librte_eal/common/eal_private.h\n+++ b/lib/librte_eal/common/eal_private.h\n@@ -37,6 +37,38 @@ struct lcore_config {\n extern struct lcore_config lcore_config[RTE_MAX_LCORE];\n \n /**\n+ * The global RTE configuration structure.\n+ */\n+struct rte_config {\n+\tuint32_t master_lcore; /**< Id of the master lcore */\n+\tuint32_t lcore_count; /**< Number of available logical cores. */\n+\tuint32_t numa_node_count; /**< Number of detected NUMA nodes. */\n+\tuint32_t numa_nodes[RTE_MAX_NUMA_NODES]; /**< List of detected NUMA nodes. */\n+\tuint32_t service_lcore_count;/**< Number of available service cores. */\n+\tenum rte_lcore_role_t lcore_role[RTE_MAX_LCORE]; /**< State of cores. */\n+\n+\t/** Primary or secondary configuration */\n+\tenum rte_proc_type_t process_type;\n+\n+\t/** PA or VA mapping mode */\n+\tenum rte_iova_mode iova_mode;\n+\n+\t/**\n+\t * Pointer to memory configuration, which may be shared across multiple\n+\t * DPDK instances\n+\t */\n+\tstruct rte_mem_config *mem_config;\n+} __attribute__((__packed__));\n+\n+/**\n+ * Get the global configuration structure.\n+ *\n+ * @return\n+ * A pointer to the global configuration structure.\n+ */\n+struct rte_config *rte_eal_get_configuration(void);\n+\n+/**\n * Initialize the memzone subsystem (private to eal).\n *\n * @return\ndiff --git a/lib/librte_eal/common/include/rte_eal.h b/lib/librte_eal/common/include/rte_eal.h\nindex ea3c9df..2f9ed29 100644\n--- a/lib/librte_eal/common/include/rte_eal.h\n+++ b/lib/librte_eal/common/include/rte_eal.h\n@@ -52,38 +52,6 @@ enum rte_proc_type_t {\n };\n \n /**\n- * The global RTE configuration structure.\n- */\n-struct rte_config {\n-\tuint32_t master_lcore; /**< Id of the master lcore */\n-\tuint32_t lcore_count; /**< Number of available logical cores. */\n-\tuint32_t numa_node_count; /**< Number of detected NUMA nodes. */\n-\tuint32_t numa_nodes[RTE_MAX_NUMA_NODES]; /**< List of detected NUMA nodes. */\n-\tuint32_t service_lcore_count;/**< Number of available service cores. */\n-\tenum rte_lcore_role_t lcore_role[RTE_MAX_LCORE]; /**< State of cores. */\n-\n-\t/** Primary or secondary configuration */\n-\tenum rte_proc_type_t process_type;\n-\n-\t/** PA or VA mapping mode */\n-\tenum rte_iova_mode iova_mode;\n-\n-\t/**\n-\t * Pointer to memory configuration, which may be shared across multiple\n-\t * DPDK instances\n-\t */\n-\tstruct rte_mem_config *mem_config;\n-} __attribute__((__packed__));\n-\n-/**\n- * Get the global configuration structure.\n- *\n- * @return\n- * A pointer to the global configuration structure.\n- */\n-struct rte_config *rte_eal_get_configuration(void);\n-\n-/**\n * Get the process type in a multi-process setup\n *\n * @return\ndiff --git a/lib/librte_eal/common/malloc_heap.c b/lib/librte_eal/common/malloc_heap.c\nindex 634ca21..842eb9d 100644\n--- a/lib/librte_eal/common/malloc_heap.c\n+++ b/lib/librte_eal/common/malloc_heap.c\n@@ -27,6 +27,7 @@\n #include \"eal_internal_cfg.h\"\n #include \"eal_memalloc.h\"\n #include \"eal_memcfg.h\"\n+#include \"eal_private.h\"\n #include \"malloc_elem.h\"\n #include \"malloc_heap.h\"\n #include \"malloc_mp.h\"\ndiff --git a/lib/librte_eal/common/rte_malloc.c b/lib/librte_eal/common/rte_malloc.c\nindex fecd9a9..044d3a9 100644\n--- a/lib/librte_eal/common/rte_malloc.c\n+++ b/lib/librte_eal/common/rte_malloc.c\n@@ -26,6 +26,7 @@\n #include \"malloc_heap.h\"\n #include \"eal_memalloc.h\"\n #include \"eal_memcfg.h\"\n+#include \"eal_private.h\"\n \n \n /* Free the memory space back to heap */\ndiff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map\nindex e7422d4..009641f 100644\n--- a/lib/librte_eal/rte_eal_version.map\n+++ b/lib/librte_eal/rte_eal_version.map\n@@ -17,7 +17,6 @@ DPDK_2.0 {\n \trte_dump_tailq;\n \trte_eal_alarm_cancel;\n \trte_eal_alarm_set;\n-\trte_eal_get_configuration;\n \trte_eal_get_lcore_state;\n \trte_eal_get_physmem_size;\n \trte_eal_has_hugepages;\n", "prefixes": [ "v2", "12/12" ] }