Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/61792/?format=api
{ "id": 61792, "url": "https://patches.dpdk.org/api/patches/61792/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1571856864-8779-12-git-send-email-david.marchand@redhat.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1571856864-8779-12-git-send-email-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1571856864-8779-12-git-send-email-david.marchand@redhat.com", "date": "2019-10-23T18:54:23", "name": "[v2,11/12] eal: factorize lcore role code in common code", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "5a0bc961165b020f72adf3c304612eac139a4871", "submitter": { "id": 1173, "url": "https://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1571856864-8779-12-git-send-email-david.marchand@redhat.com/mbox/", "series": [ { "id": 7024, "url": "https://patches.dpdk.org/api/series/7024/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=7024", "date": "2019-10-23T18:54:12", "name": "EAL and PCI ABI changes for 19.11", "version": 2, "mbox": "https://patches.dpdk.org/series/7024/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/61792/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/61792/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 2D76F1D41B;\n\tWed, 23 Oct 2019 20:55:23 +0200 (CEST)", "from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com\n\t[205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 0DFB81D157\n\tfor <dev@dpdk.org>; Wed, 23 Oct 2019 20:55:15 +0200 (CEST)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n\t[209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n\tus-mta-166-gkxpVkLAOUCqjHBAt5i8iA-1; Wed, 23 Oct 2019 14:55:13 -0400", "from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mimecast-mx01.redhat.com (Postfix) with ESMTPS id 15D151005500;\n\tWed, 23 Oct 2019 18:55:12 +0000 (UTC)", "from dmarchan.remote.csb (ovpn-204-129.brq.redhat.com\n\t[10.40.204.129])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id A9FB360872;\n\tWed, 23 Oct 2019 18:55:09 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1571856915;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=X2zCgztgUH4K7qMe9i0XP2RvmUNyE4amqdicIfdGx8Q=;\n\tb=iqKpIYfpudRhBsR/NmvUieBE5aCoQAkebVDph3k2JoXejc6WsXby5hSfTeJ6WkCAG+t0S/\n\tefgbMIUI1vQLJ3jpMsAgtdGCoNBd5O69RwxsL/BEPi+A+ZNaGqY49X+qFUfFraVq2mEirN\n\t2Lf9qcRr+zb+LhaNJl7zYFtzG/dYRXU=", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "stephen@networkplumber.org, anatoly.burakov@intel.com,\n\tthomas@monjalon.net, Bruce Richardson <bruce.richardson@intel.com>", "Date": "Wed, 23 Oct 2019 20:54:23 +0200", "Message-Id": "<1571856864-8779-12-git-send-email-david.marchand@redhat.com>", "In-Reply-To": "<1571856864-8779-1-git-send-email-david.marchand@redhat.com>", "References": "<1571736761-32134-1-git-send-email-david.marchand@redhat.com>\n\t<1571856864-8779-1-git-send-email-david.marchand@redhat.com>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.13", "X-MC-Unique": "gkxpVkLAOUCqjHBAt5i8iA-1", "X-Mimecast-Spam-Score": "0", "Content-Type": "text/plain; charset=WINDOWS-1252", "Content-Transfer-Encoding": "quoted-printable", "Subject": "[dpdk-dev] [PATCH v2 11/12] eal: factorize lcore role code in\n\tcommon code", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This code belongs to the lcore API, move the prototype to the right\nheader, then factorize the code into the common code.\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\n lib/librte_eal/common/eal_common_lcore.c | 10 ++++++++++\n lib/librte_eal/common/include/rte_eal.h | 11 -----------\n lib/librte_eal/common/include/rte_lcore.h | 10 ++++++++++\n lib/librte_eal/freebsd/eal/eal.c | 7 -------\n lib/librte_eal/linux/eal/eal.c | 7 -------\n 5 files changed, 20 insertions(+), 25 deletions(-)", "diff": "diff --git a/lib/librte_eal/common/eal_common_lcore.c b/lib/librte_eal/common/eal_common_lcore.c\nindex abd2cf8..343d9b4 100644\n--- a/lib/librte_eal/common/eal_common_lcore.c\n+++ b/lib/librte_eal/common/eal_common_lcore.c\n@@ -53,6 +53,16 @@ rte_cpuset_t rte_lcore_cpuset(unsigned int lcore_id)\n \treturn lcore_config[lcore_id].cpuset;\n }\n \n+enum rte_lcore_role_t\n+rte_eal_lcore_role(unsigned int lcore_id)\n+{\n+\tstruct rte_config *cfg = rte_eal_get_configuration();\n+\n+\tif (lcore_id >= RTE_MAX_LCORE)\n+\t\treturn ROLE_OFF;\n+\treturn cfg->lcore_role[lcore_id];\n+}\n+\n int rte_lcore_is_enabled(unsigned int lcore_id)\n {\n \tstruct rte_config *cfg = rte_eal_get_configuration();\ndiff --git a/lib/librte_eal/common/include/rte_eal.h b/lib/librte_eal/common/include/rte_eal.h\nindex b7cf912..ea3c9df 100644\n--- a/lib/librte_eal/common/include/rte_eal.h\n+++ b/lib/librte_eal/common/include/rte_eal.h\n@@ -84,17 +84,6 @@ struct rte_config {\n struct rte_config *rte_eal_get_configuration(void);\n \n /**\n- * Get a lcore's role.\n- *\n- * @param lcore_id\n- * The identifier of the lcore.\n- * @return\n- * The role of the lcore.\n- */\n-enum rte_lcore_role_t rte_eal_lcore_role(unsigned lcore_id);\n-\n-\n-/**\n * Get the process type in a multi-process setup\n *\n * @return\ndiff --git a/lib/librte_eal/common/include/rte_lcore.h b/lib/librte_eal/common/include/rte_lcore.h\nindex ea40c25..555b692 100644\n--- a/lib/librte_eal/common/include/rte_lcore.h\n+++ b/lib/librte_eal/common/include/rte_lcore.h\n@@ -70,6 +70,16 @@ RTE_DECLARE_PER_LCORE(unsigned, _lcore_id); /**< Per thread \"lcore id\". */\n RTE_DECLARE_PER_LCORE(rte_cpuset_t, _cpuset); /**< Per thread \"cpuset\". */\n \n /**\n+ * Get a lcore's role.\n+ *\n+ * @param lcore_id\n+ * The identifier of the lcore, which MUST be between 0 and RTE_MAX_LCORE-1.\n+ * @return\n+ * The role of the lcore.\n+ */\n+enum rte_lcore_role_t rte_eal_lcore_role(unsigned int lcore_id);\n+\n+/**\n * Return the Application thread ID of the execution unit.\n *\n * Note: in most cases the lcore id returned here will also correspond\ndiff --git a/lib/librte_eal/freebsd/eal/eal.c b/lib/librte_eal/freebsd/eal/eal.c\nindex f86e9aa..40d8f57 100644\n--- a/lib/librte_eal/freebsd/eal/eal.c\n+++ b/lib/librte_eal/freebsd/eal/eal.c\n@@ -943,13 +943,6 @@ rte_eal_cleanup(void)\n \treturn 0;\n }\n \n-/* get core role */\n-enum rte_lcore_role_t\n-rte_eal_lcore_role(unsigned lcore_id)\n-{\n-\treturn rte_config.lcore_role[lcore_id];\n-}\n-\n enum rte_proc_type_t\n rte_eal_process_type(void)\n {\ndiff --git a/lib/librte_eal/linux/eal/eal.c b/lib/librte_eal/linux/eal/eal.c\nindex f397206..5769489 100644\n--- a/lib/librte_eal/linux/eal/eal.c\n+++ b/lib/librte_eal/linux/eal/eal.c\n@@ -1348,13 +1348,6 @@ rte_eal_cleanup(void)\n \treturn 0;\n }\n \n-/* get core role */\n-enum rte_lcore_role_t\n-rte_eal_lcore_role(unsigned lcore_id)\n-{\n-\treturn rte_config.lcore_role[lcore_id];\n-}\n-\n enum rte_proc_type_t\n rte_eal_process_type(void)\n {\n", "prefixes": [ "v2", "11/12" ] }