Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/61787/?format=api
{ "id": 61787, "url": "https://patches.dpdk.org/api/patches/61787/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1571856864-8779-7-git-send-email-david.marchand@redhat.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1571856864-8779-7-git-send-email-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1571856864-8779-7-git-send-email-david.marchand@redhat.com", "date": "2019-10-23T18:54:18", "name": "[v2,06/12] pci: remove deprecated functions", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "c871f131384fab35870c19c21edd1e6511ed412d", "submitter": { "id": 1173, "url": "https://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1571856864-8779-7-git-send-email-david.marchand@redhat.com/mbox/", "series": [ { "id": 7024, "url": "https://patches.dpdk.org/api/series/7024/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=7024", "date": "2019-10-23T18:54:12", "name": "EAL and PCI ABI changes for 19.11", "version": 2, "mbox": "https://patches.dpdk.org/series/7024/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/61787/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/61787/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id BC4BB1D37D;\n\tWed, 23 Oct 2019 20:55:05 +0200 (CEST)", "from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com\n\t[207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 365A41D150\n\tfor <dev@dpdk.org>; Wed, 23 Oct 2019 20:55:04 +0200 (CEST)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n\t[209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n\tus-mta-169-cqFmFIFgOMajEV-qR1B_3g-1; Wed, 23 Oct 2019 14:54:59 -0400", "from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mimecast-mx01.redhat.com (Postfix) with ESMTPS id E143380183E;\n\tWed, 23 Oct 2019 18:54:57 +0000 (UTC)", "from dmarchan.remote.csb (ovpn-204-129.brq.redhat.com\n\t[10.40.204.129])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 0072A60872;\n\tWed, 23 Oct 2019 18:54:53 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1571856903;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=PghRp0V9RKCXMHPNuLq88fvmUXHYSO27NnwJJjTwd44=;\n\tb=cwYAs/IWNqVRBIldhTZzHoqSd1BLd5Um+Yml+Qb4i0tCSMHcScMe0ducABa8AcgrEkYEVN\n\tNwe91GOssM625Fx36ejZxrKH3Xe4pPIhZxNvErvAK+jizppberK4odDTVBeqXVS+/qX4W7\n\tof5/gNM5fRjL2z0/7VGI7vHy2avDwss=", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "stephen@networkplumber.org, anatoly.burakov@intel.com,\n\tthomas@monjalon.net, Neil Horman <nhorman@tuxdriver.com>,\n\tJohn McNamara <john.mcnamara@intel.com>,\n\tMarko Kovacevic <marko.kovacevic@intel.com>,\n\tGaetan Rivet <gaetan.rivet@6wind.com>", "Date": "Wed, 23 Oct 2019 20:54:18 +0200", "Message-Id": "<1571856864-8779-7-git-send-email-david.marchand@redhat.com>", "In-Reply-To": "<1571856864-8779-1-git-send-email-david.marchand@redhat.com>", "References": "<1571736761-32134-1-git-send-email-david.marchand@redhat.com>\n\t<1571856864-8779-1-git-send-email-david.marchand@redhat.com>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.13", "X-MC-Unique": "cqFmFIFgOMajEV-qR1B_3g-1", "X-Mimecast-Spam-Score": "0", "Content-Type": "text/plain; charset=WINDOWS-1252", "Content-Transfer-Encoding": "quoted-printable", "Subject": "[dpdk-dev] [PATCH v2 06/12] pci: remove deprecated functions", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Those functions have been deprecated since 17.11 and have 1:1\nreplacement.\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\n doc/guides/rel_notes/deprecation.rst | 7 -----\n doc/guides/rel_notes/release_19_11.rst | 6 +++++\n lib/librte_pci/rte_pci.c | 19 --------------\n lib/librte_pci/rte_pci.h | 47 ----------------------------------\n lib/librte_pci/rte_pci_version.map | 3 ---\n 5 files changed, 6 insertions(+), 76 deletions(-)", "diff": "diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst\nindex bbd5863..cf7744e 100644\n--- a/doc/guides/rel_notes/deprecation.rst\n+++ b/doc/guides/rel_notes/deprecation.rst\n@@ -38,13 +38,6 @@ Deprecation Notices\n have been replaced with ``rte_dev_dma_map`` and ``rte_dev_dma_unmap``\n functions. The due date for the removal targets DPDK 20.02.\n \n-* pci: Several exposed functions are misnamed.\n- The following functions are deprecated starting from v17.11 and are replaced:\n-\n- - ``eal_parse_pci_BDF`` replaced by ``rte_pci_addr_parse``\n- - ``eal_parse_pci_DomBDF`` replaced by ``rte_pci_addr_parse``\n- - ``rte_eal_compare_pci_addr`` replaced by ``rte_pci_addr_cmp``\n-\n * dpaa2: removal of ``rte_dpaa2_memsegs`` structure which has been replaced\n by a pa-va search library. This structure was earlier being used for holding\n memory segments used by dpaa2 driver for faster pa->va translation. This\ndiff --git a/doc/guides/rel_notes/release_19_11.rst b/doc/guides/rel_notes/release_19_11.rst\nindex 0c61c1c..579311d 100644\n--- a/doc/guides/rel_notes/release_19_11.rst\n+++ b/doc/guides/rel_notes/release_19_11.rst\n@@ -210,6 +210,12 @@ ABI Changes\n * eal: removed the ``rte_malloc_virt2phy`` function, replaced by\n ``rte_malloc_virt2iova`` since v17.11.\n \n+* pci: removed the following deprecated functions since dpdk:\n+\n+ - ``eal_parse_pci_BDF`` replaced by ``rte_pci_addr_parse``\n+ - ``eal_parse_pci_DomBDF`` replaced by ``rte_pci_addr_parse``\n+ - ``rte_eal_compare_pci_addr`` replaced by ``rte_pci_addr_cmp``\n+\n \n Shared Library Versions\n -----------------------\ndiff --git a/lib/librte_pci/rte_pci.c b/lib/librte_pci/rte_pci.c\nindex f400178..a753cf3 100644\n--- a/lib/librte_pci/rte_pci.c\n+++ b/lib/librte_pci/rte_pci.c\n@@ -87,18 +87,6 @@ pci_dbdf_parse(const char *input, struct rte_pci_addr *dev_addr)\n \treturn 0;\n }\n \n-int\n-eal_parse_pci_BDF(const char *input, struct rte_pci_addr *dev_addr)\n-{\n-\treturn pci_bdf_parse(input, dev_addr);\n-}\n-\n-int\n-eal_parse_pci_DomBDF(const char *input, struct rte_pci_addr *dev_addr)\n-{\n-\treturn pci_dbdf_parse(input, dev_addr);\n-}\n-\n void\n rte_pci_device_name(const struct rte_pci_addr *addr,\n \t\tchar *output, size_t size)\n@@ -110,13 +98,6 @@ rte_pci_device_name(const struct rte_pci_addr *addr,\n }\n \n int\n-rte_eal_compare_pci_addr(const struct rte_pci_addr *addr,\n-\t\t\t const struct rte_pci_addr *addr2)\n-{\n-\treturn rte_pci_addr_cmp(addr, addr2);\n-}\n-\n-int\n rte_pci_addr_cmp(const struct rte_pci_addr *addr,\n \t const struct rte_pci_addr *addr2)\n {\ndiff --git a/lib/librte_pci/rte_pci.h b/lib/librte_pci/rte_pci.h\nindex eaa9d07..c878914 100644\n--- a/lib/librte_pci/rte_pci.h\n+++ b/lib/librte_pci/rte_pci.h\n@@ -106,37 +106,6 @@ struct mapped_pci_resource {\n TAILQ_HEAD(mapped_pci_res_list, mapped_pci_resource);\n \n /**\n- * @deprecated\n- * Utility function to produce a PCI Bus-Device-Function value\n- * given a string representation. Assumes that the BDF is provided without\n- * a domain prefix (i.e. domain returned is always 0)\n- *\n- * @param input\n- *\tThe input string to be parsed. Should have the format XX:XX.X\n- * @param dev_addr\n- *\tThe PCI Bus-Device-Function address to be returned.\n- *\tDomain will always be returned as 0\n- * @return\n- * 0 on success, negative on error.\n- */\n-int eal_parse_pci_BDF(const char *input, struct rte_pci_addr *dev_addr);\n-\n-/**\n- * @deprecated\n- * Utility function to produce a PCI Bus-Device-Function value\n- * given a string representation. Assumes that the BDF is provided including\n- * a domain prefix.\n- *\n- * @param input\n- *\tThe input string to be parsed. Should have the format XXXX:XX:XX.X\n- * @param dev_addr\n- *\tThe PCI Bus-Device-Function address to be returned\n- * @return\n- * 0 on success, negative on error.\n- */\n-int eal_parse_pci_DomBDF(const char *input, struct rte_pci_addr *dev_addr);\n-\n-/**\n * Utility function to write a pci device name, this device name can later be\n * used to retrieve the corresponding rte_pci_addr using eal_parse_pci_*\n * BDF helpers.\n@@ -152,22 +121,6 @@ void rte_pci_device_name(const struct rte_pci_addr *addr,\n \t\t char *output, size_t size);\n \n /**\n- * @deprecated\n- * Utility function to compare two PCI device addresses.\n- *\n- * @param addr\n- *\tThe PCI Bus-Device-Function address to compare\n- * @param addr2\n- *\tThe PCI Bus-Device-Function address to compare\n- * @return\n- *\t0 on equal PCI address.\n- *\tPositive on addr is greater than addr2.\n- *\tNegative on addr is less than addr2, or error.\n- */\n-int rte_eal_compare_pci_addr(const struct rte_pci_addr *addr,\n-\t\t\t const struct rte_pci_addr *addr2);\n-\n-/**\n * Utility function to compare two PCI device addresses.\n *\n * @param addr\ndiff --git a/lib/librte_pci/rte_pci_version.map b/lib/librte_pci/rte_pci_version.map\nindex c028027..03790cb 100644\n--- a/lib/librte_pci/rte_pci_version.map\n+++ b/lib/librte_pci/rte_pci_version.map\n@@ -1,11 +1,8 @@\n DPDK_17.11 {\n \tglobal:\n \n-\teal_parse_pci_BDF;\n-\teal_parse_pci_DomBDF;\n \tpci_map_resource;\n \tpci_unmap_resource;\n-\trte_eal_compare_pci_addr;\n \trte_pci_addr_cmp;\n \trte_pci_addr_parse;\n \trte_pci_device_name;\n", "prefixes": [ "v2", "06/12" ] }