Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/61572/?format=api
{ "id": 61572, "url": "https://patches.dpdk.org/api/patches/61572/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1571651279-51857-2-git-send-email-gavin.hu@arm.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1571651279-51857-2-git-send-email-gavin.hu@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1571651279-51857-2-git-send-email-gavin.hu@arm.com", "date": "2019-10-21T09:47:54", "name": "[v8,1/6] bus/fslmc: fix the conflicting dmb function", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "06a2e35c408f7e8f703cbd7d2af2614e015c36d2", "submitter": { "id": 1018, "url": "https://patches.dpdk.org/api/people/1018/?format=api", "name": "Gavin Hu", "email": "gavin.hu@arm.com" }, "delegate": { "id": 24651, "url": "https://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1571651279-51857-2-git-send-email-gavin.hu@arm.com/mbox/", "series": [ { "id": 6963, "url": "https://patches.dpdk.org/api/series/6963/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=6963", "date": "2019-10-21T09:47:53", "name": "use WFE for aarch64", "version": 8, "mbox": "https://patches.dpdk.org/series/6963/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/61572/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/61572/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 525151BE85;\n\tMon, 21 Oct 2019 11:48:32 +0200 (CEST)", "from foss.arm.com (unknown [217.140.110.172])\n\tby dpdk.org (Postfix) with ESMTP id F22771BE85;\n\tMon, 21 Oct 2019 11:48:30 +0200 (CEST)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n\tby usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 79E141007;\n\tMon, 21 Oct 2019 02:48:21 -0700 (PDT)", "from net-arm-thunderx2-01.test.ast.arm.com\n\t(net-arm-thunderx2-01.shanghai.arm.com [10.169.40.40])\n\tby usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id\n\tEC7373F718; Mon, 21 Oct 2019 02:48:17 -0700 (PDT)" ], "From": "Gavin Hu <gavin.hu@arm.com>", "To": "dev@dpdk.org", "Cc": "nd@arm.com, david.marchand@redhat.com, konstantin.ananyev@intel.com,\n\tthomas@monjalon.net, stephen@networkplumber.org, hemant.agrawal@nxp.com, \n\tjerinj@marvell.com, pbhagavatula@marvell.com,\n\tHonnappa.Nagarahalli@arm.com, \n\truifeng.wang@arm.com, phil.yang@arm.com, steve.capper@arm.com,\n\tstable@dpdk.org", "Date": "Mon, 21 Oct 2019 17:47:54 +0800", "Message-Id": "<1571651279-51857-2-git-send-email-gavin.hu@arm.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": [ "<1571651279-51857-1-git-send-email-gavin.hu@arm.com>", "<1561911676-37718-1-git-send-email-gavin.hu@arm.com>" ], "References": [ "<1571651279-51857-1-git-send-email-gavin.hu@arm.com>", "<1561911676-37718-1-git-send-email-gavin.hu@arm.com>" ], "Subject": "[dpdk-dev] [PATCH v8 1/6] bus/fslmc: fix the conflicting dmb\n\tfunction", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "There are two definitions conflicting each other, for more\ndetails, refer to [1].\n\ninclude/rte_atomic_64.h:19: error: \"dmb\" redefined [-Werror]\ndrivers/bus/fslmc/mc/fsl_mc_sys.h:36: note: this is the location of the\nprevious definition\n #define dmb() {__asm__ __volatile__(\"\" : : : \"memory\"); }\n\nThe fix is to reuse the EAL definition to avoid conflicts.\n\n[1] http://inbox.dpdk.org/users/VI1PR08MB537631AB25F41B8880DCCA988FDF0@i\nVI1PR08MB5376.eurprd08.prod.outlook.com/T/#u\n\nFixes: 3af733ba8da8 (\"bus/fslmc: introduce MC object functions\")\nCc: stable@dpdk.org\n\nSigned-off-by: Gavin Hu <gavin.hu@arm.com>\nReviewed-by: Phil Yang <phi.yang@arm.com>\nAcked-by: Hemant Agrawal <hemant.agrawal@nxp.com>\n---\n drivers/bus/fslmc/mc/fsl_mc_sys.h | 8 +++-----\n 1 file changed, 3 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/bus/fslmc/mc/fsl_mc_sys.h b/drivers/bus/fslmc/mc/fsl_mc_sys.h\nindex d0c7b39..68ce38b 100644\n--- a/drivers/bus/fslmc/mc/fsl_mc_sys.h\n+++ b/drivers/bus/fslmc/mc/fsl_mc_sys.h\n@@ -31,12 +31,10 @@ struct fsl_mc_io {\n #include <errno.h>\n #include <sys/uio.h>\n #include <linux/byteorder/little_endian.h>\n+#include <rte_atomic.h>\n \n-#ifndef dmb\n-#define dmb() {__asm__ __volatile__(\"\" : : : \"memory\"); }\n-#endif\n-#define __iormb()\tdmb()\n-#define __iowmb()\tdmb()\n+#define __iormb()\trte_io_rmb()\n+#define __iowmb()\trte_io_wmb()\n #define __arch_getq(a)\t\t(*(volatile uint64_t *)(a))\n #define __arch_putq(v, a)\t(*(volatile uint64_t *)(a) = (v))\n #define __arch_putq32(v, a)\t(*(volatile uint32_t *)(a) = (v))\n", "prefixes": [ "v8", "1/6" ] }