Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/61221/?format=api
{ "id": 61221, "url": "https://patches.dpdk.org/api/patches/61221/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20191015160739.51940-4-yong.liu@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191015160739.51940-4-yong.liu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191015160739.51940-4-yong.liu@intel.com", "date": "2019-10-15T16:07:29", "name": "[v6,03/13] vhost: try to unroll for each loop", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "c16664339f92d3cc0d23d96424988204daa28fd7", "submitter": { "id": 17, "url": "https://patches.dpdk.org/api/people/17/?format=api", "name": "Marvin Liu", "email": "yong.liu@intel.com" }, "delegate": { "id": 2642, "url": "https://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20191015160739.51940-4-yong.liu@intel.com/mbox/", "series": [ { "id": 6853, "url": "https://patches.dpdk.org/api/series/6853/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=6853", "date": "2019-10-15T16:07:26", "name": "vhost packed ring performance optimization", "version": 6, "mbox": "https://patches.dpdk.org/series/6853/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/61221/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/61221/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B42351E8AA;\n\tTue, 15 Oct 2019 10:29:11 +0200 (CEST)", "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n\tby dpdk.org (Postfix) with ESMTP id 085631E544\n\tfor <dev@dpdk.org>; Tue, 15 Oct 2019 10:29:00 +0200 (CEST)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t15 Oct 2019 01:29:00 -0700", "from npg-dpdk-virtual-marvin-dev.sh.intel.com ([10.67.119.142])\n\tby orsmga001.jf.intel.com with ESMTP; 15 Oct 2019 01:28:59 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.67,298,1566889200\"; d=\"scan'208\";a=\"279120655\"", "From": "Marvin Liu <yong.liu@intel.com>", "To": "maxime.coquelin@redhat.com, tiwei.bie@intel.com, zhihong.wang@intel.com, \n\tstephen@networkplumber.org, gavin.hu@arm.com", "Cc": "dev@dpdk.org,\n\tMarvin Liu <yong.liu@intel.com>", "Date": "Wed, 16 Oct 2019 00:07:29 +0800", "Message-Id": "<20191015160739.51940-4-yong.liu@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20191015160739.51940-1-yong.liu@intel.com>", "References": "<20191015143014.1656-1-yong.liu@intel.com>\n\t<20191015160739.51940-1-yong.liu@intel.com>", "Subject": "[dpdk-dev] [PATCH v6 03/13] vhost: try to unroll for each loop", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Create macro for adding unroll pragma before for each loop. Batch\nfunctions will be contained of several small loops which can be\noptimized by compilers' loop unrolling pragma.\n\nSigned-off-by: Marvin Liu <yong.liu@intel.com>", "diff": "diff --git a/lib/librte_vhost/Makefile b/lib/librte_vhost/Makefile\nindex 8623e91c0..30839a001 100644\n--- a/lib/librte_vhost/Makefile\n+++ b/lib/librte_vhost/Makefile\n@@ -16,6 +16,24 @@ CFLAGS += -I vhost_user\n CFLAGS += -fno-strict-aliasing\n LDLIBS += -lpthread\n \n+ifeq ($(RTE_TOOLCHAIN), gcc)\n+ifeq ($(shell test $(GCC_VERSION) -ge 83 && echo 1), 1)\n+CFLAGS += -DSUPPORT_GCC_UNROLL_PRAGMA\n+endif\n+endif\n+\n+ifeq ($(RTE_TOOLCHAIN), clang)\n+ifeq ($(shell test $(CLANG_MAJOR_VERSION)$(CLANG_MINOR_VERSION) -ge 37 && echo 1), 1)\n+CFLAGS += -DSUPPORT_CLANG_UNROLL_PRAGMA\n+endif\n+endif\n+\n+ifeq ($(RTE_TOOLCHAIN), icc)\n+ifeq ($(shell test $(ICC_MAJOR_VERSION) -ge 16 && echo 1), 1)\n+CFLAGS += -DSUPPORT_ICC_UNROLL_PRAGMA\n+endif\n+endif\n+\n ifeq ($(CONFIG_RTE_LIBRTE_VHOST_NUMA),y)\n LDLIBS += -lnuma\n endif\ndiff --git a/lib/librte_vhost/meson.build b/lib/librte_vhost/meson.build\nindex cb1123ae3..ddf0ee579 100644\n--- a/lib/librte_vhost/meson.build\n+++ b/lib/librte_vhost/meson.build\n@@ -8,6 +8,13 @@ endif\n if has_libnuma == 1\n \tdpdk_conf.set10('RTE_LIBRTE_VHOST_NUMA', true)\n endif\n+if (toolchain == 'gcc' and cc.version().version_compare('>=8.3.0'))\n+\tcflags += '-DSUPPORT_GCC_UNROLL_PRAGMA'\n+elif (toolchain == 'clang' and cc.version().version_compare('>=3.7.0'))\n+\tcflags += '-DSUPPORT_CLANG_UNROLL_PRAGMA'\n+elif (toolchain == 'icc' and cc.version().version_compare('>=16.0.0'))\n+\tcflags += '-DSUPPORT_ICC_UNROLL_PRAGMA'\n+endif\n dpdk_conf.set('RTE_LIBRTE_VHOST_POSTCOPY',\n \t cc.has_header('linux/userfaultfd.h'))\n version = 4\ndiff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h\nindex 22a3ddc38..18d01cb19 100644\n--- a/lib/librte_vhost/vhost.h\n+++ b/lib/librte_vhost/vhost.h\n@@ -39,6 +39,30 @@\n \n #define VHOST_LOG_CACHE_NR 32\n \n+#define PACKED_BATCH_SIZE (RTE_CACHE_LINE_SIZE / \\\n+\t\t\t sizeof(struct vring_packed_desc))\n+#define PACKED_BATCH_MASK (PACKED_BATCH_SIZE - 1)\n+\n+#ifdef SUPPORT_GCC_UNROLL_PRAGMA\n+#define for_each_try_unroll(iter, val, size) _Pragma(\"GCC unroll 4\") \\\n+\tfor (iter = val; iter < size; iter++)\n+#endif\n+\n+#ifdef SUPPORT_CLANG_UNROLL_PRAGMA\n+#define for_each_try_unroll(iter, val, size) _Pragma(\"unroll 4\") \\\n+\tfor (iter = val; iter < size; iter++)\n+#endif\n+\n+#ifdef SUPPORT_ICC_UNROLL_PRAGMA\n+#define for_each_try_unroll(iter, val, size) _Pragma(\"unroll (4)\") \\\n+\tfor (iter = val; iter < size; iter++)\n+#endif\n+\n+#ifndef for_each_try_unroll\n+#define for_each_try_unroll(iter, val, num) \\\n+\tfor (iter = val; iter < num; iter++)\n+#endif\n+\n /**\n * Structure contains buffer address, length and descriptor index\n * from vring to do scatter RX.\n", "prefixes": [ "v6", "03/13" ] }