Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/61100/?format=api
{ "id": 61100, "url": "https://patches.dpdk.org/api/patches/61100/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20191014113448.7442-4-bruce.richardson@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191014113448.7442-4-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191014113448.7442-4-bruce.richardson@intel.com", "date": "2019-10-14T11:34:43", "name": "[3/8] examples/performance-thread: remove warning disabling", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "a2eae3747e197febd20e2110ef01ed68b863ba64", "submitter": { "id": 20, "url": "https://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20191014113448.7442-4-bruce.richardson@intel.com/mbox/", "series": [ { "id": 6830, "url": "https://patches.dpdk.org/api/series/6830/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=6830", "date": "2019-10-14T11:34:40", "name": "support all examples in a meson build", "version": 1, "mbox": "https://patches.dpdk.org/series/6830/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/61100/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/61100/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 84E641C200;\n\tMon, 14 Oct 2019 13:35:17 +0200 (CEST)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id 50ED01C1E3\n\tfor <dev@dpdk.org>; Mon, 14 Oct 2019 13:35:02 +0200 (CEST)", "from fmsmga007.fm.intel.com ([10.253.24.52])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t14 Oct 2019 04:35:01 -0700", "from silpixa00399126.ir.intel.com (HELO\n\tsilpixa00399126.ger.corp.intel.com) ([10.237.223.2])\n\tby fmsmga007.fm.intel.com with ESMTP; 14 Oct 2019 04:35:00 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.67,295,1566889200\"; d=\"scan'208\";a=\"194974144\"", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>", "Date": "Mon, 14 Oct 2019 12:34:43 +0100", "Message-Id": "<20191014113448.7442-4-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20191014113448.7442-1-bruce.richardson@intel.com>", "References": "<20191014113448.7442-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 3/8] examples/performance-thread: remove warning\n\tdisabling", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The warnings about functions not returning values can be removed from the\ncode by just adding an attribute to the function to specify it doesn't\nreturn. The GCC bug referenced in the makefile which prevents this from\nworking has been fixed for >10 years according to bugzilla.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n examples/performance-thread/l3fwd-thread/Makefile | 6 ------\n examples/performance-thread/l3fwd-thread/main.c | 4 ++--\n 2 files changed, 2 insertions(+), 8 deletions(-)", "diff": "diff --git a/examples/performance-thread/l3fwd-thread/Makefile b/examples/performance-thread/l3fwd-thread/Makefile\nindex 1a1c95829..b14b21e30 100644\n--- a/examples/performance-thread/l3fwd-thread/Makefile\n+++ b/examples/performance-thread/l3fwd-thread/Makefile\n@@ -20,10 +20,4 @@ include $(RTE_SDK)/examples/performance-thread/common/common.mk\n \n CFLAGS += -O3 -g $(USER_FLAGS) $(INCLUDES) $(WERROR_FLAGS)\n \n-# workaround for a gcc bug with noreturn attribute\n-# http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12603\n-#ifeq ($(CONFIG_RTE_TOOLCHAIN_GCC),y)\n-CFLAGS_main.o += -Wno-return-type\n-#endif\n-\n include $(RTE_SDK)/mk/rte.extapp.mk\ndiff --git a/examples/performance-thread/l3fwd-thread/main.c b/examples/performance-thread/l3fwd-thread/main.c\nindex 00f535053..d9af5c78d 100644\n--- a/examples/performance-thread/l3fwd-thread/main.c\n+++ b/examples/performance-thread/l3fwd-thread/main.c\n@@ -1877,7 +1877,7 @@ process_burst(struct rte_mbuf *pkts_burst[MAX_PKT_BURST], int nb_rx,\n /*\n * CPU-load stats collector\n */\n-static int\n+static int __attribute__((noreturn))\n cpu_load_collector(__rte_unused void *arg) {\n \tunsigned i, j, k;\n \tuint64_t hits;\n@@ -2299,7 +2299,7 @@ sched_spawner(__rte_unused void *arg) {\n }\n \n /* main processing loop */\n-static int\n+static int __attribute__((noreturn))\n pthread_tx(void *dummy)\n {\n \tstruct rte_mbuf *pkts_burst[MAX_PKT_BURST];\n", "prefixes": [ "3/8" ] }