Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/60921/?format=api
{ "id": 60921, "url": "https://patches.dpdk.org/api/patches/60921/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20191011040709.8344-1-pbhagavatula@marvell.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191011040709.8344-1-pbhagavatula@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191011040709.8344-1-pbhagavatula@marvell.com", "date": "2019-10-11T04:07:06", "name": "[1/3] app/test: use RTE_DIM instead of ARRAY_SIZE", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "0ed2fd60c66ba546bbce1b5a6cf6ef4d9b13f00a", "submitter": { "id": 1183, "url": "https://patches.dpdk.org/api/people/1183/?format=api", "name": "Pavan Nikhilesh Bhagavatula", "email": "pbhagavatula@marvell.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20191011040709.8344-1-pbhagavatula@marvell.com/mbox/", "series": [ { "id": 6796, "url": "https://patches.dpdk.org/api/series/6796/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=6796", "date": "2019-10-11T04:07:06", "name": "[1/3] app/test: use RTE_DIM instead of ARRAY_SIZE", "version": 1, "mbox": "https://patches.dpdk.org/series/6796/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/60921/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/60921/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 702BF1E877;\n\tFri, 11 Oct 2019 06:07:16 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n\t[67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 5017823D\n\tfor <dev@dpdk.org>; Fri, 11 Oct 2019 06:07:15 +0200 (CEST)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n\tby mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id\n\tx9B46KMu021729; Thu, 10 Oct 2019 21:07:14 -0700", "from sc-exch04.marvell.com ([199.233.58.184])\n\tby mx0b-0016f401.pphosted.com with ESMTP id 2vhdxc0394-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); \n\tThu, 10 Oct 2019 21:07:13 -0700", "from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH04.marvell.com\n\t(10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3;\n\tThu, 10 Oct 2019 21:07:12 -0700", "from maili.marvell.com (10.93.176.43) by SC-EXCH03.marvell.com\n\t(10.93.176.83) with Microsoft SMTP Server id 15.0.1367.3 via Frontend\n\tTransport; Thu, 10 Oct 2019 21:07:12 -0700", "from BG-LT7430.marvell.com (unknown [10.28.17.84])\n\tby maili.marvell.com (Postfix) with ESMTP id 5F4EC3F703F;\n\tThu, 10 Oct 2019 21:07:10 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n\th=from : to : cc :\n\tsubject : date : message-id : mime-version :\n\tcontent-transfer-encoding : content-type; s=pfpt0818;\n\tbh=sA4wsG/wlk2pDmG7aybo0btvrR2BxCWzmNV3k3dZOGg=; \n\tb=G+1DcP7nGbK1u+bM1Q4JAXmAr1l4MXlzRshE2pmLuz7HdKJzevi6KSaipRyCf0nULoSU\n\toB8xSUOIJnRBzXwQMDVdxLizj1eIG1WeTKuO708MjKxK4cB5JTVal7499shIhe30rlln\n\tzXxllkFWhk8tqxX7SBwe30qzx60NTMlQlpCIzWNOcAfpYlTvz684fa64dZg3K9oAC2JD\n\t0U9tCX2b5/V/cGOgT5dMhjku3hA1LUvEZbuuS9K9BNbVjQb8TF9rx1/WBi4JMKhZUXHM\n\tddEYYt+KUA183oWhN3Hp1YPDRX0/mE91VEzFUhzKxDZWH4TWcxEaEUq8xJRENKr0wfCC\n\twQ== ", "From": "<pbhagavatula@marvell.com>", "To": "Declan Doherty <declan.doherty@intel.com>,\n\tGage Eads <gage.eads@intel.com>, Olivier Matz <olivier.matz@6wind.com>", "CC": "<dev@dpdk.org>, Pavan Nikhilesh <pbhagavatula@marvell.com>", "Date": "Fri, 11 Oct 2019 09:37:06 +0530", "Message-ID": "<20191011040709.8344-1-pbhagavatula@marvell.com>", "X-Mailer": "git-send-email 2.17.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.95,1.0.8\n\tdefinitions=2019-10-11_02:2019-10-10,2019-10-11 signatures=0", "Subject": "[dpdk-dev] [PATCH 1/3] app/test: use RTE_DIM instead of ARRAY_SIZE", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Pavan Nikhilesh <pbhagavatula@marvell.com>\n\nUse RTE_DIM instead of re-defining ARRAY_SIZE.\n\nSigned-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>\n---\n app/test/test_cryptodev_asym.c | 8 ++------\n app/test/test_metrics.c | 11 +++++------\n app/test/test_stack_perf.c | 8 +++-----\n 3 files changed, 10 insertions(+), 17 deletions(-)", "diff": "diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asym.c\nindex e8177e73a..7ff631600 100644\n--- a/app/test/test_cryptodev_asym.c\n+++ b/app/test/test_cryptodev_asym.c\n@@ -26,10 +26,6 @@\n #define TEST_NUM_BUFS 10\n #define TEST_NUM_SESSIONS 4\n \n-#ifndef ARRAY_SIZE\n-#define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0]))\n-#endif\n-\n #ifndef TEST_DATA_SIZE\n \t#define TEST_DATA_SIZE 4096\n #endif\n@@ -473,7 +469,7 @@ load_test_vectors(void)\n {\n \tuint32_t i = 0, v_size = 0;\n \t/* Load MODEX vector*/\n-\tv_size = ARRAY_SIZE(modex_test_case);\n+\tv_size = RTE_DIM(modex_test_case);\n \tfor (i = 0; i < v_size; i++) {\n \t\tif (test_vector.size >= (TEST_VECTOR_SIZE)) {\n \t\t\tRTE_LOG(DEBUG, USER1,\n@@ -484,7 +480,7 @@ load_test_vectors(void)\n \t\ttest_vector.size++;\n \t}\n \t/* Load MODINV vector*/\n-\tv_size = ARRAY_SIZE(modinv_test_case);\n+\tv_size = RTE_DIM(modinv_test_case);\n \tfor (i = 0; i < v_size; i++) {\n \t\tif (test_vector.size >= (TEST_VECTOR_SIZE)) {\n \t\t\tRTE_LOG(DEBUG, USER1,\ndiff --git a/app/test/test_metrics.c b/app/test/test_metrics.c\nindex 78b3936ee..e736019ae 100644\n--- a/app/test/test_metrics.c\n+++ b/app/test/test_metrics.c\n@@ -12,7 +12,6 @@\n \n #include \"test.h\"\n \n-#define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0]))\n #define\tREG_METRIC_COUNT\t6\n #define\tMETRIC_LESSER_COUNT\t3\n #define\tKEY\t1\n@@ -106,7 +105,7 @@ test_metrics_reg_names(void)\n \t\t};\n \n \t/* Success Test: valid array and count size */\n-\terr = rte_metrics_reg_names(&mnames[0], ARRAY_SIZE(mnames));\n+\terr = rte_metrics_reg_names(&mnames[0], RTE_DIM(mnames));\n \tTEST_ASSERT(err >= 0, \"%s, %d\", __func__, __LINE__);\n \n \treturn TEST_SUCCESS;\n@@ -167,20 +166,20 @@ test_metrics_update_values(void)\n \n \t/* Failed Test: Invalid count size */\n \terr = rte_metrics_update_values(RTE_METRICS_GLOBAL,\n-\t\t\t KEY, &value[0], ARRAY_SIZE(value));\n+\t\t\t KEY, &value[0], RTE_DIM(value));\n \tTEST_ASSERT(err < 0, \"%s, %d\", __func__, __LINE__);\n \n \t/* Failed Test: Invalid port_id(lower value) and valid data */\n-\terr = rte_metrics_update_values(-2, KEY, &value[0], ARRAY_SIZE(value));\n+\terr = rte_metrics_update_values(-2, KEY, &value[0], RTE_DIM(value));\n \tTEST_ASSERT(err == -EINVAL, \"%s, %d\", __func__, __LINE__);\n \n \t/* Failed Test: Invalid port_id(higher value) and valid data */\n-\terr = rte_metrics_update_values(39, 1, &value[0], ARRAY_SIZE(value));\n+\terr = rte_metrics_update_values(39, 1, &value[0], RTE_DIM(value));\n \tTEST_ASSERT(err == -EINVAL, \"%s, %d\", __func__, __LINE__);\n \n \t/* Failed Test: Invalid array */\n \terr = rte_metrics_update_values(RTE_METRICS_GLOBAL,\n-\t\t\t KEY, NULL, ARRAY_SIZE(value));\n+\t\t\t KEY, NULL, RTE_DIM(value));\n \tTEST_ASSERT(err == -EINVAL, \"%s, %d\", __func__, __LINE__);\n \n \treturn TEST_SUCCESS;\ndiff --git a/app/test/test_stack_perf.c b/app/test/test_stack_perf.c\nindex 70561fecd..3ab7267b1 100644\n--- a/app/test/test_stack_perf.c\n+++ b/app/test/test_stack_perf.c\n@@ -18,8 +18,6 @@\n #define MAX_BURST 32\n #define STACK_SIZE (RTE_MAX_LCORE * MAX_BURST)\n \n-#define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0]))\n-\n /*\n * Push/pop bulk sizes, marked volatile so they aren't treated as compile-time\n * constants.\n@@ -176,7 +174,7 @@ run_on_core_pair(struct lcore_pair *cores, struct rte_stack *s,\n \tstruct thread_args args[2];\n \tunsigned int i;\n \n-\tfor (i = 0; i < ARRAY_SIZE(bulk_sizes); i++) {\n+\tfor (i = 0; i < RTE_DIM(bulk_sizes); i++) {\n \t\trte_atomic32_set(&lcore_barrier, 2);\n \n \t\targs[0].sz = args[1].sz = bulk_sizes[i];\n@@ -205,7 +203,7 @@ run_on_n_cores(struct rte_stack *s, lcore_function_t fn, int n)\n \tstruct thread_args args[RTE_MAX_LCORE];\n \tunsigned int i;\n \n-\tfor (i = 0; i < ARRAY_SIZE(bulk_sizes); i++) {\n+\tfor (i = 0; i < RTE_DIM(bulk_sizes); i++) {\n \t\tunsigned int lcore_id;\n \t\tint cnt = 0;\n \t\tdouble avg;\n@@ -280,7 +278,7 @@ test_bulk_push_pop(struct rte_stack *s)\n \tvoid *objs[MAX_BURST];\n \tunsigned int sz, i;\n \n-\tfor (sz = 0; sz < ARRAY_SIZE(bulk_sizes); sz++) {\n+\tfor (sz = 0; sz < RTE_DIM(bulk_sizes); sz++) {\n \t\tuint64_t start = rte_rdtsc();\n \n \t\tfor (i = 0; i < iterations; i++) {\n", "prefixes": [ "1/3" ] }