Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/60901/?format=api
{ "id": 60901, "url": "https://patches.dpdk.org/api/patches/60901/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/414705e211ee83207c7e09ce83e3f341b2d6be03.1570718029.git.cloud.wangxiaoyun@huawei.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<414705e211ee83207c7e09ce83e3f341b2d6be03.1570718029.git.cloud.wangxiaoyun@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/414705e211ee83207c7e09ce83e3f341b2d6be03.1570718029.git.cloud.wangxiaoyun@huawei.com", "date": "2019-10-10T14:51:59", "name": "[v4,15/19] net/hinic: support LRO offload", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "1af0b45f7213e25807059c0ecbcd3779be56c05a", "submitter": { "id": 1446, "url": "https://patches.dpdk.org/api/people/1446/?format=api", "name": "Wangxiaoyun (Cloud)", "email": "cloud.wangxiaoyun@huawei.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/414705e211ee83207c7e09ce83e3f341b2d6be03.1570718029.git.cloud.wangxiaoyun@huawei.com/mbox/", "series": [ { "id": 6786, "url": "https://patches.dpdk.org/api/series/6786/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=6786", "date": "2019-10-10T14:51:44", "name": "Add advanced features for Huawei hinic pmd", "version": 4, "mbox": "https://patches.dpdk.org/series/6786/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/60901/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/60901/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 3D7991EA8E;\n\tThu, 10 Oct 2019 16:40:14 +0200 (CEST)", "from huawei.com (szxga07-in.huawei.com [45.249.212.35])\n\tby dpdk.org (Postfix) with ESMTP id 57C5E1EA69\n\tfor <dev@dpdk.org>; Thu, 10 Oct 2019 16:40:10 +0200 (CEST)", "from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.59])\n\tby Forcepoint Email with ESMTP id 36E4391457F77D64CC8F\n\tfor <dev@dpdk.org>; Thu, 10 Oct 2019 22:40:07 +0800 (CST)", "from tester.localdomain (10.175.119.39) by\n\tDGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP\n\tServer id 14.3.439.0; Thu, 10 Oct 2019 22:39:57 +0800" ], "From": "Xiaoyun wang <cloud.wangxiaoyun@huawei.com>", "To": "<ferruh.yigit@intel.com>", "CC": "<dev@dpdk.org>, <xuanziyang2@huawei.com>, <shahar.belkar@huawei.com>,\n\t<luoxianjun@huawei.com>, <tanya.brokhman@huawei.com>,\n\t<zhouguoyang@huawei.com>, Xiaoyun wang <cloud.wangxiaoyun@huawei.com>", "Date": "Thu, 10 Oct 2019 22:51:59 +0800", "Message-ID": "<414705e211ee83207c7e09ce83e3f341b2d6be03.1570718029.git.cloud.wangxiaoyun@huawei.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<cover.1570718029.git.cloud.wangxiaoyun@huawei.com>", "References": "<cover.1570718029.git.cloud.wangxiaoyun@huawei.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.175.119.39]", "X-CFilter-Loop": "Reflected", "Subject": "[dpdk-dev] [PATCH v4 15/19] net/hinic: support LRO offload", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch supports LRO offload.\n\nSigned-off-by: Xiaoyun wang <cloud.wangxiaoyun@huawei.com>\n---\n doc/guides/nics/features/hinic.ini | 1 +\n doc/guides/nics/hinic.rst | 1 +\n drivers/net/hinic/hinic_pmd_ethdev.c | 24 ++++++++++++++++++------\n 3 files changed, 20 insertions(+), 6 deletions(-)", "diff": "diff --git a/doc/guides/nics/features/hinic.ini b/doc/guides/nics/features/hinic.ini\nindex 2c9d845..65a335a 100644\n--- a/doc/guides/nics/features/hinic.ini\n+++ b/doc/guides/nics/features/hinic.ini\n@@ -13,6 +13,7 @@ MTU update = Y\n Jumbo frame = Y\n Scattered Rx = Y\n TSO = Y\n+LRO = Y\n Promiscuous mode = Y\n Allmulticast mode = Y\n Unicast MAC filter = Y\ndiff --git a/doc/guides/nics/hinic.rst b/doc/guides/nics/hinic.rst\nindex ed607eb..9fb80d4 100644\n--- a/doc/guides/nics/hinic.rst\n+++ b/doc/guides/nics/hinic.rst\n@@ -33,6 +33,7 @@ Features\n - Flow director\n - Set Link down or up\n - FW version\n+- LRO\n \n Prerequisites\n -------------\ndiff --git a/drivers/net/hinic/hinic_pmd_ethdev.c b/drivers/net/hinic/hinic_pmd_ethdev.c\nindex b2cc0e4..54b9b49 100644\n--- a/drivers/net/hinic/hinic_pmd_ethdev.c\n+++ b/drivers/net/hinic/hinic_pmd_ethdev.c\n@@ -70,6 +70,9 @@\n #define HINIC_PKTLEN_TO_MTU(pktlen)\t\\\n \t((pktlen) - (ETH_HLEN + ETH_CRC_LEN))\n \n+/* lro numer limit for one packet */\n+#define HINIC_LRO_WQE_NUM_DEFAULT\t8\n+\n /* Driver-specific log messages type */\n int hinic_logtype;\n \n@@ -731,7 +734,8 @@ static void hinic_get_speed_capa(struct rte_eth_dev *dev, uint32_t *speed_capa)\n \t\t\t\tDEV_RX_OFFLOAD_TCP_CKSUM |\n \t\t\t\tDEV_RX_OFFLOAD_VLAN_FILTER |\n \t\t\t\tDEV_RX_OFFLOAD_SCATTER |\n-\t\t\t\tDEV_RX_OFFLOAD_JUMBO_FRAME;\n+\t\t\t\tDEV_RX_OFFLOAD_JUMBO_FRAME |\n+\t\t\t\tDEV_RX_OFFLOAD_TCP_LRO;\n \n \tinfo->tx_queue_offload_capa = 0;\n \tinfo->tx_offload_capa = DEV_TX_OFFLOAD_VLAN_INSERT |\n@@ -792,6 +796,7 @@ static int hinic_rxtx_configure(struct rte_eth_dev *dev)\n {\n \tint err;\n \tstruct hinic_nic_dev *nic_dev = HINIC_ETH_DEV_TO_PRIVATE_NIC_DEV(dev);\n+\tbool lro_en;\n \n \t/* rx configure, if rss enable, need to init default configuration */\n \terr = hinic_rx_configure(dev);\n@@ -808,6 +813,18 @@ static int hinic_rxtx_configure(struct rte_eth_dev *dev)\n \t\tgoto set_rx_mode_fail;\n \t}\n \n+\t/* config lro */\n+\tlro_en = dev->data->dev_conf.rxmode.offloads & DEV_RX_OFFLOAD_TCP_LRO ?\n+\t\t\ttrue : false;\n+\n+\terr = hinic_set_rx_lro(nic_dev->hwdev, lro_en, lro_en,\n+\t\t\t\tHINIC_LRO_WQE_NUM_DEFAULT);\n+\tif (err) {\n+\t\tPMD_DRV_LOG(ERR, \"%s lro failed, err: %d\",\n+\t\t\tlro_en ? \"Enable\" : \"Disable\", err);\n+\t\tgoto set_rx_mode_fail;\n+\t}\n+\n \treturn HINIC_OK;\n \n set_rx_mode_fail:\n@@ -2478,11 +2495,6 @@ static int hinic_set_default_hw_feature(struct hinic_nic_dev *nic_dev)\n \tif (err)\n \t\treturn err;\n \n-\t/* disable LRO */\n-\terr = hinic_set_rx_lro(nic_dev->hwdev, 0, 0, (u8)0);\n-\tif (err)\n-\t\treturn err;\n-\n \t/* Set pause enable, and up will disable pfc. */\n \terr = hinic_set_default_pause_feature(nic_dev);\n \tif (err)\n", "prefixes": [ "v4", "15/19" ] }