Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/60647/?format=api
{ "id": 60647, "url": "https://patches.dpdk.org/api/patches/60647/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20191007165232.14535-4-stephen@networkplumber.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191007165232.14535-4-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20191007165232.14535-4-stephen@networkplumber.org", "date": "2019-10-07T16:52:27", "name": "[RFC,3/8] pdump: tag copied mbuf with port", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "a940f1aa7d3aaa0a71cfd0fe2e6ff927c31f0e15", "submitter": { "id": 27, "url": "https://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20191007165232.14535-4-stephen@networkplumber.org/mbox/", "series": [ { "id": 6728, "url": "https://patches.dpdk.org/api/series/6728/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=6728", "date": "2019-10-07T16:52:24", "name": "Packet Capture enhancements", "version": 1, "mbox": "https://patches.dpdk.org/series/6728/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/60647/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/60647/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B37BD1D172;\n\tMon, 7 Oct 2019 18:52:50 +0200 (CEST)", "from mail-pf1-f194.google.com (mail-pf1-f194.google.com\n\t[209.85.210.194]) by dpdk.org (Postfix) with ESMTP id C7AF61D14B\n\tfor <dev@dpdk.org>; Mon, 7 Oct 2019 18:52:44 +0200 (CEST)", "by mail-pf1-f194.google.com with SMTP id h195so9028311pfe.5\n\tfor <dev@dpdk.org>; Mon, 07 Oct 2019 09:52:44 -0700 (PDT)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\tw5sm15920979pfn.96.2019.10.07.09.52.42\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 07 Oct 2019 09:52:43 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=gK1gfSTtDiveUg2rvONozxMW7EsdJv6dQhvvDqdmx4w=;\n\tb=G32iCTaXMq3Im9mnf44IuUoaSYJKkeJhAaCUeid7oMK0ftXRoyIMkQAQTqsW5hPy5r\n\tW7k0RyqvlEjg/pbtY8sjoiorU/eZtsPASiynAYNsLeThE2leicLFU6GTOKC9oZCMOKlo\n\tmlB15jpuiC2kRrv5TvrVJ1qWrinqzuWAhQPBUUWQacJGtuz9l5mCqstQ0/vqgwTL1ozX\n\t+Qx/FT1SvP4qz3kVmZL1uQ/uhoN94qagVBhZ6CwOCzyr3d6UVpasHzqoX5KXUh9b5SVn\n\tCIXwQfLA4HCbFfOcRgvqXc4/tVdGPIRtpcndda47PxdS6C9B0D9cM/zQgmodFv4zHvVS\n\tvqqg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=gK1gfSTtDiveUg2rvONozxMW7EsdJv6dQhvvDqdmx4w=;\n\tb=ItKZennzK67nKUiLP+77tiKONINIiLixCsWNC87QJSyhPOc17+thcj819vIHIazXv8\n\tfwUr0LvDx0arrW9N6E4x/d0FpsDTlbsy8kmv/MILn515OKoXkKaV19dVHNnlyy0FdOnm\n\tMEBaVjiUfVBMeTwIZqfx0rJ7giO51K7toUdUOTKC0jpozW4ugPLMU5GfotFhFL1l3Qqn\n\tXK98p7WL3fU5OjBelDcXtoln67X+lxtmANlEMFaTupzIONmYrZIg3wwA9eRDIzdyHkp/\n\t1LGkl1754mqKmGp8AYMdFpJtO9eOY5FiPXXVliGy1UzRec8PW/dv6KsEL/rq91hJueqp\n\tLbLQ==", "X-Gm-Message-State": "APjAAAVfFobobtOZ72TMwYkd5H69c8k8NLJpLPCSix3iJCGWfDuFyTWI\n\tMwNpYeB+ENl/vUz2mp6MKgERM5KlOey4fw==", "X-Google-Smtp-Source": "APXvYqwzTKDIYz7D5s0AuBdqvF+fkKcujQ3hLygKQyIIWYo2YtFbsVIHlxcbip6eATcPYc9+bVIOTw==", "X-Received": "by 2002:a17:90a:1c7:: with SMTP id 7mr234961pjd.95.1570467163632;\n\tMon, 07 Oct 2019 09:52:43 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Date": "Mon, 7 Oct 2019 09:52:27 -0700", "Message-Id": "<20191007165232.14535-4-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20191007165232.14535-1-stephen@networkplumber.org>", "References": "<20191007165232.14535-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [RFC 3/8] pdump: tag copied mbuf with port", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Set the port when packets go into ring, so same ring can be\nused for multiple ports.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/librte_pdump/rte_pdump.c | 18 ++++++++++--------\n 1 file changed, 10 insertions(+), 8 deletions(-)", "diff": "diff --git a/lib/librte_pdump/rte_pdump.c b/lib/librte_pdump/rte_pdump.c\nindex cfb8be7ca227..830decef91e2 100644\n--- a/lib/librte_pdump/rte_pdump.c\n+++ b/lib/librte_pdump/rte_pdump.c\n@@ -68,9 +68,9 @@ static struct pdump_rxtx_cbs {\n } rx_cbs[RTE_MAX_ETHPORTS][RTE_MAX_QUEUES_PER_PORT],\n tx_cbs[RTE_MAX_ETHPORTS][RTE_MAX_QUEUES_PER_PORT];\n \n-\n-static inline void\n-pdump_copy(struct rte_mbuf **pkts, uint16_t nb_pkts, void *user_params)\n+static void\n+pdump_copy(uint16_t port, struct rte_mbuf **pkts,\n+\t uint16_t nb_pkts, void *user_params)\n {\n \tunsigned i;\n \tint ring_enq;\n@@ -86,8 +86,10 @@ pdump_copy(struct rte_mbuf **pkts, uint16_t nb_pkts, void *user_params)\n \tmp = cbs->mp;\n \tfor (i = 0; i < nb_pkts; i++) {\n \t\tp = rte_pktmbuf_copy(pkts[i], mp, 0, UINT32_MAX);\n-\t\tif (p)\n+\t\tif (p) {\n+\t\t\tp->port = port;\n \t\t\tdup_bufs[d_pkts++] = p;\n+\t\t}\n \t}\n \n \tring_enq = rte_ring_enqueue_burst(ring, (void *)dup_bufs, d_pkts, NULL);\n@@ -101,20 +103,20 @@ pdump_copy(struct rte_mbuf **pkts, uint16_t nb_pkts, void *user_params)\n }\n \n static uint16_t\n-pdump_rx(uint16_t port __rte_unused, uint16_t qidx __rte_unused,\n+pdump_rx(uint16_t port, uint16_t qidx __rte_unused,\n \tstruct rte_mbuf **pkts, uint16_t nb_pkts,\n \tuint16_t max_pkts __rte_unused,\n \tvoid *user_params)\n {\n-\tpdump_copy(pkts, nb_pkts, user_params);\n+\tpdump_copy(port, pkts, nb_pkts, user_params);\n \treturn nb_pkts;\n }\n \n static uint16_t\n-pdump_tx(uint16_t port __rte_unused, uint16_t qidx __rte_unused,\n+pdump_tx(uint16_t port, uint16_t qidx __rte_unused,\n \t\tstruct rte_mbuf **pkts, uint16_t nb_pkts, void *user_params)\n {\n-\tpdump_copy(pkts, nb_pkts, user_params);\n+\tpdump_copy(port, pkts, nb_pkts, user_params);\n \treturn nb_pkts;\n }\n \n", "prefixes": [ "RFC", "3/8" ] }