Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/60645/?format=api
{ "id": 60645, "url": "https://patches.dpdk.org/api/patches/60645/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20191007165232.14535-2-stephen@networkplumber.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191007165232.14535-2-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20191007165232.14535-2-stephen@networkplumber.org", "date": "2019-10-07T16:52:25", "name": "[RFC,1/8] pdump: use new pktmbuf copy function", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "b979d58b8c211d29ad122d309d808e402a59afef", "submitter": { "id": 27, "url": "https://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20191007165232.14535-2-stephen@networkplumber.org/mbox/", "series": [ { "id": 6728, "url": "https://patches.dpdk.org/api/series/6728/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=6728", "date": "2019-10-07T16:52:24", "name": "Packet Capture enhancements", "version": 1, "mbox": "https://patches.dpdk.org/series/6728/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/60645/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/60645/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id AF1DE1D14D;\n\tMon, 7 Oct 2019 18:52:46 +0200 (CEST)", "from mail-pg1-f175.google.com (mail-pg1-f175.google.com\n\t[209.85.215.175]) by dpdk.org (Postfix) with ESMTP id 775E11C43D\n\tfor <dev@dpdk.org>; Mon, 7 Oct 2019 18:52:43 +0200 (CEST)", "by mail-pg1-f175.google.com with SMTP id b8so2206743pgm.13\n\tfor <dev@dpdk.org>; Mon, 07 Oct 2019 09:52:43 -0700 (PDT)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\tw5sm15920979pfn.96.2019.10.07.09.52.41\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 07 Oct 2019 09:52:41 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=zdsVTY0D8zVTp25c2Ag/LpUnnCKhJ2sj1djQsUGrXUo=;\n\tb=1ERzE9iqLfkegqehVqbIwtr+Jl6TULvFqBDzaQIFrpBp8DDaLal0Pbpmp/eZcUguTF\n\tYMycl2YZFuaC1Un1525ClbnJJEMSfUbzzqPq8IsVCe7e3Gcsl5mTjmWNGI3iJZa+0K/H\n\t0GXfx3G8Zhqa+9YYoHzhG3c0KL5MCT35ycSbReguc1VD8Ilf1bh/BMEI1UCul/Y85U+S\n\tj0fzjd1ZjIlIZGFp6VPWZi4jd0fi2rWq6V48Cf0TZI6qUyFnnCbEwuh1Df7Wl5cnFR1d\n\tpQbdQ0/FcngToJd9ixCWL4TJAk4XZLXU1KOcxO8BH7tyIxl3ftHA8EESfBlVlF9OwxX+\n\tGrKw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=zdsVTY0D8zVTp25c2Ag/LpUnnCKhJ2sj1djQsUGrXUo=;\n\tb=B4N9zFcY3anU4oFzApAsgAj81SkaQmysid2Y9HzD/+Oc/U7AK8iNVS+WIbyo+cwzbS\n\tq2gmMEMbFZmDf9ilu/W4mJjVwuY4LRg5/oIBC5C4GDdabG8Qp4IHxJpeDIYEKwpd2aKD\n\tnyheFVP9eGlm0f2dxNxtovPoLJRmDjeyluKSveoUa4cdHqy/D1WVQXUuyfMekwfqftB7\n\tgcggc0+x7OnSUzA/LC6yyqOeGdIOtcs33cC+ql2/xIxtF2knqklA961xVIFPa1o+Txdr\n\t876XkQRoQbJsGPKxrmJqJnY419bCLZ/biBWXDTfptGCUSrgCgVyQ59nWa55tJWaDk2Ia\n\taklA==", "X-Gm-Message-State": "APjAAAUDsjtKWRpvvvYpLkOhnhAwHbNnpMyrxr1xaI1g/Z7f0qR3qaBa\n\t7Pyh+QeXd/6znrP7Lnbs3np440B5NqNmZw==", "X-Google-Smtp-Source": "APXvYqyoRXmuN+rCXmunUWuAHHPvZl8nkl2hcayfWXi5xl8sXihgzS2NqN2xMF0H3PefL/mEqYtj1Q==", "X-Received": "by 2002:a17:90a:db4a:: with SMTP id\n\tu10mr306757pjx.30.1570467161998; \n\tMon, 07 Oct 2019 09:52:41 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Date": "Mon, 7 Oct 2019 09:52:25 -0700", "Message-Id": "<20191007165232.14535-2-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20191007165232.14535-1-stephen@networkplumber.org>", "References": "<20191007165232.14535-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [RFC 1/8] pdump: use new pktmbuf copy function", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The rte_pktmbuf_copy handles varying size mbuf pools correctly.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/librte_pdump/rte_pdump.c | 69 +-----------------------------------\n 1 file changed, 1 insertion(+), 68 deletions(-)", "diff": "diff --git a/lib/librte_pdump/rte_pdump.c b/lib/librte_pdump/rte_pdump.c\nindex cd24dd010951..c665cf237f65 100644\n--- a/lib/librte_pdump/rte_pdump.c\n+++ b/lib/librte_pdump/rte_pdump.c\n@@ -64,73 +64,6 @@ static struct pdump_rxtx_cbs {\n } rx_cbs[RTE_MAX_ETHPORTS][RTE_MAX_QUEUES_PER_PORT],\n tx_cbs[RTE_MAX_ETHPORTS][RTE_MAX_QUEUES_PER_PORT];\n \n-static inline int\n-pdump_pktmbuf_copy_data(struct rte_mbuf *seg, const struct rte_mbuf *m)\n-{\n-\tif (rte_pktmbuf_tailroom(seg) < m->data_len) {\n-\t\tRTE_LOG(ERR, PDUMP,\n-\t\t\t\"User mempool: insufficient data_len of mbuf\\n\");\n-\t\treturn -EINVAL;\n-\t}\n-\n-\tseg->port = m->port;\n-\tseg->vlan_tci = m->vlan_tci;\n-\tseg->hash = m->hash;\n-\tseg->tx_offload = m->tx_offload;\n-\tseg->ol_flags = m->ol_flags;\n-\tseg->packet_type = m->packet_type;\n-\tseg->vlan_tci_outer = m->vlan_tci_outer;\n-\tseg->data_len = m->data_len;\n-\tseg->pkt_len = seg->data_len;\n-\trte_memcpy(rte_pktmbuf_mtod(seg, void *),\n-\t\t\trte_pktmbuf_mtod(m, void *),\n-\t\t\trte_pktmbuf_data_len(seg));\n-\n-\treturn 0;\n-}\n-\n-static inline struct rte_mbuf *\n-pdump_pktmbuf_copy(struct rte_mbuf *m, struct rte_mempool *mp)\n-{\n-\tstruct rte_mbuf *m_dup, *seg, **prev;\n-\tuint32_t pktlen;\n-\tuint16_t nseg;\n-\n-\tm_dup = rte_pktmbuf_alloc(mp);\n-\tif (unlikely(m_dup == NULL))\n-\t\treturn NULL;\n-\n-\tseg = m_dup;\n-\tprev = &seg->next;\n-\tpktlen = m->pkt_len;\n-\tnseg = 0;\n-\n-\tdo {\n-\t\tnseg++;\n-\t\tif (pdump_pktmbuf_copy_data(seg, m) < 0) {\n-\t\t\tif (seg != m_dup)\n-\t\t\t\trte_pktmbuf_free_seg(seg);\n-\t\t\trte_pktmbuf_free(m_dup);\n-\t\t\treturn NULL;\n-\t\t}\n-\t\t*prev = seg;\n-\t\tprev = &seg->next;\n-\t} while ((m = m->next) != NULL &&\n-\t\t\t(seg = rte_pktmbuf_alloc(mp)) != NULL);\n-\n-\t*prev = NULL;\n-\tm_dup->nb_segs = nseg;\n-\tm_dup->pkt_len = pktlen;\n-\n-\t/* Allocation of new indirect segment failed */\n-\tif (unlikely(seg == NULL)) {\n-\t\trte_pktmbuf_free(m_dup);\n-\t\treturn NULL;\n-\t}\n-\n-\t__rte_mbuf_sanity_check(m_dup, 1);\n-\treturn m_dup;\n-}\n \n static inline void\n pdump_copy(struct rte_mbuf **pkts, uint16_t nb_pkts, void *user_params)\n@@ -148,7 +81,7 @@ pdump_copy(struct rte_mbuf **pkts, uint16_t nb_pkts, void *user_params)\n \tring = cbs->ring;\n \tmp = cbs->mp;\n \tfor (i = 0; i < nb_pkts; i++) {\n-\t\tp = pdump_pktmbuf_copy(pkts[i], mp);\n+\t\tp = rte_pktmbuf_copy(pkts[i], mp, 0, UINT32_MAX);\n \t\tif (p)\n \t\t\tdup_bufs[d_pkts++] = p;\n \t}\n", "prefixes": [ "RFC", "1/8" ] }