Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 60569,
    "url": "https://patches.dpdk.org/api/patches/60569/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20191006031408.8633-4-qi.z.zhang@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20191006031408.8633-4-qi.z.zhang@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20191006031408.8633-4-qi.z.zhang@intel.com",
    "date": "2019-10-06T03:13:59",
    "name": "[v2,03/12] net/ice/base: update flow ptype bitmaps",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "d638f515a2ef9b9a9fe04c3cc6a950e7f9d8063d",
    "submitter": {
        "id": 504,
        "url": "https://patches.dpdk.org/api/people/504/?format=api",
        "name": "Qi Zhang",
        "email": "qi.z.zhang@intel.com"
    },
    "delegate": {
        "id": 31221,
        "url": "https://patches.dpdk.org/api/users/31221/?format=api",
        "username": "yexl",
        "first_name": "xiaolong",
        "last_name": "ye",
        "email": "xiaolong.ye@intel.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20191006031408.8633-4-qi.z.zhang@intel.com/mbox/",
    "series": [
        {
            "id": 6704,
            "url": "https://patches.dpdk.org/api/series/6704/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=6704",
            "date": "2019-10-06T03:13:56",
            "name": "[v2,01/12] net/ice/base: fix for adding PPPoE switch rule",
            "version": 2,
            "mbox": "https://patches.dpdk.org/series/6704/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/60569/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/60569/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 35A701D154;\n\tSun,  6 Oct 2019 05:11:26 +0200 (CEST)",
            "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id 342131C43B\n\tfor <dev@dpdk.org>; Sun,  6 Oct 2019 05:11:21 +0200 (CEST)",
            "from orsmga007.jf.intel.com ([10.7.209.58])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t05 Oct 2019 20:11:20 -0700",
            "from dpdk51.sh.intel.com ([10.67.110.245])\n\tby orsmga007.jf.intel.com with ESMTP; 05 Oct 2019 20:11:19 -0700"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.67,261,1566889200\"; d=\"scan'208\";a=\"183095209\"",
        "From": "Qi Zhang <qi.z.zhang@intel.com>",
        "To": "wenzhuo.lu@intel.com,\n\tqiming.yang@intel.com",
        "Cc": "dev@dpdk.org, xiaolong.ye@intel.com, Qi Zhang <qi.z.zhang@intel.com>,\n\tDan Nowlin <dan.nowlin@intel.com>,\n\tPaul M Stillwell Jr <paul.m.stillwell.jr@intel.com>",
        "Date": "Sun,  6 Oct 2019 11:13:59 +0800",
        "Message-Id": "<20191006031408.8633-4-qi.z.zhang@intel.com>",
        "X-Mailer": "git-send-email 2.13.6",
        "In-Reply-To": "<20191006031408.8633-1-qi.z.zhang@intel.com>",
        "References": "<20190902035551.16852-1-qi.z.zhang@intel.com>\n\t<20191006031408.8633-1-qi.z.zhang@intel.com>",
        "Subject": "[dpdk-dev] [PATCH v2 03/12] net/ice/base: update flow ptype bitmaps",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "In the flow api, the outer first ptype bitmaps contained many references to\ninner ptypes. Because of PTG assignments, these were causing issues when\nprogramming rules on the inner ptypes. For example, in RSS when programming\nthe outer IPV6 hash fields, it also programmed several inner IPV4 PTGs\nwith the same extraction.\n\nThere were several ptypes that have been removed, thus this patch\nremoves those bits from the type bitmaps.\n\nSigned-off-by: Dan Nowlin <dan.nowlin@intel.com>\nSigned-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>\nSigned-off-by: Qi Zhang <qi.z.zhang@intel.com>\nAcked-by: Qiming Yang <qiming.yang@intel.com>\n---\n drivers/net/ice/base/ice_flow.c | 38 +++++++++++++++++++-------------------\n 1 file changed, 19 insertions(+), 19 deletions(-)",
    "diff": "diff --git a/drivers/net/ice/base/ice_flow.c b/drivers/net/ice/base/ice_flow.c\nindex e03c5d0e7..8ed3f8eb7 100644\n--- a/drivers/net/ice/base/ice_flow.c\n+++ b/drivers/net/ice/base/ice_flow.c\n@@ -141,9 +141,9 @@ struct ice_flow_field_info ice_flds_info[ICE_FLOW_FIELD_IDX_MAX] = {\n  * Packet types for packets with an Outer/First/Single MAC header\n  */\n static const u32 ice_ptypes_mac_ofos[] = {\n-\t0xFDC00CC6, 0xBFBF7F7E, 0xF7EFDFDF, 0xFEFDFDFB,\n-\t0x03BF7F7E, 0x00000000, 0x00000000, 0x00000000,\n-\t0x000B0F0F, 0x00003000, 0x00000000, 0x00000000,\n+\t0xFDC00846, 0xBFBF7F7E, 0xF70001DF, 0xFEFDFDFB,\n+\t0x0000077E, 0x00000000, 0x00000000, 0x00000000,\n+\t0x00000000, 0x00003000, 0x00000000, 0x00000000,\n \t0x00000000, 0x00000000, 0x00000000, 0x00000000,\n \t0x00000000, 0x00000000, 0x00000000, 0x00000000,\n \t0x00000000, 0x00000000, 0x00000000, 0x00000000,\n@@ -165,9 +165,9 @@ static const u32 ice_ptypes_macvlan_il[] = {\n \n /* Packet types for packets with an Outer/First/Single IPv4 header */\n static const u32 ice_ptypes_ipv4_ofos[] = {\n-\t0xFDC00000, 0xBFBF7F7E, 0x00EFDFDF, 0x00000000,\n+\t0x1DC00000, 0x04000800, 0x00000000, 0x00000000,\n \t0x00000000, 0x00000000, 0x00000000, 0x00000000,\n-\t0x0003000F, 0x000FC000, 0x00000000, 0x00000000,\n+\t0x00000000, 0x000FC000, 0x00000000, 0x00000000,\n \t0x00000000, 0x00000000, 0x00000000, 0x00000000,\n \t0x00000000, 0x00000000, 0x00000000, 0x00000000,\n \t0x00000000, 0x00000000, 0x00000000, 0x00000000,\n@@ -189,9 +189,9 @@ static const u32 ice_ptypes_ipv4_il[] = {\n \n /* Packet types for packets with an Outer/First/Single IPv6 header */\n static const u32 ice_ptypes_ipv6_ofos[] = {\n-\t0x00000000, 0x00000000, 0xF7000000, 0xFEFDFDFB,\n-\t0x03BF7F7E, 0x00000000, 0x00000000, 0x00000000,\n-\t0x00080F00, 0x03F00000, 0x00000000, 0x00000000,\n+\t0x00000000, 0x00000000, 0x77000000, 0x10002000,\n+\t0x00000000, 0x00000000, 0x00000000, 0x00000000,\n+\t0x00000000, 0x03F00000, 0x00000000, 0x00000000,\n \t0x00000000, 0x00000000, 0x00000000, 0x00000000,\n \t0x00000000, 0x00000000, 0x00000000, 0x00000000,\n \t0x00000000, 0x00000000, 0x00000000, 0x00000000,\n@@ -201,8 +201,8 @@ static const u32 ice_ptypes_ipv6_ofos[] = {\n \n /* Packet types for packets with an Innermost/Last IPv6 header */\n static const u32 ice_ptypes_ipv6_il[] = {\n-\t0x00000000, 0x03B80770, 0x00EE01DC, 0x0EE00000,\n-\t0x03B80770, 0x00000000, 0x00000000, 0x00000000,\n+\t0x00000000, 0x03B80770, 0x000001DC, 0x0EE00000,\n+\t0x00000770, 0x00000000, 0x00000000, 0x00000000,\n \t0x00000000, 0x00000000, 0x7FE00000, 0x00000000,\n \t0x00000000, 0x00000000, 0x00000000, 0x00000000,\n \t0x00000000, 0x00000000, 0x00000000, 0x00000000,\n@@ -228,7 +228,7 @@ static const u32 ice_ptypes_arp_of[] = {\n  */\n static const u32 ice_ptypes_udp_il[] = {\n \t0x81000000, 0x20204040, 0x04000010, 0x80810102,\n-\t0x00200040, 0x00000000, 0x00000000, 0x00000000,\n+\t0x00000040, 0x00000000, 0x00000000, 0x00000000,\n \t0x00000000, 0x00410000, 0x10842000, 0x00000000,\n \t0x00000000, 0x00000000, 0x00000000, 0x00000000,\n \t0x00000000, 0x00000000, 0x00000000, 0x00000000,\n@@ -240,7 +240,7 @@ static const u32 ice_ptypes_udp_il[] = {\n /* Packet types for packets with an Innermost/Last TCP header */\n static const u32 ice_ptypes_tcp_il[] = {\n \t0x04000000, 0x80810102, 0x10000040, 0x02040408,\n-\t0x00810102, 0x00000000, 0x00000000, 0x00000000,\n+\t0x00000102, 0x00000000, 0x00000000, 0x00000000,\n \t0x00000000, 0x00820000, 0x21084000, 0x00000000,\n \t0x00000000, 0x00000000, 0x00000000, 0x00000000,\n \t0x00000000, 0x00000000, 0x00000000, 0x00000000,\n@@ -252,7 +252,7 @@ static const u32 ice_ptypes_tcp_il[] = {\n /* Packet types for packets with an Innermost/Last SCTP header */\n static const u32 ice_ptypes_sctp_il[] = {\n \t0x08000000, 0x01020204, 0x20000081, 0x04080810,\n-\t0x01020204, 0x00000000, 0x00000000, 0x00000000,\n+\t0x00000204, 0x00000000, 0x00000000, 0x00000000,\n \t0x00000000, 0x01040000, 0x00000000, 0x00000000,\n \t0x00000000, 0x00000000, 0x00000000, 0x00000000,\n \t0x00000000, 0x00000000, 0x00000000, 0x00000000,\n@@ -275,8 +275,8 @@ static const u32 ice_ptypes_icmp_of[] = {\n \n /* Packet types for packets with an Innermost/Last ICMP header */\n static const u32 ice_ptypes_icmp_il[] = {\n-\t0x00000000, 0x02040408, 0x40810102, 0x08101020,\n-\t0x02040408, 0x00000000, 0x00000000, 0x00000000,\n+\t0x00000000, 0x02040408, 0x40000102, 0x08101020,\n+\t0x00000408, 0x00000000, 0x00000000, 0x00000000,\n \t0x00000000, 0x00000000, 0x42108000, 0x00000000,\n \t0x00000000, 0x00000000, 0x00000000, 0x00000000,\n \t0x00000000, 0x00000000, 0x00000000, 0x00000000,\n@@ -287,8 +287,8 @@ static const u32 ice_ptypes_icmp_il[] = {\n \n /* Packet types for packets with an Outermost/First GRE header */\n static const u32 ice_ptypes_gre_of[] = {\n-\t0x00000000, 0xBFBF7800, 0x00EFDFDF, 0xFEFDE000,\n-\t0x03BF7F7E, 0x00000000, 0x00000000, 0x00000000,\n+\t0x00000000, 0xBFBF7800, 0x000001DF, 0xFEFDE000,\n+\t0x0000017E, 0x00000000, 0x00000000, 0x00000000,\n \t0x00000000, 0x00000000, 0x00000000, 0x00000000,\n \t0x00000000, 0x00000000, 0x00000000, 0x00000000,\n \t0x00000000, 0x00000000, 0x00000000, 0x00000000,\n@@ -299,8 +299,8 @@ static const u32 ice_ptypes_gre_of[] = {\n \n /* Packet types for packets with an Innermost/Last MAC header */\n static const u32 ice_ptypes_mac_il[] = {\n-\t0x00000000, 0x00000000, 0x00EFDE00, 0x00000000,\n-\t0x03BF7800, 0x00000000, 0x00000000, 0x00000000,\n+\t0x00000000, 0x00000000, 0x00000000, 0x00000000,\n+\t0x00000000, 0x00000000, 0x00000000, 0x00000000,\n \t0x00000000, 0x00000000, 0x00000000, 0x00000000,\n \t0x00000000, 0x00000000, 0x00000000, 0x00000000,\n \t0x00000000, 0x00000000, 0x00000000, 0x00000000,\n",
    "prefixes": [
        "v2",
        "03/12"
    ]
}