Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 60521,
    "url": "https://patches.dpdk.org/api/patches/60521/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20191004050246.90165-10-ajit.khaparde@broadcom.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20191004050246.90165-10-ajit.khaparde@broadcom.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20191004050246.90165-10-ajit.khaparde@broadcom.com",
    "date": "2019-10-04T05:02:45",
    "name": "[09/10] net/bnxt: fix to handle if change status in port start only",
    "commit_ref": null,
    "pull_url": null,
    "state": "changes-requested",
    "archived": true,
    "hash": "f443a70ae7e3757040c1ded63014fccba7d949b9",
    "submitter": {
        "id": 501,
        "url": "https://patches.dpdk.org/api/people/501/?format=api",
        "name": "Ajit Khaparde",
        "email": "ajit.khaparde@broadcom.com"
    },
    "delegate": {
        "id": 319,
        "url": "https://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20191004050246.90165-10-ajit.khaparde@broadcom.com/mbox/",
    "series": [
        {
            "id": 6688,
            "url": "https://patches.dpdk.org/api/series/6688/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=6688",
            "date": "2019-10-04T05:02:37",
            "name": "bnxt patchset with bug fixes",
            "version": 1,
            "mbox": "https://patches.dpdk.org/series/6688/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/60521/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/60521/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id CC1291C1DA;\n\tFri,  4 Oct 2019 07:03:11 +0200 (CEST)",
            "from rnd-relay.smtp.broadcom.com (unknown [192.19.229.170])\n\tby dpdk.org (Postfix) with ESMTP id 8DD051C1A8\n\tfor <dev@dpdk.org>; Fri,  4 Oct 2019 07:02:55 +0200 (CEST)",
            "from mail-irv-17.broadcom.com (mail-irv-17.lvn.broadcom.net\n\t[10.75.242.48])\n\tby rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id 5A8A230C2D0;\n\tThu,  3 Oct 2019 22:01:35 -0700 (PDT)",
            "from localhost.localdomain (unknown [10.230.30.225])\n\tby mail-irv-17.broadcom.com (Postfix) with ESMTP id 5D71114008D;\n\tThu,  3 Oct 2019 22:02:51 -0700 (PDT)"
        ],
        "DKIM-Filter": "OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com 5A8A230C2D0",
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n\ts=dkimrelay; t=1570165295;\n\tbh=aWC4HU88Wd5W66MOwc/ApKZBg3WXZkn7YwHAHP7AfT4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=p/HchTdJMLpFDcFBP24AoCR2D+Bgh9eb9y0MA+LlAcMJiY9kesp2PfSMnPUQafAaG\n\tCqB+JMxDn6MTv3kPa2ih1/gacNYpM0CP82Lij9BEnPtwhtsDPWhNNgJphLDVYuUgW7\n\t/FXTKwRZOVfqFlDG64/rX5autJdhlmh3waPtASYs=",
        "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>",
        "To": "dev@dpdk.org",
        "Cc": "ferruh.yigit@intel.com, Kalesh AP <kalesh-anakkur.purayil@broadcom.com>",
        "Date": "Thu,  3 Oct 2019 22:02:45 -0700",
        "Message-Id": "<20191004050246.90165-10-ajit.khaparde@broadcom.com>",
        "X-Mailer": "git-send-email 2.20.1 (Apple Git-117)",
        "In-Reply-To": "<20191004050246.90165-1-ajit.khaparde@broadcom.com>",
        "References": "<20191004050246.90165-1-ajit.khaparde@broadcom.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[dpdk-dev] [PATCH 09/10] net/bnxt: fix to handle if change status\n\tin port start only",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\n\nDriver should handle if change status during port start only.\nAlso fixed to enable interrupts after issuing hwrm_if_change.\n\nFixes: 92d6617b6e33 (\"net/bnxt: inform firmware about IF state changes\")\n\nSigned-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\n---\n drivers/net/bnxt/bnxt_ethdev.c | 3 ++-\n drivers/net/bnxt/bnxt_hwrm.c   | 3 +++\n 2 files changed, 5 insertions(+), 1 deletion(-)",
    "diff": "diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex fb4deef821..81d58a60c5 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -867,7 +867,6 @@ static int bnxt_dev_start_op(struct rte_eth_dev *eth_dev)\n \t\t\tbp->rx_cp_nr_rings, RTE_ETHDEV_QUEUE_STAT_CNTRS);\n \t}\n \n-\tbnxt_enable_int(bp);\n \trc = bnxt_hwrm_if_change(bp, 1);\n \tif (!rc) {\n \t\tif (bp->flags & BNXT_FLAG_IF_CHANGE_HOT_FW_RESET_DONE) {\n@@ -877,6 +876,8 @@ static int bnxt_dev_start_op(struct rte_eth_dev *eth_dev)\n \t\t}\n \t}\n \n+\tbnxt_enable_int(bp);\n+\n \trc = bnxt_init_chip(bp);\n \tif (rc)\n \t\tgoto error;\ndiff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c\nindex 5e3117fee9..f94fdde2b1 100644\n--- a/drivers/net/bnxt/bnxt_hwrm.c\n+++ b/drivers/net/bnxt/bnxt_hwrm.c\n@@ -4858,6 +4858,9 @@ int bnxt_hwrm_if_change(struct bnxt *bp, bool up)\n \tflags = rte_le_to_cpu_32(resp->flags);\n \tHWRM_UNLOCK();\n \n+\tif (!up)\n+\t\treturn 0;\n+\n \tif (flags & HWRM_FUNC_DRV_IF_CHANGE_OUTPUT_FLAGS_HOT_FW_RESET_DONE) {\n \t\tPMD_DRV_LOG(INFO, \"FW reset happened while port was down\\n\");\n \t\tbp->flags |= BNXT_FLAG_IF_CHANGE_HOT_FW_RESET_DONE;\n",
    "prefixes": [
        "09/10"
    ]
}