Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/60514/?format=api
{ "id": 60514, "url": "https://patches.dpdk.org/api/patches/60514/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20191004050246.90165-2-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191004050246.90165-2-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191004050246.90165-2-ajit.khaparde@broadcom.com", "date": "2019-10-04T05:02:37", "name": "[01/10] net/bnxt: change return value of few routines", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "4e8ff548201558c32849578ff3646fcc43d65daf", "submitter": { "id": 501, "url": "https://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20191004050246.90165-2-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 6688, "url": "https://patches.dpdk.org/api/series/6688/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=6688", "date": "2019-10-04T05:02:37", "name": "bnxt patchset with bug fixes", "version": 1, "mbox": "https://patches.dpdk.org/series/6688/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/60514/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/60514/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 80E471C199;\n\tFri, 4 Oct 2019 07:02:55 +0200 (CEST)", "from rnd-relay.smtp.broadcom.com (unknown [192.19.229.170])\n\tby dpdk.org (Postfix) with ESMTP id 7C0691C1A4\n\tfor <dev@dpdk.org>; Fri, 4 Oct 2019 07:02:54 +0200 (CEST)", "from mail-irv-17.broadcom.com (mail-irv-17.lvn.broadcom.net\n\t[10.75.242.48])\n\tby rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id CA7FE30C2BC;\n\tThu, 3 Oct 2019 22:01:33 -0700 (PDT)", "from localhost.localdomain (unknown [10.230.30.225])\n\tby mail-irv-17.broadcom.com (Postfix) with ESMTP id 73A9914008B;\n\tThu, 3 Oct 2019 22:02:49 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com CA7FE30C2BC", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n\ts=dkimrelay; t=1570165293;\n\tbh=bSLPl+CONo1dup+cVr7H/F5PU1xQCcNiPSVJRhaa+Uk=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=OdF6JWmFj9y5UCfLxypuhhWztT/vHv1xfUEXMMYTfrq2/cSt/p3vmvvl/6zhqonOC\n\tODle2/FfvRqsSfGJtyEqJGSpXBecDNliyBdD5sbE4HS16cb/tNHm2eo451MOUh0srz\n\tFc8fhnUDkzBJKczWqviVDMTEhMSstrIxLxkQPNUw=", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, Kalesh AP <kalesh-anakkur.purayil@broadcom.com>, \n\tSomnath Kotur <somnath.kotur@broadcom.com>,\n\tSantoshkumar Karanappa Rastapur <santosh.rastapur@broadcom.com>", "Date": "Thu, 3 Oct 2019 22:02:37 -0700", "Message-Id": "<20191004050246.90165-2-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.20.1 (Apple Git-117)", "In-Reply-To": "<20191004050246.90165-1-ajit.khaparde@broadcom.com>", "References": "<20191004050246.90165-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 01/10] net/bnxt: change return value of few\n\troutines", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\n\nChange bnxt_init_nic() and bnxt_init_ring_grps() to void functions\nas these can never fail.\n\nSigned-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\nReviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>\nReviewed-by: Santoshkumar Karanappa Rastapur <santosh.rastapur@broadcom.com>\n---\n drivers/net/bnxt/bnxt_ethdev.c | 13 +++----------\n drivers/net/bnxt/bnxt_ring.c | 4 +---\n drivers/net/bnxt/bnxt_ring.h | 2 +-\n 3 files changed, 5 insertions(+), 14 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex 5160ac002b..533c6a07fd 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -518,20 +518,13 @@ static int bnxt_shutdown_nic(struct bnxt *bp)\n \treturn 0;\n }\n \n-static int bnxt_init_nic(struct bnxt *bp)\n+static void bnxt_init_nic(struct bnxt *bp)\n {\n-\tint rc;\n-\n-\tif (BNXT_HAS_RING_GRPS(bp)) {\n-\t\trc = bnxt_init_ring_grps(bp);\n-\t\tif (rc)\n-\t\t\treturn rc;\n-\t}\n+\tif (BNXT_HAS_RING_GRPS(bp))\n+\t\tbnxt_init_ring_grps(bp);\n \n \tbnxt_init_vnics(bp);\n \tbnxt_init_filters(bp);\n-\n-\treturn 0;\n }\n \n /*\ndiff --git a/drivers/net/bnxt/bnxt_ring.c b/drivers/net/bnxt/bnxt_ring.c\nindex 19fc45395d..0ee31ed4e8 100644\n--- a/drivers/net/bnxt/bnxt_ring.c\n+++ b/drivers/net/bnxt/bnxt_ring.c\n@@ -39,15 +39,13 @@ void bnxt_free_ring(struct bnxt_ring *ring)\n * Ring groups\n */\n \n-int bnxt_init_ring_grps(struct bnxt *bp)\n+void bnxt_init_ring_grps(struct bnxt *bp)\n {\n \tunsigned int i;\n \n \tfor (i = 0; i < bp->max_ring_grps; i++)\n \t\tmemset(&bp->grp_info[i], (uint8_t)HWRM_NA_SIGNATURE,\n \t\t sizeof(struct bnxt_ring_grp_info));\n-\n-\treturn 0;\n }\n \n int bnxt_alloc_ring_grps(struct bnxt *bp)\ndiff --git a/drivers/net/bnxt/bnxt_ring.h b/drivers/net/bnxt/bnxt_ring.h\nindex 833118391b..645dcf0e87 100644\n--- a/drivers/net/bnxt/bnxt_ring.h\n+++ b/drivers/net/bnxt/bnxt_ring.h\n@@ -65,7 +65,7 @@ struct bnxt_tx_ring_info;\n struct bnxt_rx_ring_info;\n struct bnxt_cp_ring_info;\n void bnxt_free_ring(struct bnxt_ring *ring);\n-int bnxt_init_ring_grps(struct bnxt *bp);\n+void bnxt_init_ring_grps(struct bnxt *bp);\n int bnxt_alloc_ring_grps(struct bnxt *bp);\n int bnxt_alloc_rings(struct bnxt *bp, uint16_t qidx,\n \t\t\t struct bnxt_tx_queue *txq,\n", "prefixes": [ "01/10" ] }