Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/60443/?format=api
https://patches.dpdk.org/api/patches/60443/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20191002194024.28782-1-stephen@networkplumber.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191002194024.28782-1-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20191002194024.28782-1-stephen@networkplumber.org", "date": "2019-10-02T19:40:24", "name": "[v8] eal: make lcore_config private", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "2bd46500e345acdf915546b950385b04ae20bb7e", "submitter": { "id": 27, "url": "https://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 24651, "url": "https://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20191002194024.28782-1-stephen@networkplumber.org/mbox/", "series": [ { "id": 6675, "url": "https://patches.dpdk.org/api/series/6675/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=6675", "date": "2019-10-02T19:40:24", "name": "[v8] eal: make lcore_config private", "version": 8, "mbox": "https://patches.dpdk.org/series/6675/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/60443/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/60443/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 233251BF59;\n\tWed, 2 Oct 2019 21:40:47 +0200 (CEST)", "from mail-pf1-f194.google.com (mail-pf1-f194.google.com\n\t[209.85.210.194]) by dpdk.org (Postfix) with ESMTP id 3AB061BF54\n\tfor <dev@dpdk.org>; Wed, 2 Oct 2019 21:40:45 +0200 (CEST)", "by mail-pf1-f194.google.com with SMTP id q10so40509pfl.0\n\tfor <dev@dpdk.org>; Wed, 02 Oct 2019 12:40:45 -0700 (PDT)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\tw134sm264161pfd.4.2019.10.02.12.40.42\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 02 Oct 2019 12:40:42 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=/TW/+6CJh/B5GF9WUO+WMZn5rrHZBYGBEC7268GO8XQ=;\n\tb=B5kzcDeGdPK88+XVfMRg0sD90/ZCnVJAMtoHZ5VFSIqKJVRIEfdKre+ddh4SR2L3HF\n\tmsHwrFI+6Wezj6VGuVB7sqynGMbC2vaXfk8838owkJODFee5IvwerITNyK8XjSMHKYBD\n\tBA5n1BItyY6VpX6iXOzzYXRIHxW9SeOt3gs/b4wsiTRH7grKX9EcUbMEfDFKvprvJVu+\n\t0rSLFW9Gtu3YbNz103gvqO1jeQWEqLxOMkdFAHr0Zdaci5EplAo5tMUDUYm40oyL0E63\n\tKJuWL8zpUeO+rwkVdlRU57v5fWAovZjej5gg9e+tEhXpUg1qhVJV8sEgV7895CUxHda7\n\tIbxA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=/TW/+6CJh/B5GF9WUO+WMZn5rrHZBYGBEC7268GO8XQ=;\n\tb=f/fNl2Dh7A+GfcMeKjfZHUPMuOi6kk33nAeKsHssJZhI13NMWfbCgW5mubAmZBRZ2h\n\tvFbYSHQdcU2h4T4EMW/I8jMhzoxb1+K27sVibC0QdHztY/j/NjpAQjo2UlnX+vZVelXN\n\t7nu4rEayDD6jIUQ8WHWEVOrM5HxirtgRWbWYVSGcEbz8fOjr6pw/GZyykf2zOXsTAQRG\n\t20qjQEfC6H7WkdgEHHEIexBUtIVHV/1V0gD9ONtIWacUL4gjOcoH11UPTLiAPfhQFM9o\n\taAJh4Uo74XN2ylLAszFdxb9Zm8qYL03c8F5M4jjXTfZPU/jH+DrdAl2o5HMv9yf6tk0f\n\tNpZg==", "X-Gm-Message-State": "APjAAAV+rn1tJvufx8Z9GEFUM1BvSxfXXC+7LC9Ef7bRNu8PsNGAptaB\n\tOefOWTEC/oGC3essPPBFcBfgbRVjGhn7ag==", "X-Google-Smtp-Source": "APXvYqyfgTTRdBUNa87c1ycscSBnP/H0CmVmXRWiu6X6SFNd2WylzkSg5mWqxYnnX6TTbUzzBJWQHQ==", "X-Received": "by 2002:a62:fc8c:: with SMTP id\n\te134mr6710110pfh.132.1570045243755; \n\tWed, 02 Oct 2019 12:40:43 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Date": "Wed, 2 Oct 2019 12:40:24 -0700", "Message-Id": "<20191002194024.28782-1-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190925161013.3656-1-stephen@networkplumber.org>", "References": "<20190925161013.3656-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v8] eal: make lcore_config private", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The internal structure of lcore_config is no longer be part of\nvisible API/ABI. Make it private to EAL.\n\nRearrange and resize the fields in the structure so it takes\nless memory (and cache footprint).\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\nv8 - update release notes\n rearrange to move cpuset to second cache line\n\n doc/guides/rel_notes/deprecation.rst | 4 ----\n doc/guides/rel_notes/release_19_11.rst | 2 ++\n lib/librte_eal/common/eal_common_launch.c | 2 ++\n lib/librte_eal/common/eal_private.h | 24 +++++++++++++++++++++++\n lib/librte_eal/common/include/rte_lcore.h | 24 -----------------------\n lib/librte_eal/common/rte_service.c | 2 ++\n lib/librte_eal/rte_eal_version.map | 1 -\n lib/librte_eal/windows/eal/eal_thread.c | 1 +\n 8 files changed, 31 insertions(+), 29 deletions(-)", "diff": "diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst\nindex 0ee8533b133c..89811a622591 100644\n--- a/doc/guides/rel_notes/deprecation.rst\n+++ b/doc/guides/rel_notes/deprecation.rst\n@@ -23,10 +23,6 @@ Deprecation Notices\n * eal: The function ``rte_eal_remote_launch`` will return new error codes\n after read or write error on the pipe, instead of calling ``rte_panic``.\n \n-* eal: The ``lcore_config`` struct and global symbol will be made private to\n- remove it from the externally visible ABI and allow it to be updated in the\n- future.\n-\n * eal: both declaring and identifying devices will be streamlined in v18.11.\n New functions will appear to query a specific port from buses, classes of\n device and device drivers. Device declaration will be made coherent with the\ndiff --git a/doc/guides/rel_notes/release_19_11.rst b/doc/guides/rel_notes/release_19_11.rst\nindex 27cfbd9e38c6..e8d4f9d2ba28 100644\n--- a/doc/guides/rel_notes/release_19_11.rst\n+++ b/doc/guides/rel_notes/release_19_11.rst\n@@ -110,6 +110,8 @@ ABI Changes\n Also, make sure to start the actual text at the margin.\n =========================================================\n \n+* eal: The ``lcore_config`` struct and global symbol are now private.\n+\n \n Shared Library Versions\n -----------------------\ndiff --git a/lib/librte_eal/common/eal_common_launch.c b/lib/librte_eal/common/eal_common_launch.c\nindex fe0ba3f0d617..cf52d717f68e 100644\n--- a/lib/librte_eal/common/eal_common_launch.c\n+++ b/lib/librte_eal/common/eal_common_launch.c\n@@ -15,6 +15,8 @@\n #include <rte_per_lcore.h>\n #include <rte_lcore.h>\n \n+#include \"eal_private.h\"\n+\n /*\n * Wait until a lcore finished its job.\n */\ndiff --git a/lib/librte_eal/common/eal_private.h b/lib/librte_eal/common/eal_private.h\nindex 798ede553b21..e63eaa5d262d 100644\n--- a/lib/librte_eal/common/eal_private.h\n+++ b/lib/librte_eal/common/eal_private.h\n@@ -10,6 +10,30 @@\n #include <stdio.h>\n \n #include <rte_dev.h>\n+#include <rte_lcore.h>\n+\n+/**\n+ * Structure storing internal configuration (per-lcore)\n+ */\n+struct lcore_config {\n+\tpthread_t thread_id; /**< pthread identifier */\n+\tint pipe_master2slave[2]; /**< communication pipe with master */\n+\tint pipe_slave2master[2]; /**< communication pipe with master */\n+\n+\tlcore_function_t * volatile f; /**< function to call */\n+\tvoid * volatile arg; /**< argument of function */\n+\tvolatile int ret; /**< return value of function */\n+\n+\tuint32_t core_id; /**< core number on socket for this lcore */\n+\tuint32_t core_index; /**< relative index, starting from 0 */\n+\tuint16_t socket_id; /**< physical socket id for this lcore */\n+\tuint8_t core_role; /**< role of core eg: OFF, RTE, SERVICE */\n+\tuint8_t detected; /**< true if lcore was detected */\n+\tvolatile enum rte_lcore_state_t state; /**< lcore state */\n+\trte_cpuset_t cpuset; /**< cpu set which the lcore affinity to */\n+};\n+\n+extern struct lcore_config lcore_config[RTE_MAX_LCORE];\n \n /**\n * Initialize the memzone subsystem (private to eal).\ndiff --git a/lib/librte_eal/common/include/rte_lcore.h b/lib/librte_eal/common/include/rte_lcore.h\nindex c86f72eb12a8..0c683919564e 100644\n--- a/lib/librte_eal/common/include/rte_lcore.h\n+++ b/lib/librte_eal/common/include/rte_lcore.h\n@@ -66,30 +66,6 @@ typedef cpuset_t rte_cpuset_t;\n } while (0)\n #endif\n \n-/**\n- * Structure storing internal configuration (per-lcore)\n- */\n-struct lcore_config {\n-\tunsigned detected; /**< true if lcore was detected */\n-\tpthread_t thread_id; /**< pthread identifier */\n-\tint pipe_master2slave[2]; /**< communication pipe with master */\n-\tint pipe_slave2master[2]; /**< communication pipe with master */\n-\tlcore_function_t * volatile f; /**< function to call */\n-\tvoid * volatile arg; /**< argument of function */\n-\tvolatile int ret; /**< return value of function */\n-\tvolatile enum rte_lcore_state_t state; /**< lcore state */\n-\tunsigned socket_id; /**< physical socket id for this lcore */\n-\tunsigned core_id; /**< core number on socket for this lcore */\n-\tint core_index; /**< relative index, starting from 0 */\n-\trte_cpuset_t cpuset; /**< cpu set which the lcore affinity to */\n-\tuint8_t core_role; /**< role of core eg: OFF, RTE, SERVICE */\n-};\n-\n-/**\n- * Internal configuration (per-lcore)\n- */\n-extern struct lcore_config lcore_config[RTE_MAX_LCORE];\n-\n RTE_DECLARE_PER_LCORE(unsigned, _lcore_id); /**< Per thread \"lcore id\". */\n RTE_DECLARE_PER_LCORE(rte_cpuset_t, _cpuset); /**< Per thread \"cpuset\". */\n \ndiff --git a/lib/librte_eal/common/rte_service.c b/lib/librte_eal/common/rte_service.c\nindex c3653ebae46c..6e21f549051b 100644\n--- a/lib/librte_eal/common/rte_service.c\n+++ b/lib/librte_eal/common/rte_service.c\n@@ -21,6 +21,8 @@\n #include <rte_memory.h>\n #include <rte_malloc.h>\n \n+#include \"eal_private.h\"\n+\n #define RTE_SERVICE_NUM_MAX 64\n \n #define SERVICE_F_REGISTERED (1 << 0)\ndiff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map\nindex 7cbf82d37b0a..aeedf397764f 100644\n--- a/lib/librte_eal/rte_eal_version.map\n+++ b/lib/librte_eal/rte_eal_version.map\n@@ -4,7 +4,6 @@ DPDK_2.0 {\n \t__rte_panic;\n \teal_parse_sysfs_value;\n \teal_timer_source;\n-\tlcore_config;\n \tper_lcore__lcore_id;\n \tper_lcore__rte_errno;\n \trte_calloc;\ndiff --git a/lib/librte_eal/windows/eal/eal_thread.c b/lib/librte_eal/windows/eal/eal_thread.c\nindex 906502f90982..0591d4c7fb06 100644\n--- a/lib/librte_eal/windows/eal/eal_thread.c\n+++ b/lib/librte_eal/windows/eal/eal_thread.c\n@@ -12,6 +12,7 @@\n #include <rte_common.h>\n #include <eal_thread.h>\n \n+#include \"eal_private.h\"\n \n RTE_DEFINE_PER_LCORE(unsigned int, _lcore_id) = LCORE_ID_ANY;\n \n", "prefixes": [ "v8" ] }{ "id": 60443, "url": "