Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 60254,
    "url": "https://patches.dpdk.org/api/patches/60254/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190930192056.26828-7-stephen@networkplumber.org/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20190930192056.26828-7-stephen@networkplumber.org>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20190930192056.26828-7-stephen@networkplumber.org",
    "date": "2019-09-30T19:20:56",
    "name": "[v3,6/6] pdump: use new pktmbuf copy function",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "b979d58b8c211d29ad122d309d808e402a59afef",
    "submitter": {
        "id": 27,
        "url": "https://patches.dpdk.org/api/people/27/?format=api",
        "name": "Stephen Hemminger",
        "email": "stephen@networkplumber.org"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190930192056.26828-7-stephen@networkplumber.org/mbox/",
    "series": [
        {
            "id": 6631,
            "url": "https://patches.dpdk.org/api/series/6631/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=6631",
            "date": "2019-09-30T19:20:50",
            "name": "mbuf copy/cloning enhancements",
            "version": 3,
            "mbox": "https://patches.dpdk.org/series/6631/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/60254/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/60254/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 166C61BEB7;\n\tMon, 30 Sep 2019 21:21:18 +0200 (CEST)",
            "from mail-pg1-f195.google.com (mail-pg1-f195.google.com\n\t[209.85.215.195]) by dpdk.org (Postfix) with ESMTP id 76FF837A2\n\tfor <dev@dpdk.org>; Mon, 30 Sep 2019 21:21:08 +0200 (CEST)",
            "by mail-pg1-f195.google.com with SMTP id e1so2387522pgj.6\n\tfor <dev@dpdk.org>; Mon, 30 Sep 2019 12:21:08 -0700 (PDT)",
            "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\tc64sm14788304pfc.19.2019.09.30.12.21.06\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 30 Sep 2019 12:21:06 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=zdsVTY0D8zVTp25c2Ag/LpUnnCKhJ2sj1djQsUGrXUo=;\n\tb=OlUzL+qQFhKQjYreMu1UeCD03JkZCZ7uVrqYHGdY2EufwKgxrdGXaTqrt4C3CPwD27\n\tYxVVH9v5y4Nat4g8FGKrHbeFAoafO15PiKvCyOidxGb00xsG9/NewyO4UqTxt2684zwZ\n\txK8Gq24c7COe/fM/sFDR35ih/3nvC0NI57g5PEV8cn1PgtDh0OpmAsjEpflMu3YTFboW\n\tfiaLxO9XVtAgoq1m4CizYL+7k1dQELwY6YiOXb0iwzc2H2CCmXE0xwY1FbWX0dVDx+uz\n\t/Yq/W3y/tO4fZnbNPW4PDtZVw0TosJkBJQfv0tewYaDlElNub3MkUfhz4Z593cApOBe/\n\tIEew==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=zdsVTY0D8zVTp25c2Ag/LpUnnCKhJ2sj1djQsUGrXUo=;\n\tb=Dmp0sklCHyBSPgOHYNxnvKwxMjkr/B+eKNVBXhpg0Doftfm1vUmwijdb9TL13n2ZUl\n\tiZi/dinfS6C8bHsEeyk2uD12VTMTg5wq0NqnEeE1mGjxBO+WbvhPueQI+vThelFG0mwo\n\tE+CKYtCNkLjWMXzpKJ1m5f93QY30+F24WWUZ4k+zy392GS6jahs+N2ANhb522WQ4vopu\n\t9LisSyyebUVihKTdSi+6KVzE/uapqZ+XFd0ePcx0tF1enRKS5ztzjU4TCf04mEN6ag2r\n\tbBdeSgfu5bXD3UD1yxEs0z9iXMwxj2s3LwQjVnrkgbiupISj+sR0L2/i9ft7wluj8f2k\n\tTN4A==",
        "X-Gm-Message-State": "APjAAAWrfpBItcUG52t69ELA/Cy/O9+Quv1Af8Z0sbOGFhP3yosn4dyJ\n\tZxRv1KN7rbZ99qtUYq/Sj/k3Cyc6gR8Jfg==",
        "X-Google-Smtp-Source": "APXvYqyL2AiicPF5R57ZqGXj0bcq4QYOuvIeUa0MfLyniRfm51RMHRbLC7m48PO5Z34hNOMdCL+zGQ==",
        "X-Received": "by 2002:aa7:9216:: with SMTP id\n\t22mr23747381pfo.214.1569871267400; \n\tMon, 30 Sep 2019 12:21:07 -0700 (PDT)",
        "From": "Stephen Hemminger <stephen@networkplumber.org>",
        "To": "dev@dpdk.org",
        "Cc": "Stephen Hemminger <stephen@networkplumber.org>",
        "Date": "Mon, 30 Sep 2019 12:20:56 -0700",
        "Message-Id": "<20190930192056.26828-7-stephen@networkplumber.org>",
        "X-Mailer": "git-send-email 2.20.1",
        "In-Reply-To": "<20190930192056.26828-1-stephen@networkplumber.org>",
        "References": "<20190928003758.18489-1-stephen@networkplumber.org>\n\t<20190930192056.26828-1-stephen@networkplumber.org>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[dpdk-dev] [PATCH v3 6/6] pdump: use new pktmbuf copy function",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "The rte_pktmbuf_copy handles varying size mbuf pools correctly.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/librte_pdump/rte_pdump.c | 69 +-----------------------------------\n 1 file changed, 1 insertion(+), 68 deletions(-)",
    "diff": "diff --git a/lib/librte_pdump/rte_pdump.c b/lib/librte_pdump/rte_pdump.c\nindex cd24dd010951..c665cf237f65 100644\n--- a/lib/librte_pdump/rte_pdump.c\n+++ b/lib/librte_pdump/rte_pdump.c\n@@ -64,73 +64,6 @@ static struct pdump_rxtx_cbs {\n } rx_cbs[RTE_MAX_ETHPORTS][RTE_MAX_QUEUES_PER_PORT],\n tx_cbs[RTE_MAX_ETHPORTS][RTE_MAX_QUEUES_PER_PORT];\n \n-static inline int\n-pdump_pktmbuf_copy_data(struct rte_mbuf *seg, const struct rte_mbuf *m)\n-{\n-\tif (rte_pktmbuf_tailroom(seg) < m->data_len) {\n-\t\tRTE_LOG(ERR, PDUMP,\n-\t\t\t\"User mempool: insufficient data_len of mbuf\\n\");\n-\t\treturn -EINVAL;\n-\t}\n-\n-\tseg->port = m->port;\n-\tseg->vlan_tci = m->vlan_tci;\n-\tseg->hash = m->hash;\n-\tseg->tx_offload = m->tx_offload;\n-\tseg->ol_flags = m->ol_flags;\n-\tseg->packet_type = m->packet_type;\n-\tseg->vlan_tci_outer = m->vlan_tci_outer;\n-\tseg->data_len = m->data_len;\n-\tseg->pkt_len = seg->data_len;\n-\trte_memcpy(rte_pktmbuf_mtod(seg, void *),\n-\t\t\trte_pktmbuf_mtod(m, void *),\n-\t\t\trte_pktmbuf_data_len(seg));\n-\n-\treturn 0;\n-}\n-\n-static inline struct rte_mbuf *\n-pdump_pktmbuf_copy(struct rte_mbuf *m, struct rte_mempool *mp)\n-{\n-\tstruct rte_mbuf *m_dup, *seg, **prev;\n-\tuint32_t pktlen;\n-\tuint16_t nseg;\n-\n-\tm_dup = rte_pktmbuf_alloc(mp);\n-\tif (unlikely(m_dup == NULL))\n-\t\treturn NULL;\n-\n-\tseg = m_dup;\n-\tprev = &seg->next;\n-\tpktlen = m->pkt_len;\n-\tnseg = 0;\n-\n-\tdo {\n-\t\tnseg++;\n-\t\tif (pdump_pktmbuf_copy_data(seg, m) < 0) {\n-\t\t\tif (seg != m_dup)\n-\t\t\t\trte_pktmbuf_free_seg(seg);\n-\t\t\trte_pktmbuf_free(m_dup);\n-\t\t\treturn NULL;\n-\t\t}\n-\t\t*prev = seg;\n-\t\tprev = &seg->next;\n-\t} while ((m = m->next) != NULL &&\n-\t\t\t(seg = rte_pktmbuf_alloc(mp)) != NULL);\n-\n-\t*prev = NULL;\n-\tm_dup->nb_segs = nseg;\n-\tm_dup->pkt_len = pktlen;\n-\n-\t/* Allocation of new indirect segment failed */\n-\tif (unlikely(seg == NULL)) {\n-\t\trte_pktmbuf_free(m_dup);\n-\t\treturn NULL;\n-\t}\n-\n-\t__rte_mbuf_sanity_check(m_dup, 1);\n-\treturn m_dup;\n-}\n \n static inline void\n pdump_copy(struct rte_mbuf **pkts, uint16_t nb_pkts, void *user_params)\n@@ -148,7 +81,7 @@ pdump_copy(struct rte_mbuf **pkts, uint16_t nb_pkts, void *user_params)\n \tring = cbs->ring;\n \tmp = cbs->mp;\n \tfor (i = 0; i < nb_pkts; i++) {\n-\t\tp = pdump_pktmbuf_copy(pkts[i], mp);\n+\t\tp = rte_pktmbuf_copy(pkts[i], mp, 0, UINT32_MAX);\n \t\tif (p)\n \t\t\tdup_bufs[d_pkts++] = p;\n \t}\n",
    "prefixes": [
        "v3",
        "6/6"
    ]
}