Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 60250,
    "url": "https://patches.dpdk.org/api/patches/60250/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190930192056.26828-3-stephen@networkplumber.org/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20190930192056.26828-3-stephen@networkplumber.org>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20190930192056.26828-3-stephen@networkplumber.org",
    "date": "2019-09-30T19:20:52",
    "name": "[v3,2/6] mbuf: delinline rte_pktmbuf_linearize",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "a348fd674af02a35415c73b0254aa5b1339e0478",
    "submitter": {
        "id": 27,
        "url": "https://patches.dpdk.org/api/people/27/?format=api",
        "name": "Stephen Hemminger",
        "email": "stephen@networkplumber.org"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190930192056.26828-3-stephen@networkplumber.org/mbox/",
    "series": [
        {
            "id": 6631,
            "url": "https://patches.dpdk.org/api/series/6631/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=6631",
            "date": "2019-09-30T19:20:50",
            "name": "mbuf copy/cloning enhancements",
            "version": 3,
            "mbox": "https://patches.dpdk.org/series/6631/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/60250/comments/",
    "check": "warning",
    "checks": "https://patches.dpdk.org/api/patches/60250/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D0E231BE8D;\n\tMon, 30 Sep 2019 21:21:07 +0200 (CEST)",
            "from mail-pf1-f196.google.com (mail-pf1-f196.google.com\n\t[209.85.210.196]) by dpdk.org (Postfix) with ESMTP id AAADF5B3C\n\tfor <dev@dpdk.org>; Mon, 30 Sep 2019 21:21:03 +0200 (CEST)",
            "by mail-pf1-f196.google.com with SMTP id y22so6155117pfr.3\n\tfor <dev@dpdk.org>; Mon, 30 Sep 2019 12:21:03 -0700 (PDT)",
            "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\tc64sm14788304pfc.19.2019.09.30.12.21.01\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 30 Sep 2019 12:21:01 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=DMtaGL54rpYbgFJ3Nj6b9u9VO3VzDh2cf0qWrQrQF2o=;\n\tb=TFrCo3jQfqxkmEgeXH0cild2G5Z1HDH2IQvUruSY0J812hdIVJ48PiRdx3w4URgOjK\n\t+izl3LrO1xRHCxdKuwgoeC5GTn48y1nOaHjrMZOjHF/PQ1Hi8PUwNUDX8kqrfoB5p/m/\n\t9WZmCyyy1GKCTlLREXX20NfoqQdG81QkuiICxywvOQ8H7y4613UZsvfwTdXR7W0naRg4\n\tu1GmUt1SuA3dTdoICkd+OnkDdRiTIzLOhu7mRVdzXRPvBL/WDiioNbZaoOLJWQjPYsPb\n\t6HAeS3Wh80/J7ANcoVSCykXMGzsVTAGWbAVQ32PNlY2aRMfsghHa9nv9Lb0uqcfbgQE3\n\tj8oQ==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=DMtaGL54rpYbgFJ3Nj6b9u9VO3VzDh2cf0qWrQrQF2o=;\n\tb=JJTf7VNLCt2qWm2r6/D2KDV9T1oboUCQ2MRRMBmXW0uqLtZdJx5O60Fu/G3ByAOq7Q\n\teROMAs3FmiEr7vszcd9BdHODeYUIQH3JVlBsOchrTuUIc8AHrWhwLaWgh+a9iNg7ls17\n\tiAlstnsomR0ypIMbV+1kZIHZAXFfi2KRGSLSGVhkQIZ7Pto6wiShCuu97x5zciyGGvxH\n\tMaJNb5Y/GyoRUKB525BeHBq5heX+C6/HClgHr+a2N/9O2rvD7wxmDH2YTncmPuXTRh4w\n\txiUJ2/iBIX8O5EHoDEg3HrosLlViC3wteFCMdu378CBr3NJjKYni0KtIumXdz0FqDmP4\n\t7C7w==",
        "X-Gm-Message-State": "APjAAAXyk4qt0boWzOVBvX2haGXQC4W1GJQUM1CDvtyfqLkbHzMRYmOd\n\tQllee4BiH4Hw5s+WuoQ91RBSAmngZFZXuA==",
        "X-Google-Smtp-Source": "APXvYqzCn3zgu5pbuWcOk2ubLg9YZk4cx1hGf6GT74C9ITHswInAL3LO5vfoCjXSqCkUSQVvK6MT9w==",
        "X-Received": "by 2002:a65:6147:: with SMTP id o7mr24742918pgv.97.1569871262322;\n\tMon, 30 Sep 2019 12:21:02 -0700 (PDT)",
        "From": "Stephen Hemminger <stephen@networkplumber.org>",
        "To": "dev@dpdk.org",
        "Cc": "Stephen Hemminger <stephen@networkplumber.org>",
        "Date": "Mon, 30 Sep 2019 12:20:52 -0700",
        "Message-Id": "<20190930192056.26828-3-stephen@networkplumber.org>",
        "X-Mailer": "git-send-email 2.20.1",
        "In-Reply-To": "<20190930192056.26828-1-stephen@networkplumber.org>",
        "References": "<20190928003758.18489-1-stephen@networkplumber.org>\n\t<20190930192056.26828-1-stephen@networkplumber.org>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[dpdk-dev] [PATCH v3 2/6] mbuf: delinline rte_pktmbuf_linearize",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "This copy part of this function is too big to be put inline.\nThe places it is used are only in special exception paths\nwhere a highly fragmented mbuf arrives at a device that can't handle it.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/librte_mbuf/rte_mbuf.c           | 37 +++++++++++++++++++++++++++\n lib/librte_mbuf/rte_mbuf.h           | 38 +++++-----------------------\n lib/librte_mbuf/rte_mbuf_version.map |  6 +++++\n 3 files changed, 49 insertions(+), 32 deletions(-)",
    "diff": "diff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/librte_mbuf/rte_mbuf.c\nindex 37718d49c148..e2c661c97522 100644\n--- a/lib/librte_mbuf/rte_mbuf.c\n+++ b/lib/librte_mbuf/rte_mbuf.c\n@@ -245,6 +245,43 @@ int rte_mbuf_check(const struct rte_mbuf *m, int is_header,\n \treturn 0;\n }\n \n+/* convert multi-segment mbuf to single mbuf */\n+int\n+__rte_pktmbuf_linearize(struct rte_mbuf *mbuf)\n+{\n+\tsize_t seg_len, copy_len;\n+\tstruct rte_mbuf *m;\n+\tstruct rte_mbuf *m_next;\n+\tchar *buffer;\n+\n+\t/* Extend first segment to the total packet length */\n+\tcopy_len = rte_pktmbuf_pkt_len(mbuf) - rte_pktmbuf_data_len(mbuf);\n+\n+\tif (unlikely(copy_len > rte_pktmbuf_tailroom(mbuf)))\n+\t\treturn -1;\n+\n+\tbuffer = rte_pktmbuf_mtod_offset(mbuf, char *, mbuf->data_len);\n+\tmbuf->data_len = (uint16_t)(mbuf->pkt_len);\n+\n+\t/* Append data from next segments to the first one */\n+\tm = mbuf->next;\n+\twhile (m != NULL) {\n+\t\tm_next = m->next;\n+\n+\t\tseg_len = rte_pktmbuf_data_len(m);\n+\t\trte_memcpy(buffer, rte_pktmbuf_mtod(m, char *), seg_len);\n+\t\tbuffer += seg_len;\n+\n+\t\trte_pktmbuf_free_seg(m);\n+\t\tm = m_next;\n+\t}\n+\n+\tmbuf->next = NULL;\n+\tmbuf->nb_segs = 1;\n+\n+\treturn 0;\n+}\n+\n /* dump a mbuf on console */\n void\n rte_pktmbuf_dump(FILE *f, const struct rte_mbuf *m, unsigned dump_len)\ndiff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h\nindex 98225ec80bf1..bffda1c81fbd 100644\n--- a/lib/librte_mbuf/rte_mbuf.h\n+++ b/lib/librte_mbuf/rte_mbuf.h\n@@ -2400,6 +2400,11 @@ rte_validate_tx_offload(const struct rte_mbuf *m)\n \treturn 0;\n }\n \n+/**\n+ * @internal used by rte_pktmbuf_linearize().\n+ */\n+int __rte_pktmbuf_linearize(struct rte_mbuf *mbuf);\n+\n /**\n  * Linearize data in mbuf.\n  *\n@@ -2415,40 +2420,9 @@ rte_validate_tx_offload(const struct rte_mbuf *m)\n static inline int\n rte_pktmbuf_linearize(struct rte_mbuf *mbuf)\n {\n-\tsize_t seg_len, copy_len;\n-\tstruct rte_mbuf *m;\n-\tstruct rte_mbuf *m_next;\n-\tchar *buffer;\n-\n \tif (rte_pktmbuf_is_contiguous(mbuf))\n \t\treturn 0;\n-\n-\t/* Extend first segment to the total packet length */\n-\tcopy_len = rte_pktmbuf_pkt_len(mbuf) - rte_pktmbuf_data_len(mbuf);\n-\n-\tif (unlikely(copy_len > rte_pktmbuf_tailroom(mbuf)))\n-\t\treturn -1;\n-\n-\tbuffer = rte_pktmbuf_mtod_offset(mbuf, char *, mbuf->data_len);\n-\tmbuf->data_len = (uint16_t)(mbuf->pkt_len);\n-\n-\t/* Append data from next segments to the first one */\n-\tm = mbuf->next;\n-\twhile (m != NULL) {\n-\t\tm_next = m->next;\n-\n-\t\tseg_len = rte_pktmbuf_data_len(m);\n-\t\trte_memcpy(buffer, rte_pktmbuf_mtod(m, char *), seg_len);\n-\t\tbuffer += seg_len;\n-\n-\t\trte_pktmbuf_free_seg(m);\n-\t\tm = m_next;\n-\t}\n-\n-\tmbuf->next = NULL;\n-\tmbuf->nb_segs = 1;\n-\n-\treturn 0;\n+\treturn __rte_pktmbuf_linearize(mbuf);\n }\n \n /**\ndiff --git a/lib/librte_mbuf/rte_mbuf_version.map b/lib/librte_mbuf/rte_mbuf_version.map\nindex 2662a37bf674..4d0bc9772769 100644\n--- a/lib/librte_mbuf/rte_mbuf_version.map\n+++ b/lib/librte_mbuf/rte_mbuf_version.map\n@@ -46,6 +46,12 @@ DPDK_18.08 {\n \trte_pktmbuf_pool_create_by_ops;\n } DPDK_16.11;\n \n+DPDK_19.11 {\n+\tglobal:\n+\n+\t__rte_pktmbuf_linearize;\n+} DPDK_18.08;\n+\n EXPERIMENTAL {\n \tglobal:\n \n",
    "prefixes": [
        "v3",
        "2/6"
    ]
}