Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/6012/?format=api
{ "id": 6012, "url": "https://patches.dpdk.org/api/patches/6012/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1435845053-17203-4-git-send-email-john.mcnamara@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1435845053-17203-4-git-send-email-john.mcnamara@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1435845053-17203-4-git-send-email-john.mcnamara@intel.com", "date": "2015-07-02T13:50:53", "name": "[dpdk-dev,3/3] doc: moved doxygen section to the doc guidelines", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "4faa7521f1706fecb51f1720435dc44aa8c4ef87", "submitter": { "id": 154, "url": "https://patches.dpdk.org/api/people/154/?format=api", "name": "John McNamara", "email": "john.mcnamara@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1435845053-17203-4-git-send-email-john.mcnamara@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/6012/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/6012/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id A5A5B5A44;\n\tThu, 2 Jul 2015 15:51:06 +0200 (CEST)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby dpdk.org (Postfix) with ESMTP id DB29511C5\n\tfor <dev@dpdk.org>; Thu, 2 Jul 2015 15:51:03 +0200 (CEST)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby orsmga103.jf.intel.com with ESMTP; 02 Jul 2015 06:51:02 -0700", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby orsmga001.jf.intel.com with ESMTP; 02 Jul 2015 06:51:00 -0700", "from sivswdev02.ir.intel.com (sivswdev02.ir.intel.com\n\t[10.237.217.46])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tt62Dp0Vj018975; Thu, 2 Jul 2015 14:51:00 +0100", "from sivswdev02.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev02.ir.intel.com with ESMTP id t62Dp0v8017621;\n\tThu, 2 Jul 2015 14:51:00 +0100", "(from jmcnam2x@localhost)\n\tby sivswdev02.ir.intel.com with id t62Dp0rL017617;\n\tThu, 2 Jul 2015 14:51:00 +0100" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.15,393,1432623600\"; d=\"scan'208\";a=\"721746710\"", "From": "John McNamara <john.mcnamara@intel.com>", "To": "dev@dpdk.org", "Date": "Thu, 2 Jul 2015 14:50:53 +0100", "Message-Id": "<1435845053-17203-4-git-send-email-john.mcnamara@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "In-Reply-To": "<1435845053-17203-1-git-send-email-john.mcnamara@intel.com>", "References": "<1435845053-17203-1-git-send-email-john.mcnamara@intel.com>", "Subject": "[dpdk-dev] [PATCH 3/3] doc: moved doxygen section to the doc\n\tguidelines", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Moved and refactored the Doxygen guidelines from the Coding Style doc\nto the Documentation Guidelines doc. Replaced the existing section\nwith a link.\n\nSigned-off-by: John McNamara <john.mcnamara@intel.com>\n---\n doc/guides/guidelines/coding_style.rst | 126 ++-------------------------------\n 1 file changed, 7 insertions(+), 119 deletions(-)", "diff": "diff --git a/doc/guides/guidelines/coding_style.rst b/doc/guides/guidelines/coding_style.rst\nindex c27fef4..12315bb 100644\n--- a/doc/guides/guidelines/coding_style.rst\n+++ b/doc/guides/guidelines/coding_style.rst\n@@ -1,5 +1,7 @@\n-Coding Style\n-============\n+.. _coding_style:\n+\n+DPDK Coding Style\n+=================\n \n Description\n -----------\n@@ -687,123 +689,9 @@ Control Statements\n Doxygen Documentation\n ---------------------\n \n-The API documentation is automatically generated in the DPDK framework.\n+The API documentation is automatically generated in the DPDK framework using `Doxygen <http://www.stack.nl/~dimitri/doxygen/>`_.\n That is why all files that are part of the public API must be documented using Doxygen syntax.\n \n The public API comprises functions of DPDK that can be used by an external application that will use the SDK.\n-Only the Doxygen syntax described in the coding rules (this document) should be used in the code.\n-All the Doxygen features are described in the Doxygen manual online.\n-\n-Documenting a Function\n-~~~~~~~~~~~~~~~~~~~~~~\n-\n-All public functions must be documented. The documentation is placed in the header file, above the declaration of the function.\n-The definition of the function may be documented, but using standard comments (not in doxygen format).\n-The following is an example of function documentation:\n-\n-.. code-block:: c\n-\n- /**\n- * Summary here; one sentence on one line (should not exceed 80 chars).\n- *\n- * A more detailed description goes here.\n- *\n- * A blank line forms a paragraph. There should be no trailing white-space\n- * anywhere.\n- *\n- * @param first\n- * \"@param\" is a Doxygen directive to describe a function parameter. Like\n- * some other directives, it takes a term/summary on the same line and a\n- * description (this text) indented by 2 spaces on the next line. All\n- * descriptive text should wrap at 80 chars, without going over.\n- * Newlines are NOT supported within directives; if a newline would be\n- * before this text, it would be appended to the general description above.\n- * @param second\n- * There should be no newline between multiple directives (of the same\n- * type).\n- *\n- * @return\n- * \"@return\" is a different Doxygen directive to describe the return value\n- * of a function, if there is any.\n- */\n- int rte_foo(int first, int second)\n-\n-\n-Documenting Files\n-~~~~~~~~~~~~~~~~~\n-\n-Each public file may start with a comment describing what the file does. For example:\n-\n-.. code-block:: c\n-\n- /**\n- * @file\n- * This file describes the coding rules of RTE.\n- *\n- * It contains the coding rules of C code, ASM code, reStructured\n- * Text documentation, and of course how to use doxygen to document\n- * public API.\n- */\n-\n-\n-Documenting Constants and Variables\n-~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n-\n-Examples:\n-\n-.. code-block:: c\n-\n- /**\n- * The definition of a funny TRUE.\n- */\n- #define TRUE 0\n-\n- #define TRUE 1 /**< another way to document a macro */\n-\n- /**\n- * Frequency of the HPET counter in Hz\n- *\n- * @see rte_eal_hpet_init()\n- */\n- extern uint64_t eal_hpet_resolution_hz;\n-\n-\n-Documenting Structures\n-~~~~~~~~~~~~~~~~~~~~~~\n-\n-Public structures should also be documented.\n-The ``/**<`` sequence can be used to documented the fields of the structure, as shown in the following example:\n-\n-.. code-block:: c\n-\n- /**\n- * Structure describing a memzone, which is a contiguous portions of\n- * physical memory identified by a name.\n- */\n- struct rte_memzone {\n-\n- #define MEMZONE_NAMESIZE 32\n- char name[MEMZONE_NAMESIZE]; /**< name of the memory zone */\n-\n- phys_addr_t phys_addr; /**< start physical address */\n- void *addr; /**< start virtual address */\n- uint64_t len; /**< len of the memzone */\n-\n- int socket_id; /**< NUMA socket id */\n- };\n-\n-\n-See Also Sections\n-~~~~~~~~~~~~~~~~~\n-\n-The @see keyword can be used to highlight a link to an existing function, file, or URL.\n-This directive should be placed on one line, without anything else, at the bottom of the documentation header.\n-\n-.. code-block:: c\n-\n- /**\n- * (documentation of function, file, ...)\n- *\n- * @see rte_foo()\n- * @see eal_memzone.c\n- */\n+Only the Doxygen syntax described in the :ref:`doxygen_guidelines` should be used in the code.\n+Other Doxygen features are described in the Doxygen manual online.\n", "prefixes": [ "dpdk-dev", "3/3" ] }