Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/60055/?format=api
https://patches.dpdk.org/api/patches/60055/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190927181446.14336-4-amorenoz@redhat.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190927181446.14336-4-amorenoz@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190927181446.14336-4-amorenoz@redhat.com", "date": "2019-09-27T18:14:46", "name": "[v2,3/3] vhost: prevent zero copy mode if iommu is on", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "ce53d8275cefa45e5e94a292dd01602d7737bc04", "submitter": { "id": 1397, "url": "https://patches.dpdk.org/api/people/1397/?format=api", "name": "Adrian Moreno", "email": "amorenoz@redhat.com" }, "delegate": { "id": 2642, "url": "https://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190927181446.14336-4-amorenoz@redhat.com/mbox/", "series": [ { "id": 6592, "url": "https://patches.dpdk.org/api/series/6592/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=6592", "date": "2019-09-27T18:14:43", "name": "vhost: add support for IOVA_VA mode", "version": 2, "mbox": "https://patches.dpdk.org/series/6592/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/60055/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/60055/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id DA3541BEEC;\n\tFri, 27 Sep 2019 20:15:30 +0200 (CEST)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby dpdk.org (Postfix) with ESMTP id 3A2A41BEDE;\n\tFri, 27 Sep 2019 20:15:24 +0200 (CEST)", "from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id A5D0BC0578F8;\n\tFri, 27 Sep 2019 18:15:23 +0000 (UTC)", "from amorenoz.users.ipa.redhat.com (ovpn-116-96.ams2.redhat.com\n\t[10.36.116.96])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 2704C5C21A;\n\tFri, 27 Sep 2019 18:15:21 +0000 (UTC)" ], "From": "Adrian Moreno <amorenoz@redhat.com>", "To": "dev@dpdk.org", "Cc": "tiwei.bie@intel.com, zhihong.wang@intel.com, maxime.coquelin@redhat.com, \n\tAdrian Moreno <amorenoz@redhat.com>, stable@dpdk.org", "Date": "Fri, 27 Sep 2019 20:14:46 +0200", "Message-Id": "<20190927181446.14336-4-amorenoz@redhat.com>", "In-Reply-To": "<20190927181446.14336-1-amorenoz@redhat.com>", "References": "<20190927181446.14336-1-amorenoz@redhat.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.16", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.31]); Fri, 27 Sep 2019 18:15:23 +0000 (UTC)", "Subject": "[dpdk-dev] [PATCH v2 3/3] vhost: prevent zero copy mode if iommu is\n\ton", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The simltaneous use of dequeue_zero_copy and IOMMU is problematic.\nNot only because IOVA_VA mode is not supported but also because the\npotential invalidation of guest pages while the buffers are in use\nis not handled.\n\nPrevent these two features to be enabled simultaneosly.\n\nFixes: 69c90e98f483 (\"vhost: enable IOMMU support\")\nCc: maxime.coquelin@redhat.com\nCc: stable@dpdk.org\n\nSigned-off-by: Adrian Moreno <amorenoz@redhat.com>\n---\n lib/librte_vhost/socket.c | 8 ++++++++\n 1 file changed, 8 insertions(+)", "diff": "diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c\nindex 274988c4d..63f73d2c9 100644\n--- a/lib/librte_vhost/socket.c\n+++ b/lib/librte_vhost/socket.c\n@@ -871,6 +871,14 @@ rte_vhost_driver_register(const char *path, uint64_t flags)\n \t}\n \tvsocket->dequeue_zero_copy = flags & RTE_VHOST_USER_DEQUEUE_ZERO_COPY;\n \n+\tif(vsocket->dequeue_zero_copy &&\n+\t (flags & RTE_VHOST_USER_IOMMU_SUPPORT)) {\n+\t\tRTE_LOG(ERR, VHOST_CONFIG,\n+\t\t\t\"error: enabling dequeue zero copy and IOMMU features \"\n+\t\t\t\"simultaneously is not supported\\n\");\n+\t\tgoto out_mutex;\n+\t}\n+\n \t/*\n \t * Set the supported features correctly for the builtin vhost-user\n \t * net driver.\n", "prefixes": [ "v2", "3/3" ] }{ "id": 60055, "url": "