Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/6001/?format=api
{ "id": 6001, "url": "https://patches.dpdk.org/api/patches/6001/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1435763497-7264-1-git-send-email-bruce.richardson@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1435763497-7264-1-git-send-email-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1435763497-7264-1-git-send-email-bruce.richardson@intel.com", "date": "2015-07-01T15:11:37", "name": "[dpdk-dev] cxgbe: fix compilation using icc", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "41d9b94870276664f34050cb9bbfe107eb47645a", "submitter": { "id": 20, "url": "https://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1435763497-7264-1-git-send-email-bruce.richardson@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/6001/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/6001/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 89A725A29;\n\tWed, 1 Jul 2015 17:11:41 +0200 (CEST)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id 32EFF2FDD\n\tfor <dev@dpdk.org>; Wed, 1 Jul 2015 17:11:40 +0200 (CEST)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby fmsmga102.fm.intel.com with ESMTP; 01 Jul 2015 08:11:39 -0700", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby FMSMGA003.fm.intel.com with ESMTP; 01 Jul 2015 08:11:38 -0700", "from sivswdev01.ir.intel.com (sivswdev01.ir.intel.com\n\t[10.237.217.45])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tt61FBbax026932; Wed, 1 Jul 2015 16:11:37 +0100", "from sivswdev01.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev01.ir.intel.com with ESMTP id t61FBbO4007302;\n\tWed, 1 Jul 2015 16:11:37 +0100", "(from bricha3@localhost)\n\tby sivswdev01.ir.intel.com with id t61FBbJc007298;\n\tWed, 1 Jul 2015 16:11:37 +0100" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.15,386,1432623600\"; d=\"scan'208\";a=\"517248537\"", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Date": "Wed, 1 Jul 2015 16:11:37 +0100", "Message-Id": "<1435763497-7264-1-git-send-email-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "Subject": "[dpdk-dev] [PATCH] cxgbe: fix compilation using icc", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When compiling the cxgbe driver with icc, multiple errors about using\nenums as integers appear across a number of files, including in the base\ncode and in the DPDK-specific driver code.\n\n.../drivers/net/cxgbe/cxgbe_main.c(386): error #188: enumerated type mixed\nwith another type\n t4_get_port_type_description(pi->port_type));\n ^\nFor the errors in the base driver code we use the CFLAGS_BASE_DRIVER \napproach used by other drivers to disable warnings.\n\nFor errors in the DPDK-specific code, typecasts are used to fix the\nerrors in the code itself.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n drivers/net/cxgbe/Makefile | 17 +++++++++++++----\n drivers/net/cxgbe/cxgbe_main.c | 5 +++--\n drivers/net/cxgbe/sge.c | 3 ++-\n 3 files changed, 18 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/cxgbe/Makefile b/drivers/net/cxgbe/Makefile\nindex ae12d75..0711976 100644\n--- a/drivers/net/cxgbe/Makefile\n+++ b/drivers/net/cxgbe/Makefile\n@@ -49,7 +49,7 @@ ifeq ($(CC), icc)\n #\n # CFLAGS for icc\n #\n-CFLAGS_BASE_DRIVER = -wd174 -wd593 -wd869 -wd981 -wd2259\n+CFLAGS_BASE_DRIVER = -wd188\n else\n #\n # CFLAGS for gcc/clang\n@@ -57,18 +57,27 @@ else\n ifeq ($(shell test $(CC) = gcc && test $(GCC_VERSION) -ge 44 && echo 1), 1)\n CFLAGS += -Wno-deprecated\n endif\n-CFLAGS_BASE_DRIVER = -Wno-unused-parameter -Wno-unused-value\n-CFLAGS_BASE_DRIVER += -Wno-strict-aliasing -Wno-format-extra-args\n+CFLAGS_BASE_DRIVER =\n \n endif\n \n #\n+# Add extra flags for base driver files (also known as shared code)\n+# to disable warnings in them\n+#\n+BASE_DRIVER_OBJS=$(patsubst %.c,%.o,$(notdir $(wildcard $(SRCDIR)/base/*.c)))\n+$(foreach obj, $(BASE_DRIVER_OBJS), $(eval CFLAGS_$(obj)+=$(CFLAGS_BASE_DRIVER)))\n+\n+VPATH += $(SRCDIR)/base\n+\n+\n+#\n # all source are stored in SRCS-y\n #\n SRCS-$(CONFIG_RTE_LIBRTE_CXGBE_PMD) += cxgbe_ethdev.c\n SRCS-$(CONFIG_RTE_LIBRTE_CXGBE_PMD) += cxgbe_main.c\n SRCS-$(CONFIG_RTE_LIBRTE_CXGBE_PMD) += sge.c\n-SRCS-$(CONFIG_RTE_LIBRTE_CXGBE_PMD) += base/t4_hw.c\n+SRCS-$(CONFIG_RTE_LIBRTE_CXGBE_PMD) += t4_hw.c\n \n # this lib depends upon:\n DEPDIRS-$(CONFIG_RTE_LIBRTE_CXGBE_PMD) += lib/librte_eal lib/librte_ether\ndiff --git a/drivers/net/cxgbe/cxgbe_main.c b/drivers/net/cxgbe/cxgbe_main.c\nindex dad0a98..b879820 100644\n--- a/drivers/net/cxgbe/cxgbe_main.c\n+++ b/drivers/net/cxgbe/cxgbe_main.c\n@@ -383,7 +383,8 @@ static void print_port_info(struct adapter *adap)\n \t\tif (bufp != buf)\n \t\t\t--bufp;\n \t\tsprintf(bufp, \"BASE-%s\",\n-\t\t\tt4_get_port_type_description(pi->port_type));\n+\t\t\tt4_get_port_type_description(\n+\t\t\t\t\t(enum fw_port_type)pi->port_type));\n \n \t\tdev_info(adap,\n \t\t\t \" \" PCI_PRI_FMT \" Chelsio rev %d %s %s\\n\",\n@@ -629,7 +630,7 @@ static int adap_init0(struct adapter *adap)\n \t\t\tdev_err(adap, \"Failed to restart. Exit.\\n\");\n \t\t\tgoto bye;\n \t\t}\n-\t\tstate &= ~DEV_STATE_INIT;\n+\t\tstate = (enum dev_state)((unsigned)state & ~DEV_STATE_INIT);\n \t}\n \n \tt4_get_fw_version(adap, &adap->params.fw_vers);\ndiff --git a/drivers/net/cxgbe/sge.c b/drivers/net/cxgbe/sge.c\nindex 4da6320..359296e 100644\n--- a/drivers/net/cxgbe/sge.c\n+++ b/drivers/net/cxgbe/sge.c\n@@ -1670,7 +1670,8 @@ int t4_sge_alloc_rxq(struct adapter *adap, struct sge_rspq *iq, bool fwevtq,\n \tif (fl) {\n \t\tstruct sge_eth_rxq *rxq = container_of(fl, struct sge_eth_rxq,\n \t\t\t\t\t\t fl);\n-\t\tenum chip_type chip = CHELSIO_CHIP_VERSION(adap->params.chip);\n+\t\tenum chip_type chip = (enum chip_type)CHELSIO_CHIP_VERSION(\n+\t\t\t\tadap->params.chip);\n \n \t\t/*\n \t\t * Allocate the ring for the hardware free list (with space\n", "prefixes": [ "dpdk-dev" ] }