Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/59602/?format=api
{ "id": 59602, "url": "https://patches.dpdk.org/api/patches/59602/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190923074448.7847-31-qi.z.zhang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190923074448.7847-31-qi.z.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190923074448.7847-31-qi.z.zhang@intel.com", "date": "2019-09-23T07:44:48", "name": "[v5,30/30] net/ice/base: remove unused code", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "3df5710d7d90aa2bd46672c1c15615730cf759ec", "submitter": { "id": 504, "url": "https://patches.dpdk.org/api/people/504/?format=api", "name": "Qi Zhang", "email": "qi.z.zhang@intel.com" }, "delegate": { "id": 31221, "url": "https://patches.dpdk.org/api/users/31221/?format=api", "username": "yexl", "first_name": "xiaolong", "last_name": "ye", "email": "xiaolong.ye@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190923074448.7847-31-qi.z.zhang@intel.com/mbox/", "series": [ { "id": 6483, "url": "https://patches.dpdk.org/api/series/6483/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=6483", "date": "2019-09-23T07:44:18", "name": "net/ice/base: share code update secend batch.", "version": 5, "mbox": "https://patches.dpdk.org/series/6483/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/59602/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/59602/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 552E11BF67;\n\tMon, 23 Sep 2019 09:44:22 +0200 (CEST)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby dpdk.org (Postfix) with ESMTP id 2997F1BE8B\n\tfor <dev@dpdk.org>; Mon, 23 Sep 2019 09:42:51 +0200 (CEST)", "from orsmga008.jf.intel.com ([10.7.209.65])\n\tby fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t23 Sep 2019 00:42:50 -0700", "from dpdk51.sh.intel.com ([10.67.110.245])\n\tby orsmga008.jf.intel.com with ESMTP; 23 Sep 2019 00:42:49 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.64,539,1559545200\"; d=\"scan'208\";a=\"182445753\"", "From": "Qi Zhang <qi.z.zhang@intel.com>", "To": "wenzhuo.lu@intel.com,\n\tqiming.yang@intel.com", "Cc": "dev@dpdk.org, xiaolong.ye@intel.com, Qi Zhang <qi.z.zhang@intel.com>,\n\tPaul M Stillwell Jr <paul.m.stillwell.jr@intel.com>", "Date": "Mon, 23 Sep 2019 15:44:48 +0800", "Message-Id": "<20190923074448.7847-31-qi.z.zhang@intel.com>", "X-Mailer": "git-send-email 2.13.6", "In-Reply-To": "<20190923074448.7847-1-qi.z.zhang@intel.com>", "References": "<20190902035551.16852-1-qi.z.zhang@intel.com>\n\t<20190923074448.7847-1-qi.z.zhang@intel.com>", "Subject": "[dpdk-dev] [PATCH v5 30/30] net/ice/base: remove unused code", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Remove unused code.\n\nSigned-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>\nSigned-off-by: Qi Zhang <qi.z.zhang@intel.com>\n---\n drivers/net/ice/base/ice_common.c | 4 ----\n drivers/net/ice/base/ice_common.h | 2 --\n drivers/net/ice/base/ice_flex_pipe.c | 1 -\n drivers/net/ice/base/ice_flow.h | 3 ---\n 4 files changed, 10 deletions(-)", "diff": "diff --git a/drivers/net/ice/base/ice_common.c b/drivers/net/ice/base/ice_common.c\nindex 16b91dc12..48ba160f7 100644\n--- a/drivers/net/ice/base/ice_common.c\n+++ b/drivers/net/ice/base/ice_common.c\n@@ -1068,7 +1068,6 @@ ice_write_rxq_ctx(struct ice_hw *hw, struct ice_rlan_ctx *rlan_ctx,\n \treturn ice_copy_rxq_ctx_to_hw(hw, ctx_buf, rxq_index);\n }\n \n-#if !defined(NO_UNUSED_CTX_CODE) || defined(AE_DRIVER)\n /**\n * ice_clear_rxq_ctx\n * @hw: pointer to the hardware structure\n@@ -1089,7 +1088,6 @@ enum ice_status ice_clear_rxq_ctx(struct ice_hw *hw, u32 rxq_index)\n \n \treturn ICE_SUCCESS;\n }\n-#endif /* !NO_UNUSED_CTX_CODE || AE_DRIVER */\n \n /* LAN Tx Queue Context */\n const struct ice_ctx_ele ice_tlan_ctx_info[] = {\n@@ -1125,7 +1123,6 @@ const struct ice_ctx_ele ice_tlan_ctx_info[] = {\n \t{ 0 }\n };\n \n-#if !defined(NO_UNUSED_CTX_CODE) || defined(AE_DRIVER)\n /**\n * ice_copy_tx_cmpltnq_ctx_to_hw\n * @hw: pointer to the hardware structure\n@@ -1306,7 +1303,6 @@ ice_clear_tx_drbell_q_ctx(struct ice_hw *hw, u32 tx_drbell_q_index)\n \n \treturn ICE_SUCCESS;\n }\n-#endif /* !NO_UNUSED_CTX_CODE || AE_DRIVER */\n \n /* FW Admin Queue command wrappers */\n \ndiff --git a/drivers/net/ice/base/ice_common.h b/drivers/net/ice/base/ice_common.h\nindex bcb0a999d..c73184499 100644\n--- a/drivers/net/ice/base/ice_common.h\n+++ b/drivers/net/ice/base/ice_common.h\n@@ -74,7 +74,6 @@ void ice_set_safe_mode_caps(struct ice_hw *hw);\n enum ice_status\n ice_write_rxq_ctx(struct ice_hw *hw, struct ice_rlan_ctx *rlan_ctx,\n \t\t u32 rxq_index);\n-#if !defined(NO_UNUSED_CTX_CODE) || defined(AE_DRIVER)\n enum ice_status ice_clear_rxq_ctx(struct ice_hw *hw, u32 rxq_index);\n enum ice_status\n ice_clear_tx_cmpltnq_ctx(struct ice_hw *hw, u32 tx_cmpltnq_index);\n@@ -88,7 +87,6 @@ enum ice_status\n ice_write_tx_drbell_q_ctx(struct ice_hw *hw,\n \t\t\t struct ice_tx_drbell_q_ctx *tx_drbell_q_ctx,\n \t\t\t u32 tx_drbell_q_index);\n-#endif /* !NO_UNUSED_CTX_CODE || AE_DRIVER */\n \n enum ice_status\n ice_aq_get_rss_lut(struct ice_hw *hw, u16 vsi_handle, u8 lut_type, u8 *lut,\ndiff --git a/drivers/net/ice/base/ice_flex_pipe.c b/drivers/net/ice/base/ice_flex_pipe.c\nindex 0357fbd4e..75bb87079 100644\n--- a/drivers/net/ice/base/ice_flex_pipe.c\n+++ b/drivers/net/ice/base/ice_flex_pipe.c\n@@ -2701,7 +2701,6 @@ ice_find_prof_id_with_mask(struct ice_hw *hw, enum ice_block blk,\n \n \tfor (i = 0; i < es->count; i++) {\n \t\tu16 off = i * es->fvw;\n-\t\tu16 j;\n \n \t\tif (memcmp(&es->t[off], fv, es->fvw * sizeof(*fv)))\n \t\t\tcontinue;\ndiff --git a/drivers/net/ice/base/ice_flow.h b/drivers/net/ice/base/ice_flow.h\nindex 6f26f3935..326ff6f81 100644\n--- a/drivers/net/ice/base/ice_flow.h\n+++ b/drivers/net/ice/base/ice_flow.h\n@@ -362,9 +362,6 @@ struct ice_flow_action {\n \t} data;\n };\n \n-/* TDD esp in the linux code doesn't like prototypes, so\n- * ifdef them all out, so they stop conflicting with our mocks\n- */\n u64\n ice_flow_find_prof(struct ice_hw *hw, enum ice_block blk, enum ice_flow_dir dir,\n \t\t struct ice_flow_seg_info *segs, u8 segs_cnt);\n", "prefixes": [ "v5", "30/30" ] }