Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/59598/?format=api
{ "id": 59598, "url": "https://patches.dpdk.org/api/patches/59598/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190923074448.7847-27-qi.z.zhang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190923074448.7847-27-qi.z.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190923074448.7847-27-qi.z.zhang@intel.com", "date": "2019-09-23T07:44:44", "name": "[v5,26/30] net/ice/base: use bitmap copy where appropriate", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "c3c6cfd05fa5be614d6578e271821de882607710", "submitter": { "id": 504, "url": "https://patches.dpdk.org/api/people/504/?format=api", "name": "Qi Zhang", "email": "qi.z.zhang@intel.com" }, "delegate": { "id": 31221, "url": "https://patches.dpdk.org/api/users/31221/?format=api", "username": "yexl", "first_name": "xiaolong", "last_name": "ye", "email": "xiaolong.ye@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190923074448.7847-27-qi.z.zhang@intel.com/mbox/", "series": [ { "id": 6483, "url": "https://patches.dpdk.org/api/series/6483/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=6483", "date": "2019-09-23T07:44:18", "name": "net/ice/base: share code update secend batch.", "version": 5, "mbox": "https://patches.dpdk.org/series/6483/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/59598/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/59598/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 2255A1BF4C;\n\tMon, 23 Sep 2019 09:44:09 +0200 (CEST)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby dpdk.org (Postfix) with ESMTP id 223941BEDB\n\tfor <dev@dpdk.org>; Mon, 23 Sep 2019 09:42:43 +0200 (CEST)", "from orsmga008.jf.intel.com ([10.7.209.65])\n\tby fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t23 Sep 2019 00:42:43 -0700", "from dpdk51.sh.intel.com ([10.67.110.245])\n\tby orsmga008.jf.intel.com with ESMTP; 23 Sep 2019 00:42:42 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.64,539,1559545200\"; d=\"scan'208\";a=\"182445723\"", "From": "Qi Zhang <qi.z.zhang@intel.com>", "To": "wenzhuo.lu@intel.com,\n\tqiming.yang@intel.com", "Cc": "dev@dpdk.org, xiaolong.ye@intel.com, Qi Zhang <qi.z.zhang@intel.com>,\n\tBruce Allan <bruce.w.allan@intel.com>,\n\tPaul M Stillwell Jr <paul.m.stillwell.jr@intel.com>", "Date": "Mon, 23 Sep 2019 15:44:44 +0800", "Message-Id": "<20190923074448.7847-27-qi.z.zhang@intel.com>", "X-Mailer": "git-send-email 2.13.6", "In-Reply-To": "<20190923074448.7847-1-qi.z.zhang@intel.com>", "References": "<20190902035551.16852-1-qi.z.zhang@intel.com>\n\t<20190923074448.7847-1-qi.z.zhang@intel.com>", "Subject": "[dpdk-dev] [PATCH v5 26/30] net/ice/base: use bitmap copy where\n\tappropriate", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "ice_cp_bitmap() already exists and should be used instead of\nusing ice_memcpy(). Note, there are a couple comments that suggest\nusing a bitmap-specific copy function, but those are not correct\nsince the source block of memory is not a bitmap.\n\nSigned-off-by: Bruce Allan <bruce.w.allan@intel.com>\nSigned-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>\nSigned-off-by: Qi Zhang <qi.z.zhang@intel.com>\n---\n drivers/net/ice/base/ice_switch.c | 11 +++++------\n 1 file changed, 5 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/ice/base/ice_switch.c b/drivers/net/ice/base/ice_switch.c\nindex 7681ba38b..10dfc720a 100644\n--- a/drivers/net/ice/base/ice_switch.c\n+++ b/drivers/net/ice/base/ice_switch.c\n@@ -615,8 +615,7 @@ ice_get_recp_frm_fw(struct ice_hw *hw, struct ice_sw_recipe *recps, u8 rid,\n \t\tgoto err_unroll;\n \n \t/* Copy result indexes */\n-\tice_memcpy(recps[rid].res_idxs, result_bm, sizeof(recps[rid].res_idxs),\n-\t\t ICE_NONDMA_TO_NONDMA);\n+\tice_cp_bitmap(recps[rid].res_idxs, result_bm, ICE_MAX_FV_WORDS);\n \trecps[rid].recp_created = true;\n \n err_unroll:\n@@ -645,8 +644,8 @@ ice_get_recp_to_prof_map(struct ice_hw *hw)\n \t\tice_zero_bitmap(r_bitmap, ICE_MAX_NUM_RECIPES);\n \t\tif (ice_aq_get_recipe_to_profile(hw, i, (u8 *)r_bitmap, NULL))\n \t\t\tcontinue;\n-\t\tice_memcpy(profile_to_recipe[i], r_bitmap,\n-\t\t\t sizeof(profile_to_recipe[i]), ICE_NONDMA_TO_NONDMA);\n+\t\tice_cp_bitmap(profile_to_recipe[i], r_bitmap,\n+\t\t\t ICE_MAX_NUM_RECIPES);\n \t\tfor (j = 0; j < ICE_MAX_NUM_RECIPES; j++)\n \t\t\tif (ice_is_bit_set(r_bitmap, j))\n \t\t\t\tice_set_bit(i, recipe_to_profile[j]);\n@@ -5586,8 +5585,8 @@ ice_add_adv_recipe(struct ice_hw *hw, struct ice_adv_lkup_elem *lkups,\n \t\t\tgoto err_unroll;\n \n \t\t/* Update profile to recipe bitmap array */\n-\t\tice_memcpy(profile_to_recipe[fvit->profile_id], r_bitmap,\n-\t\t\t sizeof(r_bitmap), ICE_NONDMA_TO_NONDMA);\n+\t\tice_cp_bitmap(profile_to_recipe[fvit->profile_id], r_bitmap,\n+\t\t\t ICE_MAX_NUM_RECIPES);\n \n \t\t/* Update recipe to profile bitmap array */\n \t\tfor (j = 0; j < ICE_MAX_NUM_RECIPES; j++)\n", "prefixes": [ "v5", "26/30" ] }