Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/59590/?format=api
https://patches.dpdk.org/api/patches/59590/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190923074448.7847-19-qi.z.zhang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190923074448.7847-19-qi.z.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190923074448.7847-19-qi.z.zhang@intel.com", "date": "2019-09-23T07:44:36", "name": "[v5,18/30] net/ice/base: replace alloc-followed-by-copy with memdup", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "76ca71065cd6f5d9904865675adb460a4b0bdecc", "submitter": { "id": 504, "url": "https://patches.dpdk.org/api/people/504/?format=api", "name": "Qi Zhang", "email": "qi.z.zhang@intel.com" }, "delegate": { "id": 31221, "url": "https://patches.dpdk.org/api/users/31221/?format=api", "username": "yexl", "first_name": "xiaolong", "last_name": "ye", "email": "xiaolong.ye@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190923074448.7847-19-qi.z.zhang@intel.com/mbox/", "series": [ { "id": 6483, "url": "https://patches.dpdk.org/api/series/6483/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=6483", "date": "2019-09-23T07:44:18", "name": "net/ice/base: share code update secend batch.", "version": 5, "mbox": "https://patches.dpdk.org/series/6483/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/59590/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/59590/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 7E35A1BEBE;\n\tMon, 23 Sep 2019 09:43:28 +0200 (CEST)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby dpdk.org (Postfix) with ESMTP id D80831BEB5\n\tfor <dev@dpdk.org>; Mon, 23 Sep 2019 09:42:29 +0200 (CEST)", "from orsmga008.jf.intel.com ([10.7.209.65])\n\tby fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t23 Sep 2019 00:42:29 -0700", "from dpdk51.sh.intel.com ([10.67.110.245])\n\tby orsmga008.jf.intel.com with ESMTP; 23 Sep 2019 00:42:28 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.64,539,1559545200\"; d=\"scan'208\";a=\"182445678\"", "From": "Qi Zhang <qi.z.zhang@intel.com>", "To": "wenzhuo.lu@intel.com,\n\tqiming.yang@intel.com", "Cc": "dev@dpdk.org, xiaolong.ye@intel.com, Qi Zhang <qi.z.zhang@intel.com>,\n\tBruce Allan <bruce.w.allan@intel.com>,\n\tPaul M Stillwell Jr <paul.m.stillwell.jr@intel.com>", "Date": "Mon, 23 Sep 2019 15:44:36 +0800", "Message-Id": "<20190923074448.7847-19-qi.z.zhang@intel.com>", "X-Mailer": "git-send-email 2.13.6", "In-Reply-To": "<20190923074448.7847-1-qi.z.zhang@intel.com>", "References": "<20190902035551.16852-1-qi.z.zhang@intel.com>\n\t<20190923074448.7847-1-qi.z.zhang@intel.com>", "Subject": "[dpdk-dev] [PATCH v5 18/30] net/ice/base: replace\n\talloc-followed-by-copy with memdup", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "ice_memdup() is preferred over an alloc immediately followed by a copy.\n\nSigned-off-by: Bruce Allan <bruce.w.allan@intel.com>\nSigned-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>\nSigned-off-by: Qi Zhang <qi.z.zhang@intel.com>\n---\n drivers/net/ice/base/ice_flex_pipe.c | 5 ++---\n drivers/net/ice/base/ice_switch.c | 7 ++-----\n 2 files changed, 4 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/ice/base/ice_flex_pipe.c b/drivers/net/ice/base/ice_flex_pipe.c\nindex 05cd39b17..76c26fd4e 100644\n--- a/drivers/net/ice/base/ice_flex_pipe.c\n+++ b/drivers/net/ice/base/ice_flex_pipe.c\n@@ -4939,12 +4939,11 @@ ice_get_profs_vsig(struct ice_hw *hw, enum ice_block blk, u16 vsig,\n \t\tstruct ice_vsig_prof *p;\n \n \t\t/* copy to the input list */\n-\t\tp = (struct ice_vsig_prof *)ice_malloc(hw, sizeof(*p));\n+\t\tp = (struct ice_vsig_prof *)ice_memdup(hw, ent1, sizeof(*p),\n+\t\t\t\t\t\t ICE_NONDMA_TO_NONDMA);\n \t\tif (!p)\n \t\t\tgoto err_ice_get_profs_vsig;\n \n-\t\tice_memcpy(p, ent1, sizeof(*p), ICE_NONDMA_TO_NONDMA);\n-\n \t\tLIST_ADD_TAIL(&p->list, lst);\n \t}\n \ndiff --git a/drivers/net/ice/base/ice_switch.c b/drivers/net/ice/base/ice_switch.c\nindex 64c2aec19..62ccf533c 100644\n--- a/drivers/net/ice/base/ice_switch.c\n+++ b/drivers/net/ice/base/ice_switch.c\n@@ -623,14 +623,11 @@ ice_get_recp_frm_fw(struct ice_hw *hw, struct ice_sw_recipe *recps, u8 rid,\n \trecps[rid].big_recp = (num_recps > 1);\n \trecps[rid].n_grp_count = num_recps;\n \trecps[rid].root_buf = (struct ice_aqc_recipe_data_elem *)\n-\t\tice_calloc(hw, recps[rid].n_grp_count,\n-\t\t\t sizeof(struct ice_aqc_recipe_data_elem));\n+\t\tice_memdup(hw, tmp, recps[rid].n_grp_count *\n+\t\t\t sizeof(*recps[rid].root_buf), ICE_NONDMA_TO_NONDMA);\n \tif (!recps[rid].root_buf)\n \t\tgoto err_unroll;\n \n-\tice_memcpy(recps[rid].root_buf, tmp, recps[rid].n_grp_count *\n-\t\t sizeof(*recps[rid].root_buf), ICE_NONDMA_TO_NONDMA);\n-\n \t/* Copy result indexes */\n \tice_memcpy(recps[rid].res_idxs, result_bm, sizeof(recps[rid].res_idxs),\n \t\t ICE_NONDMA_TO_NONDMA);\n", "prefixes": [ "v5", "18/30" ] }{ "id": 59590, "url": "