Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/59581/?format=api
{ "id": 59581, "url": "https://patches.dpdk.org/api/patches/59581/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190923074448.7847-10-qi.z.zhang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190923074448.7847-10-qi.z.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190923074448.7847-10-qi.z.zhang@intel.com", "date": "2019-09-23T07:44:27", "name": "[v5,09/30] net/ice/base: add support for switch rule about VLAN PPPoE", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "1a15052e03b9811499a6f6870d03e38f5c5a3b85", "submitter": { "id": 504, "url": "https://patches.dpdk.org/api/people/504/?format=api", "name": "Qi Zhang", "email": "qi.z.zhang@intel.com" }, "delegate": { "id": 31221, "url": "https://patches.dpdk.org/api/users/31221/?format=api", "username": "yexl", "first_name": "xiaolong", "last_name": "ye", "email": "xiaolong.ye@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190923074448.7847-10-qi.z.zhang@intel.com/mbox/", "series": [ { "id": 6483, "url": "https://patches.dpdk.org/api/series/6483/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=6483", "date": "2019-09-23T07:44:18", "name": "net/ice/base: share code update secend batch.", "version": 5, "mbox": "https://patches.dpdk.org/series/6483/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/59581/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/59581/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 058A91BEC6;\n\tMon, 23 Sep 2019 09:42:39 +0200 (CEST)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby dpdk.org (Postfix) with ESMTP id 42C751BEA0\n\tfor <dev@dpdk.org>; Mon, 23 Sep 2019 09:42:13 +0200 (CEST)", "from orsmga008.jf.intel.com ([10.7.209.65])\n\tby fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t23 Sep 2019 00:42:12 -0700", "from dpdk51.sh.intel.com ([10.67.110.245])\n\tby orsmga008.jf.intel.com with ESMTP; 23 Sep 2019 00:42:11 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.64,539,1559545200\"; d=\"scan'208\";a=\"182445589\"", "From": "Qi Zhang <qi.z.zhang@intel.com>", "To": "wenzhuo.lu@intel.com,\n\tqiming.yang@intel.com", "Cc": "dev@dpdk.org, xiaolong.ye@intel.com, Qi Zhang <qi.z.zhang@intel.com>,\n\tJunfeng Guo <junfeng.guo@intel.com>,\n\tPaul M Stillwell Jr <paul.m.stillwell.jr@intel.com>", "Date": "Mon, 23 Sep 2019 15:44:27 +0800", "Message-Id": "<20190923074448.7847-10-qi.z.zhang@intel.com>", "X-Mailer": "git-send-email 2.13.6", "In-Reply-To": "<20190923074448.7847-1-qi.z.zhang@intel.com>", "References": "<20190902035551.16852-1-qi.z.zhang@intel.com>\n\t<20190923074448.7847-1-qi.z.zhang@intel.com>", "Subject": "[dpdk-dev] [PATCH v5 09/30] net/ice/base: add support for switch\n\trule about VLAN PPPoE", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add support for switch rule about single-VLAN-PPPoE. Note that double\nVLAN is not supported by the hardware at this point, therefore only\nsingle-VLAN support for PPPoE is added.\n\nSigned-off-by: Junfeng Guo <junfeng.guo@intel.com>\nSigned-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>\nSigned-off-by: Qi Zhang <qi.z.zhang@intel.com>\n---\n drivers/net/ice/base/ice_protocol_type.h | 8 ++++++++\n drivers/net/ice/base/ice_switch.c | 19 +++++++++++++++----\n 2 files changed, 23 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/ice/base/ice_protocol_type.h b/drivers/net/ice/base/ice_protocol_type.h\nindex cdb691523..c6caa8562 100644\n--- a/drivers/net/ice/base/ice_protocol_type.h\n+++ b/drivers/net/ice/base/ice_protocol_type.h\n@@ -31,6 +31,7 @@ enum ice_protocol_type {\n \tICE_MAC_OFOS = 0,\n \tICE_MAC_IL,\n \tICE_ETYPE_OL,\n+\tICE_VLAN_OFOS,\n \tICE_IPV4_OFOS,\n \tICE_IPV4_IL,\n \tICE_IPV6_OFOS,\n@@ -117,6 +118,7 @@ enum ice_prot_id {\n #define ICE_MAC_OFOS_HW\t\t1\n #define ICE_MAC_IL_HW\t\t4\n #define ICE_ETYPE_OL_HW\t\t9\n+#define ICE_VLAN_OL_HW\t\t16\n #define ICE_IPV4_OFOS_HW\t32\n #define ICE_IPV4_IL_HW\t\t33\n #define ICE_IPV6_OFOS_HW\t40\n@@ -162,6 +164,11 @@ struct ice_ether_vlan_hdr {\n \tu32 vlan_id;\n };\n \n+struct ice_vlan_hdr {\n+\tu16 vlan;\n+\tu16 type;\n+};\n+\n struct ice_ipv4_hdr {\n \tu8 version;\n \tu8 tos;\n@@ -239,6 +246,7 @@ struct ice_nvgre {\n union ice_prot_hdr {\n \tstruct ice_ether_hdr eth_hdr;\n \tstruct ice_ethtype_hdr ethertype;\n+\tstruct ice_vlan_hdr vlan_hdr;\n \tstruct ice_ipv4_hdr ipv4_hdr;\n \tstruct ice_ipv6_hdr ipv6_hdr;\n \tstruct ice_l4_hdr l4_hdr;\ndiff --git a/drivers/net/ice/base/ice_switch.c b/drivers/net/ice/base/ice_switch.c\nindex fa023169d..688584563 100644\n--- a/drivers/net/ice/base/ice_switch.c\n+++ b/drivers/net/ice/base/ice_switch.c\n@@ -418,8 +418,9 @@ dummy_udp_gtp_packet[] = {\n \n static const\n struct ice_dummy_pkt_offsets dummy_pppoe_packet_offsets[] = {\n-\t{ ICE_MAC_OFOS,\t\t\t0 },\n-\t{ ICE_PPPOE,\t\t\t14 },\n+\t{ ICE_MAC_OFOS,\t\t0 },\n+\t{ ICE_VLAN_OFOS,\t14},\n+\t{ ICE_PPPOE,\t\t18 },\n \t{ ICE_PROTOCOL_LAST,\t0 },\n };\n \n@@ -428,9 +429,11 @@ dummy_pppoe_packet[] = {\n \t0x00, 0x00, 0x00, 0x00, /* ICE_MAC_OFOS 0 */\n \t0x00, 0x00, 0x00, 0x00,\n \t0x00, 0x00, 0x00, 0x00,\n-\t0x88, 0x64,\n+\t0x81, 0x00,\n+\n+\t0x00, 0x00, 0x88, 0x64, /* ICE_VLAN_OFOS 14 */\n \n-\t0x11, 0x00, 0x00, 0x01, /* ICE_PPPOE 14 */\n+\t0x11, 0x00, 0x00, 0x01, /* ICE_PPPOE 18 */\n \t0x00, 0x4e, 0x00, 0x21,\n \n \t0x45, 0x00, 0x00, 0x30, /* PDU */\n@@ -4632,6 +4635,7 @@ static const struct ice_prot_ext_tbl_entry ice_prot_ext[] = {\n \t{ ICE_MAC_OFOS,\t\t{ 0, 2, 4, 6, 8, 10, 12 } },\n \t{ ICE_MAC_IL,\t\t{ 0, 2, 4, 6, 8, 10, 12 } },\n \t{ ICE_ETYPE_OL,\t\t{ 0 } },\n+\t{ ICE_VLAN_OFOS,\t{ 0, 2 } },\n \t{ ICE_IPV4_OFOS,\t{ 0, 2, 4, 6, 8, 10, 12, 14, 16, 18 } },\n \t{ ICE_IPV4_IL,\t\t{ 0, 2, 4, 6, 8, 10, 12, 14, 16, 18 } },\n \t{ ICE_IPV6_IL,\t\t{ 0, 2, 4, 6, 8, 10, 12, 14, 16, 18, 20, 22, 24,\n@@ -4661,6 +4665,7 @@ static const struct ice_protocol_entry ice_prot_id_tbl[] = {\n \t{ ICE_MAC_OFOS,\t\tICE_MAC_OFOS_HW },\n \t{ ICE_MAC_IL,\t\tICE_MAC_IL_HW },\n \t{ ICE_ETYPE_OL,\t\tICE_ETYPE_OL_HW },\n+\t{ ICE_VLAN_OFOS,\tICE_VLAN_OL_HW },\n \t{ ICE_IPV4_OFOS,\tICE_IPV4_OFOS_HW },\n \t{ ICE_IPV4_IL,\t\tICE_IPV4_IL_HW },\n \t{ ICE_IPV6_OFOS,\tICE_IPV6_OFOS_HW },\n@@ -5784,6 +5789,9 @@ ice_fill_adv_dummy_packet(struct ice_adv_lkup_elem *lkups, u16 lkups_cnt,\n \t\tcase ICE_ETYPE_OL:\n \t\t\tlen = sizeof(struct ice_ethtype_hdr);\n \t\t\tbreak;\n+\t\tcase ICE_VLAN_OFOS:\n+\t\t\tlen = sizeof(struct ice_vlan_hdr);\n+\t\t\tbreak;\n \t\tcase ICE_IPV4_OFOS:\n \t\tcase ICE_IPV4_IL:\n \t\t\tlen = sizeof(struct ice_ipv4_hdr);\n@@ -5812,6 +5820,9 @@ ice_fill_adv_dummy_packet(struct ice_adv_lkup_elem *lkups, u16 lkups_cnt,\n \t\tcase ICE_GTP:\n \t\t\tlen = sizeof(struct ice_udp_gtp_hdr);\n \t\t\tbreak;\n+\t\tcase ICE_PPPOE:\n+\t\t\tlen = sizeof(struct ice_pppoe_hdr);\n+\t\t\tbreak;\n \t\tdefault:\n \t\t\treturn ICE_ERR_PARAM;\n \t\t}\n", "prefixes": [ "v5", "09/30" ] }