Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/59578/?format=api
{ "id": 59578, "url": "https://patches.dpdk.org/api/patches/59578/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190923074448.7847-7-qi.z.zhang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190923074448.7847-7-qi.z.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190923074448.7847-7-qi.z.zhang@intel.com", "date": "2019-09-23T07:44:24", "name": "[v5,06/30] net/ice/base: propagate errors from functions", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "b0c283b327262054ee23abe41c120db34760ad2a", "submitter": { "id": 504, "url": "https://patches.dpdk.org/api/people/504/?format=api", "name": "Qi Zhang", "email": "qi.z.zhang@intel.com" }, "delegate": { "id": 31221, "url": "https://patches.dpdk.org/api/users/31221/?format=api", "username": "yexl", "first_name": "xiaolong", "last_name": "ye", "email": "xiaolong.ye@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190923074448.7847-7-qi.z.zhang@intel.com/mbox/", "series": [ { "id": 6483, "url": "https://patches.dpdk.org/api/series/6483/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=6483", "date": "2019-09-23T07:44:18", "name": "net/ice/base: share code update secend batch.", "version": 5, "mbox": "https://patches.dpdk.org/series/6483/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/59578/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/59578/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D809B1BEB9;\n\tMon, 23 Sep 2019 09:42:30 +0200 (CEST)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby dpdk.org (Postfix) with ESMTP id 01B7E1BE92\n\tfor <dev@dpdk.org>; Mon, 23 Sep 2019 09:42:07 +0200 (CEST)", "from orsmga008.jf.intel.com ([10.7.209.65])\n\tby fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t23 Sep 2019 00:42:07 -0700", "from dpdk51.sh.intel.com ([10.67.110.245])\n\tby orsmga008.jf.intel.com with ESMTP; 23 Sep 2019 00:42:06 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.64,539,1559545200\"; d=\"scan'208\";a=\"182445561\"", "From": "Qi Zhang <qi.z.zhang@intel.com>", "To": "wenzhuo.lu@intel.com,\n\tqiming.yang@intel.com", "Cc": "dev@dpdk.org, xiaolong.ye@intel.com, Qi Zhang <qi.z.zhang@intel.com>,\n\tPaul M Stillwell Jr <paul.m.stillwell.jr@intel.com>", "Date": "Mon, 23 Sep 2019 15:44:24 +0800", "Message-Id": "<20190923074448.7847-7-qi.z.zhang@intel.com>", "X-Mailer": "git-send-email 2.13.6", "In-Reply-To": "<20190923074448.7847-1-qi.z.zhang@intel.com>", "References": "<20190902035551.16852-1-qi.z.zhang@intel.com>\n\t<20190923074448.7847-1-qi.z.zhang@intel.com>", "Subject": "[dpdk-dev] [PATCH v5 06/30] net/ice/base: propagate errors from\n\tfunctions", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "There could be an error returned from ice_fill_adv_dummy_packet()\nso we need to propagate that to the caller. Additionally, the\ncall to ice_flow_xtract_pkt_flags() could also return an error so\nwe need to propagate it as well.\n\nAlso add in the correct offsets for GENEVE and VXLAN_GPE to the\ndummy packets.\n\nSigned-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>\nSigned-off-by: Qi Zhang <qi.z.zhang@intel.com>\n---\n drivers/net/ice/base/ice_flow.c | 9 ++++++---\n drivers/net/ice/base/ice_switch.c | 8 ++++++--\n 2 files changed, 12 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/ice/base/ice_flow.c b/drivers/net/ice/base/ice_flow.c\nindex 682f26ce6..7dae53270 100644\n--- a/drivers/net/ice/base/ice_flow.c\n+++ b/drivers/net/ice/base/ice_flow.c\n@@ -869,9 +869,12 @@ ice_flow_create_xtrct_seq(struct ice_hw *hw,\n \t/* For ACL, we also need to extract the direction bit (Rx,Tx) data from\n \t * packet flags\n \t */\n-\tif (params->blk == ICE_BLK_ACL)\n-\t\tice_flow_xtract_pkt_flags(hw, params,\n-\t\t\t\t\t ICE_RX_MDID_PKT_FLAGS_15_0);\n+\tif (params->blk == ICE_BLK_ACL) {\n+\t\tstatus = ice_flow_xtract_pkt_flags(hw, params,\n+\t\t\t\t\t\t ICE_RX_MDID_PKT_FLAGS_15_0);\n+\t\tif (status)\n+\t\t\treturn status;\n+\t}\n \n \tfor (i = 0; i < params->prof->segs_cnt; i++) {\n \t\tu64 match = params->prof->segs[i].match;\ndiff --git a/drivers/net/ice/base/ice_switch.c b/drivers/net/ice/base/ice_switch.c\nindex 00358e4db..fa023169d 100644\n--- a/drivers/net/ice/base/ice_switch.c\n+++ b/drivers/net/ice/base/ice_switch.c\n@@ -156,6 +156,7 @@ struct ice_dummy_pkt_offsets dummy_udp_tun_tcp_packet_offsets[] = {\n \t{ ICE_UDP_OF,\t\t34 },\n \t{ ICE_VXLAN,\t\t42 },\n \t{ ICE_GENEVE,\t\t42 },\n+\t{ ICE_VXLAN_GPE,\t42 },\n \t{ ICE_MAC_IL,\t\t50 },\n \t{ ICE_IPV4_IL,\t\t64 },\n \t{ ICE_TCP_IL,\t\t84 },\n@@ -208,6 +209,7 @@ struct ice_dummy_pkt_offsets dummy_udp_tun_udp_packet_offsets[] = {\n \t{ ICE_UDP_OF,\t\t34 },\n \t{ ICE_VXLAN,\t\t42 },\n \t{ ICE_GENEVE,\t\t42 },\n+\t{ ICE_VXLAN_GPE,\t42 },\n \t{ ICE_MAC_IL,\t\t50 },\n \t{ ICE_IPV4_IL,\t\t64 },\n \t{ ICE_UDP_ILOS,\t\t84 },\n@@ -6189,8 +6191,10 @@ ice_add_adv_rule(struct ice_hw *hw, struct ice_adv_lkup_elem *lkups,\n \ts_rule->pdata.lkup_tx_rx.recipe_id = CPU_TO_LE16(rid);\n \ts_rule->pdata.lkup_tx_rx.act = CPU_TO_LE32(act);\n \n-\tice_fill_adv_dummy_packet(lkups, lkups_cnt, s_rule, pkt, pkt_len,\n-\t\t\t\t pkt_offsets);\n+\tstatus = ice_fill_adv_dummy_packet(lkups, lkups_cnt, s_rule, pkt,\n+\t\t\t\t\t pkt_len, pkt_offsets);\n+\tif (status)\n+\t\tgoto err_ice_add_adv_rule;\n \n \tif (rinfo->tun_type != ICE_NON_TUN) {\n \t\tstatus = ice_fill_adv_packet_tun(hw, rinfo->tun_type,\n", "prefixes": [ "v5", "06/30" ] }