Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/59463/?format=api
{ "id": 59463, "url": "https://patches.dpdk.org/api/patches/59463/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190919131729.28681-2-stephen@networkplumber.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190919131729.28681-2-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20190919131729.28681-2-stephen@networkplumber.org", "date": "2019-09-19T13:17:28", "name": "[v5,1/2] ethdev: expose basic xstats for driver use", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "16fda3b63accc80adf4aacd74952fad81bd5dd6c", "submitter": { "id": 27, "url": "https://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190919131729.28681-2-stephen@networkplumber.org/mbox/", "series": [ { "id": 6454, "url": "https://patches.dpdk.org/api/series/6454/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=6454", "date": "2019-09-19T13:17:27", "name": "failsafe: add xstats", "version": 5, "mbox": "https://patches.dpdk.org/series/6454/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/59463/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/59463/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 8FE971F009;\n\tThu, 19 Sep 2019 15:17:35 +0200 (CEST)", "from mail-wm1-f67.google.com (mail-wm1-f67.google.com\n\t[209.85.128.67]) by dpdk.org (Postfix) with ESMTP id 20D181F005\n\tfor <dev@dpdk.org>; Thu, 19 Sep 2019 15:17:34 +0200 (CEST)", "by mail-wm1-f67.google.com with SMTP id a6so4461819wma.5\n\tfor <dev@dpdk.org>; Thu, 19 Sep 2019 06:17:34 -0700 (PDT)", "from localhost.localdomain\n\t(lmontsouris-657-1-167-187.w82-127.abo.wanadoo.fr. [82.127.205.187])\n\tby smtp.gmail.com with ESMTPSA id\n\tb194sm9684643wmg.46.2019.09.19.06.17.32\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 19 Sep 2019 06:17:32 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=LGZ+tU1gmovrhETBagcrX0KDaoetERsZIVXfbmQoWv4=;\n\tb=I0/62RTtqmHqANL2IUra3CANe6LEuc7EICYNpSwS1lUR9fb8c3QkI7s4JFKqsVLfOo\n\tG/M24XkuxRUpev8sSSfRw6OOcH5TgwXEL1HoO5qHmazcecg5u0yFiUy7enVX46B1XIl0\n\tw/6i7JTSM6jAXqqd9bY3iXoP/Bn/nI5WbtCr8+uiECxqwa1BroZanZgbtQyhHIDwXAXx\n\tgUDyngrlGQ27revUL34UcYaKsxz8Oaq5+MEpdGUdgxhOUiPlfOeo2JcVrbEoS9x4KlMg\n\tL0AL+pmEpSOF8WzyrztdZHa5Ft0KCYH+kVlz6bROZPtBD3bX+pmWNiE8gZGunX0p/VRb\n\tsKtQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=LGZ+tU1gmovrhETBagcrX0KDaoetERsZIVXfbmQoWv4=;\n\tb=cLNGqSZu67XLSga2cztbTpKq0QiDqkwlM6tGfgKzI3o1dqSDT/I8ivar3DAVMX5b0a\n\t39OZLIUlZGgpTQZ06WIjnnh1LrY4xUmjj3XwldDHxfwthUu3Aj+lsCvDrS/nsoLkye3+\n\tSr9q6CjuF97l4ly+52vw0fyleLKl09GeIVc0ACipRZv7MUQOaGFB/qgLKk1f93Bwpk8n\n\tQEW6YeSNB1xBWbluIBN/x5beaJZfCWrSxll27KQYRNBzopIOpKvGqUs9deZlPUSGLWNI\n\tuOqCAEP/4/1T9pg1Tjmp+ScjwCbUVBHOcb/Te+9gU78XGPAquL92++skEROifuFNmp65\n\tk0XQ==", "X-Gm-Message-State": "APjAAAUguDUu09zw6QUB2+qOoso4bUPDhtw7/ecCGmn/kAcg9WgS4kb2\n\tZscDP42PtZCJgNLM6UCiH0r7/wB9369XbQ==", "X-Google-Smtp-Source": "APXvYqz/HH0/BAT6HMC0BthzQEuXzgRQdvmpJZRkhvwZGpr37juPIeAMWvCWhUq2top3RqDExBqlAg==", "X-Received": "by 2002:a7b:c306:: with SMTP id k6mr3055902wmj.127.1568899053290;\n\tThu, 19 Sep 2019 06:17:33 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Date": "Thu, 19 Sep 2019 15:17:28 +0200", "Message-Id": "<20190919131729.28681-2-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20190919131729.28681-1-stephen@networkplumber.org>", "References": "<20190811160607.16441-1-stephen@networkplumber.org>\n\t<20190919131729.28681-1-stephen@networkplumber.org>", "Subject": "[dpdk-dev] [PATCH v5 1/2] ethdev: expose basic xstats for driver use", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Avoid duplication by having generic basic xstats available\nfor use by drivers. A later patch uses this for failsafe\ndriver.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\nAcked-by: Gaetan Rivet <gaetan.rivet@6wind.com>\n---\n lib/librte_ethdev/rte_ethdev.c | 17 +++----\n lib/librte_ethdev/rte_ethdev_driver.h | 65 ++++++++++++++++++++++++\n lib/librte_ethdev/rte_ethdev_version.map | 5 ++\n 3 files changed, 78 insertions(+), 9 deletions(-)", "diff": "diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c\nindex 17d183e1f0ec..88e3065d06fd 100644\n--- a/lib/librte_ethdev/rte_ethdev.c\n+++ b/lib/librte_ethdev/rte_ethdev.c\n@@ -1996,8 +1996,8 @@ rte_eth_stats_reset(uint16_t port_id)\n \treturn 0;\n }\n \n-static inline int\n-get_xstats_basic_count(struct rte_eth_dev *dev)\n+int\n+rte_eth_basic_stats_count(struct rte_eth_dev *dev)\n {\n \tuint16_t nb_rxqs, nb_txqs;\n \tint count;\n@@ -2034,7 +2034,7 @@ get_xstats_count(uint16_t port_id)\n \t\tcount = 0;\n \n \n-\tcount += get_xstats_basic_count(dev);\n+\tcount += rte_eth_basic_stats_count(dev);\n \n \treturn count;\n }\n@@ -2084,7 +2084,7 @@ rte_eth_xstats_get_id_by_name(uint16_t port_id, const char *xstat_name,\n }\n \n /* retrieve basic stats names */\n-static int\n+int\n rte_eth_basic_stats_get_names(struct rte_eth_dev *dev,\n \tstruct rte_eth_xstat_name *xstats_names)\n {\n@@ -2140,7 +2140,7 @@ rte_eth_xstats_get_names_by_id(uint16_t port_id,\n \tRTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);\n \tdev = &rte_eth_devices[port_id];\n \n-\tbasic_count = get_xstats_basic_count(dev);\n+\tbasic_count = rte_eth_basic_stats_count(dev);\n \tret = get_xstats_count(port_id);\n \tif (ret < 0)\n \t\treturn ret;\n@@ -2268,8 +2268,7 @@ rte_eth_xstats_get_names(uint16_t port_id,\n \treturn cnt_used_entries;\n }\n \n-\n-static int\n+int\n rte_eth_basic_stats_get(uint16_t port_id, struct rte_eth_xstat *xstats)\n {\n \tstruct rte_eth_dev *dev;\n@@ -2341,7 +2340,7 @@ rte_eth_xstats_get_by_id(uint16_t port_id, const uint64_t *ids,\n \texpected_entries = (uint16_t)ret;\n \tstruct rte_eth_xstat xstats[expected_entries];\n \tdev = &rte_eth_devices[port_id];\n-\tbasic_count = get_xstats_basic_count(dev);\n+\tbasic_count = rte_eth_basic_stats_count(dev);\n \n \t/* Return max number of stats if no ids given */\n \tif (!ids) {\n@@ -2355,7 +2354,7 @@ rte_eth_xstats_get_by_id(uint16_t port_id, const uint64_t *ids,\n \t\treturn -EINVAL;\n \n \tif (ids && dev->dev_ops->xstats_get_by_id != NULL && size) {\n-\t\tunsigned int basic_count = get_xstats_basic_count(dev);\n+\t\tunsigned int basic_count = rte_eth_basic_stats_count(dev);\n \t\tuint64_t ids_copy[size];\n \n \t\tfor (i = 0; i < size; i++) {\ndiff --git a/lib/librte_ethdev/rte_ethdev_driver.h b/lib/librte_ethdev/rte_ethdev_driver.h\nindex 936ff8c98651..489889a72203 100644\n--- a/lib/librte_ethdev/rte_ethdev_driver.h\n+++ b/lib/librte_ethdev/rte_ethdev_driver.h\n@@ -208,6 +208,71 @@ rte_eth_linkstatus_get(const struct rte_eth_dev *dev,\n #endif\n }\n \n+/**\n+ * @internal\n+ * Get basic stats part of xstats for an ethernet device.\n+ *\n+ * @param dev\n+ * Pointer to struct rte_eth_dev.\n+ */\n+__rte_experimental\n+int\n+rte_eth_basic_stats_count(struct rte_eth_dev *dev);\n+\n+/**\n+ * @internal\n+ * @b EXPERIMENTAL: this API may change without prior notice.\n+ *\n+ * Retrieve the names for the basic part of extended statistics.\n+ *\n+ * @param dev\n+ * Pointer to struct rte_eth_dev.\n+ * @param xstats_names\n+ * An rte_eth_xstat_name array of at least *size* elements to\n+ * be filled. If set to NULL, the function returns the required number\n+ * of elements.\n+ * @return\n+ * - A positive value lower or equal to size: success. The return value\n+ * is the number of entries filled in the stats table.\n+ * - A positive value higher than size: error, the given statistics table\n+ * is too small. The return value corresponds to the size that should\n+ * be given to succeed. The entries in the table are not valid and\n+ * shall not be used by the caller.\n+ * - A negative value on error (invalid port id).\n+ */\n+__rte_experimental\n+int\n+rte_eth_basic_stats_get_names(struct rte_eth_dev *dev,\n+\t\t\t struct rte_eth_xstat_name *xstats_names);\n+\n+/**\n+ * @internal\n+ * @b EXPERIMENTAL: this API may change without prior notice.\n+ *\n+ * Retrieve the basic part of the extended statistics.\n+ *\n+ * @param dev\n+ * Pointer to struct rte_eth_dev.\n+ * @param xstats\n+ * A pointer to a table of structure of type *rte_eth_xstat*\n+ * to be filled with device statistics ids and values.\n+ * This parameter can be set to NULL if n is 0.\n+ * @param n\n+ * The size of the xstats array (number of elements).\n+ * @return\n+ * - A positive value lower or equal to n: success. The return value\n+ * is the number of entries filled in the stats table.\n+ * - A positive value higher than n: error, the given statistics table\n+ * is too small. The return value corresponds to the size that should\n+ * be given to succeed. The entries in the table are not valid and\n+ * shall not be used by the caller.\n+ * - A negative value on error (invalid port id).\n+ */\n+__rte_experimental\n+int\n+rte_eth_basic_stats_get(uint16_t port_id, struct rte_eth_xstat *xstats);\n+\n+\n /**\n * @warning\n * @b EXPERIMENTAL: this API may change without prior notice.\ndiff --git a/lib/librte_ethdev/rte_ethdev_version.map b/lib/librte_ethdev/rte_ethdev_version.map\nindex 6df42a47b89d..df7e83a90603 100644\n--- a/lib/librte_ethdev/rte_ethdev_version.map\n+++ b/lib/librte_ethdev/rte_ethdev_version.map\n@@ -283,4 +283,9 @@ EXPERIMENTAL {\n \n \t# added in 19.08\n \trte_eth_read_clock;\n+\n+\t# added in 19.11\n+\trte_eth_basic_stats_count;\n+\trte_eth_basic_stats_get;\n+\trte_eth_basic_stats_get_names;\n };\n", "prefixes": [ "v5", "1/2" ] }