Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/59461/?format=api
{ "id": 59461, "url": "https://patches.dpdk.org/api/patches/59461/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190919125650.27262-3-stephen@networkplumber.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190919125650.27262-3-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20190919125650.27262-3-stephen@networkplumber.org", "date": "2019-09-19T12:56:50", "name": "[2/2] net/failsafe: implement xstats", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "d19e09b35e4c8d088cd67a89bcef9cb51b3694f5", "submitter": { "id": 27, "url": "https://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190919125650.27262-3-stephen@networkplumber.org/mbox/", "series": [ { "id": 6453, "url": "https://patches.dpdk.org/api/series/6453/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=6453", "date": "2019-09-19T12:56:48", "name": "failsafe: add xstats", "version": 4, "mbox": "https://patches.dpdk.org/series/6453/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/59461/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/59461/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E727F1EFEB;\n\tThu, 19 Sep 2019 14:56:59 +0200 (CEST)", "from mail-wr1-f66.google.com (mail-wr1-f66.google.com\n\t[209.85.221.66]) by dpdk.org (Postfix) with ESMTP id 81EE51EFDF\n\tfor <dev@dpdk.org>; Thu, 19 Sep 2019 14:56:57 +0200 (CEST)", "by mail-wr1-f66.google.com with SMTP id r5so2944446wrm.12\n\tfor <dev@dpdk.org>; Thu, 19 Sep 2019 05:56:57 -0700 (PDT)", "from localhost.localdomain\n\t(lmontsouris-657-1-167-187.w82-127.abo.wanadoo.fr. [82.127.205.187])\n\tby smtp.gmail.com with ESMTPSA id\n\tf186sm8030519wmg.21.2019.09.19.05.56.54\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 19 Sep 2019 05:56:55 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=5e+KNvphZQf/O34q0pjNdu4cp7DnIhHMPoCcSIn/f18=;\n\tb=nzzBaF8adXUUKkcl2zpuOY3LiFwp+BNXibWu/9BdfiuKdnrlEYTE4cdmZdznm3Dpea\n\t6o4IDMsUUS2EL44ifBmfatFz6EvBuD9j9jbMOam0uuLHeVs3y0yh50X+igCFHw3WuU3y\n\t91Cu/uhAjJUcwKxh++VDmKqUATZFc5ua89ANBGuM6NN54InpXwyBftRyoh5Um6D92s24\n\tXsvJKycXaTwLaglqZeuND3J577xGkSxglFR6uOd9xJyg9lT9GnauQfYxcMh92gC6l/j2\n\t7pdMLl5eFxpLRmEFmp/bZg49GCXMw/i8h2KL5om6a36Tu2cd/pnARHU/VWdmmVup87Zl\n\tZdxA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=5e+KNvphZQf/O34q0pjNdu4cp7DnIhHMPoCcSIn/f18=;\n\tb=C6kbH7VPgCFF441jsCoRWuWoj2R0c4t2Ql75ghNnJF+hc7ln41R2t8SbXsC8TARP0b\n\tpmgzaQR6d5myNjFXIsRZ0swIgyuMc3WdZws9Zo+mn3GfsI3V/+Bj5Yy+bIDYyYmiiofb\n\tg0/bGJMFuzBxf9KY7wXzB++Wfj9pQ6TPryNCoj5uk8I5NDjDZtpp8R9KrokSv6+cTtqc\n\tQDymFfmIvmb/9ggATVeTRyzYgOD+9TVev2QtCbQiqGl8z+GApVdE5pNnUx3g+bcyrD22\n\tCOzjDeNaHUu+x0d5Aotz1p5KtvM8yOqesTa9EQduLoMaAH8v9lxvUpRAacLFni5prC8h\n\tWMgQ==", "X-Gm-Message-State": "APjAAAXKqPKWwmqBaBbBFyshJ/xyyP0bC0k3pqwqIYL48ctn72Sx4gFu\n\tTVhYnUXWlE8OO0YInErmG/pN29P6nAEyww==", "X-Google-Smtp-Source": "APXvYqzJFwTpzZtU4OcFDIwLfvAnFHCd0mF0+rlLts6rRebMLaZf5sNYBPGSXsm2pOI/O4yrL3efDA==", "X-Received": "by 2002:adf:ec09:: with SMTP id x9mr7031842wrn.308.1568897816760;\n\tThu, 19 Sep 2019 05:56:56 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Date": "Thu, 19 Sep 2019 14:56:50 +0200", "Message-Id": "<20190919125650.27262-3-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20190919125650.27262-1-stephen@networkplumber.org>", "References": "<20190811160607.16441-1-stephen@networkplumber.org>\n\t<20190919125650.27262-1-stephen@networkplumber.org>", "Subject": "[dpdk-dev] [PATCH 2/2] net/failsafe: implement xstats", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add support for extended statistics in failsafe driver.\nReports basic statistics for the failsafe driver, and detailed\nstatistics for each sub device.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\nAcked-by: Gaetan Rivet <gaetan.rivet@6wind.com>\n---\n drivers/net/failsafe/failsafe_ops.c | 135 ++++++++++++++++++++++++++++\n 1 file changed, 135 insertions(+)", "diff": "diff --git a/drivers/net/failsafe/failsafe_ops.c b/drivers/net/failsafe/failsafe_ops.c\nindex 96e05d4dc4b1..711fdf302f4f 100644\n--- a/drivers/net/failsafe/failsafe_ops.c\n+++ b/drivers/net/failsafe/failsafe_ops.c\n@@ -789,6 +789,138 @@ fs_stats_reset(struct rte_eth_dev *dev)\n \tfs_unlock(dev, 0);\n }\n \n+/*\n+ * Count how many xstats in total\n+ * Include basic stats for failsafe device\n+ * plus xstats for each sub-device present.\n+ */\n+static int\n+fs_xstats_count(struct rte_eth_dev *dev)\n+{\n+\tstruct sub_device *sdev;\n+\tuint8_t i;\n+\tint count;\n+\n+\tcount = rte_eth_basic_stats_count(dev);\n+\n+\tfs_lock(dev, 0);\n+\tFOREACH_SUBDEV(sdev, i, dev) {\n+\t\tcount += rte_eth_xstats_get_names(PORT_ID(sdev), NULL, 0);\n+\t}\n+\tfs_unlock(dev, 0);\n+\n+\treturn count;\n+}\n+\n+static int\n+fs_xstats_get_names(struct rte_eth_dev *dev,\n+\t\t struct rte_eth_xstat_name *xstats_names,\n+\t\t unsigned int limit)\n+{\n+\tstruct sub_device *sdev;\n+\tunsigned int count;\n+\tchar tmp[RTE_ETH_XSTATS_NAME_SIZE];\n+\tuint8_t i;\n+\tint r;\n+\n+\t/* Caller only cares about count */\n+\tif (!xstats_names)\n+\t\treturn fs_xstats_count(dev);\n+\n+\tr = rte_eth_basic_stats_get_names(dev, xstats_names);\n+\tif (r < 0)\n+\t\treturn r;\n+\n+\tcount = r;\n+\n+\tfs_lock(dev, 0);\n+\tFOREACH_SUBDEV(sdev, i, dev) {\n+\t\tstruct rte_eth_xstat_name *sub_names = xstats_names + count;\n+\n+\t\tif (count >= limit)\n+\t\t\tbreak;\n+\n+\t\tr = rte_eth_xstats_get_names(PORT_ID(sdev), sub_names,\n+\t\t\t\t\t limit - count);\n+\t\tif (r < 0) {\n+\t\t\tfs_unlock(dev, 0);\n+\t\t\treturn r;\n+\t\t}\n+\n+\t\t/* add sub_ prefix to names */\n+\t\tfor (i = 0; i < r; i++) {\n+\t\t\tsnprintf(tmp, sizeof(tmp), \"sub%u_%s\",\n+\t\t\t\t i, sub_names[i].name);\n+\t\t\tmemcpy(sub_names[i].name, tmp,\n+\t\t\t RTE_ETH_XSTATS_NAME_SIZE);\n+\t\t}\n+\n+\t\tcount += r;\n+\t}\n+\tfs_unlock(dev, 0);\n+\n+\treturn count;\n+}\n+\n+static int\n+fs_xstats_get(struct rte_eth_dev *dev,\n+\t struct rte_eth_xstat *xstats,\n+\t unsigned int n)\n+{\n+\tunsigned int nstats, j, count, scount;\n+\tstruct sub_device *sdev;\n+\tuint8_t i;\n+\tint ret;\n+\n+\tnstats = fs_xstats_count(dev);\n+\tif (n < nstats || xstats == NULL)\n+\t\treturn nstats;\n+\n+\tret = rte_eth_basic_stats_get(dev->data->port_id, xstats);\n+\tif (ret < 0)\n+\t\treturn ret;\n+\n+\tcount = ret;\n+\tfor (j = 0; j < count; j++)\n+\t\txstats[j].id = j;\n+\n+\tfs_lock(dev, 0);\n+\tFOREACH_SUBDEV(sdev, i, dev) {\n+\t\tret = rte_eth_xstats_get(PORT_ID(sdev),\n+\t\t\t\t\t xstats + count,\n+\t\t\t\t\t n > count ? n - count : 0);\n+\t\tif (ret < 0) {\n+\t\t\tfs_unlock(dev, 0);\n+\t\t\treturn ret;\n+\t\t}\n+\t\tscount = ret;\n+\n+\t\t/* add offset to id's from sub-device */\n+\t\tfor (j = 0; j < scount; j++)\n+\t\t\txstats[count + j].id += count;\n+\n+\t\tcount += scount;\n+\t}\n+\tfs_unlock(dev, 0);\n+\n+\treturn count;\n+}\n+\n+static void\n+fs_xstats_reset(struct rte_eth_dev *dev)\n+{\n+\tstruct sub_device *sdev;\n+\tuint8_t i;\n+\n+\trte_eth_stats_reset(dev->data->port_id);\n+\n+\tfs_lock(dev, 0);\n+\tFOREACH_SUBDEV(sdev, i, dev) {\n+\t\trte_eth_xstats_reset(PORT_ID(sdev));\n+\t}\n+\tfs_unlock(dev, 0);\n+}\n+\n static void\n fs_dev_merge_desc_lim(struct rte_eth_desc_lim *to,\n \t\t const struct rte_eth_desc_lim *from)\n@@ -1233,6 +1365,9 @@ const struct eth_dev_ops failsafe_ops = {\n \t.link_update = fs_link_update,\n \t.stats_get = fs_stats_get,\n \t.stats_reset = fs_stats_reset,\n+\t.xstats_get = fs_xstats_get,\n+\t.xstats_get_names = fs_xstats_get_names,\n+\t.xstats_reset = fs_xstats_reset,\n \t.dev_infos_get = fs_dev_infos_get,\n \t.dev_supported_ptypes_get = fs_dev_supported_ptypes_get,\n \t.mtu_set = fs_mtu_set,\n", "prefixes": [ "2/2" ] }