Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/59300/?format=api
{ "id": 59300, "url": "https://patches.dpdk.org/api/patches/59300/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190916230615.411726-2-ying.a.wang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190916230615.411726-2-ying.a.wang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190916230615.411726-2-ying.a.wang@intel.com", "date": "2019-09-16T23:06:11", "name": "[v2,1/5] net/ice: minor code clean", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "2986d203585b6793809402dd7afffebfa8c50dfb", "submitter": { "id": 1280, "url": "https://patches.dpdk.org/api/people/1280/?format=api", "name": "Ying Wang", "email": "ying.a.wang@intel.com" }, "delegate": { "id": 31221, "url": "https://patches.dpdk.org/api/users/31221/?format=api", "username": "yexl", "first_name": "xiaolong", "last_name": "ye", "email": "xiaolong.ye@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190916230615.411726-2-ying.a.wang@intel.com/mbox/", "series": [ { "id": 6420, "url": "https://patches.dpdk.org/api/series/6420/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=6420", "date": "2019-09-16T23:06:10", "name": "rework for ice generic flow framework and switch filter", "version": 2, "mbox": "https://patches.dpdk.org/series/6420/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/59300/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/59300/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id DF8D31BFB9;\n\tTue, 17 Sep 2019 09:28:52 +0200 (CEST)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby dpdk.org (Postfix) with ESMTP id 7FD8A1BFB8\n\tfor <dev@dpdk.org>; Tue, 17 Sep 2019 09:28:49 +0200 (CEST)", "from fmsmga007.fm.intel.com ([10.253.24.52])\n\tby orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t17 Sep 2019 00:28:49 -0700", "from unknown (HELO npg-dpdk-cvl-yingwang-117d84.sh.intel.com)\n\t([10.67.117.84])\n\tby fmsmga007.fm.intel.com with ESMTP; 17 Sep 2019 00:28:47 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.64,515,1559545200\"; d=\"scan'208\";a=\"187384638\"", "From": "Ying Wang <ying.a.wang@intel.com>", "To": "xiaolong.ye@intel.com,\n\tqi.z.zhang@intel.com", "Cc": "dev@dpdk.org, qiming.yang@intel.com, wei.zhao1@intel.com,\n\tying.a.wang@intel.com", "Date": "Tue, 17 Sep 2019 07:06:11 +0800", "Message-Id": "<20190916230615.411726-2-ying.a.wang@intel.com>", "X-Mailer": "git-send-email 2.15.1", "In-Reply-To": "<20190916230615.411726-1-ying.a.wang@intel.com>", "References": "<20190903221522.151382-2-ying.a.wang@intel.com>\n\t<20190916230615.411726-1-ying.a.wang@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 1/5] net/ice: minor code clean", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The patch removes redundant code and cleans up some wrong indentations.\n\nSigned-off-by: Ying Wang <ying.a.wang@intel.com>\n---\n drivers/net/ice/ice_generic_flow.c | 39 +++++++++++++++++++-------------------\n 1 file changed, 19 insertions(+), 20 deletions(-)", "diff": "diff --git a/drivers/net/ice/ice_generic_flow.c b/drivers/net/ice/ice_generic_flow.c\nindex 1c0adc779..44dbccd3d 100644\n--- a/drivers/net/ice/ice_generic_flow.c\n+++ b/drivers/net/ice/ice_generic_flow.c\n@@ -44,21 +44,21 @@ const struct rte_flow_ops ice_flow_ops = {\n \n static int\n ice_flow_valid_attr(const struct rte_flow_attr *attr,\n-\t\t struct rte_flow_error *error)\n+\t\tstruct rte_flow_error *error)\n {\n \t/* Must be input direction */\n \tif (!attr->ingress) {\n \t\trte_flow_error_set(error, EINVAL,\n-\t\t\t\t RTE_FLOW_ERROR_TYPE_ATTR_INGRESS,\n-\t\t\t\t attr, \"Only support ingress.\");\n+\t\t\t\tRTE_FLOW_ERROR_TYPE_ATTR_INGRESS,\n+\t\t\t\tattr, \"Only support ingress.\");\n \t\treturn -rte_errno;\n \t}\n \n \t/* Not supported */\n \tif (attr->egress) {\n \t\trte_flow_error_set(error, EINVAL,\n-\t\t\t\t RTE_FLOW_ERROR_TYPE_ATTR_EGRESS,\n-\t\t\t\t attr, \"Not support egress.\");\n+\t\t\t\tRTE_FLOW_ERROR_TYPE_ATTR_EGRESS,\n+\t\t\t\tattr, \"Not support egress.\");\n \t\treturn -rte_errno;\n \t}\n \n@@ -73,8 +73,8 @@ ice_flow_valid_attr(const struct rte_flow_attr *attr,\n \t/* Not supported */\n \tif (attr->group) {\n \t\trte_flow_error_set(error, EINVAL,\n-\t\t\t\t RTE_FLOW_ERROR_TYPE_ATTR_GROUP,\n-\t\t\t\t attr, \"Not support group.\");\n+\t\t\t\tRTE_FLOW_ERROR_TYPE_ATTR_GROUP,\n+\t\t\t\tattr, \"Not support group.\");\n \t\treturn -rte_errno;\n \t}\n \n@@ -102,7 +102,7 @@ ice_find_first_item(const struct rte_flow_item *item, bool is_void)\n /* Skip all VOID items of the pattern */\n static void\n ice_pattern_skip_void_item(struct rte_flow_item *items,\n-\t\t\t const struct rte_flow_item *pattern)\n+\t\t\tconst struct rte_flow_item *pattern)\n {\n \tuint32_t cpy_count = 0;\n \tconst struct rte_flow_item *pb = pattern, *pe = pattern;\n@@ -124,7 +124,6 @@ ice_pattern_skip_void_item(struct rte_flow_item *items,\n \t\titems += cpy_count;\n \n \t\tif (pe->type == RTE_FLOW_ITEM_TYPE_END) {\n-\t\t\tpb = pe;\n \t\t\tbreak;\n \t\t}\n \n@@ -560,10 +559,10 @@ static int ice_flow_valid_action(struct rte_eth_dev *dev,\n \n static int\n ice_flow_validate(struct rte_eth_dev *dev,\n-\t\t const struct rte_flow_attr *attr,\n-\t\t const struct rte_flow_item pattern[],\n-\t\t const struct rte_flow_action actions[],\n-\t\t struct rte_flow_error *error)\n+\t\tconst struct rte_flow_attr *attr,\n+\t\tconst struct rte_flow_item pattern[],\n+\t\tconst struct rte_flow_action actions[],\n+\t\tstruct rte_flow_error *error)\n {\n \tuint64_t inset = 0;\n \tint ret = ICE_ERR_NOT_SUPPORTED;\n@@ -609,10 +608,10 @@ ice_flow_validate(struct rte_eth_dev *dev,\n \n static struct rte_flow *\n ice_flow_create(struct rte_eth_dev *dev,\n-\t\t const struct rte_flow_attr *attr,\n-\t\t const struct rte_flow_item pattern[],\n-\t\t const struct rte_flow_action actions[],\n-\t\t struct rte_flow_error *error)\n+\t\tconst struct rte_flow_attr *attr,\n+\t\tconst struct rte_flow_item pattern[],\n+\t\tconst struct rte_flow_action actions[],\n+\t\tstruct rte_flow_error *error)\n {\n \tstruct ice_pf *pf = ICE_DEV_PRIVATE_TO_PF(dev->data->dev_private);\n \tstruct rte_flow *flow = NULL;\n@@ -647,8 +646,8 @@ ice_flow_create(struct rte_eth_dev *dev,\n \n static int\n ice_flow_destroy(struct rte_eth_dev *dev,\n-\t\t struct rte_flow *flow,\n-\t\t struct rte_flow_error *error)\n+\t\tstruct rte_flow *flow,\n+\t\tstruct rte_flow_error *error)\n {\n \tstruct ice_pf *pf = ICE_DEV_PRIVATE_TO_PF(dev->data->dev_private);\n \tint ret = 0;\n@@ -669,7 +668,7 @@ ice_flow_destroy(struct rte_eth_dev *dev,\n \n static int\n ice_flow_flush(struct rte_eth_dev *dev,\n-\t struct rte_flow_error *error)\n+\t\tstruct rte_flow_error *error)\n {\n \tstruct ice_pf *pf = ICE_DEV_PRIVATE_TO_PF(dev->data->dev_private);\n \tstruct rte_flow *p_flow;\n", "prefixes": [ "v2", "1/5" ] }