Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/59260/?format=api
{ "id": 59260, "url": "https://patches.dpdk.org/api/patches/59260/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1568461055-16472-13-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1568461055-16472-13-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1568461055-16472-13-git-send-email-arybchenko@solarflare.com", "date": "2019-09-14T11:37:32", "name": "[v3,12/13] test/bonding: check code of promiscuous mode switch", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "4b51c200046ce995f64ba25dc3383352e49a2072", "submitter": { "id": 607, "url": "https://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1568461055-16472-13-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 6407, "url": "https://patches.dpdk.org/api/series/6407/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=6407", "date": "2019-09-14T11:37:20", "name": "ethdev: change promiscuous mode functions to return status", "version": 3, "mbox": "https://patches.dpdk.org/series/6407/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/59260/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/59260/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B645E1EB72;\n\tSat, 14 Sep 2019 13:38:24 +0200 (CEST)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n\t[67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 814AE1EAD5\n\tfor <dev@dpdk.org>; Sat, 14 Sep 2019 13:37:56 +0200 (CEST)", "from webmail.solarflare.com (webmail.solarflare.com\n\t[12.187.104.26])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id\n\t82130400056; Sat, 14 Sep 2019 11:37:55 +0000 (UTC)", "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1395.4; Sat, 14 Sep 2019 04:37:49 -0700", "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1395.4 via Frontend Transport; Sat, 14 Sep 2019 04:37:49 -0700", "from ukv-loginhost.uk.solarflarecom.com\n\t(ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tx8EBbn83015476; Sat, 14 Sep 2019 12:37:49 +0100", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n\tby ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id\n\tE80021613D1; Sat, 14 Sep 2019 12:37:48 +0100 (BST)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "Chas Williams <chas3@att.com>", "CC": "<dev@dpdk.org>, Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.ru>", "Date": "Sat, 14 Sep 2019 12:37:32 +0100", "Message-ID": "<1568461055-16472-13-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1568461055-16472-1-git-send-email-arybchenko@solarflare.com>", "References": "<1567699852-31693-1-git-send-email-arybchenko@solarflare.com>\n\t<1568461055-16472-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.5.1010-24910.005", "X-TM-AS-Result": "No-1.313600-4.000000-10", "X-TMASE-MatchedRID": "Wn2D/DSOcBHbS0m47m6fSn84FZpy/6JVAPiR4btCEeaYkF7ZtFfCU0kx\n\tAPClfhN0YHB0GcKFMltFdYu4cV7ttyHhSBQfglfsA9lly13c/gHYuVu0X/rOkMwh6K2EqJIn5sL\n\t6YgE8QF8p0ZJ5Yq0pe9xj9GFWJ4cRhK/XSkr3BlTylEfNwb6iLfX71s7cIJuTJmE4A+qD79lZru\n\tEoKvBZSVhWGQmcjfw3aTyuzdOrGrRovGFNoIkoj0f49ONH0RaSNV9S7O+u3KYLIq08JORQQtAOO\n\tSAF0cTNVMlZj3RhDo/E+eyncEK+S+VHGbcDbAq6FEUknJ/kEl7dB/CxWTRRu+rAZ8KTspSzuSwk\n\tPonTUZonBhYubDV2+R9d12UENbYOodYhWSP6AW+nHkmWKhJRHKRexQ5qx4DYBERlEGknaQ8DbQf\n\tO/FbpcGyOcLFer6EeD1y8R38S3l1URzkirO0Q1F5h9KQWrq4BvuMTr7CQJJ5+3BndfXUhXQ==", "X-TM-AS-User-Approved-Sender": "No", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10--1.313600-4.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.5.1010-24910.005", "X-MDID": "1568461076-wC-b8Gi1wmwq", "Subject": "[dpdk-dev] [PATCH v3 12/13] test/bonding: check code of promiscuous\n\tmode switch", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.ru>\n\nrte_eth_promiscuous_enable()/rte_eth_promiscuous_disable() return\nvalue was changed from void to int, so this patch modify usage\nof these functions across test/bonding\naccording to new return type.\n\nSigned-off-by: Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.ru>\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n app/test/test_link_bonding.c | 55 ++++++++++++++++++++++++------\n app/test/test_link_bonding_mode4.c | 16 +++++++--\n 2 files changed, 58 insertions(+), 13 deletions(-)", "diff": "diff --git a/app/test/test_link_bonding.c b/app/test/test_link_bonding.c\nindex 938fafca3..cbbbc98a1 100644\n--- a/app/test/test_link_bonding.c\n+++ b/app/test/test_link_bonding.c\n@@ -1760,13 +1760,17 @@ static int\n test_roundrobin_verify_promiscuous_enable_disable(void)\n {\n \tint i, promiscuous_en;\n+\tint ret;\n \n \t/* Initialize bonded device with 4 slaves in round robin mode */\n \tTEST_ASSERT_SUCCESS(initialize_bonded_device_with_slaves(\n \t\t\tBONDING_MODE_ROUND_ROBIN, 0, 4, 1),\n \t\t\t\"Failed to initialize bonded device with slaves\");\n \n-\trte_eth_promiscuous_enable(test_params->bonded_port_id);\n+\tret = rte_eth_promiscuous_enable(test_params->bonded_port_id);\n+\tTEST_ASSERT_SUCCESS(ret,\n+\t\t\"Failed to enable promiscuous mode for port %d: %s\",\n+\t\ttest_params->bonded_port_id, rte_strerror(-ret));\n \n \tpromiscuous_en = rte_eth_promiscuous_get(test_params->bonded_port_id);\n \tTEST_ASSERT_EQUAL(promiscuous_en, 1,\n@@ -1781,7 +1785,10 @@ test_roundrobin_verify_promiscuous_enable_disable(void)\n \t\t\t\ttest_params->slave_port_ids[i]);\n \t}\n \n-\trte_eth_promiscuous_disable(test_params->bonded_port_id);\n+\tret = rte_eth_promiscuous_disable(test_params->bonded_port_id);\n+\tTEST_ASSERT_SUCCESS(ret,\n+\t\t\"Failed to disable promiscuous mode for port %d: %s\",\n+\t\ttest_params->bonded_port_id, rte_strerror(-ret));\n \n \tpromiscuous_en = rte_eth_promiscuous_get(test_params->bonded_port_id);\n \tTEST_ASSERT_EQUAL(promiscuous_en, 0,\n@@ -2200,6 +2207,7 @@ static int\n test_activebackup_verify_promiscuous_enable_disable(void)\n {\n \tint i, primary_port, promiscuous_en;\n+\tint ret;\n \n \t/* Initialize bonded device with 4 slaves in round robin mode */\n \tTEST_ASSERT_SUCCESS(initialize_bonded_device_with_slaves(\n@@ -2211,7 +2219,10 @@ test_activebackup_verify_promiscuous_enable_disable(void)\n \t\t\t\"failed to get primary slave for bonded port (%d)\",\n \t\t\ttest_params->bonded_port_id);\n \n-\trte_eth_promiscuous_enable(test_params->bonded_port_id);\n+\tret = rte_eth_promiscuous_enable(test_params->bonded_port_id);\n+\tTEST_ASSERT_SUCCESS(ret,\n+\t\t\"Failed to enable promiscuous mode for port %d: %s\",\n+\t\ttest_params->bonded_port_id, rte_strerror(-ret));\n \n \tTEST_ASSERT_EQUAL(rte_eth_promiscuous_get(test_params->bonded_port_id), 1,\n \t\t\t\"Port (%d) promiscuous mode not enabled\",\n@@ -2232,7 +2243,10 @@ test_activebackup_verify_promiscuous_enable_disable(void)\n \n \t}\n \n-\trte_eth_promiscuous_disable(test_params->bonded_port_id);\n+\tret = rte_eth_promiscuous_disable(test_params->bonded_port_id);\n+\tTEST_ASSERT_SUCCESS(ret,\n+\t\t\"Failed to disable promiscuous mode for port %d: %s\",\n+\t\ttest_params->bonded_port_id, rte_strerror(-ret));\n \n \tTEST_ASSERT_EQUAL(rte_eth_promiscuous_get(test_params->bonded_port_id), 0,\n \t\t\t\"Port (%d) promiscuous mode not disabled\\n\",\n@@ -3110,13 +3124,17 @@ static int\n test_balance_verify_promiscuous_enable_disable(void)\n {\n \tint i;\n+\tint ret;\n \n \t/* Initialize bonded device with 4 slaves in round robin mode */\n \tTEST_ASSERT_SUCCESS(initialize_bonded_device_with_slaves(\n \t\t\tBONDING_MODE_BALANCE, 0, 4, 1),\n \t\t\t\"Failed to initialise bonded device\");\n \n-\trte_eth_promiscuous_enable(test_params->bonded_port_id);\n+\tret = rte_eth_promiscuous_enable(test_params->bonded_port_id);\n+\tTEST_ASSERT_SUCCESS(ret,\n+\t\t\"Failed to enable promiscuous mode for port %d: %s\",\n+\t\ttest_params->bonded_port_id, rte_strerror(-ret));\n \n \tTEST_ASSERT_EQUAL(rte_eth_promiscuous_get(test_params->bonded_port_id), 1,\n \t\t\t\"Port (%d) promiscuous mode not enabled\",\n@@ -3129,7 +3147,10 @@ test_balance_verify_promiscuous_enable_disable(void)\n \t\t\t\ttest_params->slave_port_ids[i]);\n \t}\n \n-\trte_eth_promiscuous_disable(test_params->bonded_port_id);\n+\tret = rte_eth_promiscuous_disable(test_params->bonded_port_id);\n+\tTEST_ASSERT_SUCCESS(ret,\n+\t\t\"Failed to disable promiscuous mode for port %d: %s\",\n+\t\ttest_params->bonded_port_id, rte_strerror(-ret));\n \n \tTEST_ASSERT_EQUAL(rte_eth_promiscuous_get(test_params->bonded_port_id), 0,\n \t\t\t\"Port (%d) promiscuous mode not disabled\",\n@@ -3696,13 +3717,17 @@ static int\n test_broadcast_verify_promiscuous_enable_disable(void)\n {\n \tint i;\n+\tint ret;\n \n \t/* Initialize bonded device with 4 slaves in round robin mode */\n \tTEST_ASSERT_SUCCESS(initialize_bonded_device_with_slaves(\n \t\t\tBONDING_MODE_BROADCAST, 0, 4, 1),\n \t\t\t\"Failed to initialise bonded device\");\n \n-\trte_eth_promiscuous_enable(test_params->bonded_port_id);\n+\tret = rte_eth_promiscuous_enable(test_params->bonded_port_id);\n+\tTEST_ASSERT_SUCCESS(ret,\n+\t\t\"Failed to enable promiscuous mode for port %d: %s\",\n+\t\ttest_params->bonded_port_id, rte_strerror(-ret));\n \n \n \tTEST_ASSERT_EQUAL(rte_eth_promiscuous_get(test_params->bonded_port_id), 1,\n@@ -3716,7 +3741,10 @@ test_broadcast_verify_promiscuous_enable_disable(void)\n \t\t\t\ttest_params->slave_port_ids[i]);\n \t}\n \n-\trte_eth_promiscuous_disable(test_params->bonded_port_id);\n+\tret = rte_eth_promiscuous_disable(test_params->bonded_port_id);\n+\tTEST_ASSERT_SUCCESS(ret,\n+\t\t\"Failed to disable promiscuous mode for port %d: %s\",\n+\t\ttest_params->bonded_port_id, rte_strerror(-ret));\n \n \tTEST_ASSERT_EQUAL(rte_eth_promiscuous_get(test_params->bonded_port_id), 0,\n \t\t\t\"Port (%d) promiscuous mode not disabled\",\n@@ -4174,6 +4202,7 @@ static int\n test_tlb_verify_promiscuous_enable_disable(void)\n {\n \tint i, primary_port, promiscuous_en;\n+\tint ret;\n \n \t/* Initialize bonded device with 4 slaves in transmit load balancing mode */\n \tTEST_ASSERT_SUCCESS( initialize_bonded_device_with_slaves(\n@@ -4185,7 +4214,10 @@ test_tlb_verify_promiscuous_enable_disable(void)\n \t\t\t\"failed to get primary slave for bonded port (%d)\",\n \t\t\ttest_params->bonded_port_id);\n \n-\trte_eth_promiscuous_enable(test_params->bonded_port_id);\n+\tret = rte_eth_promiscuous_enable(test_params->bonded_port_id);\n+\tTEST_ASSERT_SUCCESS(ret,\n+\t\t\"Failed to enable promiscuous mode for port %d: %s\",\n+\t\ttest_params->bonded_port_id, rte_strerror(-ret));\n \n \tpromiscuous_en = rte_eth_promiscuous_get(test_params->bonded_port_id);\n \tTEST_ASSERT_EQUAL(promiscuous_en, (int)1,\n@@ -4206,7 +4238,10 @@ test_tlb_verify_promiscuous_enable_disable(void)\n \n \t}\n \n-\trte_eth_promiscuous_disable(test_params->bonded_port_id);\n+\tret = rte_eth_promiscuous_disable(test_params->bonded_port_id);\n+\tTEST_ASSERT_SUCCESS(ret,\n+\t\t\"Failed to disable promiscuous mode for port %d: %s\\n\",\n+\t\ttest_params->bonded_port_id, rte_strerror(-ret));\n \n \tpromiscuous_en = rte_eth_promiscuous_get(test_params->bonded_port_id);\n \tTEST_ASSERT_EQUAL(promiscuous_en, (int)0,\ndiff --git a/app/test/test_link_bonding_mode4.c b/app/test/test_link_bonding_mode4.c\nindex bbb4e9cce..70b95d040 100644\n--- a/app/test/test_link_bonding_mode4.c\n+++ b/app/test/test_link_bonding_mode4.c\n@@ -312,6 +312,7 @@ static int\n initialize_bonded_device_with_slaves(uint16_t slave_count, uint8_t external_sm)\n {\n \tuint8_t i;\n+\tint ret;\n \n \tRTE_VERIFY(test_params.bonded_port_id != INVALID_PORT_ID);\n \n@@ -323,7 +324,10 @@ initialize_bonded_device_with_slaves(uint16_t slave_count, uint8_t external_sm)\n \n \t/* Reset mode 4 configuration */\n \trte_eth_bond_8023ad_setup(test_params.bonded_port_id, NULL);\n-\trte_eth_promiscuous_disable(test_params.bonded_port_id);\n+\tret = rte_eth_promiscuous_disable(test_params.bonded_port_id);\n+\tTEST_ASSERT_SUCCESS(ret,\n+\t\t\"Failed disable promiscuous mode for port %d: %s\",\n+\t\ttest_params.bonded_port_id, rte_strerror(-ret));\n \n \tif (external_sm) {\n \t\tstruct rte_eth_bond_8023ad_conf conf;\n@@ -824,7 +828,10 @@ test_mode4_rx(void)\n \t/* First try with promiscuous mode enabled.\n \t * Add 2 packets to each slave. First with bonding MAC address, second with\n \t * different. Check if we received all of them. */\n-\trte_eth_promiscuous_enable(test_params.bonded_port_id);\n+\tretval = rte_eth_promiscuous_enable(test_params.bonded_port_id);\n+\tTEST_ASSERT_SUCCESS(retval,\n+\t\t\t\"Failed to enable promiscuous mode for port %d: %s\",\n+\t\t\ttest_params.bonded_port_id, rte_strerror(-retval));\n \n \texpected_pkts_cnt = 0;\n \tFOR_EACH_SLAVE(i, slave) {\n@@ -869,7 +876,10 @@ test_mode4_rx(void)\n \n \t/* Now, disable promiscuous mode. When promiscuous mode is disabled we\n \t * expect to receive only packets that are directed to bonding port. */\n-\trte_eth_promiscuous_disable(test_params.bonded_port_id);\n+\tretval = rte_eth_promiscuous_disable(test_params.bonded_port_id);\n+\tTEST_ASSERT_SUCCESS(retval,\n+\t\t\"Failed to disable promiscuous mode for port %d: %s\",\n+\t\ttest_params.bonded_port_id, rte_strerror(-retval));\n \n \texpected_pkts_cnt = 0;\n \tFOR_EACH_SLAVE(i, slave) {\n", "prefixes": [ "v3", "12/13" ] }