Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/59121/?format=api
{ "id": 59121, "url": "https://patches.dpdk.org/api/patches/59121/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/cf2cbf6ab9f0f8d1a49960d78b246c01ec8b1375.1568216827.git.thierry.herbelot@6wind.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<cf2cbf6ab9f0f8d1a49960d78b246c01ec8b1375.1568216827.git.thierry.herbelot@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/cf2cbf6ab9f0f8d1a49960d78b246c01ec8b1375.1568216827.git.thierry.herbelot@6wind.com", "date": "2019-09-11T16:04:08", "name": "[1/2] virtio: fix rx stats with vectorized functions", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "63f6a63dae6295f1cfca16db35f8c12773df458c", "submitter": { "id": 897, "url": "https://patches.dpdk.org/api/people/897/?format=api", "name": "Thierry Herbelot", "email": "thierry.herbelot@6wind.com" }, "delegate": { "id": 2642, "url": "https://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/cf2cbf6ab9f0f8d1a49960d78b246c01ec8b1375.1568216827.git.thierry.herbelot@6wind.com/mbox/", "series": [ { "id": 6376, "url": "https://patches.dpdk.org/api/series/6376/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=6376", "date": "2019-09-11T16:04:07", "name": "Fixes in virtio vectorized functions", "version": 1, "mbox": "https://patches.dpdk.org/series/6376/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/59121/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/59121/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id BA9EF1E8CA;\n\tWed, 11 Sep 2019 18:04:52 +0200 (CEST)", "from mail-wm1-f67.google.com (mail-wm1-f67.google.com\n\t[209.85.128.67]) by dpdk.org (Postfix) with ESMTP id D97F81E8C2\n\tfor <dev@dpdk.org>; Wed, 11 Sep 2019 18:04:51 +0200 (CEST)", "by mail-wm1-f67.google.com with SMTP id p7so4142596wmp.4\n\tfor <dev@dpdk.org>; Wed, 11 Sep 2019 09:04:51 -0700 (PDT)", "from ascain.dev.6wind.com. (host.78.145.23.62.rev.coltfrance.com.\n\t[62.23.145.78]) by smtp.gmail.com with ESMTPSA id\n\tv8sm33477216wra.79.2019.09.11.09.04.50\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 11 Sep 2019 09:04:50 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=9k+VkqWIKhC5aBr3JYg4qcAj0AVeNDxY4zBQQntLZUI=;\n\tb=jAMqlH5tbFxOTIma4XCqGKHVoHwKdVD1g8lXbSKKVmYERWbTvKPnhlPL3xCfe9SJKb\n\tbm2/uyc4+pIz7g3ga6z/RJhk6SpR+zwmThIlzbWAL3Il5lUZGP90RF2oEnaGf8VNjoAd\n\tDLb4IgYf8gfp0uIndjIFqk5qsYTL+844SXMCmb6A2NRn1ug0/bvzfeUkAwkufX845E2Z\n\tqCF24FLug7M5/tQ8RwJskDWPUoPbYhmahSNcCmAc28v2PqVbfmoTdylCvZxNU0Rgi94C\n\t9pEfhuJYlj1JDHTG8ooP5NWumzAi4l9i6TcHyVSsUlKXVq0PDW1mnUE4zIqhvBPFmlFf\n\tmVDg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=9k+VkqWIKhC5aBr3JYg4qcAj0AVeNDxY4zBQQntLZUI=;\n\tb=VorfImg57XoI1gdgCkCTI/9HIe5kUvVV2uyjoT2x1S9MQqNXHkMC16GcGgW9ViQz3f\n\tPs1RgF31r2/wWPWyym/3dV6CDnvBfMTPRVKed0+NAkLKYD9Y7gy5X9QA5eY2VpX9iOUX\n\tx19pg0y2NRCU5czBs/7rwGoBfZXClsDv/p81+ROSd80FPeJBIQXjvvXzIipXeABkrnSn\n\twy+ff2p03C83GjApjiE6FRbsM7TWzqb509sL00Fkau1No2wWa9UviLcew/ZhL+kpmE0z\n\t5fZ+Oy0Tu4X9eBiLhW2YzokvfTUkWlaxH/wMSV1vyTwl+5SsNiPJo+403CZ4r9svCPJa\n\t3plQ==", "X-Gm-Message-State": "APjAAAWsbEfz/TifEgzdpDllgzNCP5pT5NY1m33w5t49/kCPxsr/L8Lq\n\tZlt/KWr+oLUJwNJkPf6+ryTDWRHe2TXZ", "X-Google-Smtp-Source": "APXvYqwWMCexadyr4b7TeJ3cvDAF5cNjID5eFVjWCgAcaVn2lj640B39LuP4R3QryTiujFo5DB46CQ==", "X-Received": "by 2002:a1c:9ec9:: with SMTP id\n\th192mr4739937wme.105.1568217891392; \n\tWed, 11 Sep 2019 09:04:51 -0700 (PDT)", "From": "Thierry Herbelot <thierry.herbelot@6wind.com>", "To": "dev@dpdk.org", "Cc": "Thibaut Collet <thibaut.collet@6wind.com>,\n\tThomas Monjalon <thomas@monjalon.net>, stable@dpdk.org,\n\tmaxime.coquelin@redhat.com, tiwei.bie@intel.com, zhihong.wang@intel.com", "Date": "Wed, 11 Sep 2019 18:04:08 +0200", "Message-Id": "<cf2cbf6ab9f0f8d1a49960d78b246c01ec8b1375.1568216827.git.thierry.herbelot@6wind.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<cover.1568216827.git.thierry.herbelot@6wind.com>", "References": "<cover.1568216827.git.thierry.herbelot@6wind.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 1/2] virtio: fix rx stats with vectorized\n\tfunctions", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Thibaut Collet <thibaut.collet@6wind.com>\n\nWith vectorized functions, only the rx stats for number of packets is\nincremented.\nUpdate also the other statistics.\nPerformance impact is about 2%\n\nFixes: fc3d66212fed (\"virtio: add vector Rx\")\nCc: stable@dpdk.org\nCc: maxime.coquelin@redhat.com\nCc: tiwei.bie@intel.com\nCc: zhihong.wang@intel.com\n\nSigned-off-by: Thibaut Collet <thibaut.collet@6wind.com>\n---\n drivers/net/virtio/virtio_rxtx.c | 2 +-\n drivers/net/virtio/virtio_rxtx.h | 2 ++\n drivers/net/virtio/virtio_rxtx_simple_neon.c | 5 +++++\n drivers/net/virtio/virtio_rxtx_simple_sse.c | 5 +++++\n 4 files changed, 13 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c\nindex 27ead19fbe81..6dd62bf51863 100644\n--- a/drivers/net/virtio/virtio_rxtx.c\n+++ b/drivers/net/virtio/virtio_rxtx.c\n@@ -1083,7 +1083,7 @@ virtio_discard_rxbuf_inorder(struct virtqueue *vq, struct rte_mbuf *m)\n \t}\n }\n \n-static inline void\n+void\n virtio_update_packet_stats(struct virtnet_stats *stats, struct rte_mbuf *mbuf)\n {\n \tuint32_t s = mbuf->pkt_len;\ndiff --git a/drivers/net/virtio/virtio_rxtx.h b/drivers/net/virtio/virtio_rxtx.h\nindex 685cc4f8104c..1eb8dae227ee 100644\n--- a/drivers/net/virtio/virtio_rxtx.h\n+++ b/drivers/net/virtio/virtio_rxtx.h\n@@ -59,5 +59,7 @@ struct virtnet_ctl {\n };\n \n int virtio_rxq_vec_setup(struct virtnet_rx *rxvq);\n+void virtio_update_packet_stats(struct virtnet_stats *stats,\n+\t\t\t\tstruct rte_mbuf *mbuf);\n \n #endif /* _VIRTIO_RXTX_H_ */\ndiff --git a/drivers/net/virtio/virtio_rxtx_simple_neon.c b/drivers/net/virtio/virtio_rxtx_simple_neon.c\nindex cdc2a4d28ed5..70e89fc428e0 100644\n--- a/drivers/net/virtio/virtio_rxtx_simple_neon.c\n+++ b/drivers/net/virtio/virtio_rxtx_simple_neon.c\n@@ -47,6 +47,7 @@ virtio_recv_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts,\n \tstruct vring_used_elem *rused;\n \tstruct rte_mbuf **sw_ring;\n \tstruct rte_mbuf **sw_ring_end;\n+\tstruct rte_mbuf **ref_rx_pkts;\n \tuint16_t nb_pkts_received = 0;\n \n \tuint8x16_t shuf_msk1 = {\n@@ -105,6 +106,7 @@ virtio_recv_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts,\n \t\t\tvirtqueue_notify(vq);\n \t}\n \n+\tref_rx_pkts = rx_pkts;\n \tfor (nb_pkts_received = 0;\n \t\tnb_pkts_received < nb_used;) {\n \t\tuint64x2_t desc[RTE_VIRTIO_DESC_PER_LOOP / 2];\n@@ -204,5 +206,8 @@ virtio_recv_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts,\n \tvq->vq_used_cons_idx += nb_pkts_received;\n \tvq->vq_free_cnt += nb_pkts_received;\n \trxvq->stats.packets += nb_pkts_received;\n+\tfor (nb_used = 0; nb_used < nb_pkts_received; nb_used++)\n+\t\tvirtio_update_packet_stats(&rxvq->stats, ref_rx_pkts[nb_used]);\n+\n \treturn nb_pkts_received;\n }\ndiff --git a/drivers/net/virtio/virtio_rxtx_simple_sse.c b/drivers/net/virtio/virtio_rxtx_simple_sse.c\nindex af76708d66ae..cb1610e71563 100644\n--- a/drivers/net/virtio/virtio_rxtx_simple_sse.c\n+++ b/drivers/net/virtio/virtio_rxtx_simple_sse.c\n@@ -48,6 +48,7 @@ virtio_recv_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts,\n \tstruct vring_used_elem *rused;\n \tstruct rte_mbuf **sw_ring;\n \tstruct rte_mbuf **sw_ring_end;\n+\tstruct rte_mbuf **ref_rx_pkts;\n \tuint16_t nb_pkts_received = 0;\n \t__m128i shuf_msk1, shuf_msk2, len_adjust;\n \n@@ -107,6 +108,7 @@ virtio_recv_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts,\n \t\t\tvirtqueue_notify(vq);\n \t}\n \n+\tref_rx_pkts = rx_pkts;\n \tfor (nb_pkts_received = 0;\n \t\tnb_pkts_received < nb_used;) {\n \t\t__m128i desc[RTE_VIRTIO_DESC_PER_LOOP / 2];\n@@ -190,5 +192,8 @@ virtio_recv_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts,\n \tvq->vq_used_cons_idx += nb_pkts_received;\n \tvq->vq_free_cnt += nb_pkts_received;\n \trxvq->stats.packets += nb_pkts_received;\n+\tfor (nb_used = 0; nb_used < nb_pkts_received; nb_used++)\n+\t\tvirtio_update_packet_stats(&rxvq->stats, ref_rx_pkts[nb_used]);\n+\n \treturn nb_pkts_received;\n }\n", "prefixes": [ "1/2" ] }