Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/59069/?format=api
{ "id": 59069, "url": "https://patches.dpdk.org/api/patches/59069/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1568103959-25572-13-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1568103959-25572-13-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1568103959-25572-13-git-send-email-arybchenko@solarflare.com", "date": "2019-09-10T08:25:52", "name": "[12/18] examples/ip_pipeline: check status of getting link info", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "6267c93519baf0da082f57eb850bc61bd876ea74", "submitter": { "id": 607, "url": "https://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1568103959-25572-13-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 6350, "url": "https://patches.dpdk.org/api/series/6350/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=6350", "date": "2019-09-10T08:25:41", "name": "ethdev: change link status get functions return value to int", "version": 1, "mbox": "https://patches.dpdk.org/series/6350/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/59069/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/59069/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 713211EDF2;\n\tTue, 10 Sep 2019 10:26:46 +0200 (CEST)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n\t[148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 90E2D1ECC1\n\tfor <dev@dpdk.org>; Tue, 10 Sep 2019 10:26:22 +0200 (CEST)", "from webmail.solarflare.com (webmail.solarflare.com\n\t[12.187.104.26])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby mx1-us2.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id\n\t5196C1C005F; Tue, 10 Sep 2019 08:26:21 +0000 (UTC)", "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1395.4; Tue, 10 Sep 2019 01:26:18 -0700", "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1395.4 via Frontend Transport; Tue, 10 Sep 2019 01:26:18 -0700", "from ukv-loginhost.uk.solarflarecom.com\n\t(ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tx8A8QHie002295; Tue, 10 Sep 2019 09:26:17 +0100", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n\tby ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id\n\t134E81613D1; Tue, 10 Sep 2019 09:26:17 +0100 (BST)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "Cristian Dumitrescu <cristian.dumitrescu@intel.com>", "CC": "<dev@dpdk.org>, Igor Romanov <igor.romanov@oktetlabs.ru>", "Date": "Tue, 10 Sep 2019 09:25:52 +0100", "Message-ID": "<1568103959-25572-13-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1568103959-25572-1-git-send-email-arybchenko@solarflare.com>", "References": "<1568103959-25572-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.5.1010-24898.005", "X-TM-AS-Result": "No-2.951000-4.000000-10", "X-TMASE-MatchedRID": "b9G8HiAV2WLDOgXZFRFV83CO70QAsBdCWw/S0HB7eoMGmHr1eMxt2UAc\n\t6DyoS2rI2lO9wdJIjwWKGUoOUuWu8kgMxOkBoMP0U9ht8cPjV459LQinZ4QefPcjNeVeWlqY+gt\n\tHj7OwNO2W79Uq8KMo9bcuXXkiU33CCu7i//gJOIHH+0bHvNGr2vsNTmPX05uVNH9TJ0G6KVH4sx\n\thA236J5hnQEgrb3gkrFsMCCABgmQbMQrcaswZ6hNpAu0sLxpSoQ8G+yYJYYdZRZDsGiXQioBjm2\n\t8f1HLY3", "X-TM-AS-User-Approved-Sender": "No", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10--2.951000-4.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.5.1010-24898.005", "X-MDID": "1568103981-LXPHS3eH_v7I", "Subject": "[dpdk-dev] [PATCH 12/18] examples/ip_pipeline: check status of\n\tgetting link info", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Igor Romanov <igor.romanov@oktetlabs.ru>\n\nThe return value of rte_eth_link_get() and rte_eth_link_get_nowait()\nwas changed from void to int. Update the usage of the functions\naccording to the new return type.\n\nSigned-off-by: Igor Romanov <igor.romanov@oktetlabs.ru>\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n examples/ip_pipeline/cli.c | 9 ++++++++-\n examples/ip_pipeline/link.c | 3 ++-\n 2 files changed, 10 insertions(+), 2 deletions(-)", "diff": "diff --git a/examples/ip_pipeline/cli.c b/examples/ip_pipeline/cli.c\nindex c6cf4204e..4930310cc 100644\n--- a/examples/ip_pipeline/cli.c\n+++ b/examples/ip_pipeline/cli.c\n@@ -248,12 +248,19 @@ print_link_info(struct link *link, char *out, size_t out_size)\n \tstruct rte_ether_addr mac_addr;\n \tstruct rte_eth_link eth_link;\n \tuint16_t mtu;\n+\tint ret;\n \n \tmemset(&stats, 0, sizeof(stats));\n \trte_eth_stats_get(link->port_id, &stats);\n \n \trte_eth_macaddr_get(link->port_id, &mac_addr);\n-\trte_eth_link_get(link->port_id, ð_link);\n+\tret = rte_eth_link_get(link->port_id, ð_link);\n+\tif (ret < 0) {\n+\t\tsnprintf(out, out_size, \"\\n%s: link get failed: %s\",\n+\t\t\t link->name, rte_strerror(-ret));\n+\t\treturn;\n+\t}\n+\n \trte_eth_dev_get_mtu(link->port_id, &mtu);\n \n \tsnprintf(out, out_size,\ndiff --git a/examples/ip_pipeline/link.c b/examples/ip_pipeline/link.c\nindex 744abf394..16bcffe35 100644\n--- a/examples/ip_pipeline/link.c\n+++ b/examples/ip_pipeline/link.c\n@@ -264,7 +264,8 @@ link_is_up(const char *name)\n \t\treturn 0;\n \n \t/* Resource */\n-\trte_eth_link_get(link->port_id, &link_params);\n+\tif (rte_eth_link_get(link->port_id, &link_params) < 0)\n+\t\treturn 0;\n \n \treturn (link_params.link_status == ETH_LINK_DOWN) ? 0 : 1;\n }\n", "prefixes": [ "12/18" ] }