Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/59067/?format=api
{ "id": 59067, "url": "https://patches.dpdk.org/api/patches/59067/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1568103959-25572-12-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1568103959-25572-12-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1568103959-25572-12-git-send-email-arybchenko@solarflare.com", "date": "2019-09-10T08:25:51", "name": "[11/18] examples/bbdev_app: check status of getting link info", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "a7cca83a8e0d1fb4be69c03c2bec66c1f2484eb4", "submitter": { "id": 607, "url": "https://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1568103959-25572-12-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 6350, "url": "https://patches.dpdk.org/api/series/6350/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=6350", "date": "2019-09-10T08:25:41", "name": "ethdev: change link status get functions return value to int", "version": 1, "mbox": "https://patches.dpdk.org/series/6350/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/59067/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/59067/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 420981EDE1;\n\tTue, 10 Sep 2019 10:26:43 +0200 (CEST)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n\t[148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 189F51ECFA\n\tfor <dev@dpdk.org>; Tue, 10 Sep 2019 10:26:22 +0200 (CEST)", "from webmail.solarflare.com (webmail.solarflare.com\n\t[12.187.104.26])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby mx1-us2.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id\n\t27DDD1C005F; Tue, 10 Sep 2019 08:26:21 +0000 (UTC)", "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1395.4; Tue, 10 Sep 2019 01:26:18 -0700", "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1395.4 via Frontend Transport; Tue, 10 Sep 2019 01:26:18 -0700", "from ukv-loginhost.uk.solarflarecom.com\n\t(ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tx8A8QGHH002285; Tue, 10 Sep 2019 09:26:16 +0100", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n\tby ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id\n\tD96C11613D1; Tue, 10 Sep 2019 09:26:16 +0100 (BST)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "Nicolas Chautru <nicolas.chautru@intel.com>", "CC": "<dev@dpdk.org>, Igor Romanov <igor.romanov@oktetlabs.ru>", "Date": "Tue, 10 Sep 2019 09:25:51 +0100", "Message-ID": "<1568103959-25572-12-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1568103959-25572-1-git-send-email-arybchenko@solarflare.com>", "References": "<1568103959-25572-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.5.1010-24898.005", "X-TM-AS-Result": "No-2.648700-4.000000-10", "X-TMASE-MatchedRID": "vdeff2Q33gXDOgXZFRFV83CO70QAsBdCWw/S0HB7eoM7FE26mju9O7ny\n\tO1e9qRizrdoLblq9S5rMJYD0aRF0RV/b0/1cTOafFyv3UWjlpb0txMagbN9/PIpLyz8UyqY4Pl0\n\t9xg2LPPP2Y7i50sDX+EVXxsfqi11sNyl1nd9CIt0URSScn+QSXt0H8LFZNFG76sBnwpOylLPT7v\n\tw5HIV9LlGeyDURAZSSJThO9rNWyQIwsLyiDqALuPc75DZHoUtBrRopBnHRVSNR19YoLS1LYgAfj\n\tIYhKfaMLIuhItrFRYEPXLxHfxLeXVRHOSKs7RDUXmH0pBaurgG+4xOvsJAknn7cGd19dSFd", "X-TM-AS-User-Approved-Sender": "No", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10--2.648700-4.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.5.1010-24898.005", "X-MDID": "1568103981-NqfJCcaVVcBR", "Subject": "[dpdk-dev] [PATCH 11/18] examples/bbdev_app: check status of\n\tgetting link info", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Igor Romanov <igor.romanov@oktetlabs.ru>\n\nThe return value of rte_eth_link_get() and rte_eth_link_get_nowait()\nwas changed from void to int. Update the usage of the functions\naccording to the new return type.\n\nSigned-off-by: Igor Romanov <igor.romanov@oktetlabs.ru>\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n examples/bbdev_app/main.c | 12 +++++++++---\n 1 file changed, 9 insertions(+), 3 deletions(-)", "diff": "diff --git a/examples/bbdev_app/main.c b/examples/bbdev_app/main.c\nindex 3d36629a1..349876589 100644\n--- a/examples/bbdev_app/main.c\n+++ b/examples/bbdev_app/main.c\n@@ -312,6 +312,7 @@ check_port_link_status(uint16_t port_id)\n #define MAX_CHECK_TIME 90 /* 9s (90 * 100ms) in total */\n \tuint8_t count;\n \tstruct rte_eth_link link;\n+\tint link_get_err = -EINVAL;\n \n \tprintf(\"\\nChecking link status.\");\n \tfflush(stdout);\n@@ -319,9 +320,9 @@ check_port_link_status(uint16_t port_id)\n \tfor (count = 0; count <= MAX_CHECK_TIME &&\n \t\t\t!rte_atomic16_read(&global_exit_flag); count++) {\n \t\tmemset(&link, 0, sizeof(link));\n-\t\trte_eth_link_get_nowait(port_id, &link);\n+\t\tlink_get_err = rte_eth_link_get_nowait(port_id, &link);\n \n-\t\tif (link.link_status) {\n+\t\tif (link_get_err >= 0 && link.link_status) {\n \t\t\tconst char *dp = (link.link_duplex ==\n \t\t\t\tETH_LINK_FULL_DUPLEX) ?\n \t\t\t\t\"full-duplex\" : \"half-duplex\";\n@@ -334,7 +335,12 @@ check_port_link_status(uint16_t port_id)\n \t\trte_delay_ms(CHECK_INTERVAL);\n \t}\n \n-\tprintf(\"\\nPort %d Link Down\\n\", port_id);\n+\tif (link_get_err >= 0)\n+\t\tprintf(\"\\nPort %d Link Down\\n\", port_id);\n+\telse\n+\t\tprintf(\"\\nGet link failed (port %d): %s\\n\", port_id,\n+\t\t rte_strerror(-link_get_err));\n+\n \treturn 0;\n }\n \n", "prefixes": [ "11/18" ] }