Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/59063/?format=api
{ "id": 59063, "url": "https://patches.dpdk.org/api/patches/59063/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1568103959-25572-7-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1568103959-25572-7-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1568103959-25572-7-git-send-email-arybchenko@solarflare.com", "date": "2019-09-10T08:25:46", "name": "[06/18] net/memif: check status of getting link info", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "b8e5295956747d6561052defd40caf6ab513ecd5", "submitter": { "id": 607, "url": "https://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1568103959-25572-7-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 6350, "url": "https://patches.dpdk.org/api/series/6350/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=6350", "date": "2019-09-10T08:25:41", "name": "ethdev: change link status get functions return value to int", "version": 1, "mbox": "https://patches.dpdk.org/series/6350/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/59063/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/59063/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id DB1B11EDB4;\n\tTue, 10 Sep 2019 10:26:35 +0200 (CEST)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n\t[148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 489031EB02\n\tfor <dev@dpdk.org>; Tue, 10 Sep 2019 10:26:21 +0200 (CEST)", "from webmail.solarflare.com (webmail.solarflare.com\n\t[12.187.104.26])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby mx1-us2.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id\n\t25D4A1C0068; Tue, 10 Sep 2019 08:26:20 +0000 (UTC)", "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1395.4; Tue, 10 Sep 2019 01:26:17 -0700", "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1395.4 via Frontend Transport; Tue, 10 Sep 2019 01:26:16 -0700", "from ukv-loginhost.uk.solarflarecom.com\n\t(ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tx8A8QFUA002226; Tue, 10 Sep 2019 09:26:15 +0100", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n\tby ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id\n\tA224F1613D2; Tue, 10 Sep 2019 09:26:15 +0100 (BST)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "Jakub Grajciar <jgrajcia@cisco.com>", "CC": "<dev@dpdk.org>", "Date": "Tue, 10 Sep 2019 09:25:46 +0100", "Message-ID": "<1568103959-25572-7-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1568103959-25572-1-git-send-email-arybchenko@solarflare.com>", "References": "<1568103959-25572-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.5.1010-24898.005", "X-TM-AS-Result": "No-2.614500-4.000000-10", "X-TMASE-MatchedRID": "m3UrM73BECPDOgXZFRFV83CO70QAsBdC3V4UShoTXad+SLLtNOiBhhnq\n\tZOIRSjISfMtvnnFP0XhTvVffeIwvQyHhSBQfglfsA9lly13c/gFKgIbix5+XxEFungmhsSsCEG3\n\tUzQEO6wqPBX+OQ5pJCm7LD6wi4cwC1aorlXfSzHmeAiCmPx4NwBnUJ0Ek6yhjxEHRux+uk8hxKp\n\tvEGAbTDkcJbjdBythVYAL6X/NdAGqyJvpQRd8E0JCRa/husYgGGLQYciovTMRTo0JZGTZDx4bWF\n\twnRX1x9GFPRNHvUQnd3jtuaHNW7a5N1JFeUKeMEiOOUXfTkScBZSbxIRLLN380Goa3UM++8", "X-TM-AS-User-Approved-Sender": "No", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10--2.614500-4.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.5.1010-24898.005", "X-MDID": "1568103980-eXsLqIrloTSQ", "Subject": "[dpdk-dev] [PATCH 06/18] net/memif: check status of getting link\n\tinfo", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The return value of rte_eth_link_get() was changed from void to int.\nUpdate the usage of the function according to the new return type.\n\nJust log error if something goes wrong.\n\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n drivers/net/memif/rte_eth_memif.c | 12 ++++++++++--\n 1 file changed, 10 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/memif/rte_eth_memif.c b/drivers/net/memif/rte_eth_memif.c\nindex af260f7a8..a347e27bd 100644\n--- a/drivers/net/memif/rte_eth_memif.c\n+++ b/drivers/net/memif/rte_eth_memif.c\n@@ -266,7 +266,10 @@ eth_memif_rx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)\n \t\treturn 0;\n \tif (unlikely(ring == NULL)) {\n \t\t/* Secondary process will attempt to request regions. */\n-\t\trte_eth_link_get(mq->in_port, &link);\n+\t\tret = rte_eth_link_get(mq->in_port, &link);\n+\t\tif (ret < 0)\n+\t\t\tMIF_LOG(ERR, \"Failed to get port %u link info: %s\",\n+\t\t\t\tmq->in_port, rte_strerror(-ret));\n \t\treturn 0;\n \t}\n \n@@ -392,8 +395,13 @@ eth_memif_tx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)\n \tif (unlikely((pmd->flags & ETH_MEMIF_FLAG_CONNECTED) == 0))\n \t\treturn 0;\n \tif (unlikely(ring == NULL)) {\n+\t\tint ret;\n+\n \t\t/* Secondary process will attempt to request regions. */\n-\t\trte_eth_link_get(mq->in_port, &link);\n+\t\tret = rte_eth_link_get(mq->in_port, &link);\n+\t\tif (ret < 0)\n+\t\t\tMIF_LOG(ERR, \"Failed to get port %u link info: %s\",\n+\t\t\t\tmq->in_port, rte_strerror(-ret));\n \t\treturn 0;\n \t}\n \n", "prefixes": [ "06/18" ] }