Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/59003/?format=api
{ "id": 59003, "url": "https://patches.dpdk.org/api/patches/59003/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1568030331-16526-12-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1568030331-16526-12-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1568030331-16526-12-git-send-email-arybchenko@solarflare.com", "date": "2019-09-09T11:58:48", "name": "[v2,11/13] kni: check code of promiscuous mode switch", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "1b3995ad1479000f16526ec1dcfc2ef0e64d39e3", "submitter": { "id": 607, "url": "https://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1568030331-16526-12-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 6334, "url": "https://patches.dpdk.org/api/series/6334/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=6334", "date": "2019-09-09T11:58:37", "name": "ethdev: change promiscuous mode functions to return status", "version": 2, "mbox": "https://patches.dpdk.org/series/6334/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/59003/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/59003/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 17E2B1ED3A;\n\tMon, 9 Sep 2019 13:59:34 +0200 (CEST)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n\t[148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 256F61EC8A\n\tfor <dev@dpdk.org>; Mon, 9 Sep 2019 13:59:11 +0200 (CEST)", "from webmail.solarflare.com (webmail.solarflare.com\n\t[12.187.104.26])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby mx1-us3.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id\n\tDD770B40069; Mon, 9 Sep 2019 11:59:09 +0000 (UTC)", "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1395.4; Mon, 9 Sep 2019 04:59:04 -0700", "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1395.4 via Frontend Transport; Mon, 9 Sep 2019 04:59:04 -0700", "from ukv-loginhost.uk.solarflarecom.com\n\t(ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tx89Bx39o027773; Mon, 9 Sep 2019 12:59:03 +0100", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n\tby ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id\n\t60C681613D1; Mon, 9 Sep 2019 12:59:03 +0100 (BST)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "Ferruh Yigit <ferruh.yigit@intel.com>", "CC": "<dev@dpdk.org>, Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.ru>", "Date": "Mon, 9 Sep 2019 12:58:48 +0100", "Message-ID": "<1568030331-16526-12-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1568030331-16526-1-git-send-email-arybchenko@solarflare.com>", "References": "<1567699852-31693-1-git-send-email-arybchenko@solarflare.com>\n\t<1568030331-16526-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.5.1010-24898.005", "X-TM-AS-Result": "No-2.102900-4.000000-10", "X-TMASE-MatchedRID": "m3UrM73BECPbS0m47m6fSn84FZpy/6JVWw/S0HB7eoOBzO52zKOpBbSz\n\tHnxqKzJVyOrHSvvEufhw5T4Iaj538mJZXQNDzktSutvHF25zoU/Lvfc3C6SWwlzv/y1NmdYq4tJ\n\t1U/a1mfn5pK34ToPSRVbUzEb3S0GPa/3oK40sUSqeAiCmPx4NwBnUJ0Ek6yhjxEHRux+uk8hxKp\n\tvEGAbTDonB/qrt45nI6+OLvwvWuW6RD9R8sqUh1bZXDE4WrQIfSIobZ1A4i4EhNY5B3kiTi0RlL\n\tMXmEBrY1YBvRWmgSjMtziGBPos3YZN1JFeUKeMEiOOUXfTkScBZSbxIRLLN380Goa3UM++8", "X-TM-AS-User-Approved-Sender": "No", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10--2.102900-4.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.5.1010-24898.005", "X-MDID": "1568030350-dwfqvWaWwjjz", "Subject": "[dpdk-dev] [PATCH v2 11/13] kni: check code of promiscuous mode\n\tswitch", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.ru>\n\nrte_eth_promiscuous_enable()/rte_eth_promiscuous_disable() return\nvalue was changed from void to int, so modify usage of these\nfunctions across lib/librte_kni according to new return type.\n\nSigned-off-by: Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.ru>\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n app/test/test_kni.c | 7 ++++++-\n examples/kni/main.c | 9 +++++++--\n lib/librte_kni/rte_kni.c | 14 +++++++++++---\n 3 files changed, 24 insertions(+), 6 deletions(-)", "diff": "diff --git a/app/test/test_kni.c b/app/test/test_kni.c\nindex 2c333748db..e47ab36e02 100644\n--- a/app/test/test_kni.c\n+++ b/app/test/test_kni.c\n@@ -601,7 +601,12 @@ test_kni(void)\n \t\tprintf(\"fail to start port %d\\n\", port_id);\n \t\treturn -1;\n \t}\n-\trte_eth_promiscuous_enable(port_id);\n+\tret = rte_eth_promiscuous_enable(port_id);\n+\tif (ret != 0) {\n+\t\tprintf(\"fail to enable promiscuous mode for port %d: %s\\n\",\n+\t\t\tport_id, rte_strerror(-ret));\n+\t\treturn -1;\n+\t}\n \n \t/* basic test of kni processing */\n \tfd = fopen(KNI_MODULE_PARAM_LO, \"r\");\ndiff --git a/examples/kni/main.c b/examples/kni/main.c\nindex e43f174479..1069fd08bb 100644\n--- a/examples/kni/main.c\n+++ b/examples/kni/main.c\n@@ -636,8 +636,13 @@ init_port(uint16_t port)\n \t\trte_exit(EXIT_FAILURE, \"Could not start port%u (%d)\\n\",\n \t\t\t\t\t\t(unsigned)port, ret);\n \n-\tif (promiscuous_on)\n-\t\trte_eth_promiscuous_enable(port);\n+\tif (promiscuous_on) {\n+\t\tret = rte_eth_promiscuous_enable(port);\n+\t\tif (ret != 0)\n+\t\t\trte_exit(EXIT_FAILURE,\n+\t\t\t\t\"Could not enable promiscuous mode for port%u: %s\\n\",\n+\t\t\t\tport, rte_strerror(-ret));\n+\t}\n }\n \n /* Check the link status of all ports in up to 9s, and print them finally */\ndiff --git a/lib/librte_kni/rte_kni.c b/lib/librte_kni/rte_kni.c\nindex 4b51fb4fed..04806ebb40 100644\n--- a/lib/librte_kni/rte_kni.c\n+++ b/lib/librte_kni/rte_kni.c\n@@ -472,6 +472,8 @@ kni_config_mac_address(uint16_t port_id, uint8_t mac_addr[])\n static int\n kni_config_promiscusity(uint16_t port_id, uint8_t to_on)\n {\n+\tint ret;\n+\n \tif (!rte_eth_dev_is_valid_port(port_id)) {\n \t\tRTE_LOG(ERR, KNI, \"Invalid port id %d\\n\", port_id);\n \t\treturn -EINVAL;\n@@ -481,11 +483,17 @@ kni_config_promiscusity(uint16_t port_id, uint8_t to_on)\n \t\tport_id, to_on);\n \n \tif (to_on)\n-\t\trte_eth_promiscuous_enable(port_id);\n+\t\tret = rte_eth_promiscuous_enable(port_id);\n \telse\n-\t\trte_eth_promiscuous_disable(port_id);\n+\t\tret = rte_eth_promiscuous_disable(port_id);\n \n-\treturn 0;\n+\tif (ret != 0)\n+\t\tRTE_LOG(ERR, KNI,\n+\t\t\t\"Failed to %s promiscuous mode for port %u: %s\\n\",\n+\t\t\tto_on ? \"enable\" : \"disable\", port_id,\n+\t\t\trte_strerror(-ret));\n+\n+\treturn ret;\n }\n \n int\n", "prefixes": [ "v2", "11/13" ] }