Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/58691/?format=api
{ "id": 58691, "url": "https://patches.dpdk.org/api/patches/58691/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1567699852-31693-14-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1567699852-31693-14-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1567699852-31693-14-git-send-email-arybchenko@solarflare.com", "date": "2019-09-05T16:10:51", "name": "[13/13] examples: take promiscuous mode switch result into account", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "23a18307686694843444ad30627986e83693c182", "submitter": { "id": 607, "url": "https://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1567699852-31693-14-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 6264, "url": "https://patches.dpdk.org/api/series/6264/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=6264", "date": "2019-09-05T16:10:38", "name": "ethdev: change promiscuous mode functions to return status", "version": 1, "mbox": "https://patches.dpdk.org/series/6264/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/58691/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/58691/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 9BE881F083;\n\tThu, 5 Sep 2019 18:11:37 +0200 (CEST)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n\t[67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 174B41BFEF\n\tfor <dev@dpdk.org>; Thu, 5 Sep 2019 18:11:13 +0200 (CEST)", "from webmail.solarflare.com (webmail.solarflare.com\n\t[12.187.104.26])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby mx1-us4.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id\n\t739AE28007C; Thu, 5 Sep 2019 16:11:11 +0000 (UTC)", "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1395.4; Thu, 5 Sep 2019 09:11:08 -0700", "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1395.4 via Frontend Transport; Thu, 5 Sep 2019 09:11:07 -0700", "from ukv-loginhost.uk.solarflarecom.com\n\t(ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tx85GB63A016284; Thu, 5 Sep 2019 17:11:06 +0100", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n\tby ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id\n\t47ADF1613D1; Thu, 5 Sep 2019 17:11:06 +0100 (BST)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "Nicolas Chautru <nicolas.chautru@intel.com>, Chas Williams\n\t<chas3@att.com>, David Hunt <david.hunt@intel.com>, Harry van Haaren\n\t<harry.van.haaren@intel.com>,\n\tMarko Kovacevic <marko.kovacevic@intel.com>, \n\tOri Kam <orika@mellanox.com>,\n\tBruce Richardson <bruce.richardson@intel.com>, \n\tPablo de Lara <pablo.de.lara.guarch@intel.com>, Radu Nicolau\n\t<radu.nicolau@intel.com>, Akhil Goyal <akhil.goyal@nxp.com>,\n\tTomasz Kantecki <tomasz.kantecki@intel.com>,\n\tBernard Iremonger <bernard.iremonger@intel.com>, \n\tKonstantin Ananyev <konstantin.ananyev@intel.com>, Cristian Dumitrescu\n\t<cristian.dumitrescu@intel.com>,\n\tDeclan Doherty <declan.doherty@intel.com>, \n\tAnatoly Burakov <anatoly.burakov@intel.com>, Reshma Pattan\n\t<reshma.pattan@intel.com>, John McNamara <john.mcnamara@intel.com>,\n\t\"Xiaoyun Li\" <xiaoyun.li@intel.com>,\n\tJasvinder Singh <jasvinder.singh@intel.com>, \n\t\"Byron Marohn\" <byron.marohn@intel.com>, Maxime Coquelin\n\t<maxime.coquelin@redhat.com>, Tiwei Bie <tiwei.bie@intel.com>,\n\tZhihong Wang <zhihong.wang@intel.com>", "CC": "<dev@dpdk.org>, Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.ru>", "Date": "Thu, 5 Sep 2019 17:10:51 +0100", "Message-ID": "<1567699852-31693-14-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1567699852-31693-1-git-send-email-arybchenko@solarflare.com>", "References": "<1567699852-31693-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.5.1010-24890.005", "X-TM-AS-Result": "No-3.927300-4.000000-10", "X-TMASE-MatchedRID": "v6t7Wybkjo3bS0m47m6fSn84FZpy/6JVAPiR4btCEeZ+SLLtNOiBhvFo\n\tO2munXhOaagifOf0sgWUyUJfx1AjkCZShfo024fxA9lly13c/gFOyHF6Q7mfS7krYtQaB6j2SAl\n\tT3z7ftsfcAroy7dOlEXDlPghqPnfyT3nCKCHJ3mlPs79gcmEg0I7u1T4G/rnN0SxMhOhuA0Rcpk\n\tb9zUI7BH3JM7viRV/Qi/28hsPyzHtH6+lhuE4fWm6HurDH4PpPovA/6ONsv0rkVOku4OQngGtgc\n\tkGXH2knbxEDJAhdvmSQ5vUIflqHwJhLYh8i4UZXPja3w1ExF8TgXnxE81iysUoPLn6eZ90+S717\n\thL/58vaws27Aq0JsBUoaCLCy5dSUoXYTq/8UnCHobINHZkH5xn4kYxhimH/bV7MQTbTl029xQtH\n\tzHkAOcG6eu7TebRfM8JLFXexmHOv2O6qBs+mx8cebIMlISwjbxO20cNGQz3WbKItl61J/yZ+inT\n\tK0bC9eKrauXd3MZDVPFzjCkfkYUmgHEo0OkvTQ+ioBF7fcO3ARFF0gLdQJ4lOxMI21S5YRq32ri\n\t9Osi+6N0LuanEknoVh+O+/0PE239mbY9dbXqzBGkBjbMbD9rzigZBQJvBjlD6DuZ3COjrnoW0Nk\n\tKZgEncpMvD+U2DDy", "X-TM-AS-User-Approved-Sender": "No", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10--3.927300-4.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.5.1010-24890.005", "X-MDID": "1567699872-JfkbwxpV3on0", "Subject": "[dpdk-dev] [PATCH 13/13] examples: take promiscuous mode switch\n\tresult into account", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.ru>\n\nrte_eth_promiscuous_enable()/rte_eth_promiscuous_disable() return\nvalue was changed from void to int, so this patch modify usage\nof these functions across examples according to new return type.\n\nSigned-off-by: Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.ru>\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n examples/bbdev_app/main.c | 7 ++++++-\n examples/bond/main.c | 8 +++++++-\n examples/distributor/main.c | 4 +++-\n examples/eventdev_pipeline/main.c | 4 +++-\n examples/exception_path/main.c | 5 ++++-\n examples/flow_classify/flow_classify.c | 4 +++-\n examples/flow_filtering/main.c | 7 ++++++-\n examples/ip_fragmentation/main.c | 6 +++++-\n examples/ip_pipeline/link.c | 7 +++++--\n examples/ip_reassembly/main.c | 6 +++++-\n examples/ipsec-secgw/ipsec-secgw.c | 9 +++++++--\n examples/l2fwd-cat/l2fwd-cat.c | 4 +++-\n examples/l2fwd-crypto/main.c | 7 ++++++-\n examples/l2fwd-jobstats/main.c | 9 ++++++++-\n examples/l2fwd-keepalive/main.c | 6 +++++-\n examples/l2fwd/main.c | 6 +++++-\n examples/l3fwd-acl/main.c | 9 +++++++--\n examples/l3fwd-power/main.c | 9 +++++++--\n examples/l3fwd/main.c | 9 +++++++--\n examples/link_status_interrupt/main.c | 6 +++++-\n examples/load_balancer/init.c | 6 +++++-\n .../multi_process/client_server_mp/mp_server/init.c | 4 +++-\n examples/multi_process/symmetric_mp/main.c | 4 +++-\n examples/netmap_compat/bridge/bridge.c | 6 +++++-\n examples/packet_ordering/main.c | 4 +++-\n examples/performance-thread/l3fwd-thread/main.c | 9 +++++++--\n examples/ptpclient/ptpclient.c | 7 ++++++-\n examples/qos_meter/main.c | 12 ++++++++++--\n examples/qos_sched/init.c | 6 +++++-\n examples/quota_watermark/qw/init.c | 6 +++++-\n examples/rxtx_callbacks/main.c | 5 ++++-\n examples/server_node_efd/server/init.c | 4 +++-\n examples/skeleton/basicfwd.c | 4 +++-\n examples/vhost/main.c | 11 +++++++++--\n examples/vm_power_manager/main.c | 4 +++-\n 35 files changed, 181 insertions(+), 43 deletions(-)", "diff": "diff --git a/examples/bbdev_app/main.c b/examples/bbdev_app/main.c\nindex 9acf666dc9..3d36629a1b 100644\n--- a/examples/bbdev_app/main.c\n+++ b/examples/bbdev_app/main.c\n@@ -477,7 +477,12 @@ initialize_ports(struct app_config_params *app_params,\n \t\t}\n \t}\n \n-\trte_eth_promiscuous_enable(port_id);\n+\tret = rte_eth_promiscuous_enable(port_id);\n+\tif (ret != 0) {\n+\t\tprintf(\"Cannot enable promiscuous mode: err=%s, port=%u\\n\",\n+\t\t\trte_strerror(-ret), port_id);\n+\t\treturn ret;\n+\t}\n \n \trte_eth_macaddr_get(port_id, &bbdev_port_eth_addr);\n \tprint_mac(port_id, &bbdev_port_eth_addr);\ndiff --git a/examples/bond/main.c b/examples/bond/main.c\nindex be62c1713a..39214cfeeb 100644\n--- a/examples/bond/main.c\n+++ b/examples/bond/main.c\n@@ -299,7 +299,13 @@ bond_port_init(struct rte_mempool *mbuf_pool)\n \t\t\trte_exit(-1, \"\\nFailed to activate slaves\\n\");\n \t}\n \n-\trte_eth_promiscuous_enable(BOND_PORT);\n+\tretval = rte_eth_promiscuous_enable(BOND_PORT);\n+\tif (retval != 0) {\n+\t\trte_exit(EXIT_FAILURE,\n+\t\t\t\t\"port %u: promiscuous mode enable failed: %s\\n\",\n+\t\t\t\tBOND_PORT, rte_strerror(-retval));\n+\t\treturn;\n+\t}\n \n \tstruct rte_ether_addr addr;\n \ndiff --git a/examples/distributor/main.c b/examples/distributor/main.c\nindex 8942f3607c..125ee877f3 100644\n--- a/examples/distributor/main.c\n+++ b/examples/distributor/main.c\n@@ -194,7 +194,9 @@ port_init(uint16_t port, struct rte_mempool *mbuf_pool)\n \t\t\taddr.addr_bytes[2], addr.addr_bytes[3],\n \t\t\taddr.addr_bytes[4], addr.addr_bytes[5]);\n \n-\trte_eth_promiscuous_enable(port);\n+\tretval = rte_eth_promiscuous_enable(port);\n+\tif (retval != 0)\n+\t\treturn retval;\n \n \treturn 0;\n }\ndiff --git a/examples/eventdev_pipeline/main.c b/examples/eventdev_pipeline/main.c\nindex 3789fbfd7b..c734c7750c 100644\n--- a/examples/eventdev_pipeline/main.c\n+++ b/examples/eventdev_pipeline/main.c\n@@ -333,7 +333,9 @@ port_init(uint8_t port, struct rte_mempool *mbuf_pool)\n \t\t\taddr.addr_bytes[4], addr.addr_bytes[5]);\n \n \t/* Enable RX in promiscuous mode for the Ethernet device. */\n-\trte_eth_promiscuous_enable(port);\n+\tretval = rte_eth_promiscuous_enable(port);\n+\tif (retval != 0)\n+\t\treturn retval;\n \n \treturn 0;\n }\ndiff --git a/examples/exception_path/main.c b/examples/exception_path/main.c\nindex d7f3598afb..f3c0206b53 100644\n--- a/examples/exception_path/main.c\n+++ b/examples/exception_path/main.c\n@@ -473,7 +473,10 @@ init_port(uint16_t port)\n \tif (ret < 0)\n \t\tFATAL_ERROR(\"Could not start port%u (%d)\", port, ret);\n \n-\trte_eth_promiscuous_enable(port);\n+\tret = rte_eth_promiscuous_enable(port);\n+\tif (ret != 0)\n+\t\tFATAL_ERROR(\"Could not enable promiscuous mode for port%u (%s)\",\n+\t\t\t port, rte_strerror(-ret));\n }\n \n /* Check the link status of all ports in up to 9s, and print them finally */\ndiff --git a/examples/flow_classify/flow_classify.c b/examples/flow_classify/flow_classify.c\nindex 2130c13d85..ae0faf621c 100644\n--- a/examples/flow_classify/flow_classify.c\n+++ b/examples/flow_classify/flow_classify.c\n@@ -251,7 +251,9 @@ port_init(uint8_t port, struct rte_mempool *mbuf_pool)\n \t\t\taddr.addr_bytes[4], addr.addr_bytes[5]);\n \n \t/* Enable RX in promiscuous mode for the Ethernet device. */\n-\trte_eth_promiscuous_enable(port);\n+\tretval = rte_eth_promiscuous_enable(port);\n+\tif (retval != 0)\n+\t\treturn retval;\n \n \treturn 0;\n }\ndiff --git a/examples/flow_filtering/main.c b/examples/flow_filtering/main.c\nindex fe064fa022..c40cfd098b 100644\n--- a/examples/flow_filtering/main.c\n+++ b/examples/flow_filtering/main.c\n@@ -180,7 +180,12 @@ init_port(void)\n \t\t}\n \t}\n \n-\trte_eth_promiscuous_enable(port_id);\n+\tret = rte_eth_promiscuous_enable(port_id);\n+\tif (ret != 0)\n+\t\trte_exit(EXIT_FAILURE,\n+\t\t\t\":: promiscuous mode enable failed: err=%s, port=%u\\n\",\n+\t\t\trte_strerror(-ret), port_id);\n+\n \tret = rte_eth_dev_start(port_id);\n \tif (ret < 0) {\n \t\trte_exit(EXIT_FAILURE,\ndiff --git a/examples/ip_fragmentation/main.c b/examples/ip_fragmentation/main.c\nindex 6b832445aa..70139ee4d2 100644\n--- a/examples/ip_fragmentation/main.c\n+++ b/examples/ip_fragmentation/main.c\n@@ -1038,7 +1038,11 @@ main(int argc, char **argv)\n \t\t\trte_exit(EXIT_FAILURE, \"rte_eth_dev_start: err=%d, port=%d\\n\",\n \t\t\t\tret, portid);\n \n-\t\trte_eth_promiscuous_enable(portid);\n+\t\tret = rte_eth_promiscuous_enable(portid);\n+\t\tif (ret != 0)\n+\t\t\trte_exit(EXIT_FAILURE,\n+\t\t\t\t\"rte_eth_promiscuous_enable: err=%s, port=%d\\n\",\n+\t\t\t\trte_strerror(-ret), portid);\n \n \t\tif (check_ptype(portid) == 0) {\n \t\t\trte_eth_add_rx_callback(portid, 0, cb_parse_ptype, NULL);\ndiff --git a/examples/ip_pipeline/link.c b/examples/ip_pipeline/link.c\nindex 4e3a40b5a8..744abf394f 100644\n--- a/examples/ip_pipeline/link.c\n+++ b/examples/ip_pipeline/link.c\n@@ -176,8 +176,11 @@ link_create(const char *name, struct link_params *params)\n \tif (status < 0)\n \t\treturn NULL;\n \n-\tif (params->promiscuous)\n-\t\trte_eth_promiscuous_enable(port_id);\n+\tif (params->promiscuous) {\n+\t\tstatus = rte_eth_promiscuous_enable(port_id);\n+\t\tif (status != 0)\n+\t\t\treturn NULL;\n+\t}\n \n \t/* Port RX */\n \tfor (i = 0; i < params->rx.n_queues; i++) {\ndiff --git a/examples/ip_reassembly/main.c b/examples/ip_reassembly/main.c\nindex 87d4b5c01f..e810e9f3f4 100644\n--- a/examples/ip_reassembly/main.c\n+++ b/examples/ip_reassembly/main.c\n@@ -1169,7 +1169,11 @@ main(int argc, char **argv)\n \t\t\trte_exit(EXIT_FAILURE, \"rte_eth_dev_start: err=%d, port=%d\\n\",\n \t\t\t\tret, portid);\n \n-\t\trte_eth_promiscuous_enable(portid);\n+\t\tret = rte_eth_promiscuous_enable(portid);\n+\t\tif (ret != 0)\n+\t\t\trte_exit(EXIT_FAILURE,\n+\t\t\t\t\"rte_eth_promiscuous_enable: err=%s, port=%d\\n\",\n+\t\t\t\trte_strerror(-ret), portid);\n \t}\n \n \tif (init_routing_table() < 0)\ndiff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-secgw/ipsec-secgw.c\nindex 534830a8e0..8154fc76af 100644\n--- a/examples/ipsec-secgw/ipsec-secgw.c\n+++ b/examples/ipsec-secgw/ipsec-secgw.c\n@@ -2467,8 +2467,13 @@ main(int32_t argc, char **argv)\n \t\t * to itself through 2 cross-connected ports of the\n \t\t * target machine.\n \t\t */\n-\t\tif (promiscuous_on)\n-\t\t\trte_eth_promiscuous_enable(portid);\n+\t\tif (promiscuous_on) {\n+\t\t\tret = rte_eth_promiscuous_enable(portid);\n+\t\t\tif (ret != 0)\n+\t\t\t\trte_exit(EXIT_FAILURE,\n+\t\t\t\t\t\"rte_eth_promiscuous_enable: err=%s, port=%d\\n\",\n+\t\t\t\t\trte_strerror(-ret), portid);\n+\t\t}\n \n \t\trte_eth_dev_callback_register(portid,\n \t\t\tRTE_ETH_EVENT_IPSEC, inline_ipsec_event_callback, NULL);\ndiff --git a/examples/l2fwd-cat/l2fwd-cat.c b/examples/l2fwd-cat/l2fwd-cat.c\nindex b34b40a006..b15f0330b8 100644\n--- a/examples/l2fwd-cat/l2fwd-cat.c\n+++ b/examples/l2fwd-cat/l2fwd-cat.c\n@@ -83,7 +83,9 @@ port_init(uint16_t port, struct rte_mempool *mbuf_pool)\n \t\t\taddr.addr_bytes[4], addr.addr_bytes[5]);\n \n \t/* Enable RX in promiscuous mode for the Ethernet device. */\n-\trte_eth_promiscuous_enable(port);\n+\tretval = rte_eth_promiscuous_enable(port);\n+\tif (retval != 0)\n+\t\treturn retval;\n \n \treturn 0;\n }\ndiff --git a/examples/l2fwd-crypto/main.c b/examples/l2fwd-crypto/main.c\nindex 9a370f2dea..c4ef310312 100644\n--- a/examples/l2fwd-crypto/main.c\n+++ b/examples/l2fwd-crypto/main.c\n@@ -2574,7 +2574,12 @@ initialize_ports(struct l2fwd_crypto_options *options)\n \t\t\treturn -1;\n \t\t}\n \n-\t\trte_eth_promiscuous_enable(portid);\n+\t\tretval = rte_eth_promiscuous_enable(portid);\n+\t\tif (retval != 0) {\n+\t\t\tprintf(\"rte_eth_promiscuous_enable:err=%s, port=%u\\n\",\n+\t\t\t\trte_strerror(-retval), portid);\n+\t\t\treturn -1;\n+\t\t}\n \n \t\trte_eth_macaddr_get(portid, &l2fwd_ports_eth_addr[portid]);\n \ndiff --git a/examples/l2fwd-jobstats/main.c b/examples/l2fwd-jobstats/main.c\nindex 5fcba5c88c..3dd6e45b86 100644\n--- a/examples/l2fwd-jobstats/main.c\n+++ b/examples/l2fwd-jobstats/main.c\n@@ -916,7 +916,14 @@ main(int argc, char **argv)\n \n \t\tprintf(\"done:\\n\");\n \n-\t\trte_eth_promiscuous_enable(portid);\n+\t\tret = rte_eth_promiscuous_enable(portid);\n+\t\tif (ret != 0) {\n+\t\t\trte_exit(EXIT_FAILURE,\n+\t\t\t\t \"rte_eth_promiscuous_enable:err=%s, port=%u\\n\",\n+\t\t\t\t rte_strerror(-ret), portid);\n+\t\t\treturn ret;\n+\n+\t\t}\n \n \t\tprintf(\"Port %u, MAC address: %02X:%02X:%02X:%02X:%02X:%02X\\n\\n\",\n \t\t\t\tportid,\ndiff --git a/examples/l2fwd-keepalive/main.c b/examples/l2fwd-keepalive/main.c\nindex a051390688..708f44ee0d 100644\n--- a/examples/l2fwd-keepalive/main.c\n+++ b/examples/l2fwd-keepalive/main.c\n@@ -709,7 +709,11 @@ main(int argc, char **argv)\n \t\t\t\t\"rte_eth_dev_start:err=%d, port=%u\\n\",\n \t\t\t\t ret, portid);\n \n-\t\trte_eth_promiscuous_enable(portid);\n+\t\tret = rte_eth_promiscuous_enable(portid);\n+\t\tif (ret != 0)\n+\t\t\trte_exit(EXIT_FAILURE,\n+\t\t\t\t \"rte_eth_promiscuous_enable:err=%s, port=%u\\n\",\n+\t\t\t\t rte_strerror(-ret), portid);\n \n \t\tprintf(\"Port %u, MAC address: \"\n \t\t\t\"%02X:%02X:%02X:%02X:%02X:%02X\\n\\n\",\ndiff --git a/examples/l2fwd/main.c b/examples/l2fwd/main.c\nindex 8d4c539810..db070a18be 100644\n--- a/examples/l2fwd/main.c\n+++ b/examples/l2fwd/main.c\n@@ -708,7 +708,11 @@ main(int argc, char **argv)\n \n \t\tprintf(\"done: \\n\");\n \n-\t\trte_eth_promiscuous_enable(portid);\n+\t\tret = rte_eth_promiscuous_enable(portid);\n+\t\tif (ret != 0)\n+\t\t\trte_exit(EXIT_FAILURE,\n+\t\t\t\t \"rte_eth_promiscuous_enable:err=%s, port=%u\\n\",\n+\t\t\t\t rte_strerror(-ret), portid);\n \n \t\tprintf(\"Port %u, MAC address: %02X:%02X:%02X:%02X:%02X:%02X\\n\\n\",\n \t\t\t\tportid,\ndiff --git a/examples/l3fwd-acl/main.c b/examples/l3fwd-acl/main.c\nindex 60531ce0ec..c974a357be 100644\n--- a/examples/l3fwd-acl/main.c\n+++ b/examples/l3fwd-acl/main.c\n@@ -2085,8 +2085,13 @@ main(int argc, char **argv)\n \t\t * to itself through 2 cross-connected ports of the\n \t\t * target machine.\n \t\t */\n-\t\tif (promiscuous_on)\n-\t\t\trte_eth_promiscuous_enable(portid);\n+\t\tif (promiscuous_on) {\n+\t\t\tret = rte_eth_promiscuous_enable(portid);\n+\t\t\tif (ret != 0)\n+\t\t\t\trte_exit(EXIT_FAILURE,\n+\t\t\t\t\t\"rte_eth_promiscuous_enable: err=%s, port=%u\\n\",\n+\t\t\t\t\trte_strerror(-ret), portid);\n+\t\t}\n \t}\n \n \tcheck_all_ports_link_status(enabled_port_mask);\ndiff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c\nindex bfcaa46c58..8ddc9ceb1e 100644\n--- a/examples/l3fwd-power/main.c\n+++ b/examples/l3fwd-power/main.c\n@@ -2453,8 +2453,13 @@ main(int argc, char **argv)\n \t\t * to itself through 2 cross-connected ports of the\n \t\t * target machine.\n \t\t */\n-\t\tif (promiscuous_on)\n-\t\t\trte_eth_promiscuous_enable(portid);\n+\t\tif (promiscuous_on) {\n+\t\t\tret = rte_eth_promiscuous_enable(portid);\n+\t\t\tif (ret != 0)\n+\t\t\t\trte_exit(EXIT_FAILURE,\n+\t\t\t\t\t\"rte_eth_promiscuous_enable: err=%s, port=%u\\n\",\n+\t\t\t\t\trte_strerror(-ret), portid);\n+\t\t}\n \t\t/* initialize spinlock for each port */\n \t\trte_spinlock_init(&(locks[portid]));\n \t}\ndiff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c\nindex 3294ac2dab..9ed495ee01 100644\n--- a/examples/l3fwd/main.c\n+++ b/examples/l3fwd/main.c\n@@ -1035,8 +1035,13 @@ main(int argc, char **argv)\n \t\t * to itself through 2 cross-connected ports of the\n \t\t * target machine.\n \t\t */\n-\t\tif (promiscuous_on)\n-\t\t\trte_eth_promiscuous_enable(portid);\n+\t\tif (promiscuous_on) {\n+\t\t\tret = rte_eth_promiscuous_enable(portid);\n+\t\t\tif (ret != 0)\n+\t\t\t\trte_exit(EXIT_FAILURE,\n+\t\t\t\t\t\"rte_eth_promiscuous_enable: err=%s, port=%u\\n\",\n+\t\t\t\t\trte_strerror(-ret), portid);\n+\t\t}\n \t}\n \n \tprintf(\"\\n\");\ndiff --git a/examples/link_status_interrupt/main.c b/examples/link_status_interrupt/main.c\nindex 0c3dfc6912..be57e6a982 100644\n--- a/examples/link_status_interrupt/main.c\n+++ b/examples/link_status_interrupt/main.c\n@@ -689,7 +689,11 @@ main(int argc, char **argv)\n \t\t\t\t ret, (unsigned) portid);\n \t\tprintf(\"done:\\n\");\n \n-\t\trte_eth_promiscuous_enable(portid);\n+\t\tret = rte_eth_promiscuous_enable(portid);\n+\t\tif (ret != 0)\n+\t\t\trte_exit(EXIT_FAILURE,\n+\t\t\t\t\"rte_eth_promiscuous_enable: err=%s, port=%u\\n\",\n+\t\t\t\trte_strerror(-ret), portid);\n \n \t\tprintf(\"Port %u, MAC address: %02X:%02X:%02X:%02X:%02X:%02X\\n\\n\",\n \t\t\t\t(unsigned) portid,\ndiff --git a/examples/load_balancer/init.c b/examples/load_balancer/init.c\nindex 660f5a8edd..4d49c9514a 100644\n--- a/examples/load_balancer/init.c\n+++ b/examples/load_balancer/init.c\n@@ -440,7 +440,11 @@ app_init_nics(void)\n \t\tif (ret < 0) {\n \t\t\trte_panic(\"Cannot init NIC port %u (%d)\\n\", port, ret);\n \t\t}\n-\t\trte_eth_promiscuous_enable(port);\n+\n+\t\tret = rte_eth_promiscuous_enable(port);\n+\t\tif (ret != 0)\n+\t\t\trte_panic(\"Cannot enable promiscuous mode on port %u (%s)\\n\",\n+\t\t\t\tport, rte_strerror(-ret));\n \n \t\tnic_rx_ring_size = app.nic_rx_ring_size;\n \t\tnic_tx_ring_size = app.nic_tx_ring_size;\ndiff --git a/examples/multi_process/client_server_mp/mp_server/init.c b/examples/multi_process/client_server_mp/mp_server/init.c\nindex 3af5dc6994..e55def84b5 100644\n--- a/examples/multi_process/client_server_mp/mp_server/init.c\n+++ b/examples/multi_process/client_server_mp/mp_server/init.c\n@@ -132,7 +132,9 @@ init_port(uint16_t port_num)\n \t\tif (retval < 0) return retval;\n \t}\n \n-\trte_eth_promiscuous_enable(port_num);\n+\tretval = rte_eth_promiscuous_enable(port_num);\n+\tif (retval < 0)\n+\t\treturn retval;\n \n \tretval = rte_eth_dev_start(port_num);\n \tif (retval < 0) return retval;\ndiff --git a/examples/multi_process/symmetric_mp/main.c b/examples/multi_process/symmetric_mp/main.c\nindex 9ae8efb0ba..95058a5dc5 100644\n--- a/examples/multi_process/symmetric_mp/main.c\n+++ b/examples/multi_process/symmetric_mp/main.c\n@@ -261,7 +261,9 @@ smp_port_init(uint16_t port, struct rte_mempool *mbuf_pool,\n \t\t\treturn retval;\n \t}\n \n-\trte_eth_promiscuous_enable(port);\n+\tretval = rte_eth_promiscuous_enable(port);\n+\tif (retval != 0)\n+\t\treturn retval;\n \n \tretval = rte_eth_dev_start(port);\n \tif (retval < 0)\ndiff --git a/examples/netmap_compat/bridge/bridge.c b/examples/netmap_compat/bridge/bridge.c\nindex d40e163b0e..f3819d2224 100644\n--- a/examples/netmap_compat/bridge/bridge.c\n+++ b/examples/netmap_compat/bridge/bridge.c\n@@ -261,7 +261,11 @@ int main(int argc, char *argv[])\n \t\t\trte_exit(EXIT_FAILURE, \"Couldn't setup port %hhu\\n\",\n \t\t\t\tports.p[i].id);\n \n-\t\trte_eth_promiscuous_enable(ports.p[i].id);\n+\t\terr = rte_eth_promiscuous_enable(ports.p[i].id);\n+\t\tif (err != 0)\n+\t\t\trte_exit(EXIT_FAILURE,\n+\t\t\t\t\"Couldn't enable promiscuous mode on port %u: %s\\n\",\n+\t\t\t\tports.p[i].id, rte_strerror(-err));\n \t}\n \n \tfor (i = 0; i != ports.num; i++) {\ndiff --git a/examples/packet_ordering/main.c b/examples/packet_ordering/main.c\nindex a99961f821..132f582a95 100644\n--- a/examples/packet_ordering/main.c\n+++ b/examples/packet_ordering/main.c\n@@ -330,7 +330,9 @@ configure_eth_port(uint16_t port_id)\n \t\t\taddr.addr_bytes[2], addr.addr_bytes[3],\n \t\t\taddr.addr_bytes[4], addr.addr_bytes[5]);\n \n-\trte_eth_promiscuous_enable(port_id);\n+\tret = rte_eth_promiscuous_enable(port_id);\n+\tif (ret != 0)\n+\t\treturn ret;\n \n \treturn 0;\n }\ndiff --git a/examples/performance-thread/l3fwd-thread/main.c b/examples/performance-thread/l3fwd-thread/main.c\nindex 00f535053c..9e25f064ed 100644\n--- a/examples/performance-thread/l3fwd-thread/main.c\n+++ b/examples/performance-thread/l3fwd-thread/main.c\n@@ -3706,8 +3706,13 @@ main(int argc, char **argv)\n \t\t * to itself through 2 cross-connected ports of the\n \t\t * target machine.\n \t\t */\n-\t\tif (promiscuous_on)\n-\t\t\trte_eth_promiscuous_enable(portid);\n+\t\tif (promiscuous_on) {\n+\t\t\tret = rte_eth_promiscuous_enable(portid);\n+\t\t\tif (ret != 0)\n+\t\t\t\trte_exit(EXIT_FAILURE,\n+\t\t\t\t\t\"rte_eth_promiscuous_enable: err=%s, port=%u\\n\",\n+\t\t\t\t\trte_strerror(-ret), portid);\n+\t\t}\n \t}\n \n \tfor (i = 0; i < n_rx_thread; i++) {\ndiff --git a/examples/ptpclient/ptpclient.c b/examples/ptpclient/ptpclient.c\nindex bc427a526c..6e273f644f 100644\n--- a/examples/ptpclient/ptpclient.c\n+++ b/examples/ptpclient/ptpclient.c\n@@ -247,7 +247,12 @@ port_init(uint16_t port, struct rte_mempool *mbuf_pool)\n \t}\n \n \t/* Enable RX in promiscuous mode for the Ethernet device. */\n-\trte_eth_promiscuous_enable(port);\n+\tretval = rte_eth_promiscuous_enable(port);\n+\tif (retval != 0) {\n+\t\tprintf(\"Promiscuous mode enable failed: %s\\n\",\n+\t\t\trte_strerror(-retval));\n+\t\treturn retval;\n+\t}\n \n \treturn 0;\n }\ndiff --git a/examples/qos_meter/main.c b/examples/qos_meter/main.c\nindex 13c85e9406..e8112c83a2 100644\n--- a/examples/qos_meter/main.c\n+++ b/examples/qos_meter/main.c\n@@ -439,9 +439,17 @@ main(int argc, char **argv)\n \tif (ret < 0)\n \t\trte_exit(EXIT_FAILURE, \"Port %d start error (%d)\\n\", port_tx, ret);\n \n-\trte_eth_promiscuous_enable(port_rx);\n+\tret = rte_eth_promiscuous_enable(port_rx);\n+\tif (ret != 0)\n+\t\trte_exit(EXIT_FAILURE,\n+\t\t\t\"Port %d promiscuous mode enable error (%s)\\n\",\n+\t\t\tport_rx, rte_strerror(-ret));\n \n-\trte_eth_promiscuous_enable(port_tx);\n+\tret = rte_eth_promiscuous_enable(port_tx);\n+\tif (ret != 0)\n+\t\trte_exit(EXIT_FAILURE,\n+\t\t\t\"Port %d promiscuous mode enable error (%s)\\n\",\n+\t\t\tport_rx, rte_strerror(-ret));\n \n \t/* App configuration */\n \tret = app_configure_flow_table();\ndiff --git a/examples/qos_sched/init.c b/examples/qos_sched/init.c\nindex cf9e8f4ac7..dbdbdefea7 100644\n--- a/examples/qos_sched/init.c\n+++ b/examples/qos_sched/init.c\n@@ -163,7 +163,11 @@ app_init_port(uint16_t portid, struct rte_mempool *mp)\n \t} else {\n \t\tprintf(\" Link Down\\n\");\n \t}\n-\trte_eth_promiscuous_enable(portid);\n+\tret = rte_eth_promiscuous_enable(portid);\n+\tif (ret != 0)\n+\t\trte_exit(EXIT_FAILURE,\n+\t\t\t\"rte_eth_promiscuous_enable: err=%s, port=%u\\n\",\n+\t\t\trte_strerror(-ret), portid);\n \n \t/* mark port as initialized */\n \tapp_inited_port_mask |= 1u << portid;\ndiff --git a/examples/quota_watermark/qw/init.c b/examples/quota_watermark/qw/init.c\nindex 5a0f64f454..5ebcc83ac3 100644\n--- a/examples/quota_watermark/qw/init.c\n+++ b/examples/quota_watermark/qw/init.c\n@@ -103,7 +103,11 @@ void configure_eth_port(uint16_t port_id)\n \t\t\t\t(unsigned int) port_id, ret);\n \n \t/* Put it in promiscuous mode */\n-\trte_eth_promiscuous_enable(port_id);\n+\tret = rte_eth_promiscuous_enable(port_id);\n+\tif (ret != 0)\n+\t\trte_exit(EXIT_FAILURE,\n+\t\t\t\"Failed to enable promiscuous mode for port %u: %s\\n\",\n+\t\t\tport_id, rte_strerror(-ret));\n }\n \n void\ndiff --git a/examples/rxtx_callbacks/main.c b/examples/rxtx_callbacks/main.c\nindex 9fd4b8efd5..5d545115c4 100644\n--- a/examples/rxtx_callbacks/main.c\n+++ b/examples/rxtx_callbacks/main.c\n@@ -196,7 +196,10 @@ port_init(uint16_t port, struct rte_mempool *mbuf_pool)\n \t\t\taddr.addr_bytes[2], addr.addr_bytes[3],\n \t\t\taddr.addr_bytes[4], addr.addr_bytes[5]);\n \n-\trte_eth_promiscuous_enable(port);\n+\tretval = rte_eth_promiscuous_enable(port);\n+\tif (retval != 0)\n+\t\treturn retval;\n+\n \trte_eth_add_rx_callback(port, 0, add_timestamps, NULL);\n \trte_eth_add_tx_callback(port, 0, calc_latency, NULL);\n \ndiff --git a/examples/server_node_efd/server/init.c b/examples/server_node_efd/server/init.c\nindex 773780b4d2..335741a8fc 100644\n--- a/examples/server_node_efd/server/init.c\n+++ b/examples/server_node_efd/server/init.c\n@@ -150,7 +150,9 @@ init_port(uint16_t port_num)\n \t\t\treturn retval;\n \t}\n \n-\trte_eth_promiscuous_enable(port_num);\n+\tretval = rte_eth_promiscuous_enable(port_num);\n+\tif (retval != 0)\n+\t\treturn retval;\n \n \tretval = rte_eth_dev_start(port_num);\n \tif (retval < 0)\ndiff --git a/examples/skeleton/basicfwd.c b/examples/skeleton/basicfwd.c\nindex 171ebde7bd..8f1805aeb5 100644\n--- a/examples/skeleton/basicfwd.c\n+++ b/examples/skeleton/basicfwd.c\n@@ -98,7 +98,9 @@ port_init(uint16_t port, struct rte_mempool *mbuf_pool)\n \t\t\taddr.addr_bytes[4], addr.addr_bytes[5]);\n \n \t/* Enable RX in promiscuous mode for the Ethernet device. */\n-\trte_eth_promiscuous_enable(port);\n+\tretval = rte_eth_promiscuous_enable(port);\n+\tif (retval != 0)\n+\t\treturn retval;\n \n \treturn 0;\n }\ndiff --git a/examples/vhost/main.c b/examples/vhost/main.c\nindex 794d12ba7e..b5632d771d 100644\n--- a/examples/vhost/main.c\n+++ b/examples/vhost/main.c\n@@ -336,8 +336,15 @@ port_init(uint16_t port)\n \t\treturn retval;\n \t}\n \n-\tif (promiscuous)\n-\t\trte_eth_promiscuous_enable(port);\n+\tif (promiscuous) {\n+\t\tretval = rte_eth_promiscuous_enable(port);\n+\t\tif (retval != 0) {\n+\t\t\tRTE_LOG(ERR, VHOST_PORT,\n+\t\t\t\t\"Failed to enable promiscuous mode on port %u: %s\\n\",\n+\t\t\t\tport, rte_strerror(-retval));\n+\t\t\treturn retval;\n+\t\t}\n+\t}\n \n \trte_eth_macaddr_get(port, &vmdq_ports_eth_addr[port]);\n \tRTE_LOG(INFO, VHOST_PORT, \"Max virtio devices supported: %u\\n\", num_devices);\ndiff --git a/examples/vm_power_manager/main.c b/examples/vm_power_manager/main.c\nindex 0f48ae926c..a3a7478296 100644\n--- a/examples/vm_power_manager/main.c\n+++ b/examples/vm_power_manager/main.c\n@@ -121,7 +121,9 @@ port_init(uint16_t port, struct rte_mempool *mbuf_pool)\n \t\t\taddr.addr_bytes[4], addr.addr_bytes[5]);\n \n \t/* Enable RX in promiscuous mode for the Ethernet device. */\n-\trte_eth_promiscuous_enable(port);\n+\tretval = rte_eth_promiscuous_enable(port);\n+\tif (ret != 0)\n+\t\treturn retval;\n \n \n \treturn 0;\n", "prefixes": [ "13/13" ] }