Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/58657/?format=api
{ "id": 58657, "url": "https://patches.dpdk.org/api/patches/58657/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190905145315.19395-3-ferruh.yigit@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190905145315.19395-3-ferruh.yigit@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190905145315.19395-3-ferruh.yigit@intel.com", "date": "2019-09-05T14:53:07", "name": "[02/10] net/igb: fix global variable multiple definitions", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "b42e9db70a0868dd3a8f60915d6c3d71d1e4c879", "submitter": { "id": 324, "url": "https://patches.dpdk.org/api/people/324/?format=api", "name": "Ferruh Yigit", "email": "ferruh.yigit@intel.com" }, "delegate": { "id": 24651, "url": "https://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190905145315.19395-3-ferruh.yigit@intel.com/mbox/", "series": [ { "id": 6259, "url": "https://patches.dpdk.org/api/series/6259/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=6259", "date": "2019-09-05T14:53:05", "name": "fix global variable multiple definitions", "version": 1, "mbox": "https://patches.dpdk.org/series/6259/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/58657/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/58657/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 337FA1EFC0;\n\tThu, 5 Sep 2019 16:53:30 +0200 (CEST)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n\tby dpdk.org (Postfix) with ESMTP id 393B41EF4D;\n\tThu, 5 Sep 2019 16:53:23 +0200 (CEST)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n\tby fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t05 Sep 2019 07:53:22 -0700", "from silpixa00399752.ir.intel.com (HELO\n\tsilpixa00399752.ger.corp.intel.com) ([10.237.223.78])\n\tby fmsmga008.fm.intel.com with ESMTP; 05 Sep 2019 07:53:22 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.64,470,1559545200\"; d=\"scan'208\";a=\"182846342\"", "From": "Ferruh Yigit <ferruh.yigit@intel.com>", "To": "Wenzhuo Lu <wenzhuo.lu@intel.com>", "Cc": "dev@dpdk.org,\n\tstable@dpdk.org", "Date": "Thu, 5 Sep 2019 15:53:07 +0100", "Message-Id": "<20190905145315.19395-3-ferruh.yigit@intel.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190905145315.19395-1-ferruh.yigit@intel.com>", "References": "<20190905145315.19395-1-ferruh.yigit@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 02/10] net/igb: fix global variable multiple\n\tdefinitions", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Filtering related global variables are defined in a header file which\nwas causing multiple definitions of the variables, fixed it by moving\nthem to the .c file.\n\nIssue has been detected by '-fno-common' gcc flag.\n\nFixes: 22bb13410cb2 (\"net/igb: create consistent filter\")\nFixes: 424ae915baf0 (\"net/e1000: move RSS to flow API\")\nCc: stable@dpdk.org\n\nSigned-off-by: Ferruh Yigit <ferruh.yigit@intel.com>\n---\n drivers/net/e1000/e1000_ethdev.h | 12 ++++++------\n drivers/net/e1000/igb_flow.c | 7 +++++++\n 2 files changed, 13 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/e1000/e1000_ethdev.h b/drivers/net/e1000/e1000_ethdev.h\nindex 01ff9433b..1e41ae9de 100644\n--- a/drivers/net/e1000/e1000_ethdev.h\n+++ b/drivers/net/e1000/e1000_ethdev.h\n@@ -351,17 +351,17 @@ struct igb_flow_mem {\n };\n \n TAILQ_HEAD(igb_ntuple_filter_list, igb_ntuple_filter_ele);\n-struct igb_ntuple_filter_list igb_filter_ntuple_list;\n+extern struct igb_ntuple_filter_list igb_filter_ntuple_list;\n TAILQ_HEAD(igb_ethertype_filter_list, igb_ethertype_filter_ele);\n-struct igb_ethertype_filter_list igb_filter_ethertype_list;\n+extern struct igb_ethertype_filter_list igb_filter_ethertype_list;\n TAILQ_HEAD(igb_syn_filter_list, igb_eth_syn_filter_ele);\n-struct igb_syn_filter_list igb_filter_syn_list;\n+extern struct igb_syn_filter_list igb_filter_syn_list;\n TAILQ_HEAD(igb_flex_filter_list, igb_flex_filter_ele);\n-struct igb_flex_filter_list igb_filter_flex_list;\n+extern struct igb_flex_filter_list igb_filter_flex_list;\n TAILQ_HEAD(igb_rss_filter_list, igb_rss_conf_ele);\n-struct igb_rss_filter_list igb_filter_rss_list;\n+extern struct igb_rss_filter_list igb_filter_rss_list;\n TAILQ_HEAD(igb_flow_mem_list, igb_flow_mem);\n-struct igb_flow_mem_list igb_flow_list;\n+extern struct igb_flow_mem_list igb_flow_list;\n \n extern const struct rte_flow_ops igb_flow_ops;\n \ndiff --git a/drivers/net/e1000/igb_flow.c b/drivers/net/e1000/igb_flow.c\nindex 4e0b38fcf..31ca9bb1c 100644\n--- a/drivers/net/e1000/igb_flow.c\n+++ b/drivers/net/e1000/igb_flow.c\n@@ -49,6 +49,13 @@\n \n #define\tIGB_FLEX_RAW_NUM\t12\n \n+struct igb_flow_mem_list igb_flow_list;\n+struct igb_ntuple_filter_list igb_filter_ntuple_list;\n+struct igb_ethertype_filter_list igb_filter_ethertype_list;\n+struct igb_syn_filter_list igb_filter_syn_list;\n+struct igb_flex_filter_list igb_filter_flex_list;\n+struct igb_rss_filter_list igb_filter_rss_list;\n+\n /**\n * Please aware there's an asumption for all the parsers.\n * rte_flow_item is using big endian, rte_flow_attr and\n", "prefixes": [ "02/10" ] }