Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/58513/?format=api
https://patches.dpdk.org/api/patches/58513/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1567519051-28189-48-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1567519051-28189-48-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1567519051-28189-48-git-send-email-arybchenko@solarflare.com", "date": "2019-09-03T13:57:21", "name": "[v2,47/54] examples/ipsec-secgw: check status of getting ethdev info", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "25a5384726a8c508df4e9363b566f1a6cab99cd8", "submitter": { "id": 607, "url": "https://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1567519051-28189-48-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 6222, "url": "https://patches.dpdk.org/api/series/6222/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=6222", "date": "2019-09-03T13:56:35", "name": "ethdev: change rte_eth_dev_info_get() return value to int", "version": 2, "mbox": "https://patches.dpdk.org/series/6222/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/58513/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/58513/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 153B51EC9D;\n\tTue, 3 Sep 2019 15:59:50 +0200 (CEST)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n\t[148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 432B21EAE9\n\tfor <dev@dpdk.org>; Tue, 3 Sep 2019 15:58:12 +0200 (CEST)", "from webmail.solarflare.com (webmail.solarflare.com\n\t[12.187.104.26])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby mx1-us4.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id\n\tB4026BC005A; Tue, 3 Sep 2019 13:58:10 +0000 (UTC)", "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1395.4; Tue, 3 Sep 2019 06:58:05 -0700", "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1395.4 via Frontend Transport; Tue, 3 Sep 2019 06:58:05 -0700", "from ukv-loginhost.uk.solarflarecom.com\n\t(ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tx83Dw42U000669; Tue, 3 Sep 2019 14:58:04 +0100", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n\tby ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id\n\t504E91613D1; Tue, 3 Sep 2019 14:58:04 +0100 (BST)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "Marko Kovacevic <marko.kovacevic@intel.com>, Ori Kam <orika@mellanox.com>,\n\tBruce Richardson <bruce.richardson@intel.com>, Pablo de Lara\n\t<pablo.de.lara.guarch@intel.com>, Radu Nicolau <radu.nicolau@intel.com>, \n\tAkhil Goyal <akhil.goyal@nxp.com>, Tomasz Kantecki\n\t<tomasz.kantecki@intel.com>", "CC": "<dev@dpdk.org>, Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.com>", "Date": "Tue, 3 Sep 2019 14:57:21 +0100", "Message-ID": "<1567519051-28189-48-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1567519051-28189-1-git-send-email-arybchenko@solarflare.com>", "References": "<1566915962-5472-1-git-send-email-arybchenko@solarflare.com>\n\t<1567519051-28189-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.5.1010-24886.005", "X-TM-AS-Result": "No-2.400300-4.000000-10", "X-TMASE-MatchedRID": "Y4ICLEyyxIvDOgXZFRFV8+b3p4cnIXGNAPiR4btCEeZ+SLLtNOiBhnIo\n\tzGa69omdrdoLblq9S5qnJ7eS8LcE2XclHfp8DcYbSVHYMTQ1F1oGd+nhDe1/IW0EPEQZaNPteDw\n\tovWdce3fCMVI+l4mz+PvQCPiy8IEcHxPMjOKY7A8LbigRnpKlKZvjAepGmdoOJt4MXz82HlH+vs\n\tNNYulqPZcE135pi/Y4wBp1OJ0gQtdr9ogKUA1UBQNVApx/a8rsl8dCsmPULU3GBwBjHq/vVDZ5D\n\t+QmCa9X5APDq2B3cAxn2JWP8qFf9FKehBzm9vnO5B2Qzud0EsI35c5BnKCu9g==", "X-TM-AS-User-Approved-Sender": "No", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10--2.400300-4.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.5.1010-24886.005", "X-MDID": "1567519091-Wyz7oM5Wdt2R", "Subject": "[dpdk-dev] [PATCH v2 47/54] examples/ipsec-secgw: check status of\n\tgetting ethdev info", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.com>\n\nrte_eth_dev_info_get() return value was changed from void to\nint, so this patch modify rte_eth_dev_info_get() usage across\nexamples/ipsec-secgw according to its new return type.\n\nSigned-off-by: Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.com>\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n examples/ipsec-secgw/ipsec-secgw.c | 6 +++++-\n examples/ipsec-secgw/ipsec.c | 9 ++++++++-\n examples/ipsec-secgw/sa.c | 10 +++++++++-\n 3 files changed, 22 insertions(+), 3 deletions(-)", "diff": "diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-secgw/ipsec-secgw.c\nindex 0d1fd6a..534830a 100644\n--- a/examples/ipsec-secgw/ipsec-secgw.c\n+++ b/examples/ipsec-secgw/ipsec-secgw.c\n@@ -1911,7 +1911,11 @@ struct lcore_conf {\n \tstruct rte_ether_addr ethaddr;\n \tstruct rte_eth_conf local_port_conf = port_conf;\n \n-\trte_eth_dev_info_get(portid, &dev_info);\n+\tret = rte_eth_dev_info_get(portid, &dev_info);\n+\tif (ret != 0)\n+\t\trte_exit(EXIT_FAILURE,\n+\t\t\t\"Error during getting device (port %u) info: %s\\n\",\n+\t\t\tportid, strerror(-ret));\n \n \t/* limit allowed HW offloafs, as user requested */\n \tdev_info.rx_offload_capa &= dev_rx_offload;\ndiff --git a/examples/ipsec-secgw/ipsec.c b/examples/ipsec-secgw/ipsec.c\nindex dc85adf..7720080 100644\n--- a/examples/ipsec-secgw/ipsec.c\n+++ b/examples/ipsec-secgw/ipsec.c\n@@ -243,7 +243,14 @@\n \t\t\tunsigned int i;\n \t\t\tunsigned int j;\n \n-\t\t\trte_eth_dev_info_get(sa->portid, &dev_info);\n+\t\t\tret = rte_eth_dev_info_get(sa->portid, &dev_info);\n+\t\t\tif (ret != 0) {\n+\t\t\t\tRTE_LOG(ERR, IPSEC,\n+\t\t\t\t\t\"Error during getting device (port %u) info: %s\\n\",\n+\t\t\t\t\tsa->portid, strerror(-ret));\n+\t\t\t\treturn ret;\n+\t\t\t}\n+\n \t\t\tsa->action[2].type = RTE_FLOW_ACTION_TYPE_END;\n \t\t\t/* Try RSS. */\n \t\t\tsa->action[1].type = RTE_FLOW_ACTION_TYPE_RSS;\ndiff --git a/examples/ipsec-secgw/sa.c b/examples/ipsec-secgw/sa.c\nindex c3cf3bd..14ee947 100644\n--- a/examples/ipsec-secgw/sa.c\n+++ b/examples/ipsec-secgw/sa.c\n@@ -756,8 +756,16 @@ struct sa_ctx {\n check_eth_dev_caps(uint16_t portid, uint32_t inbound)\n {\n \tstruct rte_eth_dev_info dev_info;\n+\tint retval;\n \n-\trte_eth_dev_info_get(portid, &dev_info);\n+\tretval = rte_eth_dev_info_get(portid, &dev_info);\n+\tif (retval != 0) {\n+\t\tRTE_LOG(ERR, IPSEC,\n+\t\t\t\"Error during getting device (port %u) info: %s\\n\",\n+\t\t\tportid, strerror(-retval));\n+\n+\t\treturn retval;\n+\t}\n \n \tif (inbound) {\n \t\tif ((dev_info.rx_offload_capa &\n", "prefixes": [ "v2", "47/54" ] }{ "id": 58513, "url": "