Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/58488/?format=api
{ "id": 58488, "url": "https://patches.dpdk.org/api/patches/58488/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1567519051-28189-53-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1567519051-28189-53-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1567519051-28189-53-git-send-email-arybchenko@solarflare.com", "date": "2019-09-03T13:57:26", "name": "[v2,52/54] examples/kni: check status of getting ethdev info", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "32ca5868224c0d556c3291991787caaad1300765", "submitter": { "id": 607, "url": "https://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1567519051-28189-53-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 6222, "url": "https://patches.dpdk.org/api/series/6222/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=6222", "date": "2019-09-03T13:56:35", "name": "ethdev: change rte_eth_dev_info_get() return value to int", "version": 2, "mbox": "https://patches.dpdk.org/series/6222/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/58488/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/58488/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B3E831ECCD;\n\tTue, 3 Sep 2019 15:59:55 +0200 (CEST)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n\t[148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 0D71D1EAAE\n\tfor <dev@dpdk.org>; Tue, 3 Sep 2019 15:58:13 +0200 (CEST)", "from webmail.solarflare.com (webmail.solarflare.com\n\t[12.187.104.26])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby mx1-us4.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id\n\t9B6DEBC005E; Tue, 3 Sep 2019 13:58:11 +0000 (UTC)", "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1395.4; Tue, 3 Sep 2019 06:58:08 -0700", "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1395.4 via Frontend Transport; Tue, 3 Sep 2019 06:58:08 -0700", "from ukv-loginhost.uk.solarflarecom.com\n\t(ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tx83Dw6ww000726; Tue, 3 Sep 2019 14:58:06 +0100", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n\tby ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id\n\tDE1241613D1; Tue, 3 Sep 2019 14:58:06 +0100 (BST)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "Ferruh Yigit <ferruh.yigit@intel.com>", "CC": "<dev@dpdk.org>, Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.com>", "Date": "Tue, 3 Sep 2019 14:57:26 +0100", "Message-ID": "<1567519051-28189-53-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1567519051-28189-1-git-send-email-arybchenko@solarflare.com>", "References": "<1566915962-5472-1-git-send-email-arybchenko@solarflare.com>\n\t<1567519051-28189-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.5.1010-24886.005", "X-TM-AS-Result": "No-2.220300-4.000000-10", "X-TMASE-MatchedRID": "JJf+xfeHh43DOgXZFRFV8+b3p4cnIXGNAPiR4btCEeZ+SLLtNOiBhrny\n\tO1e9qRizrdoLblq9S5qnJ7eS8LcE2Rf+TLxNffg6UyxW4vmvLt2ByxVkfd04JEUf4hgvt6xq+3n\n\t5TORW5Is6w/ejczwdN3GGEKfcJAliCWJZymXNAFfHmyDJSEsI28MA9JsxaUa3eoHKBqqMb3GjxY\n\tyRBa/qJcFwgTvxipFajoczmuoPCq05l8HgkvZCyaVkNovSzDSRJfAmeSigXHwYev67myyhtB8RW\n\tZ419oquT1U+566F0BpmqTXl2g5/KKuckqlg4XmJqoT84JrYyt+F15h6/oibNbKsWJ44GuEGPNxa\n\tu39/BitFwHZmk+dWMmhnUCrcDtVn", "X-TM-AS-User-Approved-Sender": "No", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10--2.220300-4.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.5.1010-24886.005", "X-MDID": "1567519092-tvO1SrO3JEHN", "Subject": "[dpdk-dev] [PATCH v2 52/54] examples/kni: check status of getting\n\tethdev info", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.com>\n\nrte_eth_dev_info_get() return value was changed from void to\nint, so this patch modify rte_eth_dev_info_get() usage across\nexamples/kni according to its new return type.\n\nSigned-off-by: Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.com>\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n examples/kni/main.c | 25 ++++++++++++++++++++++---\n 1 file changed, 22 insertions(+), 3 deletions(-)", "diff": "diff --git a/examples/kni/main.c b/examples/kni/main.c\nindex 17f695e..e43f174 100644\n--- a/examples/kni/main.c\n+++ b/examples/kni/main.c\n@@ -595,7 +595,13 @@ struct kni_interface_stats {\n \t/* Initialise device and RX/TX queues */\n \tRTE_LOG(INFO, APP, \"Initialising port %u ...\\n\", (unsigned)port);\n \tfflush(stdout);\n-\trte_eth_dev_info_get(port, &dev_info);\n+\n+\tret = rte_eth_dev_info_get(port, &dev_info);\n+\tif (ret != 0)\n+\t\trte_exit(EXIT_FAILURE,\n+\t\t\t\"Error during getting device (port %u) info: %s\\n\",\n+\t\t\tport, strerror(-ret));\n+\n \tif (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MBUF_FAST_FREE)\n \t\tlocal_port_conf.txmode.offloads |=\n \t\t\tDEV_TX_OFFLOAD_MBUF_FAST_FREE;\n@@ -780,7 +786,15 @@ struct kni_interface_stats {\n \t\t\t\t\"for port%u (%d)\\n\", (unsigned int)port_id,\n \t\t\t\tret);\n \n-\trte_eth_dev_info_get(port_id, &dev_info);\n+\tret = rte_eth_dev_info_get(port_id, &dev_info);\n+\tif (ret != 0) {\n+\t\tRTE_LOG(ERR, APP,\n+\t\t\t\"Error during getting device (port %u) info: %s\\n\",\n+\t\t\tport_id, strerror(-ret));\n+\n+\t\treturn ret;\n+\t}\n+\n \trxq_conf = dev_info.default_rxconf;\n \trxq_conf.offloads = conf.rxmode.offloads;\n \tret = rte_eth_rx_queue_setup(port_id, 0, nb_rxd,\n@@ -869,6 +883,7 @@ struct kni_interface_stats {\n \tstruct rte_kni *kni;\n \tstruct rte_kni_conf conf;\n \tstruct kni_port_params **params = kni_port_params_array;\n+\tint ret;\n \n \tif (port_id >= RTE_MAX_ETHPORTS || !params[port_id])\n \t\treturn -1;\n@@ -898,7 +913,11 @@ struct kni_interface_stats {\n \t\t\tstruct rte_kni_ops ops;\n \t\t\tstruct rte_eth_dev_info dev_info;\n \n-\t\t\trte_eth_dev_info_get(port_id, &dev_info);\n+\t\t\tret = rte_eth_dev_info_get(port_id, &dev_info);\n+\t\t\tif (ret != 0)\n+\t\t\t\trte_exit(EXIT_FAILURE,\n+\t\t\t\t\t\"Error during getting device (port %u) info: %s\\n\",\n+\t\t\t\t\tport_id, strerror(-ret));\n \n \t\t\t/* Get the interface default mac address */\n \t\t\trte_eth_macaddr_get(port_id,\n", "prefixes": [ "v2", "52/54" ] }