Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/58446/?format=api
{ "id": 58446, "url": "https://patches.dpdk.org/api/patches/58446/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1567500378-89175-1-git-send-email-andy.pei@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1567500378-89175-1-git-send-email-andy.pei@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1567500378-89175-1-git-send-email-andy.pei@intel.com", "date": "2019-09-03T08:46:18", "name": "[v4] net/ipn3ke: setup MTU when HW init", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "c020fa14b829ab71e84f10f5c16ba731207e1504", "submitter": { "id": 1185, "url": "https://patches.dpdk.org/api/people/1185/?format=api", "name": "Pei, Andy", "email": "andy.pei@intel.com" }, "delegate": { "id": 1540, "url": "https://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1567500378-89175-1-git-send-email-andy.pei@intel.com/mbox/", "series": [ { "id": 6215, "url": "https://patches.dpdk.org/api/series/6215/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=6215", "date": "2019-09-03T08:46:18", "name": "[v4] net/ipn3ke: setup MTU when HW init", "version": 4, "mbox": "https://patches.dpdk.org/series/6215/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/58446/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/58446/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 4FBA41C0B4;\n\tTue, 3 Sep 2019 10:58:39 +0200 (CEST)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n\tby dpdk.org (Postfix) with ESMTP id 557C21BEE9\n\tfor <dev@dpdk.org>; Tue, 3 Sep 2019 10:58:38 +0200 (CEST)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t03 Sep 2019 01:58:37 -0700", "from dpdk-dipei.sh.intel.com ([10.67.110.224])\n\tby orsmga003.jf.intel.com with ESMTP; 03 Sep 2019 01:58:35 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.64,462,1559545200\"; d=\"scan'208\";a=\"184690075\"", "From": "Andy Pei <andy.pei@intel.com>", "To": "dev@dpdk.org", "Cc": "andy.pei@intel.com, qi.z.zhang@intel.com, ferruh.yigit@intel.com,\n\trosen.xu@intel.com, xiaolong.ye@intel.com", "Date": "Tue, 3 Sep 2019 16:46:18 +0800", "Message-Id": "<1567500378-89175-1-git-send-email-andy.pei@intel.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1567392847-445709-1-git-send-email-andy.pei@intel.com>", "References": "<1567392847-445709-1-git-send-email-andy.pei@intel.com>", "Subject": "[dpdk-dev] [PATCH v4] net/ipn3ke: setup MTU when HW init", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "set up mtu to the minimun in tx mtu, rx mtu and IPN3KE_MAC_FRAME_SIZE_MAX.\n\nSigned-off-by: Andy Pei <andy.pei@intel.com>\n---\n\nCc: qi.z.zhang@intel.com\nCc: ferruh.yigit@intel.com\nCc: rosen.xu@intel.com\nCc: xiaolong.ye@intel.com\n\nv2:\nmodify low bound and upper bound.\n\nv3:\ndelete unnecessary MACROs.\nextract the duplicated code to a common function.\n\nv4:\ndelete unnecessary MACROs.\nextract the duplicated code to a common function.\n\n drivers/net/ipn3ke/ipn3ke_ethdev.c | 87 ++++++++++++++++++++++++++++++++++++++\n drivers/net/ipn3ke/ipn3ke_ethdev.h | 6 +++\n 2 files changed, 93 insertions(+)", "diff": "diff --git a/drivers/net/ipn3ke/ipn3ke_ethdev.c b/drivers/net/ipn3ke/ipn3ke_ethdev.c\nindex c226d63..e619ba3 100644\n--- a/drivers/net/ipn3ke/ipn3ke_ethdev.c\n+++ b/drivers/net/ipn3ke/ipn3ke_ethdev.c\n@@ -209,6 +209,90 @@\n \treturn 0;\n }\n \n+static uint32_t\n+ipn3ke_mtu_cal(uint32_t tx, uint32_t rx)\n+{\n+\tuint32_t tmp;\n+\ttmp = RTE_MIN(tx, rx);\n+\ttmp = RTE_MAX(tmp, (uint32_t)RTE_ETHER_MIN_MTU);\n+\ttmp = RTE_MIN(tmp, (uint32_t)(IPN3KE_MAC_FRAME_SIZE_MAX -\n+\t\tIPN3KE_ETH_OVERHEAD));\n+\treturn tmp;\n+}\n+\n+static void\n+ipn3ke_mtu_set\n+(struct ipn3ke_hw *hw, uint32_t mac_num, uint32_t eth_group_sel,\n+uint32_t txaddr, uint32_t rxaddr)\n+{\n+\tuint32_t tx;\n+\tuint32_t rx;\n+\tuint32_t tmp;\n+\n+\tif (!(*hw->f_mac_read) || !(*hw->f_mac_write))\n+\t\treturn;\n+\n+\t(*hw->f_mac_read)(hw,\n+\t\t\t&tx,\n+\t\t\ttxaddr,\n+\t\t\tmac_num,\n+\t\t\teth_group_sel);\n+\n+\t(*hw->f_mac_read)(hw,\n+\t\t\t&rx,\n+\t\t\trxaddr,\n+\t\t\tmac_num,\n+\t\t\teth_group_sel);\n+\n+\ttmp = ipn3ke_mtu_cal(tx, rx);\n+\n+\t(*hw->f_mac_write)(hw,\n+\t\t\ttmp,\n+\t\t\ttxaddr,\n+\t\t\tmac_num,\n+\t\t\teth_group_sel);\n+\n+\t(*hw->f_mac_write)(hw,\n+\t\t\ttmp,\n+\t\t\trxaddr,\n+\t\t\tmac_num,\n+\t\t\teth_group_sel);\n+}\n+\n+static void\n+ipn3ke_10G_mtu_setup\n+(struct ipn3ke_hw *hw, uint32_t mac_num, uint32_t eth_group_sel)\n+{\n+\tipn3ke_mtu_set(hw, mac_num, eth_group_sel,\n+\t\tIPN3KE_10G_TX_FRAME_MAXLENGTH, IPN3KE_10G_RX_FRAME_MAXLENGTH);\n+}\n+\n+static void\n+ipn3ke_25G_mtu_setup\n+(struct ipn3ke_hw *hw, uint32_t mac_num, uint32_t eth_group_sel)\n+{\n+\tipn3ke_mtu_set(hw, mac_num, eth_group_sel,\n+\t\tIPN3KE_25G_MAX_TX_SIZE_CONFIG, IPN3KE_25G_MAX_RX_SIZE_CONFIG);\n+}\n+\n+static void\n+ipn3ke_mtu_setup(struct ipn3ke_hw *hw)\n+{\n+\tint i;\n+\tif (hw->retimer.mac_type == IFPGA_RAWDEV_RETIMER_MAC_TYPE_10GE_XFI) {\n+\t\tfor (i = 0; i < hw->port_num; i++) {\n+\t\t\tipn3ke_10G_mtu_setup(hw, i, 0);\n+\t\t\tipn3ke_10G_mtu_setup(hw, i, 1);\n+\t\t}\n+\t} else if (hw->retimer.mac_type ==\n+\t\t\tIFPGA_RAWDEV_RETIMER_MAC_TYPE_25GE_25GAUI) {\n+\t\tfor (i = 0; i < hw->port_num; i++) {\n+\t\t\tipn3ke_25G_mtu_setup(hw, i, 0);\n+\t\t\tipn3ke_25G_mtu_setup(hw, i, 1);\n+\t\t}\n+\t}\n+}\n+\n static int\n ipn3ke_hw_init(struct rte_afu_device *afu_dev,\n \tstruct ipn3ke_hw *hw)\n@@ -303,6 +387,9 @@\n \t\t}\n \t}\n \n+\t/* init mtu */\n+\tipn3ke_mtu_setup(hw);\n+\n \tret = rte_eth_switch_domain_alloc(&hw->switch_domain_id);\n \tif (ret)\n \t\tIPN3KE_AFU_PMD_WARN(\"failed to allocate switch domain for device %d\",\ndiff --git a/drivers/net/ipn3ke/ipn3ke_ethdev.h b/drivers/net/ipn3ke/ipn3ke_ethdev.h\nindex c7b336b..fc45826 100644\n--- a/drivers/net/ipn3ke/ipn3ke_ethdev.h\n+++ b/drivers/net/ipn3ke/ipn3ke_ethdev.h\n@@ -654,6 +654,12 @@ static inline void _ipn3ke_indrct_write(struct ipn3ke_hw *hw,\n #define IPN3KE_MAC_RX_FRAME_MAXLENGTH_MASK \\\n \tIPN3KE_MASK(0xFFFF, IPN3KE_MAC_RX_FRAME_MAXLENGTH_SHIFT)\n \n+#define IPN3KE_25G_MAX_TX_SIZE_CONFIG 0x407\n+#define IPN3KE_25G_MAX_RX_SIZE_CONFIG 0x506\n+\n+#define IPN3KE_10G_TX_FRAME_MAXLENGTH 0x002C\n+#define IPN3KE_10G_RX_FRAME_MAXLENGTH 0x00AE\n+\n #define IPN3KE_REGISTER_WIDTH 32\n \n /*Bits[2:0]: Configuration of TX statistics counters:\n", "prefixes": [ "v4" ] }