Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/58439/?format=api
{ "id": 58439, "url": "https://patches.dpdk.org/api/patches/58439/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190903021901.25895-18-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190903021901.25895-18-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190903021901.25895-18-ajit.khaparde@broadcom.com", "date": "2019-09-03T02:19:01", "name": "[17/17] net/bnxt: drop untagged frames when specified", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "8359b0b64f6f8a18b3abcfcaa0a05fd0205b2571", "submitter": { "id": 501, "url": "https://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190903021901.25895-18-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 6209, "url": "https://patches.dpdk.org/api/series/6209/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=6209", "date": "2019-09-03T02:18:44", "name": "bnxt patchset to improve rte flow support", "version": 1, "mbox": "https://patches.dpdk.org/series/6209/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/58439/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/58439/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 33F661EB62;\n\tTue, 3 Sep 2019 04:19:42 +0200 (CEST)", "from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com\n\t[192.19.229.170]) by dpdk.org (Postfix) with ESMTP id B4A9A2B94\n\tfor <dev@dpdk.org>; Tue, 3 Sep 2019 04:19:10 +0200 (CEST)", "from nis-sj1-27.broadcom.com (nis-sj1-27.lvn.broadcom.net\n\t[10.75.144.136])\n\tby rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id 8486030C1F1;\n\tMon, 2 Sep 2019 19:19:03 -0700 (PDT)", "from localhost.localdomain (unknown [10.230.30.225])\n\tby nis-sj1-27.broadcom.com (Postfix) with ESMTP id 8EC65AC06AB;\n\tMon, 2 Sep 2019 19:19:09 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com 8486030C1F1", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n\ts=dkimrelay; t=1567477143;\n\tbh=0B5UPiJ0YPmxZwhDI+FdfQQmV5A56ipw4VsKUQMdgx4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=kMgIcOeNJt0BYKc/tqfa12z+8PKcxGuA5xwKgDGiyDW/8bEu46CCPbr4nrx1a+lws\n\tz0eHX+ziWplSjE5xyQS8DmIr7fktdTyHZ33O/UAKrcPWLJvUzn0o0i8Ko4LBSjWnw+\n\tAKtTchJXF7d70J75Zl7A+K1EKquTrLzH5lWumCj0=", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, Rahul Gupta <rahul.gupta@broadcom.com>,\n\tSomnath Kotur <somnath.kotur@broadcom.com>,\n\tKalesh Anakkur Purayil <kalesh-anakkur.purayil@broadcom.com>", "Date": "Mon, 2 Sep 2019 19:19:01 -0700", "Message-Id": "<20190903021901.25895-18-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.20.1 (Apple Git-117)", "In-Reply-To": "<20190903021901.25895-1-ajit.khaparde@broadcom.com>", "References": "<20190903021901.25895-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 17/17] net/bnxt: drop untagged frames when\n\tspecified", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When a drop action for L2 filters is specified, support it.\n\nSigned-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\nReviewed-by: Rahul Gupta <rahul.gupta@broadcom.com>\nReviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>\nReviewed-by: Kalesh Anakkur Purayil <kalesh-anakkur.purayil@broadcom.com>\n---\n drivers/net/bnxt/bnxt_filter.h | 6 ++++\n drivers/net/bnxt/bnxt_flow.c | 61 ++++++++++++++++++++++++++++++----\n 2 files changed, 61 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_filter.h b/drivers/net/bnxt/bnxt_filter.h\nindex bcb9d6031..2d10bd728 100644\n--- a/drivers/net/bnxt/bnxt_filter.h\n+++ b/drivers/net/bnxt/bnxt_filter.h\n@@ -15,6 +15,8 @@ struct bnxt;\n #define BNXT_FLOW_L2_INNER_SRC_VALID_FLAG\tBIT(2)\n #define BNXT_FLOW_L2_DST_VALID_FLAG\t\tBIT(3)\n #define BNXT_FLOW_L2_INNER_DST_VALID_FLAG\tBIT(4)\n+#define BNXT_FLOW_L2_DROP_FLAG\t\t\tBIT(5)\n+#define BNXT_FLOW_PARSE_INNER_FLAG\t\tBIT(6)\n \n struct bnxt_filter_info {\n \tSTAILQ_ENTRY(bnxt_filter_info)\tnext;\n@@ -146,4 +148,8 @@ struct bnxt_filter_info *bnxt_get_l2_filter(struct bnxt *bp,\n \tHWRM_CFA_NTUPLE_FILTER_ALLOC_INPUT_ENABLES_MIRROR_VNIC_ID\n #define NTUPLE_FLTR_ALLOC_INPUT_EN_MIRROR_VNIC_ID\t\\\n \tHWRM_CFA_NTUPLE_FILTER_ALLOC_INPUT_ENABLES_MIRROR_VNIC_ID\n+#define L2_FILTER_ALLOC_INPUT_EN_T_NUM_VLANS \\\n+\tHWRM_CFA_L2_FILTER_ALLOC_INPUT_ENABLES_T_NUM_VLANS\n+#define L2_FILTER_ALLOC_INPUT_EN_NUM_VLANS \\\n+\tHWRM_CFA_L2_FILTER_ALLOC_INPUT_ENABLES_NUM_VLANS\n #endif\ndiff --git a/drivers/net/bnxt/bnxt_flow.c b/drivers/net/bnxt/bnxt_flow.c\nindex d640a923a..50cad5480 100644\n--- a/drivers/net/bnxt/bnxt_flow.c\n+++ b/drivers/net/bnxt/bnxt_flow.c\n@@ -273,6 +273,8 @@ bnxt_validate_and_parse_flow_type(struct bnxt *bp,\n \t\t\t\t\trte_be_to_cpu_16(eth_spec->type);\n \t\t\t\ten |= en_ethertype;\n \t\t\t}\n+\t\t\tif (inner)\n+\t\t\t\tvalid_flags |= BNXT_FLOW_PARSE_INNER_FLAG;\n \n \t\t\tbreak;\n \t\tcase RTE_FLOW_ITEM_TYPE_VLAN:\n@@ -794,9 +796,36 @@ bnxt_get_l2_filter(struct bnxt *bp, struct bnxt_filter_info *nf,\n \t\t}\n \t}\n \n-\tfilter1->enables = HWRM_CFA_L2_FILTER_ALLOC_INPUT_ENABLES_L2_ADDR |\n+\tif (nf->valid_flags & (BNXT_FLOW_L2_DST_VALID_FLAG |\n+\t\t\t BNXT_FLOW_L2_SRC_VALID_FLAG |\n+\t\t\t BNXT_FLOW_L2_INNER_SRC_VALID_FLAG |\n+\t\t\t BNXT_FLOW_L2_INNER_DST_VALID_FLAG)) {\n+\t\tfilter1->enables =\n+\t\t\tHWRM_CFA_L2_FILTER_ALLOC_INPUT_ENABLES_L2_ADDR |\n \t\t\tL2_FILTER_ALLOC_INPUT_EN_L2_ADDR_MASK;\n-\tmemset(filter1->l2_addr_mask, 0xff, RTE_ETHER_ADDR_LEN);\n+\t\tmemset(filter1->l2_addr_mask, 0xff, RTE_ETHER_ADDR_LEN);\n+\t}\n+\n+\tif (nf->valid_flags & BNXT_FLOW_L2_DROP_FLAG) {\n+\t\tfilter1->flags |=\n+\t\t\tHWRM_CFA_L2_FILTER_ALLOC_INPUT_FLAGS_DROP;\n+\t\tif (nf->ethertype == RTE_ETHER_TYPE_IPV4) {\n+\t\t\t/* Num VLANs for drop filter will/should be 0.\n+\t\t\t * If the req is memset to 0, then the count will\n+\t\t\t * be automatically set to 0.\n+\t\t\t */\n+\t\t\tif (nf->valid_flags & BNXT_FLOW_PARSE_INNER_FLAG) {\n+\t\t\t\tfilter1->enables |=\n+\t\t\t\t\tL2_FILTER_ALLOC_INPUT_EN_T_NUM_VLANS;\n+\t\t\t} else {\n+\t\t\t\tfilter1->enables |=\n+\t\t\t\t\tL2_FILTER_ALLOC_INPUT_EN_NUM_VLANS;\n+\t\t\t\tfilter1->flags |=\n+\t\t\t\tHWRM_CFA_L2_FILTER_ALLOC_INPUT_FLAGS_OUTERMOST;\n+\t\t\t}\n+\t\t}\n+\t}\n+\n \trc = bnxt_hwrm_set_l2_filter(bp, vnic->fw_vnic_id,\n \t\t\t\t filter1);\n \tif (rc) {\n@@ -893,7 +922,9 @@ bnxt_update_filter_flags_en(struct bnxt_filter_info *filter,\n \t ~(BNXT_FLOW_L2_DST_VALID_FLAG |\n \t\tBNXT_FLOW_L2_SRC_VALID_FLAG |\n \t\tBNXT_FLOW_L2_INNER_SRC_VALID_FLAG |\n-\t\tBNXT_FLOW_L2_INNER_DST_VALID_FLAG))) {\n+\t\tBNXT_FLOW_L2_INNER_DST_VALID_FLAG |\n+\t\tBNXT_FLOW_L2_DROP_FLAG |\n+\t\tBNXT_FLOW_PARSE_INNER_FLAG))) {\n \t\tfilter->flags = filter1->flags;\n \t\tfilter->enables = filter1->enables;\n \t\tfilter->filter_type = HWRM_CFA_L2_FILTER;\n@@ -1052,19 +1083,27 @@ bnxt_validate_and_parse_flow(struct rte_eth_dev *dev,\n \t\tbreak;\n \tcase RTE_FLOW_ACTION_TYPE_DROP:\n \t\tvnic0 = &bp->vnic_info[0];\n+\t\tfilter->dst_id = vnic0->fw_vnic_id;\n+\t\tfilter->valid_flags |= BNXT_FLOW_L2_DROP_FLAG;\n \t\tfilter1 = bnxt_get_l2_filter(bp, filter, vnic0);\n \t\tif (filter1 == NULL) {\n+\t\t\trte_flow_error_set(error,\n+\t\t\t\t\t ENOSPC,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION,\n+\t\t\t\t\t act,\n+\t\t\t\t\t \"Filter not available\");\n \t\t\trc = -ENOSPC;\n \t\t\tgoto ret;\n \t\t}\n \n-\t\tfilter->fw_l2_filter_id = filter1->fw_l2_filter_id;\n \t\tif (filter->filter_type == HWRM_CFA_EM_FILTER)\n \t\t\tfilter->flags =\n \t\t\t\tHWRM_CFA_EM_FLOW_ALLOC_INPUT_FLAGS_DROP;\n-\t\telse\n+\t\telse if (filter->filter_type == HWRM_CFA_NTUPLE_FILTER)\n \t\t\tfilter->flags =\n \t\t\t\tHWRM_CFA_NTUPLE_FILTER_ALLOC_INPUT_FLAGS_DROP;\n+\n+\t\tbnxt_update_filter_flags_en(filter, filter1);\n \t\tbreak;\n \tcase RTE_FLOW_ACTION_TYPE_COUNT:\n \t\tvnic0 = &bp->vnic_info[0];\n@@ -1758,6 +1797,15 @@ bnxt_flow_destroy(struct rte_eth_dev *dev,\n \n done:\n \tif (!ret) {\n+\t\t/* If it is a L2 drop filter, when the filter is created,\n+\t\t * the FW updates the BC/MC records.\n+\t\t * Once this filter is removed, issue the set_rx_mask command\n+\t\t * to reset the BC/MC records in the HW to the settings\n+\t\t * before the drop counter is created.\n+\t\t */\n+\t\tif (filter->valid_flags & BNXT_FLOW_L2_DROP_FLAG)\n+\t\t\tbnxt_set_rx_mask_no_vlan(bp, &bp->vnic_info[0]);\n+\n \t\tSTAILQ_REMOVE(&vnic->filter, filter, bnxt_filter_info, next);\n \t\tbnxt_free_filter(bp, filter);\n \t\tSTAILQ_REMOVE(&vnic->flow_list, flow, rte_flow, next);\n@@ -1766,7 +1814,8 @@ bnxt_flow_destroy(struct rte_eth_dev *dev,\n \t\t/* If this was the last flow associated with this vnic,\n \t\t * switch the queue back to RSS pool.\n \t\t */\n-\t\tif (vnic && STAILQ_EMPTY(&vnic->flow_list)) {\n+\t\tif (vnic && !vnic->func_default &&\n+\t\t STAILQ_EMPTY(&vnic->flow_list)) {\n \t\t\trte_free(vnic->fw_grp_ids);\n \t\t\tif (vnic->rx_queue_cnt > 1)\n \t\t\t\tbnxt_hwrm_vnic_ctx_free(bp, vnic);\n", "prefixes": [ "17/17" ] }