Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/58437/?format=api
{ "id": 58437, "url": "https://patches.dpdk.org/api/patches/58437/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190903021901.25895-16-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190903021901.25895-16-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190903021901.25895-16-ajit.khaparde@broadcom.com", "date": "2019-09-03T02:18:59", "name": "[15/17] net/bnxt: handle cleanup if flow creation fails", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "930b5e115cb5a70382afded947fcab3124b4bca9", "submitter": { "id": 501, "url": "https://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190903021901.25895-16-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 6209, "url": "https://patches.dpdk.org/api/series/6209/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=6209", "date": "2019-09-03T02:18:44", "name": "bnxt patchset to improve rte flow support", "version": 1, "mbox": "https://patches.dpdk.org/series/6209/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/58437/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/58437/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 4EEC51EB4E;\n\tTue, 3 Sep 2019 04:19:38 +0200 (CEST)", "from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com\n\t[192.19.229.170]) by dpdk.org (Postfix) with ESMTP id ED7D11E9CF\n\tfor <dev@dpdk.org>; Tue, 3 Sep 2019 04:19:09 +0200 (CEST)", "from nis-sj1-27.broadcom.com (nis-sj1-27.lvn.broadcom.net\n\t[10.75.144.136])\n\tby rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id BF7A230C200;\n\tMon, 2 Sep 2019 19:19:02 -0700 (PDT)", "from localhost.localdomain (unknown [10.230.30.225])\n\tby nis-sj1-27.broadcom.com (Postfix) with ESMTP id 259FAAC078E;\n\tMon, 2 Sep 2019 19:19:09 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com BF7A230C200", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n\ts=dkimrelay; t=1567477142;\n\tbh=F8pF06fMhOUul4OfZE5CQp0l+FjJ6KnnITzZxwByWDs=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=AHbZw9fYgi0+ki3V96PAUUJvMTDJJMRfoKswkWtHsVlV0XUTS+v4frE20z0J/0UgM\n\tILp7HcdcvQz1kO4fcpd/HZRuNjpK4fP0r4y1tOaYREDyzcM2k7FlEGche91VcPAd68\n\tvNjAKSmELe21ViGVmu3gRmVK2Ubu+5o4MbKtEJy8=", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, Rahul Gupta <rahul.gupta@broadcom.com>,\n\tVenkat Duvvuru <venkatkumar.duvvuru@broadcom.com>,\n\tKalesh Anakkur Purayil <kalesh-anakkur.purayil@broadcom.com>", "Date": "Mon, 2 Sep 2019 19:18:59 -0700", "Message-Id": "<20190903021901.25895-16-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.20.1 (Apple Git-117)", "In-Reply-To": "<20190903021901.25895-1-ajit.khaparde@broadcom.com>", "References": "<20190903021901.25895-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 15/17] net/bnxt: handle cleanup if flow creation\n\tfails", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "If flow creation fails because of an HWRM command failure or\nor some other reason, reset the vnic and rxq info set earlier.\n\nSigned-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\nReviewed-by: Rahul Gupta <rahul.gupta@broadcom.com>\nReviewed-by: Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>\nReviewed-by: Kalesh Anakkur Purayil <kalesh-anakkur.purayil@broadcom.com>\n---\n drivers/net/bnxt/bnxt_flow.c | 68 ++++++++++++++++++++++++++++++++----\n 1 file changed, 62 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_flow.c b/drivers/net/bnxt/bnxt_flow.c\nindex 9d943cd14..8156b5b4b 100644\n--- a/drivers/net/bnxt/bnxt_flow.c\n+++ b/drivers/net/bnxt/bnxt_flow.c\n@@ -175,6 +175,14 @@ bnxt_validate_and_parse_flow_type(struct bnxt *bp,\n \t\t\treturn -rte_errno;\n \t\t}\n \n+\t\tif (!item->spec || !item->mask) {\n+\t\t\trte_flow_error_set(error, EINVAL,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ITEM,\n+\t\t\t\t\t item,\n+\t\t\t\t\t \"spec/mask is NULL\");\n+\t\t\treturn -rte_errno;\n+\t\t}\n+\n \t\tswitch (item->type) {\n \t\tcase RTE_FLOW_ITEM_TYPE_ANY:\n \t\t\tinner =\n@@ -907,10 +915,10 @@ bnxt_validate_and_parse_flow(struct rte_eth_dev *dev,\n \tconst struct rte_flow_action *act =\n \t\tbnxt_flow_non_void_action(actions);\n \tstruct bnxt *bp = dev->data->dev_private;\n+\tstruct bnxt_vnic_info *vnic = NULL, *vnic0 = NULL;\n \tconst struct rte_flow_action_queue *act_q;\n-\tconst struct rte_flow_action_rss *rss;\n \tconst struct rte_flow_action_vf *act_vf;\n-\tstruct bnxt_vnic_info *vnic, *vnic0;\n+\tconst struct rte_flow_action_rss *rss;\n \tstruct bnxt_filter_info *filter1;\n \tstruct bnxt_rx_queue *rxq = NULL;\n \tint dflt_vnic, vnic_id;\n@@ -1009,8 +1017,15 @@ bnxt_validate_and_parse_flow(struct rte_eth_dev *dev,\n \t\tPMD_DRV_LOG(DEBUG, \"VNIC found\\n\");\n \n \t\trc = bnxt_vnic_prep(bp, vnic);\n-\t\tif (rc)\n+\t\tif (rc) {\n+\t\t\trte_flow_error_set(error,\n+\t\t\t\t\t EINVAL,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION,\n+\t\t\t\t\t act,\n+\t\t\t\t\t \"VNIC prep fail\");\n+\t\t\trc = -rte_errno;\n \t\t\tgoto ret;\n+\t\t}\n \n \t\tPMD_DRV_LOG(DEBUG,\n \t\t\t \"vnic[%d] = %p vnic->fw_grp_ids = %p\\n\",\n@@ -1023,7 +1038,12 @@ bnxt_validate_and_parse_flow(struct rte_eth_dev *dev,\n \t\tfilter->dst_id = vnic->fw_vnic_id;\n \t\tfilter1 = bnxt_get_l2_filter(bp, filter, vnic);\n \t\tif (filter1 == NULL) {\n-\t\t\trc = -ENOSPC;\n+\t\t\trte_flow_error_set(error,\n+\t\t\t\t\t ENOSPC,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION,\n+\t\t\t\t\t act,\n+\t\t\t\t\t \"Filter not available\");\n+\t\t\trc = -rte_errno;\n \t\t\tgoto ret;\n \t\t}\n \n@@ -1050,7 +1070,12 @@ bnxt_validate_and_parse_flow(struct rte_eth_dev *dev,\n \t\tvnic0 = &bp->vnic_info[0];\n \t\tfilter1 = bnxt_get_l2_filter(bp, filter, vnic0);\n \t\tif (filter1 == NULL) {\n-\t\t\trc = -ENOSPC;\n+\t\t\trte_flow_error_set(error,\n+\t\t\t\t\t ENOSPC,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION,\n+\t\t\t\t\t act,\n+\t\t\t\t\t \"New filter not available\");\n+\t\t\trc = -rte_errno;\n \t\t\tgoto ret;\n \t\t}\n \n@@ -1113,6 +1138,11 @@ bnxt_validate_and_parse_flow(struct rte_eth_dev *dev,\n \t\tvnic0 = &bp->vnic_info[0];\n \t\tfilter1 = bnxt_get_l2_filter(bp, filter, vnic0);\n \t\tif (filter1 == NULL) {\n+\t\t\trte_flow_error_set(error,\n+\t\t\t\t\t ENOSPC,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION,\n+\t\t\t\t\t act,\n+\t\t\t\t\t \"New filter not available\");\n \t\t\trc = -ENOSPC;\n \t\t\tgoto ret;\n \t\t}\n@@ -1209,8 +1239,15 @@ bnxt_validate_and_parse_flow(struct rte_eth_dev *dev,\n \t\tvnic->func_default = 0;\t//This is not a default VNIC.\n \n \t\trc = bnxt_vnic_prep(bp, vnic);\n-\t\tif (rc)\n+\t\tif (rc) {\n+\t\t\trte_flow_error_set(error,\n+\t\t\t\t\t EINVAL,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION,\n+\t\t\t\t\t act,\n+\t\t\t\t\t \"VNIC prep fail\");\n+\t\t\trc = -rte_errno;\n \t\t\tgoto ret;\n+\t\t}\n \n \t\tPMD_DRV_LOG(DEBUG,\n \t\t\t \"vnic[%d] = %p vnic->fw_grp_ids = %p\\n\",\n@@ -1265,6 +1302,11 @@ bnxt_validate_and_parse_flow(struct rte_eth_dev *dev,\n \t\tfilter->dst_id = vnic->fw_vnic_id;\n \t\tfilter1 = bnxt_get_l2_filter(bp, filter, vnic);\n \t\tif (filter1 == NULL) {\n+\t\t\trte_flow_error_set(error,\n+\t\t\t\t\t ENOSPC,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION,\n+\t\t\t\t\t act,\n+\t\t\t\t\t \"New filter not available\");\n \t\t\trc = -ENOSPC;\n \t\t\tgoto ret;\n \t\t}\n@@ -1297,7 +1339,18 @@ bnxt_validate_and_parse_flow(struct rte_eth_dev *dev,\n \t\trc = -rte_errno;\n \t\tgoto ret;\n \t}\n+\n+\treturn rc;\n ret:\n+\n+\t//TODO: Cleanup according to ACTION TYPE.\n+\tif (rte_errno) {\n+\t\tif (vnic && STAILQ_EMPTY(&vnic->filter))\n+\t\t\tvnic->rx_queue_cnt = 0;\n+\n+\t\tif (rxq && !vnic->rx_queue_cnt)\n+\t\t\trxq->vnic = &bp->vnic_info[0];\n+\t}\n \treturn rc;\n }\n \n@@ -1344,6 +1397,8 @@ bnxt_flow_validate(struct rte_eth_dev *dev,\n \n \tret = bnxt_validate_and_parse_flow(dev, pattern, actions, attr,\n \t\t\t\t\t error, filter);\n+\tif (ret)\n+\t\tgoto exit;\n \n \tvnic = find_matching_vnic(bp, filter);\n \tif (vnic) {\n@@ -1364,6 +1419,7 @@ bnxt_flow_validate(struct rte_eth_dev *dev,\n \telse\n \t\tbnxt_hwrm_clear_l2_filter(bp, filter);\n \n+exit:\n \t/* No need to hold on to this filter if we are just validating flow */\n \tfilter->fw_l2_filter_id = UINT64_MAX;\n \tbnxt_free_filter(bp, filter);\n", "prefixes": [ "15/17" ] }