Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/58435/?format=api
{ "id": 58435, "url": "https://patches.dpdk.org/api/patches/58435/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190903021901.25895-15-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190903021901.25895-15-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190903021901.25895-15-ajit.khaparde@broadcom.com", "date": "2019-09-03T02:18:58", "name": "[14/17] net/bnxt: validate RSS hash key length", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "e559b1a39c3c4493d0a3e0d9350510a765e5a724", "submitter": { "id": 501, "url": "https://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190903021901.25895-15-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 6209, "url": "https://patches.dpdk.org/api/series/6209/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=6209", "date": "2019-09-03T02:18:44", "name": "bnxt patchset to improve rte flow support", "version": 1, "mbox": "https://patches.dpdk.org/series/6209/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/58435/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/58435/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 85AF61EB3F;\n\tTue, 3 Sep 2019 04:19:35 +0200 (CEST)", "from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com\n\t[192.19.229.170]) by dpdk.org (Postfix) with ESMTP id 131192B94\n\tfor <dev@dpdk.org>; Tue, 3 Sep 2019 04:19:10 +0200 (CEST)", "from nis-sj1-27.broadcom.com (nis-sj1-27.lvn.broadcom.net\n\t[10.75.144.136])\n\tby rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id D71B330C209;\n\tMon, 2 Sep 2019 19:19:02 -0700 (PDT)", "from localhost.localdomain (unknown [10.230.30.225])\n\tby nis-sj1-27.broadcom.com (Postfix) with ESMTP id D6748AC06AB;\n\tMon, 2 Sep 2019 19:19:08 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com D71B330C209", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n\ts=dkimrelay; t=1567477142;\n\tbh=GeHO/rFgnhbPuBc1+j5Y+bzYQvW8F3N0q1eve5wLFEw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=NQqwJD/M+lMBzpLS5Zifh7UofjjefLQEnkOU9eQnNtZmZ6gfJ/wxKJtYenf4K+/5c\n\tKZfpMDWOgYWI0+FhwWoPXOQWJZlNoMyJ6XT779BufKYQiwBCT6SUN+fm9lzRGZeiMH\n\tsMNgCq6VCxrpw/M66/lGeg1+NG6TNGHQf91RIvc8=", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>,\n\tSomnath Kotur <somnath.kotur@broadcom.com>,\n\tRahul Gupta <rahul.gupta@broadcom.com>,\n\tSantoshkumar Karanappa Rastapur <santosh.rastapur@broadcom.com>,\n\tKalesh Anakkur Purayil <kalesh-anakkur.purayil@broadcom.com>", "Date": "Mon, 2 Sep 2019 19:18:58 -0700", "Message-Id": "<20190903021901.25895-15-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.20.1 (Apple Git-117)", "In-Reply-To": "<20190903021901.25895-1-ajit.khaparde@broadcom.com>", "References": "<20190903021901.25895-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 14/17] net/bnxt: validate RSS hash key length", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>\n\nIn bnxt_rss_hash_update_op, driver is proceeding with\nbnxt_hwrm_vnic_rss_cfg even though RSS hashkey length is invalid.\n\nThis patch fixes the problem by returning -EINVAL when RSS hashkey length\nis invalid.\n\nSigned-off-by: Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>\nReviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>\nReviewed-by: Rahul Gupta <rahul.gupta@broadcom.com>\nReviewed-by: Santoshkumar Karanappa Rastapur <santosh.rastapur@broadcom.com>\nReviewed-by: Kalesh Anakkur Purayil <kalesh-anakkur.purayil@broadcom.com>\nReviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\nSigned-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt_ethdev.c | 18 ++++++++++++------\n 1 file changed, 12 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex b72466467..5ef2ee0c4 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -1308,14 +1308,20 @@ static int bnxt_rss_hash_update_op(struct rte_eth_dev *eth_dev,\n \tvnic->hash_type = bnxt_rte_to_hwrm_hash_types(rss_conf->rss_hf);\n \n \t/*\n-\t * Use the supplied key if the key length is\n-\t * acceptable and the rss_key is not NULL\n+\t * If hashkey is not specified, use the previously configured\n+\t * hashkey\n \t */\n-\tif (rss_conf->rss_key && rss_conf->rss_key_len <= HW_HASH_KEY_SIZE)\n-\t\tmemcpy(vnic->rss_hash_key,\n-\t\t rss_conf->rss_key,\n-\t\t rss_conf->rss_key_len);\n+\tif (!rss_conf->rss_key)\n+\t\tgoto rss_config;\n \n+\tif (rss_conf->rss_key_len != HW_HASH_KEY_SIZE) {\n+\t\tPMD_DRV_LOG(ERR,\n+\t\t\t \"Invalid hashkey length, should be 16 bytes\\n\");\n+\t\treturn -EINVAL;\n+\t}\n+\tmemcpy(vnic->rss_hash_key, rss_conf->rss_key, rss_conf->rss_key_len);\n+\n+rss_config:\n \tbnxt_hwrm_vnic_rss_cfg(bp, vnic);\n \treturn 0;\n }\n", "prefixes": [ "14/17" ] }