Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 58434,
    "url": "https://patches.dpdk.org/api/patches/58434/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190903021901.25895-11-ajit.khaparde@broadcom.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20190903021901.25895-11-ajit.khaparde@broadcom.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20190903021901.25895-11-ajit.khaparde@broadcom.com",
    "date": "2019-09-03T02:18:54",
    "name": "[10/17] net/bnxt: properly handle ring cleanup in case of error",
    "commit_ref": null,
    "pull_url": null,
    "state": "changes-requested",
    "archived": true,
    "hash": "cda2dd436ffe41d10a8a8e23a5210ad927560324",
    "submitter": {
        "id": 501,
        "url": "https://patches.dpdk.org/api/people/501/?format=api",
        "name": "Ajit Khaparde",
        "email": "ajit.khaparde@broadcom.com"
    },
    "delegate": {
        "id": 319,
        "url": "https://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190903021901.25895-11-ajit.khaparde@broadcom.com/mbox/",
    "series": [
        {
            "id": 6209,
            "url": "https://patches.dpdk.org/api/series/6209/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=6209",
            "date": "2019-09-03T02:18:44",
            "name": "bnxt patchset to improve rte flow support",
            "version": 1,
            "mbox": "https://patches.dpdk.org/series/6209/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/58434/comments/",
    "check": "fail",
    "checks": "https://patches.dpdk.org/api/patches/58434/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E5CD51EB36;\n\tTue,  3 Sep 2019 04:19:33 +0200 (CEST)",
            "from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com\n\t[192.19.229.170]) by dpdk.org (Postfix) with ESMTP id 64E5A2B94\n\tfor <dev@dpdk.org>; Tue,  3 Sep 2019 04:19:09 +0200 (CEST)",
            "from nis-sj1-27.broadcom.com (nis-sj1-27.lvn.broadcom.net\n\t[10.75.144.136])\n\tby rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id CC31B30C1FE;\n\tMon,  2 Sep 2019 19:19:01 -0700 (PDT)",
            "from localhost.localdomain (unknown [10.230.30.225])\n\tby nis-sj1-27.broadcom.com (Postfix) with ESMTP id D68A6AC078A;\n\tMon,  2 Sep 2019 19:19:07 -0700 (PDT)"
        ],
        "DKIM-Filter": "OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com CC31B30C1FE",
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n\ts=dkimrelay; t=1567477141;\n\tbh=T4katix4EVgL+HcU+T6Bkj1hOuGec0vgZhDulyx9JL4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=funBSWyb8H0Ptx+AXbp8KGtAgOkgIG7xOcvJazEgK7kioWDGRQFun4FB6em6aMoRH\n\tH7J/3kKRSSocAdvlKbYllBWB3aXIj9amZDqMvjcohZ4KxWBhX1DL8ym2wcU4iRCo1P\n\tt1J7ve/wOQfKflmcCfBkwySGqlaG63lhi8UTBrHk=",
        "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>",
        "To": "dev@dpdk.org",
        "Cc": "ferruh.yigit@intel.com, Rahul Gupta <rahul.gupta@broadcom.com>,\n\tVenkat Duvvuru <venkatkumar.duvvuru@broadcom.com>,\n\tKalesh Anakkur Purayil <kalesh-anakkur.purayil@broadcom.com>",
        "Date": "Mon,  2 Sep 2019 19:18:54 -0700",
        "Message-Id": "<20190903021901.25895-11-ajit.khaparde@broadcom.com>",
        "X-Mailer": "git-send-email 2.20.1 (Apple Git-117)",
        "In-Reply-To": "<20190903021901.25895-1-ajit.khaparde@broadcom.com>",
        "References": "<20190903021901.25895-1-ajit.khaparde@broadcom.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[dpdk-dev] [PATCH 10/17] net/bnxt: properly handle ring cleanup in\n\tcase of error",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "From: Rahul Gupta <rahul.gupta@broadcom.com>\n\nInitialize all rings to INVALID_HW_RING_ID.\nThis can be used to determine the rings to free if allocation fails.\n\nSigned-off-by: Rahul Gupta <rahul.gupta@broadcom.com>\nReviewed-by: Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>\nReviewed-by: Kalesh Anakkur Purayil <kalesh-anakkur.purayil@broadcom.com>\nReviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\nSigned-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt_ring.c | 37 ++++++++++++++++++++++++++++++++++++\n 1 file changed, 37 insertions(+)",
    "diff": "diff --git a/drivers/net/bnxt/bnxt_ring.c b/drivers/net/bnxt/bnxt_ring.c\nindex 119a6919f..f6e81d308 100644\n--- a/drivers/net/bnxt/bnxt_ring.c\n+++ b/drivers/net/bnxt/bnxt_ring.c\n@@ -637,6 +637,42 @@ int bnxt_alloc_hwrm_rx_ring(struct bnxt *bp, int queue_index)\n \treturn rc;\n }\n \n+/* Initialise all rings to -1, its used to free rings later if allocation\n+ * of few rings fails.\n+ */\n+static void bnxt_init_all_rings(struct bnxt *bp)\n+{\n+\tunsigned int i = 0;\n+\tstruct bnxt_rx_queue *rxq;\n+\tstruct bnxt_ring *cp_ring;\n+\tstruct bnxt_ring *ring;\n+\tstruct bnxt_rx_ring_info *rxr;\n+\tstruct bnxt_tx_queue *txq;\n+\n+\tfor (i = 0; i < bp->rx_cp_nr_rings; i++) {\n+\t\trxq = bp->rx_queues[i];\n+\t\t/* Rx-compl */\n+\t\tcp_ring = rxq->cp_ring->cp_ring_struct;\n+\t\tcp_ring->fw_ring_id = INVALID_HW_RING_ID;\n+\t\t/* Rx-Reg */\n+\t\trxr = rxq->rx_ring;\n+\t\tring = rxr->rx_ring_struct;\n+\t\tring->fw_ring_id = INVALID_HW_RING_ID;\n+\t\t/* Rx-AGG */\n+\t\tring = rxr->ag_ring_struct;\n+\t\tring->fw_ring_id = INVALID_HW_RING_ID;\n+\t}\n+\tfor (i = 0; i < bp->tx_cp_nr_rings; i++) {\n+\t\ttxq = bp->tx_queues[i];\n+\t\t/* Tx cmpl */\n+\t\tcp_ring = txq->cp_ring->cp_ring_struct;\n+\t\tcp_ring->fw_ring_id = INVALID_HW_RING_ID;\n+\t\t/*Tx Ring */\n+\t\tring = txq->tx_ring->tx_ring_struct;\n+\t\tring->fw_ring_id = INVALID_HW_RING_ID;\n+\t}\n+}\n+\n /* ring_grp usage:\n  * [0] = default completion ring\n  * [1 -> +rx_cp_nr_rings] = rx_cp, rx rings\n@@ -650,6 +686,7 @@ int bnxt_alloc_hwrm_rings(struct bnxt *bp)\n \tint rc = 0;\n \n \tbnxt_init_dflt_coal(&coal);\n+\tbnxt_init_all_rings(bp);\n \n \tfor (i = 0; i < bp->rx_cp_nr_rings; i++) {\n \t\tstruct bnxt_rx_queue *rxq = bp->rx_queues[i];\n",
    "prefixes": [
        "10/17"
    ]
}